75 Commits

• Rename SkinComponentsContainer to SkinnableContainer
  Dean Herbert · 2024-08-22 17:42:50 +09:00
  41756520b1
• Fix more tests
  Dean Herbert · 2024-08-20 17:59:55 +09:00
  73f2f5cb12
• Fix legacy key counter's background being visible when intended to be hidden
  Dean Herbert · 2024-08-06 16:12:00 +09:00
  8619bbb943
• Update usages of GameplayClockContainer not using an adjustable source
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  c40bd74138
• Don't apply decoupling to SpectatorPlayerClocks

  See inline comment for reasoning. It's a bit complicated.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  8367bb6bee
• Fix incorrect dependency caching

  These are tested framework-side to throw exceptions, but the
  test is ignored for the source generated version because it quietly
  allows this scenario.
  
  The source gen project should eventually have an analyser for these
  unsupported cases, or we could consider relaxing this particular case.

  Dan Balasescu · 2023-07-20 22:30:49 +09:00
  733ce4c382
• Add safety to tests to ensure loaded
  Dean Herbert · 2023-06-27 16:04:34 +09:00
  e99de0eb5d
• Attempt to remedy HUD overlay test failure by waiting more
  Bartłomiej Dach · 2023-06-26 22:41:31 +02:00
  9c87d42f2b
• Rename {KeyCounter -> InputCount}Controller
  Bartłomiej Dach · 2023-06-26 19:27:42 +02:00
  8d91580dc1
• Merge branch 'master' into hud/kc-skinnable
  tsrk · 2023-06-25 15:42:08 +02:00
  350d722c8d
• Apply required nullability changes
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  3585c3f1d5
• test: change hideTarget drawable and testing logic

  Doesn't change what it needs to test conceptually

  tsrk · 2023-06-16 17:24:40 +02:00
  f9321a24d9
• refactor: decouple Trigger logic from KeyCounterDisplay

  This allows to keep a coeherent state regardless of the progress of the play

  tsrk · 2023-06-14 21:13:35 +02:00
  c637fddf73
• test: remove hard usages of KeyCounterDisplay
  tsrk · 2023-06-14 13:25:24 +02:00
  758831b983
• Massage tests a bit more
  Dan Balasescu · 2023-05-25 16:38:22 +09:00
  6d9ba9248d
• Fix test failures due to type mismatch
  Bartłomiej Dach · 2023-04-25 20:10:11 +02:00
  753fa09356
• Fix missing using statements in multiple test scenes
  Dean Herbert · 2023-04-03 15:37:10 +09:00
  6239789188
• Rename Add/AddRange methods as they are no longer conflicting with Container
  Dean Herbert · 2023-03-15 18:02:41 +09:00
  5f9b13a775
• Fix super-dodgy cast of IEnumerable to Drawable
  Dean Herbert · 2023-03-15 18:01:22 +09:00
  8908648f97
• revert: make counters an IEnumerable again

  As suggested by bdach as this would make the last two commits useless
  
  Refs: 5d15426

  tsrk · 2023-03-09 10:25:03 +00:00
  d806b85a30
• Merge branch 'master' into gameplay/key-counter-abstraction
  Dean Herbert · 2023-03-07 16:09:45 +09:00
  8f6df5ea0f
• refactor(KeyCounterDisplay): apply suggestions

  I also took the freedom to add type checking, as we can't limit the
  usage of `Add()` since it's a Container. The exception thrown also
  advises of using the suggested `AddTrigger()` instead.

  tsrk · 2023-02-22 14:58:27 +00:00
  1beec71037
• refactor: rename trigger classes

  Makes it better to understand their purpose

  tsrk · 2023-02-15 21:46:13 +00:00
  076eb81b21
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• refactor: separate impl of KeyCounterDisplay

  This allows for different layouts of display. Idk, maybe someone would
  want to mix both variants? (don't do this please). This commit is mostly
  prep for further changes.

  tsrk · 2023-02-13 01:36:12 +00:00
  11d0e185b8
• Remove no longer necessary interface type
  Dean Herbert · 2023-01-18 15:23:55 +09:00
  e8770b84cd
• Switch test to specifically target the argon verison of the progress bar
  Dean Herbert · 2023-01-18 15:23:55 +09:00
  f9dd3f6def
• Simplify HUD test to not require casting to specific ProgressBar type
  Dean Herbert · 2023-01-18 14:37:09 +09:00
  45c5bd8403
• refactor(hud/gameplay/SongProgress): Add interface to designate SongProgressBars
  tsrk · 2023-01-09 21:48:53 +01:00
  0f1fe1d683
• Attempt to fix flaky TestHoldForMenuDoesWorkWhenHidden

  Seems like the most likely cause.

  Dean Herbert · 2022-11-30 17:35:51 +09:00
  1bb32ec24d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add failing test showing hold for menu not working when HUD is hidden
  Dean Herbert · 2022-10-30 21:38:31 +09:00
  8399261c77
• Apply nullability to HUD test scene
  Dean Herbert · 2022-10-30 21:25:31 +09:00
  f5e11343c2
• Add test showing broken input in HUD overlay when hidden
  Dean Herbert · 2022-10-10 16:05:41 +09:00
  f6a8cc3f32
• Remove remaining usage of GameplayClock
  Dean Herbert · 2022-08-15 20:22:36 +09:00
  704568ae3b
• Make GameplayClockContainer also an IGameplayClock and expose to remaining tests
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  f81c7644b4
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Fix intermittent HUD tests
  Dan Balasescu · 2022-07-28 17:58:07 +09:00
  1039338d80
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add test coverage of HUD components still getting updated when hidden
  Dean Herbert · 2022-06-14 18:35:49 +09:00
  0147a8ecee
• Fix remaining cases of incorrect GameplayState construction in tests

  Manual attempts to initialise replaced by a new `TestGameplayState`
  helper for ease of use.

  Bartłomiej Dach · 2022-05-28 15:23:29 +02:00
  a8e1c5ba87
• Cache gameplay clock in more places to fix song progress related tests
  Bartłomiej Dach · 2022-03-17 21:22:07 +01:00
  a8bb696e5b
• Change PerformancePointsCounter resolution requirements to be required

  All other similar UI components have required dependencies, so this is
  mainly to bring things in line with expectations. I am using this fact
  in the skin editor to only show components which can be used in the
  current editor context (by `try-catch`ing their
  `Activator.CreateInstance`).

  Dean Herbert · 2022-03-17 14:56:35 +09:00
  ac739c9dae
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Fix test not working intermittently
  smoogipoo · 2021-08-24 15:18:05 +09:00
  342f2d756d
• Fix wrong attribute used for setup method
  Salman Ahmed · 2021-08-18 06:50:01 +03:00
  6ed3e469f7
• Fix config pollution in HUD overlay test scene
  Salman Ahmed · 2021-08-18 04:59:08 +03:00
  f592350856
• Add failing test case
  Salman Ahmed · 2021-08-16 06:56:59 +03:00
  9d99741663
• Remove unnecessary binding logic from HUDOverlay
  Dean Herbert · 2021-05-07 17:51:46 +09:00
  1cb10c2a22
• Fix drain start time being weirdly incorrect
  Dean Herbert · 2021-05-07 17:47:33 +09:00
  6c255a0572