353 Commits

• Remove JSON property attributes from non-databased taiko difficulty attributes
  tsunyoku · 2025-03-12 19:10:41 +00:00
  db0676d615
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Add note about weird taiko iteration
  Dean Herbert · 2025-02-10 17:57:01 +09:00
  d4ce712672
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Fix inspections
  Dean Herbert · 2025-02-07 13:54:35 +09:00
  4f6fd68a91
• Add better documentation for interval change code
  Dean Herbert · 2025-02-05 18:48:48 +09:00
  40ea7ff238
• Initial tidy-up pass on IntervalGroupingUtils
  Dean Herbert · 2025-02-05 15:47:18 +09:00
  8447679db9
• Tidy up xmldoc and remove another unused field
  Dean Herbert · 2025-02-05 15:33:06 +09:00
  325483192a
• Remove unused HitObjectInterval
  Dean Herbert · 2025-02-05 15:10:15 +09:00
  fc93390284
• Simplify TaikoRhythmData's ratio computation
  Dean Herbert · 2025-02-05 15:09:51 +09:00
  709ad02a51
• Rename Colour / Rhythm related fields and classes
  Dean Herbert · 2025-02-05 15:08:15 +09:00
  fa844b0ebc
• Use correct English
  tsunyoku · 2025-01-27 12:56:33 +00:00
  f3c17f1c2b
• Rename class, rename children to hit objects and groups, make fields un-settable
  tsunyoku · 2025-01-27 12:54:22 +00:00
  71b89c390f
• Account for floating point errors
  tsunyoku · 2025-01-26 20:15:13 +00:00
  13c956c248
• Fix incorrect startTime calculation
  tsunyoku · 2025-01-26 16:21:07 +00:00
  a7aa553445
• Remove unused default value
  tsunyoku · 2025-01-23 10:29:04 +00:00
  8f17a44976
• Keep old behaviour of double.PositiveInfinity being the default for Interval
  tsunyoku · 2025-01-22 13:26:12 +00:00
  753e9ef7c7
• Fix incorrect namespace
  tsunyoku · 2025-01-22 13:24:30 +00:00
  2c0d6b14c8
• Replace weird IntervalGroupedHitObjects inheritance layer
  tsunyoku · 2025-01-21 15:58:33 +00:00
  14c68bcc58
• Revert Precision.DefinitelyBigger usage
  tsunyoku · 2025-01-21 15:01:32 +00:00
  1c4bc6dffd
• Fix typo in ColourEvaluator
  tsunyoku · 2025-01-21 14:56:51 +00:00
  764b0001ef
• Make rescale a static method
  tsunyoku · 2025-01-21 14:33:40 +00:00
  e0882d2a53
• Rename rhythm preprocessing objects to be clearer with intent
  tsunyoku · 2025-01-21 14:29:07 +00:00
  20a76d832d
• Add xmldoc to explain IHasInterval.Interval
  tsunyoku · 2025-01-21 14:28:15 +00:00
  ef8867704a
• Refactor StaminaEvaluator
  tsunyoku · 2025-01-21 14:25:28 +00:00
  b8c79d58a7
• Format ReadingEvaluator
  tsunyoku · 2025-01-21 14:24:46 +00:00
  9919179b0b
• Refactor ColourEvaluator
  tsunyoku · 2025-01-21 14:24:27 +00:00
  dbe36887f6
• Remove EffectiveBPMPreprocessor
  tsunyoku · 2025-01-21 14:24:04 +00:00
  fa20bc6631
• Tidy up code quality of RhythmEvaluator
  Dean Herbert · 2025-01-21 13:40:55 +09:00
  c8b05ce114
• Use correct HitWindows class for osu!taiko hit windows in difficulty calculator (#31579)

  * Use correct `HitWindows` class for osu!taiko hit windows in difficulty calculator
  
  * Remove redundant (and incorrect) hit window creation
  
  * Balance rhythm against hit window changes

  James Wilson · 2025-01-20 17:04:31 +05:00
  a77dfb1068
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• osu!taiko new rhythm penalty for long intervals using stamina difficulty (#31573)

  * Replace long interval nerf with a new one that uses stamina difficulty
  
  * Turn tabs into spaces
  
  * Update unit tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Eloise · 2025-01-20 11:40:52 +03:00
  e57565435e
• Rebalance stamina length bonus in osu!taiko (#31556)

  * adjust straincount to assume 1300
  
  * remove comment
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-01-19 22:40:09 +00:00
  2d0bc6cb62
• Improve convert considerations in osu!taiko (#31546)

  * return a higher finger count
  
  * implement isConvert
  
  * diffcalc cleanup
  
  * harshen monostaminafactor accuracy curve
  
  * readd comment
  
  * adjusts tests

  Jay Lawton · 2025-01-19 21:55:34 +00:00
  e04727afb1
• Penalise the reading difficulty of high velocity notes using "note density" (#31512)

  * Penalise reading difficulty of high velocity notes at high densities
  
  * Use System for math functions
  
  * Lawtrohux changes
  
  * Clean up density penalty comment
  
  * Swap midVelocity and highVelocity back around
  
  * code quality pass
  
  ---------
  
  Co-authored-by: Jay Lawton <jaime@merkids.com>
  Co-authored-by: StanR <hi@stanr.info>

  Eloise · 2025-01-18 13:52:47 +00:00
  8354cd5f93
• Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils (#31520)

  * Move error function implementation to osu.Game.Rulesets.Difficulty.Utils
  
  * Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

  Natelytle · 2025-01-17 19:37:34 +00:00
  5b4ba9225d
• osu!taiko further considerations for rhythm (#31339)

  * further considerations for rhythm
  
  * new rhythm balancing
  
  * fix license header
  
  * use isNormal to validate ratio
  
  * adjust tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-01-17 16:15:22 +05:00
  a42c03cea4
• osu!taiko star rating and performance points rebalance (#31338)

  * rebalance
  
  * revert pp scaling change
  
  * further rebalancing
  
  * comment
  
  * adjust tests

  Jay Lawton · 2025-01-16 21:14:05 +00:00
  a83f917d87
• osu!taiko stamina balancing (#31337)

  * stamina considerations
  
  * remove consecutive note count
  
  * adjust multiplier
  
  * add back comment
  
  * adjust tests
  
  * adjusts tests post merge
  
  * use diffcalcutils
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-01-16 10:30:02 +00:00
  9da8dcd815
• reading mono nerf (#31510)
  Jay Lawton · 2025-01-15 10:34:21 +00:00
  0a21183e54
• Remove lower cap on deviation without misses (#31499)
  Natelytle · 2025-01-14 19:12:08 +00:00
  5bed7c22e3
• Add consistentRatioPenalty to the Colour skill. (#31285)

  * fix colour
  
  * review fix
  
  Co-authored-by: StanR <castl@inbox.ru>
  
  * remove cancelled out operand
  
  * increase nerf, adjust tests
  
  * fix automated spacing issues
  
  * up penalty
  
  * adjust tests
  
  * apply review changes
  
  * fix nullable hell
  
  ---------
  
  Co-authored-by: StanR <castl@inbox.ru>

  Jay Lawton · 2025-01-07 11:36:56 +00:00
  4095b2662b
• Rewrite of the Rhythm Skill within osu!taiko (#31284)

  * implement bell curve into diffcalcutils
  
  * remove unneeded attributes
  
  * implement new rhythm skill
  
  * change dho variables
  
  * update dho rhythm
  
  * interval interface
  
  * implement rhythmevaluator
  
  * evenhitobjects
  
  * evenpatterns
  
  * evenrhythm
  
  * change attribute ordering
  
  * initial balancing
  
  * change naming to Same instead of Even
  
  * remove attribute bump for display
  
  * Fix diffcalc tests
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2024-12-27 16:30:30 +03:00
  824497d82c
• Implement Reading Skill into osu!taiko (#31208)
  Jay Lawton · 2024-12-21 13:19:14 +03:00
  f6a36f7b2e
• remove particular condition on convert nerf (#31196)

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Jay Lawton · 2024-12-19 17:22:16 +00:00
  d8c3d899eb
• Increase accscalingshift and include countok in hit proportion (#31195)

  * revert acc scaling shift to previous values
  
  * increase variance in accuracy values across od
  
  * move return values, move nullcheck into return
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Jay Lawton · 2024-12-19 14:45:11 +00:00
  ecd6b41928
• Refactor TaikoDifficultyCalculator and add DifficultStrain attributes (#31191)

  * refactor + countdifficultstrain
  
  * norm in utils
  
  * adjust scaling shift
  
  * fix comment
  
  * revert all value changes
  
  * add the else back
  
  * remove cds comments

  Jay Lawton · 2024-12-19 11:32:59 +00:00
  4ca88ae2d6
• Adjust DifficultyValue curve to avoid lower star rating of osu!taiko being too inflated (#31067)

  * low sr
  
  * merge two line
  
  * update decimal
  
  * fix formatting
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  YaniFR · 2024-12-18 21:11:51 +03:00
  0f2f25db53
• Implement considerations for Relax within osu!taiko diffcalc (#30591)
  Jay Lawton · 2024-12-18 18:16:27 +03:00
  79a3afe06f
• Fix strong drum rolls being counted for double the combo in legacy scoring attributes
  Bartłomiej Dach · 2024-11-29 10:54:32 +01:00
  3cfa455369