560 Commits

• Fix inspections
  Salman Ahmed · 2024-08-02 11:16:32 +03:00
  dc9f6a07cb
• Add comment
  Salman Ahmed · 2024-08-02 11:01:40 +03:00
  f5a3eb5612
• Fix clicking resume overlay hitting underlying hit circle
  Salman Ahmed · 2024-08-02 10:22:01 +03:00
  5368a43633
• Fix clicking resume cursor not triggering a gameplay press in osu!
  Salman Ahmed · 2024-08-02 10:21:44 +03:00
  eafc0f79af
• Submit vertices in local space to avoid cross-thread access
  Dan Balasescu · 2024-07-30 20:13:00 +09:00
  ff7815c3c5
• Fix cursor trail alignment issue with UI panels

  - Convert cursor trail coordinates to local space before storing.
  - Apply necessary transformations to align with other UI elements.
  - Ensure cursor trail remains connected during UI panel movements.

  Caiyi Shyu · 2024-07-25 18:23:01 +08:00
  e564b1dc9e
• Add explanatory note
  Salman Ahmed · 2024-07-19 19:19:36 +03:00
  e539670df1
• Schedule resume operation by one frame to ensure the triggered key down event does not cause a gameplay press
  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  4f6c7fe7c3
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
  Dean Herbert · 2024-06-28 18:12:20 +09:00
  55b80f70f6
• Fix playfield border size not updating in editor on circle size change
  Bartłomiej Dach · 2024-06-17 09:36:01 +02:00
  1b00d0181a
• Account for osu! circle radius when drawing playfield border

  Addresses https://github.com/ppy/osu/discussions/13167.

  Bartłomiej Dach · 2024-06-17 09:08:43 +02:00
  97003b3679
• Use delayed resume overlay for autopilot
  Dan Balasescu · 2024-05-30 19:17:18 +09:00
  f6a59bee9a
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Apply required changes after framework masking updates
  Dan Balasescu · 2024-05-09 20:18:53 +09:00
  3b8b56cbcb
• Fix resume overlay not appearing after pausing inside window but outside of actual playfield area

  Related to https://github.com/ppy/osu/discussions/27871 (although does
  not actually fix the issue with the pause button, _if_ it is to be
  considered an issue - the problem there is that the gameplay cursor
  gets hidden, so the other condition in the modified check takes over).
  
  Regressed in
  https://github.com/ppy/osu/commit/bce3bd55e5a863e52f41598c306a248a79638843.
  Reasoning for breakage is silent change in `this` when moving the
  `Contains()` check (`DrawableRuleset` will encompass screen bounds,
  while `OsuResumeOverlay` is only as big as the actual playfield).

  Bartłomiej Dach · 2024-04-16 13:45:09 +02:00
  e5e345712e
• Apply NRT in OsuResumeOverlay
  Bartłomiej Dach · 2024-04-16 13:39:06 +02:00
  f9873968a5
• Merge branch 'master' into tcm-resume
  Dan Balasescu · 2024-03-14 12:22:46 +09:00
  0beaa8e8c5
• Adjust NRT to prevent future issues

  This way, it will yet at us if the setter is ever moved out of the ctor.

  Dan Balasescu · 2024-03-11 15:52:40 +09:00
  e0f1f70b82
• Fix nullability hint
  Dean Herbert · 2024-03-11 14:43:58 +08:00
  091425db30
• Add inline comment explaining optimisation
  Dean Herbert · 2024-03-11 11:28:15 +08:00
  f3d154a995
• Apply NRT to OsuPlayfield
  Dean Herbert · 2024-03-11 11:26:03 +08:00
  2be6d1f1c6
• Don't update SubTreeMasking in OsuPlayfield
  Andrei Zavatski · 2024-03-10 15:42:03 +03:00
  6ff4b1d7e3
• Fix catch by moving cursor-specific handling local
  Dan Balasescu · 2024-03-04 16:08:17 +09:00
  bce3bd55e5
• fix code formatting
  Sheepposu · 2024-02-27 22:03:45 -05:00
  7687ab63ed
• remove skinnable

  better to add skinnable elements later

  Sheepposu · 2024-02-27 21:51:54 -05:00
  29e5f409ba
• remove unnecessary changes
  Sheepposu · 2024-02-23 23:52:17 -05:00
  822ecb7106
• skinning changes

  improve default design

  Sheepposu · 2024-02-23 23:46:50 -05:00
  8cdd9c9ddc
• remove old files
  Sheepposu · 2024-02-23 23:45:58 -05:00
  c95e85368f
• implement pooling

  Uses pooling for all analysis objects and creates the lifetime entries from replay data when the analysis container is constructed.

  Sheepposu · 2024-02-23 23:32:35 -05:00
  4d669c56a2
• fix OsuAnalysisSettings text not updating
  Sheepposu · 2024-02-22 22:34:38 -05:00
  2a1fa8ccac
• fix formatting issues
  Sheepposu · 2024-02-22 19:01:52 -05:00
  45444b39d4
• revert mod visibility toggle
  Sheepposu · 2024-02-21 23:23:40 -05:00
  35b89966bc
• Fix cursor ripples being added on release positions in replays
  Salman Ahmed · 2024-02-17 00:53:53 +03:00
  ce903987e7
• new features + improvements

  Hit & aim markers are skinnable. Hidden can be toggled off. Aim line with skinnable color was added. The fadeout time is based on the approach rate. Cursor hide fixed.

  Sheepposu · 2024-02-10 02:02:26 -05:00
  288eed53df
• early replay analysis settings version

  committing early version for others in the discussion to do their own testing with it

  Sheepposu · 2024-02-01 10:19:09 -05:00
  b5dbf24d27
• Fix cursor scale animation not matching stable on classic skins
  Dean Herbert · 2024-01-16 17:15:25 +09:00
  c45daa373e
• Merge pull request #26545 from frenzibyte/fix-resume-cursor-transition-abused

  Fix pop-in scale transition in resume overlay affecting input area

  Bartłomiej Dach · 2024-01-15 20:06:16 +01:00
  71d0543213
• Merge pull request #26547 from bdach/cursor-ripple-pool-wrong

  Fix cursor ripple pool not loading pooled drawables ahead of time

  Dean Herbert · 2024-01-15 22:56:50 +09:00
  23815b2045
• Fix cursor ripple pool not loading pooled drawables ahead of time

  Increment the counter over at
  https://github.com/ppy/osu-framework/pull/6136.

  Bartłomiej Dach · 2024-01-15 13:22:22 +01:00
  399fc8195a
• Split out judgement pooling concepts from OsuPlayfield for reuse
  Dean Herbert · 2024-01-15 20:50:09 +09:00
  6b844ed8b6
• Apply scale transitions in resume overlay cursor to local container
  Salman Ahmed · 2024-01-15 14:03:23 +03:00
  13517869f6
• Force minimum cursor size for OsuResumeOverlay

  On cursor sizes below 0.3x it becomes exceedingly difficult to quickly locate and then accurately click the resume cursor on the pause overlay as it could as big as a handful of pixels. This clamps the minimum cursor size to 1x for the resume overlay, which is way more comfortable and more closely resembles stable.

  rushiiMachine · 2023-12-26 10:07:21 -08:00
  c087578e01
• Revert change to OsuHitWindows and move logic local to pooling initialisation
  Dean Herbert · 2023-12-21 00:48:46 +09:00
  fcf47267fd
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Adjust with framework changes
  Dan Balasescu · 2023-12-04 08:51:21 +09:00
  b56a78c6ec
• Merge branch 'master' into better-touch-settings
  Dean Herbert · 2023-11-07 23:21:59 +09:00
  c00a1d948a
• Move static method to end of file
  Dean Herbert · 2023-11-07 21:08:49 +09:00
  7bedf7cf16
• Add failing test coverage
  Dean Herbert · 2023-11-07 19:54:21 +09:00
  38c9a98e67