52 Commits

• Fix slider repeat arrows appearing too early in editor when hit markers are enabled

  Closes https://github.com/ppy/osu/issues/32880
  
  Broke in conjunction with https://github.com/ppy/osu/pull/32638 because
  of transforms not being applied to `DrawableSliderRepeat` but its
  individual pieces instead.
  
  In cross-checking with stable (visual only) the early fade in of the
  arrow should still apply, it just shouldn't be instantaneous as is
  currently ends up being with how the code is structured.

  Bartłomiej Dach · 2025-04-21 10:00:22 +02:00
  78d9bd7fb4
• Adjust again to be closer to stable
  Dean Herbert · 2025-04-03 17:25:42 +09:00
  4cd2e5ba25
• Syncrhonise tranforms between arrow and circle pieces
  Dean Herbert · 2025-04-03 15:49:15 +09:00
  f9ceb59d70
• Fix slider repeat arrow fade not matching expectations
  Dean Herbert · 2025-03-31 17:15:25 +09:00
  acc5790b74
• Fix slider repeats not properly respecting "show hit markers" setting

  Closes https://github.com/ppy/osu/issues/31286.
  
  Curious on thoughts about how the instant arrow fade looks on
  non-classic skins. On argon it's probably fine, but it does look a
  little off on triangles...

  Bartłomiej Dach · 2024-12-30 13:52:50 +01:00
  06879eee39
• Fix cross-talk between pooled DrawableSliderRepeat usage causing incorrect rotation
  Dean Herbert · 2024-03-08 11:37:13 +08:00
  fcc35a6acc
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Remove unnecessary second iteration over NestedHitObjects
  Dean Herbert · 2024-01-07 14:31:22 +09:00
  35eff639cb
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Refactor all slider input into SliderInputManager
  Dan Balasescu · 2023-12-15 16:13:32 +09:00
  6bd190c55d
• Add lenience for late-hit of slider heads
  Dan Balasescu · 2023-12-15 14:14:58 +09:00
  599fdb0128
• Add note about implementation being shared
  Dean Herbert · 2023-10-25 15:44:51 +09:00
  2f95e7a284
• Force miss head when a tick or repeat is successfully judged
  Dean Herbert · 2023-10-24 19:10:57 +09:00
  5503407907
• Standardise DrawableSliderRepeat / DrawableSliderTick judgement implementations
  Dean Herbert · 2023-10-24 19:10:57 +09:00
  5eefc5323d
• Fix legacy slider repeats becoming much too large on hit

  They had scale transforms applied to them in two places: the actual
  legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
  `DrawableSliderRepeat` level.
  
  This change moves all of the scale transforms to the skinnable pieces.
  Argon and triangles have received a copy of the previous logic each,
  so behaviour on those skins should not change.

  Bartłomiej Dach · 2023-10-17 14:47:44 +02:00
  f3cda58474
• Split out reverse arrow implementations to allow better animation
  Dean Herbert · 2023-10-02 18:43:50 +09:00
  7dd9951c44
• Simplify some maximum size specs
  Dean Herbert · 2023-09-20 12:48:15 +09:00
  8e16b1d507
• Fix nullability and remove extra preempt from SliderEndCircle calculation
  Dean Herbert · 2023-05-02 16:36:43 +09:00
  a619812cab
• Fix fade in delay for first slider end circle being incorrect when snaking disabled
  Dean Herbert · 2023-05-02 16:27:17 +09:00
  1a04be15c7
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Remove unused IHasMainCirclePiece interface
  Dean Herbert · 2022-11-09 13:31:50 +09:00
  710c224de4
• Update osu! hitobject implementation to avoid triggering ClearInternal
  Dean Herbert · 2022-09-22 15:04:20 +09:00
  749053481a
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix repeat arrows being hidden beneath head circles in legacy skins

  Aims to make minimal changes to `DrawableSlider` itself. I'm not super
  happy about the slider ball being moved above the head circle, but it
  *is* what people are used to so no one except for me is going to
  complain.
  
  Supersedes and closes https://github.com/ppy/osu/pull/14561.

  Dean Herbert · 2021-09-01 19:41:49 +09:00
  738ce0f689
• Fix slider repeat arrow not updating rotation immediately while paused in editor

  A bit of a local solution, but not sure there's a better way to handle
  this.
  
  Closes #13342.

  Dean Herbert · 2021-06-07 15:58:43 +09:00
  277eb9fa6e
• Remove defunct Animate calls
  ekrctb · 2021-06-02 11:46:28 +09:00
  c06ff3c623
• Extract scale constant
  Dean Herbert · 2021-04-26 15:30:22 +09:00
  d10aac851d
• Expose DrawableSliderRepeat's arrow and move transforms to children
  Dean Herbert · 2021-04-26 15:22:42 +09:00
  4da964c3f3
• Expose presence of MainCirclePiece via an interface
  Dean Herbert · 2021-04-26 15:22:17 +09:00
  aa7ade8186
• Animate back slider repeat and tail circle pieces
  Salman Ahmed · 2021-04-26 02:39:49 +03:00
  0b9172a1dc
• Adjust namespace
  ekrctb · 2020-12-04 20:21:53 +09:00
  245be2c5ed
• Merge branch 'dho-remove-onparentreceived' into fix-hidden-mod-crash
  smoogipoo · 2020-12-03 20:10:16 +09:00
  09af4bbd57
• Remove OnParentReceived()
  smoogipoo · 2020-12-03 20:08:42 +09:00
  0bdf99b97a
• Change order of OnParentReceived()
  smoogipoo · 2020-12-03 20:06:26 +09:00
  73e99718bc
• Rework osu! hidden mod to avoid storing hitobjects
  smoogipoo · 2020-12-03 14:45:56 +09:00
  e3bbc2b128
• Add nested osu! hitobject pooling
  smoogipoo · 2020-11-12 15:59:48 +09:00
  3f78d81386
• Merge branch 'master' into drawable-hit-object-hit-state-fix
  Dean Herbert · 2020-11-05 17:07:52 +09:00
  0cadb31947
• Use BDL for top-level osu! DHOs
  smoogipoo · 2020-11-05 13:51:46 +09:00
  9a7fcadabc
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Remove redundant array type specification
  Dean Herbert · 2020-10-02 19:56:24 +09:00
  a3ecc6c5a4
• Fix hidden mod support for sliderendcircle
  Dean Herbert · 2020-10-02 18:41:28 +09:00
  5a6c45e2ff
• Add final sliderendcircle display support
  Dean Herbert · 2020-10-02 14:50:03 +09:00
  5d2a8ec764
• Use new hit results in osu
  smoogipoo · 2020-09-29 16:33:38 +09:00
  a77741927c
• Hide slider repeat judgements temporarily
  Dean Herbert · 2020-07-22 19:30:10 +09:00
  bd6a51f545
• Also fix slider repeat circles
  Dean Herbert · 2020-04-08 18:59:31 +09:00
  067ec27859
• Reword comment
  Dean Herbert · 2020-03-30 18:35:01 +09:00
  c4df49954f
• Add a comment
  Endrik Tombak · 2020-03-29 10:50:43 +03:00
  2ab8267f84
• Don't snake when hit
  Endrik Tombak · 2020-03-28 23:12:13 +02:00
  d3114ca858