2038 Commits

• Add some comments
  ekrctb · 2021-07-26 17:58:34 +09:00
  c08130398c
• Move catcher trail generation logic to Catcher

  It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
  Trail generation logic is moved to `Catcher`.
  The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
  Instead, the last time a trail is generated is calculated and used.
  The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.

  ekrctb · 2021-07-26 17:51:59 +09:00
  bb046fa3b8
• Merge pull request #12683 from frenzibyte/legacy-beatmap-combo-offset

  Apply combo offsets "colour hax" only on beatmap skins

  Dean Herbert · 2021-07-23 14:30:18 +09:00
  50a2abbe7f
• Merge pull request #13983 from ekrctb/juice-stream-placement

  Add initial implementation of juice stream placement

  Dean Herbert · 2021-07-23 13:52:25 +09:00
  a7d6c682de
• Fix previously placed vertices in juice stream placement

  A different UX than not fixing vertices.

  ekrctb · 2021-07-23 10:18:37 +09:00
  bd3386e770
• Use the more consistent lastVertex, with a comment
  ekrctb · 2021-07-23 10:13:55 +09:00
  4509c8bcfb
• Call GetContainingInputManager at LoadComplete
  ekrctb · 2021-07-23 10:10:55 +09:00
  d49d303bae
• Add ComboIndexWithOffsetsBindable and bind similar to ComboIndexBindable
  Salman Ahmed · 2021-07-22 16:40:33 +03:00
  523c154f15
• Implement reversing of selected pattern in catch editor
  ekrctb · 2021-07-22 17:00:08 +09:00
  9fff304554
• EditorBeatmap.SelectedHitObjects -> SelectedItems (same thing)
  ekrctb · 2021-07-22 16:52:47 +09:00
  dc90e4d24c
• Add initial implementation of juice stream placement
  ekrctb · 2021-07-22 15:47:23 +09:00
  64102d2972
• Add empty juice stream placement blueprint (no implementation)
  ekrctb · 2021-07-22 15:47:23 +09:00
  2beef89c23
• Merge pull request #13961 from ekrctb/catch-editor-flip

  Implement horizontal flipping of hit objects in catch editor

  Dean Herbert · 2021-07-22 15:27:59 +09:00
  e8aaf4df16
• Merge pull request #13937 from ekrctb/selection-editable-path

  Add initial implementation of juice stream path editing

  Dean Herbert · 2021-07-22 14:48:02 +09:00
  1d2fdd9841
• Rename variables for catch-specific casting to avoid any confusion
  Dean Herbert · 2021-07-22 14:07:32 +09:00
  2151c1863e
• Guard against empty range in PositionRange
  ekrctb · 2021-07-22 13:29:32 +09:00
  19657cd00e
• Don't show the flip button when flipping is a no-op
  ekrctb · 2021-07-22 13:29:32 +09:00
  7b6981c632
• Don't handle mouse down at fixed vertices
  ekrctb · 2021-07-22 12:58:39 +09:00
  d93bf5be80
• Merge branch 'master' into catch-editor-flip
  Dean Herbert · 2021-07-21 19:54:39 +09:00
  73866c2837
• Rename property, reword xmldoc and improve readability of update code
  Dean Herbert · 2021-07-21 17:32:56 +09:00
  399c3b0be8
• Merge branch 'master' into catcher-area-catcher

  # Conflicts:
  #	osu.Game.Rulesets.Catch.Tests/TestSceneCatcher.cs

  ekrctb · 2021-07-21 16:45:28 +09:00
  179ba3c9a8
• Move catcher base size constant to Catcher.
  ekrctb · 2021-07-21 16:43:24 +09:00
  d9f9ad35be
• Add some doc comment to CatcherArea
  ekrctb · 2021-07-21 16:40:35 +09:00
  30777795ce
• Rename CatcherArea.MovableCatcher to Catcher
  ekrctb · 2021-07-21 16:28:31 +09:00
  94678064ff
• Implement horizontal flipping of hit objects in catch editor
  ekrctb · 2021-07-21 16:07:02 +09:00
  d2d3214d47
• Use added position range computation in hit object move handling
  ekrctb · 2021-07-21 16:06:34 +09:00
  4c8b9c168e
• Add function of computing position range occupied by hit objects
  ekrctb · 2021-07-21 16:06:34 +09:00
  60f876511d
• Add some doc comment to JuiceStreamSelectionBlueprint
  ekrctb · 2021-07-21 13:27:07 +09:00
  cd447f0305
• Add doc comment to VertexState
  ekrctb · 2021-07-21 13:17:18 +09:00
  cc0110aa52
• Use existing method for the same code
  ekrctb · 2021-07-21 12:59:42 +09:00
  97fba5df58
• Fix comment
  ekrctb · 2021-07-21 12:53:48 +09:00
  ca3dfb2498
• Revert making ComboOffsets legacy and define BeatmapSkinComboIndex instead
  Salman Ahmed · 2021-07-20 14:15:43 +03:00
  9d92b795fa
• Merge branch 'refactor-combo-colour-retrieval' into legacy-beatmap-combo-offset
  Salman Ahmed · 2021-07-20 10:11:52 +03:00
  554652b033
• Merge branch 'master' into refactor-combo-colour-retrieval
  Salman Ahmed · 2021-07-20 10:08:25 +03:00
  1af230c48c
• Implement vertex deletion in juice stream selection blueprint
  ekrctb · 2021-07-19 22:53:32 +09:00
  8586458704
• Implement vertex addition in juice stream selection blueprint
  ekrctb · 2021-07-19 22:53:32 +09:00
  08f8d4e65e
• Add initial juice stream editing
  ekrctb · 2021-07-19 22:53:32 +09:00
  8cc1630655
• Merge pull request #13928 from ekrctb/juice-stream-path

  Add `JuiceStreamPath` as alternative representation of `JuiceStream` path for catch editor

  Dean Herbert · 2021-07-19 22:18:05 +09:00
  6d49165664
• Fix item ordering
  ekrctb · 2021-07-19 21:05:36 +09:00
  81d0a9bd9c
• Add [NotNull]
  ekrctb · 2021-07-19 20:20:10 +09:00
  41169fbdaf
• Move child drawable creation of CatchPlayfield from constructor to load.
  ekrctb · 2021-07-19 20:18:17 +09:00
  7201cfe0b4
• Fix catcher trails displayed in wrong place
  ekrctb · 2021-07-19 20:13:31 +09:00
  879467961f
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Replace usage of CatcherArea.MovableCatcher with Catcher
  ekrctb · 2021-07-19 19:52:40 +09:00
  50f9e5f362
• Create Catcher in CatchPlayfield
  ekrctb · 2021-07-19 19:44:40 +09:00
  97059a9f50
• Merge pull request #13887 from ekrctb/legacy-converted-y

  Preserve Y position of hit objects in osu!catch

  Dean Herbert · 2021-07-19 18:48:23 +09:00
  23ef666f34
• Move playfield constant to top of file and make internal
  Dean Herbert · 2021-07-19 18:41:29 +09:00
  443058f879
• Add JuiceStreamPath to allow editing JuiceStream in catch editor

  A `JuiceStream` holds a legacy `SliderPath` as the representation of the path.
  However, the `SliderPath` representation is difficult to work with because `SliderPath` works in 2D position, while osu!catch works in `(time, x)` coordinates.
  This `JuiceStreamPath` represents the path in a more convenient way, a polyline connecting list of `(distance, x)` vertices.

  ekrctb · 2021-07-19 13:59:10 +09:00
  be495a7488
• Use added utility function
  ekrctb · 2021-07-19 13:33:46 +09:00
  c347584851
• Add a function to compute hit object position in catch editor
  ekrctb · 2021-07-19 13:33:22 +09:00
  70c9d7105f