127 Commits

• Add beat snap grid for osu!catch editor

  As discussed in https://github.com/ppy/osu/discussions/23462.

  Dean Herbert · 2023-06-06 17:52:29 +09:00
  c1f23ef211
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Remove #nullable disable from Catch.UI
  ekrctb · 2023-01-15 17:29:35 +09:00
  b88091262d
• Remove unused using statements
  Dean Herbert · 2022-12-13 18:57:17 +09:00
  775952380f
• hide cursor in catch
  Dylan Nantz · 2022-12-12 21:18:01 -05:00
  0dd4e0cf94
• Remove unused using directive
  Bartłomiej Dach · 2022-11-30 20:01:59 +01:00
  7f68fe429f
• Fix potential null dereference in CatchPlayfield
  Bartłomiej Dach · 2022-11-30 20:01:11 +01:00
  285248d554
• Hide the game mouse cursor when playing osu!catch with relax mod
  Dean Herbert · 2022-11-30 18:13:53 +09:00
  5ce2d6f54a
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Allow arbitrary height catch editor

  Useful because can see more notes at once.

  ekrctb · 2022-10-06 17:26:03 +09:00
  e8cd9a5d11
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Move catcher trail generation logic to CatcherArea
  ekrctb · 2021-07-27 19:07:37 +09:00
  da69867fd4
• Move catcher trail generation logic to Catcher

  It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
  Trail generation logic is moved to `Catcher`.
  The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
  Instead, the last time a trail is generated is calculated and used.
  The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.

  ekrctb · 2021-07-26 17:51:59 +09:00
  bb046fa3b8
• Rename CatcherArea.MovableCatcher to Catcher
  ekrctb · 2021-07-21 16:28:31 +09:00
  94678064ff
• Fix item ordering
  ekrctb · 2021-07-19 21:05:36 +09:00
  81d0a9bd9c
• Move child drawable creation of CatchPlayfield from constructor to load.
  ekrctb · 2021-07-19 20:18:17 +09:00
  7201cfe0b4
• Fix catcher trails displayed in wrong place
  ekrctb · 2021-07-19 20:13:31 +09:00
  879467961f
• Pass DroppedObjectContainer via constructor instead of DI

  It is now just one level deep, so it is not beneficial to use DI here.
  This effectively reverts ae09c23e.

  ekrctb · 2021-07-19 20:11:49 +09:00
  b88ee3c1a1
• Replace usage of CatcherArea.MovableCatcher with Catcher
  ekrctb · 2021-07-19 19:52:40 +09:00
  50f9e5f362
• Create Catcher in CatchPlayfield
  ekrctb · 2021-07-19 19:44:40 +09:00
  97059a9f50
• Resolve DroppedObjectContainer via DI
  ekrctb · 2021-06-24 16:09:13 +09:00
  ae09c23e4e
• Add DroppedObjectContainer class
  ekrctb · 2021-06-24 15:51:54 +09:00
  16d5893535
• Remove unused argument from CatchPlayfield
  ekrctb · 2021-06-22 15:23:50 +09:00
  b54e82eb99
• Make sure latest catcher position is used for catching logic

  A replay frame processed in CatchInputManager is applied to catcher in `CatcherArea`.
  The catcher position is then used for the catching logic for each hit object under `HitObjectContainer`.
  Thus, if `HitObjectContainer` came before `CatcherArea`, the replay input is delayed one frame.
  That was one reason why the catch autoplay misses hit objects (especially when fast-forwarded).

  ekrctb · 2021-04-09 16:04:45 +09:00
  6d0dc62502
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Move catcher state changing logic to OnNewResult method
  ekrctb · 2020-12-08 14:28:30 +09:00
  0213f77b4b
• Fix depth of dropped objects
  ekrctb · 2020-12-04 10:21:54 +09:00
  e82ca66d3e
• Refactor fruit dropping code

  - The repeated `Remove` call was quadratic complexity.
    Now it is linear time.

  ekrctb · 2020-12-03 16:44:36 +09:00
  2eb2c934cc
• Use bigger initial capacity for catch hit object pool
  ekrctb · 2020-12-01 14:50:42 +09:00
  e8842eed81
• Use hit object pooling for BananaShower.
  ekrctb · 2020-11-30 19:22:40 +09:00
  70628235e3
• Use hit object pooling for JuiceStream.

  - Use `Clear(false)` to not dispose pooled children.
  - Don't set nested DHO `Origin`.
  - Simplify the layout (remove custom `Origin`).

  ekrctb · 2020-11-30 19:19:14 +09:00
  9611aaf09e
• Use hit object pooling for Fruit and Banana.
  ekrctb · 2020-11-30 19:07:50 +09:00
  b76ae525b2
• Use hit object pooling for Droplet and TinyDroplet.
  ekrctb · 2020-11-30 19:04:09 +09:00
  94fd607a7c
• Don't use CreateDrawableRepresentation in CatcherArea
  ekrctb · 2020-11-30 19:02:49 +09:00
  05aaa377e7
• Add comment explaining requirement
  Dean Herbert · 2020-11-30 15:22:55 +09:00
  9fbfb1aa9f
• Fix osu!catch combo counter not showing after 1 combo
  Dean Herbert · 2020-11-30 15:20:52 +09:00
  73990a6674
• Remove more code and make some methods private
  ekrctb · 2020-11-22 18:51:16 +09:00
  c506b438bf
• Event -> virtual method
  ekrctb · 2020-11-21 15:20:33 +09:00
  4345d8dcb6
• Rework and rename to OnNewDrawableHitObject.

  The semantics is changed and hopefully more clear.

  ekrctb · 2020-11-21 00:27:19 +09:00
  82aefa3868
• Use events instead of overriding Add (catch)
  ekrctb · 2020-11-20 17:56:47 +09:00
  468b2a97cb
• Encapsulate combo display better
  Bartłomiej Dach · 2020-09-12 22:40:34 +02:00
  fcf3a1d13c
• Move osu!catch combo counter display to inside CatcherArea
  Salman Ahmed · 2020-09-01 20:17:21 +03:00
  ba8a4eb6f0
• Fix wrong ordering
  Salman Ahmed · 2020-08-04 00:04:00 +03:00
  4dbf695bca
• Add catch-specific combo counter with its legacy design
  Salman Ahmed · 2020-08-03 22:13:02 +03:00
  f37ba49f7f
• Expose via CreateProxiedContent method
  Dean Herbert · 2020-07-16 15:35:19 +09:00
  c42b315abb
• Remove space
  Dean Herbert · 2020-07-15 22:00:48 +09:00
  3666599053
• Remove redundant array spec
  Dean Herbert · 2020-07-15 21:52:37 +09:00
  72789dc0aa
• Fix osu!catch dropping fruit appearing above the plate instead of behind
  Dean Herbert · 2020-07-15 20:58:09 +09:00
  2624862e32
• Standardize osu!catch coordinate system

  There were two coordinate systems used:
  - 0..512 (used in osu!stable)
  - 0..1 (relative coordinate)
  
  This commit replaces the usage of
  the relative coordinate system to
  the coordinate system of 0..512.

  ekrctb · 2020-07-02 00:21:45 +09:00
  3278a1d7d8