Bartłomiej Dach
4cfc95c673
Add backwards migration of catch dash binding
2023-10-17 09:43:40 +02:00
Dean Herbert
1b9acdf55c
Abstract out common implementation of BeatSnapGrid
2023-10-17 16:42:52 +09:00
Dean Herbert
d26d4b8b79
Cache IScrollingInfo at a HitObjectComposer level automatically
2023-10-17 16:42:22 +09:00
Bartłomiej Dach
79a4b985fe
Use left mouse as alternative default binding for catch dash
...
This mirrors stable. Although the way stable does this is pretty dodgy,
see:
https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Play/Rulesets/Fruits/RulesetFruits.cs#L274-L275
2023-10-17 09:31:29 +02:00
Dean Herbert
165cd07428
Persist the state of "show speed changes" between editor sessions
...
Addresses https://github.com/ppy/osu/discussions/25149 .
2023-10-17 16:01:02 +09:00
Dan Balasescu
6f4a2b9889
Merge pull request #25111 from peppy/mania-bonus-refactor
...
Change osu!mania "perfect" judgements to only award bonus score
2023-10-17 14:27:54 +09:00
Dan Balasescu
d2a3f14d5b
Merge branch 'master' into mania-bonus-refactor
2023-10-17 13:28:04 +09:00
Bartłomiej Dach
240d317928
Merge pull request #25143 from peppy/split-spinner-fix
...
Apply various fixes and cleanup to spinner logic
2023-10-16 22:30:24 +02:00
Bartłomiej Dach
828cedea33
Fix bindings being cleared if multiple bindings for same action have the same combination
...
This actually seems to be the case in catch (dash is bound to shift
twice). This is annoying but harmless, so let's work around it for now
to avoid ruining users' configs.
2023-10-16 22:20:26 +02:00
Bartłomiej Dach
3aae07d1ca
Add failing case for two bindings of single action bound to same key
2023-10-16 22:20:26 +02:00
Bartłomiej Dach
9c6166ec3d
Add migration to remove duplicate bindings
2023-10-16 22:20:26 +02:00
Bartłomiej Dach
639c96e60c
Prevent ruleset input managers from reading duplicate bindings
2023-10-16 21:02:24 +02:00
Bartłomiej Dach
90c44cee54
Implement method to deduplicate keybindings
2023-10-16 20:51:57 +02:00
Bartłomiej Dach
79273b88f6
Add stub of method to deduplicate bindings (and failing test)
2023-10-16 20:48:52 +02:00
Bartłomiej Dach
f14928cdfb
Merge branch 'master' into split-spinner-fix
2023-10-16 18:59:08 +02:00
Dan Balasescu
3065c9f23d
Fix potential frame misordering in generator
2023-10-16 22:49:41 +09:00
Bartłomiej Dach
b3d60c6d4f
Add inline commentary about workarounds in beatmap conversion test
2023-10-16 13:40:45 +02:00
Bartłomiej Dach
937694cd14
Fix conversion test failures
2023-10-16 13:37:11 +02:00
Dean Herbert
75011db3a7
Merge pull request #25142 from bdach/clean-up-scoring-difficulty-attributes
...
Remove no longer used scoring difficulty attributes
2023-10-16 20:16:20 +09:00
Bartłomiej Dach
f2436a5ecb
Remove no longer used scoring difficulty attributes
2023-10-16 12:36:58 +02:00
Dean Herbert
0bb95cfa88
Fix incorrect initial rotation transfer value
...
Should have been removed as part of https://github.com/ppy/osu/pull/24360 .
2023-10-16 19:34:55 +09:00
Dean Herbert
10bab61441
Tidy up lastAngle usage and add assertion of maximum delta
2023-10-16 19:34:22 +09:00
Dean Herbert
04af46b8c7
Change SpinFramesGenerator to take degrees as input
2023-10-16 18:34:56 +09:00
Dean Herbert
28ee99f132
Add prospective test coverage of spinner input handling
2023-10-16 18:31:01 +09:00
Dean Herbert
cfa4adb24d
Add SpinFramesGenerator class to simplify creating spinner tests
2023-10-16 18:25:40 +09:00
Dean Herbert
159b24acf7
Rename RateAdjustedRotation to TotalRotation
2023-10-16 18:25:03 +09:00
Dan Balasescu
84be714d6b
Fix large instantaneous delta on first frame
...
Happens when the first update frame comes in before any mouse input.
2023-10-16 18:17:11 +09:00
Bartłomiej Dach
9cd33d9bb2
Merge pull request #25139 from peppy/collection-ordering-fix
...
Fix collections not being sorted alphabetically in context menus
2023-10-16 10:53:43 +02:00
Bartłomiej Dach
ee3ddacf46
Merge pull request #25140 from peppy/manage-collections-drag-handles-bye-bye
...
Remove drag handles from manage collections dialog for now
2023-10-16 10:47:38 +02:00
Bartłomiej Dach
38d92187af
Merge pull request #25136 from peppy/fix-taiko-hp-bar-animation
...
Fix health bar animating when it shouldn't be
2023-10-16 10:30:17 +02:00
Bartłomiej Dach
c48142816c
Reformat long lines
2023-10-16 09:06:34 +02:00
Bartłomiej Dach
624c05e0ff
Rename test step
2023-10-16 09:04:53 +02:00
Dean Herbert
7139592e43
Fix collections not being sorted correctly in context menus
2023-10-16 16:03:12 +09:00
Bartłomiej Dach
b9a84127ac
Remove mention of "any tick"
...
They're very dead now.
2023-10-16 08:57:35 +02:00
Bartłomiej Dach
db00b794a2
Fix test failure due to missing zero (and FP shenanigans)
2023-10-16 08:53:56 +02:00
Dean Herbert
36112302d6
Remove drag handles from manage collections dialog for now
...
The realm implementation doesn't support this.
2023-10-16 15:51:18 +09:00
Dean Herbert
d9d0629157
Fix code quality inspection (weird one)
2023-10-16 15:16:10 +09:00
Dean Herbert
4f1546c474
Rename PerfectBonusNote to NotePerfectBonus
2023-10-16 15:14:28 +09:00
Dean Herbert
3f09ed396f
Fix legacy skin body piece dimming when it shouldn't
2023-10-16 15:11:33 +09:00
Dean Herbert
1a957364ae
Add empty hit windows on PefectBonusNote
2023-10-16 14:58:49 +09:00
Dean Herbert
43f619f92a
Add DisplayResult flag and remove unnecessary AlwaysPresent
2023-10-16 14:57:58 +09:00
Dean Herbert
14fedffcc1
Fix MissForcefully not considering the bonus object
2023-10-16 14:53:36 +09:00
Dean Herbert
7c49843411
Fix various tests
2023-10-16 14:21:33 +09:00
Dean Herbert
e85c039722
Adjust method flow to hopefully be more legible
2023-10-16 13:31:14 +09:00
Dean Herbert
ddbda69751
Remove nullability of bonusNote
2023-10-16 13:14:58 +09:00
Dean Herbert
48832c64ac
Fix health bar animating when it shouldn't be
...
It wasn't correctly checking the current underlying health, which could
be zero in usages of `AccumulatingHealthProcessor`, for instance.
Closes #25046 .
2023-10-16 13:12:04 +09:00
Dean Herbert
54722bf251
Merge pull request #25113 from nekodex/generic-error-sfx
...
Use new `generic-error` sample in appropriate places
2023-10-14 04:35:12 +09:00
Dean Herbert
67a8a51ec7
Merge branch 'master' into generic-error-sfx
2023-10-14 03:56:41 +09:00
Dean Herbert
3cb9945545
Merge pull request #25101 from peppy/fix-hr-cs-mania-adjustment
...
Fix "Hard Rock" mod affecting CS/AR in osu!mania and osu!taiko
2023-10-14 03:56:24 +09:00
Dean Herbert
d4627a2402
Update resources
2023-10-14 03:48:59 +09:00
