Bartłomiej Dach
4ead7ea33f
Merge branch 'master' into fix-leaderboard-fetch-wrong
2023-01-03 20:01:30 +01:00
Bartłomiej Dach
3d425c93e6
Merge branch 'master' into fix-combo-colour-export
2023-01-03 19:21:24 +01:00
Dean Herbert
beb3b96aca
Harden request equality checks
2023-01-04 01:44:00 +08:00
Dean Herbert
96e81e7f41
Switch on NRT and add IEquatable to GetScoresRequest
2023-01-04 01:41:21 +08:00
Salman Ahmed
4491a5ba9f
Fix editor exporting beatmap combo colours in wrong order
2023-01-03 13:41:08 +03:00
Dean Herbert
ac85433178
Fix default volume control keys not working when chat textbox is focused
...
Closes #22004 .
2023-01-03 09:44:35 +08:00
Dean Herbert
8f7ae0395a
Fix song select leaderboard potentially showing wrong scores on quick beatmap changes
...
Closes #22002 .
2023-01-03 00:55:09 +08:00
Bartłomiej Dach
88e90d5fa0
Enable NRT in user profile overlay
2023-01-01 23:49:11 +01:00
Bartłomiej Dach
b689ad6d80
Fix changing preview point not prompting for save
2023-01-01 19:54:26 +01:00
Bartłomiej Dach
efdd557f3b
Adjust binding logic
2023-01-01 19:45:23 +01:00
Bartłomiej Dach
452ebddfd2
Adjust visual appearance of preview time part
...
- Use slightly different hue of green to distinguish from difficulty
control points. The colour is still not ideal, but picking
a distinctive enough hue is pretty hard.
- Place the preview time part at the bottom rather at the top.
Not sure why it was at the top; not only could it overlap with the
control points, but it also looked quite badly misaligned there
when bookmarks were displayed at the bottom.
2023-01-01 19:42:55 +01:00
Bartłomiej Dach
a82f1a6abd
Adjust method naming and copy
2023-01-01 18:50:47 +01:00
Bartłomiej Dach
0e59b55a12
Merge branch 'master' into previewTime
2023-01-01 18:38:19 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel
2023-01-01 17:29:38 +01:00
Dean Herbert
7e39ee3982
Merge pull request #21945 from cdwcgt/acc-UI
...
Add new display modes for accuracy counter
2023-01-01 23:20:12 +08:00
Dean Herbert
9a4f0cad2c
Fix incorrect domain root being used for recent activity entries on profile overlay
...
Closes https://github.com/ppy/osu/issues/21980 .
2023-01-01 17:48:05 +08:00
Dean Herbert
87250ad847
Add search keywords for beatmap colours / hitsound overrides
2023-01-01 14:32:28 +08:00
Bartłomiej Dach
6509d3538c
Fix counter initially rolling down from 100% to 0% in minimum achievable mode
2022-12-30 21:13:41 +01:00
Bartłomiej Dach
7580ab78be
Move binding to LoadComplete()
2022-12-30 21:08:48 +01:00
Bartłomiej Dach
6ed474d4fb
Rearrange formula for maximum accuracy
...
Feels like it's easier to understand this way. The difference of the
maximum scoring values for the entire beatmap and the max values for the
part of the beatmap that has already been played represents the act of
filling the rest of the unjudged objects with maximum results.
2022-12-30 20:56:54 +01:00
Bartłomiej Dach
8ace635249
Adjust minimum values
2022-12-30 20:55:51 +01:00
Bartłomiej Dach
bb2822a175
xmldoc pass
2022-12-30 20:55:48 +01:00
Bartłomiej Dach
6d42cc5a36
Naming pass
2022-12-30 20:30:58 +01:00
cdwcgt
d60349c7c6
add description
2022-12-30 23:24:41 +09:00
cdwcgt
8beb168be9
remove nullable disabled
2022-12-30 23:24:20 +09:00
cdwcgt
784fe7ecf2
rename AccType to AccuracyDisplay
2022-12-30 23:06:10 +09:00
cdwcgt
23c485c763
readonly
2022-12-30 22:59:56 +09:00
cdwcgt
a91da2284d
safe way to pass bindable
2022-12-30 22:58:46 +09:00
cdwcgt
3c32a50c12
add new accuracy counter display
2022-12-30 21:19:46 +09:00
Bartłomiej Dach
0d70f2c0fd
Use alternative workaround
2022-12-30 09:08:17 +01:00
Bartłomiej Dach
f625c5d744
Fix gradient showing when toggling toolbar with mouse above window
2022-12-29 23:35:45 +01:00
Bartłomiej Dach
bf975eb48a
Fix toolbar gradient not showing when mouse is hovered over buttons
2022-12-29 23:03:53 +01:00
Dean Herbert
ccf713c885
Fix incorrect hard link validity check in stable import screen
2022-12-29 23:18:12 +08:00
Dean Herbert
0fcf10e10a
Also support hard links on macOS
2022-12-29 22:35:13 +08:00
Dean Herbert
f9f6918fc3
Merge branch 'master' into add_linux_hardlink
2022-12-29 21:29:57 +08:00
Bartłomiej Dach
c5f7da9a4e
Fix hover propagating through toolbar buttons
...
Closes #21920 .
Weirdly enough this was semeingly fixed once before in ancient times in
3891f467a3566e09083f#9447 .
2022-12-29 13:19:14 +01:00
Joseph Madamba
70dbb8edac
Fix stand alone chat display textbox not binding to local channel
2022-12-29 01:37:37 -08:00
Joseph Madamba
c326745f96
Save / sync chat text box messages per channel
2022-12-28 16:09:40 -08:00
Joseph Madamba
b40d114e76
Remove context menu from news card for now
2022-12-28 15:00:57 -08:00
Bartłomiej Dach
74bc5d4666
Disable naming rule inspection on struct stat definition
2022-12-28 22:38:42 +01:00
Bartłomiej Dach
10c11e974d
Fix broken spacing
2022-12-28 22:24:21 +01:00
Bartłomiej Dach
49b0ec9ddb
Fix broken condition
2022-12-28 22:24:18 +01:00
Bartłomiej Dach
8d79fa93ac
Implement GetFileLinkCount() for Linux
2022-12-28 22:14:56 +01:00
Bartłomiej Dach
d4b3965967
Change warning message about file duplication
...
- It was being glued in an ugly way that would have prevented sanely
localising it.
- Even on Linux, the filesystem (whichever one the user has chosen out
of the multitude available) still needs to support hard links for them
to have a chance of working.
2022-12-28 22:04:08 +01:00
Bartłomiej Dach
04d4b4a6ce
Rename and xmldoc hard link creation method
2022-12-28 22:04:05 +01:00
Bartłomiej Dach
cadd487c75
Use switch statement in AttemptHardLink()
2022-12-28 21:20:49 +01:00
Bartłomiej Dach
2c346eae0d
Revert inlining of hard link creation into condition
...
Just feels bad. Mixing data access with actual underlying logic.
2022-12-28 21:19:28 +01:00
BlauFx
d63be3ff17
Change name of variable
2022-12-28 15:02:44 +01:00
BlauFx
c6da7248ba
Remove unnecessary directive
2022-12-28 14:40:32 +01:00
BlauFx
53bca947d1
Move duplicated code into its own method
2022-12-28 14:34:27 +01:00
BlauFx
f32564652b
Mention the filesystem should be NTFS on Windows
2022-12-28 14:33:38 +01:00
BlauFx
5c5e84f931
Fix formatiing
2022-12-28 14:06:50 +01:00
Dean Herbert
ea8beffa61
Merge pull request #21871 from bdach/solo-statistics-watcher-reliability
...
Improve reliability of solo statistics watcher
2022-12-28 21:05:38 +08:00
BlauFx
16165b1f67
Remove blank line
2022-12-28 13:58:52 +01:00
Bartłomiej Dach
e4c060fc3a
Merge pull request #21854 from peppy/fix-website-root
...
Fix `osu.ppy.sh` links no longer opening in-game
2022-12-28 13:43:24 +01:00
BlauFx
b2aa2e1602
Add hardlink support for Linux
2022-12-28 13:32:49 +01:00
Bartłomiej Dach
4b71ccf315
Merge pull request #21879 from frenzibyte/first-object-visbility-keywords
...
Add keywords to ease search of "first object visibility" setting
2022-12-28 12:15:34 +01:00
Salman Ahmed
b4c5e18da0
Add keywords to ease search of "first object visibility" setting
2022-12-28 13:23:50 +03:00
Bartłomiej Dach
3c0b8af8f1
Allow unsubscribing from solo statistics updates
...
This is more of a safety item. To avoid potential duplicate key in
dictionary errors (and also avoid being slightly memory-leaky), allow
`SoloStatisticsWatcher` consumers to dispose of the subscriptions they
take out.
2022-12-28 08:07:48 +01:00
Bartłomiej Dach
04f9a354c3
Convert SoloResultsScreen to NRT
2022-12-28 07:54:36 +01:00
Bartłomiej Dach
a0a26b1e8c
Ignore statistics update subscriptions with invalid score ID
...
If score submission fails, the score will not receive a correct online
ID from web, but will still be passed on to the solo statistics watcher
on the results screen. This could lead to the watcher subscribing to
changes with score ID equal to the default of -1. If this happened more
than once, that would cause a crash due to duplicate keys in the
`callbacks` dictionary.
Closes #21837 .
2022-12-28 07:54:01 +01:00
Bartłomiej Dach
e9d32fca18
Fix various failures in initial statistics fetch
...
- If the local user is restricted, then attempting to fetch their data
from the `/users` endpoint would result in an empty response.
- Even if the user was successfully fetched, their `RulesetsStatistics`
may not be populated (and instead be `null`). Curiously this was not
picked up by static analysis until the first issue was fixed.
Closes #21839 .
2022-12-28 07:31:36 +01:00
Dean Herbert
0d78bc2248
Fix osu.ppy.sh links no longer opening in-game
...
Addresses https://github.com/ppy/osu/discussions/21838 .
2022-12-28 06:42:35 +08:00
Bartłomiej Dach
e90619244d
Fix incorrect accuracy display on overall ranking view
2022-12-27 19:51:51 +01:00
Bartłomiej Dach
ae2058b55e
Merge branch 'master' into split_trimentries
2022-12-27 18:07:36 +01:00
Salman Ahmed
1a4489edb2
Move version pinning of system packages to osu.Game
2022-12-27 14:58:18 +03:00
Dean Herbert
61029b126d
Add link to hard link explanation wiki page
2022-12-27 17:56:23 +08:00
Dean Herbert
b3e44f20bc
Use new lazer API endpoint
...
This is a temporary change to target the new experimental/next deploy.
The main change that should result from this is having the user profile
show the pp^next values from the new domain.
2022-12-27 17:20:40 +08:00
Berkan Diler
182f36c434
Use StringSplitOptions.TrimEntries for string.Split() when possible
2022-12-27 09:41:58 +01:00
Dean Herbert
df6f2ad0a1
Merge pull request #21804 from bdach/hide-global-rankings-when-presenting-scores
...
Only show global rankings on solo results screen when progressing from gameplay
2022-12-27 16:39:26 +08:00
Joseph Madamba
777ffcf805
Highlight "open" option on external link button context menu
2022-12-26 20:47:24 -08:00
Joseph Madamba
bb58976838
Merge remote-tracking branch 'upstream/master' into overlay-panels-context-menu
2022-12-26 17:54:15 -08:00
Joseph Madamba
8bc8b0d0af
Remove redundant context menu container
2022-12-26 15:38:07 -08:00
Joseph Madamba
84e3858a86
Move context menu / popover container one level to account for header
2022-12-26 15:37:46 -08:00
Bartłomiej Dach
01cf96e240
Only show global rankings on results screen when progressing from gameplay
2022-12-26 23:35:45 +01:00
Bartłomiej Dach
cb2b0d4178
Remove redundant type specs
2022-12-26 23:12:53 +01:00
Berkan Diler
fcbb21c75e
Fix typo
2022-12-26 20:38:35 +01:00
Berkan Diler
c7ca4bbba5
Use generic Enum methods
2022-12-26 20:36:39 +01:00
Bartłomiej Dach
e416bdd06b
Merge branch 'master' into remove_obsolete_star_colours
2022-12-26 16:35:47 +01:00
mk56-spn
fbff5d8d69
Remove obsoleted "ForDifficultyRating" method
2022-12-26 16:16:52 +01:00
Dean Herbert
5dd03c6c60
Update framework
2022-12-26 21:53:52 +08:00
Dan Balasescu
786d94c149
Merge pull request #21792 from Joehuu/fix-parameters-inspection
...
Fix parameters with the same default value inspection
2022-12-26 15:41:54 +09:00
Joseph Madamba
0dba25e0ab
Refactor to just exit sub screens until lounge sub screen
...
Co-Authored-By: Salman Ahmed <frenzibyte@gmail.com>
2022-12-25 21:56:22 -08:00
Dean Herbert
09cc41604f
Merge branch 'master' into score-stats-on-results
2022-12-26 13:37:36 +08:00
Joseph Madamba
144144c40c
Revert removing redundant font parameter
2022-12-25 20:47:05 -08:00
Salman Ahmed
ee77b8cad3
Merge branch 'master' into fix-parameters-inspection
2022-12-26 05:17:40 +03:00
Salman Ahmed
2d57ea6f15
Merge branch 'master' into link-title-and-artist
2022-12-26 03:23:05 +03:00
Joseph Madamba
973fd90af2
Fix parameters with the same default value inspection
2022-12-25 16:15:02 -08:00
Joseph Madamba
f959b02dc8
Use empty drawables for spacing badges instead
2022-12-25 16:05:59 -08:00
Joseph Madamba
8e899c2e92
Use localisation parameters to find preferred string instead
2022-12-25 16:03:44 -08:00
Joseph Madamba
1a571e1c7f
Remove nullable disable on user panel
2022-12-25 15:03:08 -08:00
integer
272288c9aa
fix code style and naming
2022-12-25 21:50:56 +00:00
Joseph Madamba
b9dfb8b602
Add localisation for context menu strings
2022-12-25 10:12:02 -08:00
Joseph Madamba
2c2f347e25
Add context menus to overlay panels/cards
2022-12-25 09:57:42 -08:00
Joseph Madamba
5232588a1f
Use PerformFromScreen to exit sub screens instead
2022-12-24 20:04:45 -08:00
integer
d392d1a5c0
override a sub-method instead of the whole Export()
2022-12-24 22:18:42 +00:00
Joseph Madamba
00ed5d6f92
Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting
2022-12-24 14:01:11 -08:00
Joseph Madamba
b871d6f078
Remove unused fields
2022-12-24 13:35:17 -08:00
Joseph Madamba
ae967e08b0
Add badges when needed instead of using alpha
2022-12-24 13:27:46 -08:00
Joseph Madamba
4f6b3644f3
Fix title/artist overflowing to right side
2022-12-24 12:40:32 -08:00
Joseph Madamba
df645ef3cb
Change title/artist idle colour to white
2022-12-24 11:42:05 -08:00
Joseph Madamba
9d073f4228
Link beatmap set title and artist to listing search
2022-12-24 11:26:09 -08:00
Bartłomiej Dach
36a6f3685e
Don't show global rankings display when not logged in
2022-12-24 14:35:11 +01:00
Bartłomiej Dach
145130ba80
Register solo statistics watcher at game level
2022-12-24 14:35:07 +01:00
Bartłomiej Dach
da519acb20
Add overall ranking display to solo results
2022-12-24 14:35:04 +01:00
Bartłomiej Dach
3abdf557ea
Add protected method for customising statistics panel rows
2022-12-24 14:35:00 +01:00
Bartłomiej Dach
600ada46be
Add protected method for customising statistics panel
2022-12-24 14:34:54 +01:00
Bartłomiej Dach
cf0b3ec879
Merge branch 'master' into score-stats-display
2022-12-24 14:32:08 +01:00
Dean Herbert
209d44746a
Merge pull request #21762 from bdach/score-stats-updates
...
Add solo statistics watcher component to deliver incremental global user statistics updates
2022-12-24 21:30:34 +08:00
Bartłomiej Dach
e961af20cc
Merge branch 'score-stats-updates' into score-stats-display
2022-12-24 13:56:10 +01:00
Bartłomiej Dach
78c47a3695
Add callback to dictionary rather than overwrite
...
Attempting to overwrite will henceforth throw an exception.
2022-12-24 13:45:04 +01:00
Bartłomiej Dach
6c4ca387e0
Fix wrong handling of missing ruleset statistics
2022-12-24 13:44:11 +01:00
Bartłomiej Dach
3c26016b61
Ensure latest stats are cleared on successful profile fetch
2022-12-24 13:44:08 +01:00
Bartłomiej Dach
fd9110a61e
Fix solo statistics watcher firing requests for invalid user with id 1
...
Can happen during login flow (see `APIAccess.attemptConnect()`).
2022-12-24 13:44:05 +01:00
Bartłomiej Dach
d6e079a2b4
Ignore statistics update requests from third-party rulesets for now
2022-12-24 13:43:57 +01:00
Bartłomiej Dach
83a50816b6
Remove unused constructor param
2022-12-24 10:44:38 +01:00
Bartłomiej Dach
4bcc2b832c
Merge branch 'master' into add-help-button
2022-12-24 10:40:35 +01:00
Bartłomiej Dach
301eb71e22
Fix wrong member names
2022-12-24 10:39:05 +01:00
Dean Herbert
2c060ac8d4
Add localisation support for new button's strings
2022-12-24 17:32:04 +08:00
Bartłomiej Dach
4e5109a649
Use plain bindable flow instead of binding to watcher directly
2022-12-24 10:27:28 +01:00
Bartłomiej Dach
75ddeaeeb8
Merge branch 'master' into argon-pro-skin-hide-highest-judgement
2022-12-24 09:41:18 +01:00
Bartłomiej Dach
80de5dac66
Fix judgement text never being added to hierarchy
2022-12-24 09:37:40 +01:00
Bartłomiej Dach
f973befcd4
Remove unused resolved member
2022-12-24 09:34:30 +01:00
Dean Herbert
91bde14fb3
Add button to settings to show lazer upgrade guide
2022-12-24 15:42:24 +08:00
Dean Herbert
5e9fb1063a
Move judgement text creation to base class and tidy things up
2022-12-24 12:22:36 +08:00
Bartłomiej Dach
c7f248e13c
Implement overall ranking display for solo results screen
2022-12-24 00:30:38 +01:00
integer
498d00935b
limit date appending to LegacyScoreExporter only
2022-12-23 23:01:04 +00:00
Bartłomiej Dach
3e782c5f5f
Extract interface for solo statistics watcher
2022-12-23 23:46:41 +01:00
Dean Herbert
727ac00f6d
Combine base class for JudgementPiece
2022-12-24 03:32:13 +08:00
Joseph Madamba
2dbcf05fe4
Use enum values as ids in fallback instead
2022-12-23 11:13:27 -08:00
Joseph Madamba
494886ef92
Rename Text to Metadata
2022-12-23 11:11:15 -08:00
Bartłomiej Dach
94d78a47a4
Merge branch 'master' into upgrade-guide-help
2022-12-23 17:22:04 +01:00
Bartłomiej Dach
9a2cc04361
Fix wrong path being used in fail handler
2022-12-23 16:44:03 +01:00
Bartłomiej Dach
67aea34e7e
Merge branch 'master' into fix-breadcrumb-tab-item-click-area
2022-12-23 16:36:58 +01:00
Dean Herbert
a677c8be06
Change path on error
2022-12-23 21:17:42 +08:00
Dean Herbert
5eccafe190
Fix wiki overlay showing error message when load is cancelled
2022-12-23 16:45:40 +08:00
ansel
f25439e359
Move track change subscription to LoadComplete
2022-12-23 01:54:49 +03:00
Bartłomiej Dach
676d4a0d6d
Merge branch 'master' into fix-waveform-zoom-reload
2022-12-22 23:48:50 +01:00
Salman Ahmed
0cb9b79834
Fix ZoomableScrollContainer potentially not updating content width on setup
2022-12-23 00:56:38 +03:00
Salman Ahmed
30de9ba795
Dispose previous waveform on track reload
2022-12-23 00:35:59 +03:00
Berkan Diler
08d2fbeb8e
Use new ArgumentNullException.ThrowIfNull throw-helper API
2022-12-22 21:27:59 +01:00
Bartłomiej Dach
fa2d50fe31
Limit tracking unhandled scores to just the last one
2022-12-22 19:59:39 +01:00
Bartłomiej Dach
48dc2332fd
Refactor test to be easier to work with
2022-12-22 19:59:35 +01:00
Bartłomiej Dach
ac872fac9e
Implement solo statistics watcher
2022-12-22 19:59:07 +01:00
ansel
20370bd5ae
Invalidate waveform on track load
2022-12-22 20:49:09 +03:00
Salman Ahmed
8be6350c01
Remove no longer necessary assert
2022-12-22 20:07:53 +03:00
Flutterish
5df440e20e
dont use is..or syntax
2022-12-22 17:27:55 +01:00
Flutterish
422fdd8ae5
dont post notifications from custom log targets
2022-12-22 16:56:27 +01:00
ansel
d0645ce151
Rewrite waveform invalidation
2022-12-22 15:59:51 +03:00
ansel
f2e8776529
Bind to clock instead of music controller
2022-12-22 15:35:53 +03:00
