518 Commits

• Use StateUpdateTime for transform clearing logic

  `MainCirclePiece` specifies a state transform starting at
  `StateUpdateTime`, which is earlier than the previously-used
  `HitStateUpdateTime`. Change the transform clearing logic to use the
  former to ensure that exactly all animation transforms are cleared.

  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  afc89b39d9
• Ensure editor ruleset animation disable execution order
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  e94fbd83e2
• Add coverage for hit circle fade-out duration
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  e2a370f602
• Fix sliders jumping around the screen on movement
  smoogipoo · 2021-05-24 17:15:57 +09:00
  3db995c778
• Merge branch 'master' into refactor-selection-rotate-logic
  Dean Herbert · 2021-05-21 19:19:54 +09:00
  bb2fae55ce
• Create base implementations of the two most common TernaryStateMenuItems
  Dean Herbert · 2021-05-20 19:34:53 +09:00
  df5970fab4
• Implement proper rotation algorithm for skin editor
  Dean Herbert · 2021-05-20 18:21:16 +09:00
  27e81d6504
• Move scaling logic out of OsuSelectionHandler for reuse
  Dean Herbert · 2021-05-19 17:37:28 +09:00
  a0f67ef3bc
• Move common functionality out of OsuSelectionHandler and implement flip support
  Dean Herbert · 2021-05-18 18:34:06 +09:00
  d661e98fa6
• Merge pull request #12782 from smoogipoo/rework-hitobject-blueprints

  Rename hitobject blueprints and tie them to HitObjects

  Dean Herbert · 2021-05-18 16:30:58 +09:00
  a96603f025
• Remove nested blueprints from sliders
  smoogipoo · 2021-05-18 14:19:11 +09:00
  532c41c82e
• Add Apply() method for applying new DHOs
  smoogipoo · 2021-05-18 14:14:10 +09:00
  e621cfc4ea
• Rework hitobject blueprints to take in hitobject models
  smoogipoo · 2021-05-13 19:53:32 +09:00
  ffb6135a1b
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Rename "playableBeatmap" check arg to "beatmap"

  The working beatmap is now in the context, so it's easier to distinguish beatmap type, hence no need for this prefix.

  Naxess · 2021-05-12 02:34:16 +02:00
  b7bc42e0d3
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Revert "Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling"

  This reverts commit 54fe10c82a.

  Dean Herbert · 2021-05-08 23:33:03 +09:00
  01d732bb65
• Revert "Trim redundant this qualifier"

  This reverts commit df630d9428.

  Dean Herbert · 2021-05-08 23:32:52 +09:00
  63e267a3be
• Trim redundant this qualifier
  Bartłomiej Dach · 2021-05-08 14:53:19 +02:00
  df630d9428
• Refactor SliderSelectionBlueprint to not reference blueprint pieces for input handling
  Dean Herbert · 2021-05-07 10:36:03 +09:00
  54fe10c82a
• Fix slider input handling potentially being offset after composer area resize

  Closes https://github.com/ppy/osu/issues/12671.

  Dean Herbert · 2021-05-06 17:19:19 +09:00
  39067e6926
• Refactor SelectionBlueprint and MoveSelectionEvent to work in screen-space coordinates

  Until now, the implementation of the overrides in `SelectionBlueprint`
  have been confusing to the point where I would just implement by
  trial-and-error (or copying from an existing implementation). This was
  due to a combination of using "object" space coordinates
  (ie. the thing the `Blueprint` is operating on) and screen-space coordinates.
  
  This change switches all event related coordinates to screen-space,
  which is how we already handle rotation/scale operations. With the
  introduction of other editor types where the related objects are
  drawables, this also makes a lot more sense.

  Dean Herbert · 2021-04-29 16:10:42 +09:00
  9c62c90cfc
• Avoid using EditorBeatmap.SelectedHitObjects
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f586bc46e6
• Refactor editor selection/blueprint components to be generic
  Dean Herbert · 2021-04-27 19:01:29 +09:00
  f2e56bd306
• Fix a couple of inspections
  Dean Herbert · 2021-04-27 13:23:14 +09:00
  ec1c336b0a
• Update osu! editor transform logic to allow adjustments to DrawableSliderRepeat and DrawableSliderTail
  Dean Herbert · 2021-04-26 15:27:10 +09:00
  8795c5f082
• Rename "EditRuleset" and "EditPlayfield" to use full "Editor" keyword
  Dean Herbert · 2021-04-26 14:33:30 +09:00
  e8d83f2f99
• Only apply custom editor overrides if hit animations is disabled
  Dean Herbert · 2021-04-21 19:44:17 +09:00
  0f70469d1c
• Adjust existing fades to close match stable editor
  Dean Herbert · 2021-04-21 19:41:15 +09:00
  f2824a222a
• Add the playable beatmap as check argument

  This is different from the working beatmap's `.Beatmap` property in that it is mutated by the ruleset/editor.
  
  So hit objects, for example, are actually of type `Slider` and such instead of the legacy `ConvertSlider`.
  
  This should be preferred over `workingBeatmap.Beatmap`.

  Naxess · 2021-04-20 01:31:51 +02:00
  8656176ab8
• Take IWorkingBeatmap instead of WorkingBeatmap

  This makes testing much easier, and allows for checking of any class deriving from that interface, including `WorkingBeatmap`.

  Naxess · 2021-04-18 01:21:20 +02:00
  56bf49c85c
• Use WorkingBeatmap instead of IBeatmap

  This lets us access things like the background, track, etc. which are necessary for quality and filesize checks.
  
  Also improves the structure of the `CheckBackgroundTest` class in the process.

  Naxess · 2021-04-17 17:33:53 +02:00
  448574e7e6
• Merge branch 'fix-slider-scale-crash' into fix-slider-zero-length
  Dean Herbert · 2021-04-16 16:58:19 +09:00
  401bf368a7
• Fix div-by-zero when scaling a 1-dimensional slider
  Dean Herbert · 2021-04-16 16:55:26 +09:00
  8de68e0ebf
• Handle scaling a slider below minimum length
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  ff408b852e
• Handle control point deletion when the resulting slider would be too short to be useful
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  89373638be
• Handle control point drag revert
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  2949a6bbdc
• Centralise length validation function
  Dean Herbert · 2021-04-16 15:45:24 +09:00
  d38e294d96
• Disallow zero-length slider blueprint placements
  Dean Herbert · 2021-04-16 14:38:30 +09:00
  965a1ead36
• Rename SliderPlacementState to make way for more generic version
  Dean Herbert · 2021-04-16 14:09:35 +09:00
  5c0ef55691
• Merge branch 'master' into verify-tab
  Dean Herbert · 2021-04-13 23:05:48 +09:00
  1ff4e2076f
• Split out general checks into its own verifier class (and remove static usage)
  Dean Herbert · 2021-04-13 19:50:22 +09:00
  03ba04e8ce
• Add CheckBackground to OsuBeatmapVerifier
  Naxess · 2021-04-13 10:41:02 +02:00
  304fe5cd34
• Make BeatmapVerifier an interface
  Naxess · 2021-04-13 10:40:56 +02:00
  60c2494b31
• Add reference for screen bounding box numbers
  Naxess · 2021-04-13 10:35:06 +02:00
  c8cb4286f6
• Split out common logic into private method and add inline comment for future visitors
  Dean Herbert · 2021-04-13 15:35:57 +09:00
  fbc6fb8fc5
• Use is class instead of Equals with template index

  Ensures ordering of `PossibleTemplates` does not affect tests.

  Naxess · 2021-04-13 02:29:25 +02:00
  6d3f9fa9ce
• Don't update path type once immediately
  Naxess · 2021-04-12 19:18:22 +02:00
  d9e3276d0e
• Rename checkOrigin -> check

  More consistent with `Issue.ctor`'s "template".

  Naxess · 2021-04-12 17:28:12 +02:00
  19a154ddf1
• Remove check ctors and locals
  Naxess · 2021-04-12 17:12:37 +02:00
  bb720c23a0