Dan Balasescu
3b24ec3643
Merge branch 'master' into multi-queueing-modes
2021-11-12 22:16:04 +09:00
Dean Herbert
692e846acd
Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
2021-11-12 17:52:44 +09:00
Dean Herbert
6a098a8634
Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
2021-11-12 17:46:24 +09:00
Dean Herbert
62600f1390
Merge branch 'master' into editor-gameplay-test
2021-11-12 14:14:06 +09:00
Bartłomiej Dach
459ec7b3bf
Fix test failures due to missing dependencies
2021-11-11 20:54:37 +01:00
Bartłomiej Dach
c465bcb821
Ensure track is stopped on player completion
2021-11-11 20:54:36 +01:00
Bartłomiej Dach
385df51b06
Ensure editor test player is exited on completion
2021-11-11 20:54:36 +01:00
Bartłomiej Dach
6ce1a78723
Add test coverage for basic gameplay testing scenarios
2021-11-11 20:54:36 +01:00
Bartłomiej Dach
32b5a736c8
Add preview gameplay button to bottom editor bar
2021-11-11 17:12:21 +01:00
Bartłomiej Dach
dbdbfc4723
Add failing test case for PP counter not initially updating
2021-11-11 16:33:31 +01:00
Dan Balasescu
5c8c121446
Update behaviour to match server (removing playlist items) + tests
2021-11-11 23:39:15 +09:00
Dan Balasescu
07a7b4bcdc
Merge branch 'master' into multi-queueing-modes
2021-11-11 22:19:30 +09:00
Bartłomiej Dach
9bad912dd0
Add failing test case
2021-11-11 13:22:06 +01:00
Dan Balasescu
4db2ad1cb3
Merge branch 'master' into rename-ef-model-properties
2021-11-11 19:12:54 +09:00
Dean Herbert
51a353e12d
Rename BeatmapInfo.Version to DifficultyName to match underlying interface
2021-11-11 17:20:53 +09:00
Dean Herbert
ebe58cee11
Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
2021-11-11 17:19:46 +09:00
Bartłomiej Dach
f38d6ef8db
Add failing test steps
2021-11-11 09:01:50 +01:00
Dean Herbert
8371307709
Merge branch 'master' into editor-clipboard-refactor
2021-11-11 01:09:39 +09:00
Bartłomiej Dach
91baaa73f3
Show download progress on card body rather than in button
2021-11-10 16:03:48 +01:00
Bartłomiej Dach
5e31e890ae
Extract class for clipboard contents for DI purposes
2021-11-10 12:36:23 +01:00
Bartłomiej Dach
343318c6f9
Merge branch 'master' into display-string
2021-11-10 11:10:38 +01:00
smoogipoo
35a5182ebf
Merge branch 'master' into multi-queueing-modes
2021-11-10 15:01:13 +09:00
Dean Herbert
52c740b377
Add failing test showing team display display failure
2021-11-10 13:44:31 +09:00
Bartłomiej Dach
410e9159d1
Fix test failures due to missing dependencies
2021-11-09 19:54:38 +01:00
Bartłomiej Dach
03a315b9f5
Fix missing beatmap in replay download test scene
...
Was causing nullrefs in `GetDisplayTitle()`.
2021-11-09 14:33:06 +01:00
Dean Herbert
3b485b5f37
Rewrite PreviewTrackManager to avoid constructing TrackBass locally
...
This paves the way for the framework code quality change
(https://github.com/ppy/osu-framework/pull/4873 ) which stops exposing
the constructor.
Most of the restructuring here is required to give `PreviewTrackManager`
an adjustable target to apply the global mute.
2021-11-09 17:38:12 +09:00
Bartłomiej Dach
74c37e248d
Merge branch 'master' into master
2021-11-09 08:40:52 +01:00
Bartłomiej Dach
2186b51676
Implement detailed download button behaviour
2021-11-08 22:18:14 +01:00
Bartłomiej Dach
a60cceeda6
Implement basic appearance of download button
2021-11-08 22:18:14 +01:00
Bartłomiej Dach
c65e7a4436
Add test coverage for download button
2021-11-08 22:17:56 +01:00
Bartłomiej Dach
f4b8dee2d0
Update favourite statistic value on favourite button clicks
2021-11-08 11:53:54 +01:00
Bartłomiej Dach
5cb533004d
Add test coverage for favourite button
2021-11-08 11:53:53 +01:00
smoogipoo
c716051530
Merge branch 'master' into multi-queueing-modes
2021-11-08 19:19:50 +09:00
Dean Herbert
8b85c2c8de
Merge pull request #15491 from peppy/remove-stupid-weak-reference-bindable-events
...
Revert weird event flow in model manager/importers
2021-11-08 15:19:58 +09:00
Dean Herbert
a2dfb5fd8c
Merge pull request #15513 from bdach/beatmap-card/statistics
...
Add statistics display to beatmap card
2021-11-08 14:45:56 +09:00
Dan Balasescu
1c40d5bc08
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 14:41:32 +09:00
Dean Herbert
dede0e56ce
Merge branch 'master' into user-lookup-by-username-cleanup
2021-11-08 13:38:26 +09:00
Dean Herbert
78aef9ce86
Merge branch 'master' into remove-stupid-weak-reference-bindable-events
2021-11-08 13:35:49 +09:00
Dean Herbert
1589b50d6e
Merge branch 'master' into beatmap-card/statistics
2021-11-08 13:28:31 +09:00
Dean Herbert
43f87844e2
Add text to test cards to better explain their purpose
2021-11-08 13:27:04 +09:00
Dean Herbert
62600b47b1
Merge branch 'master' into user-class-cleanup
2021-11-08 12:51:12 +09:00
Bartłomiej Dach
0e09edfce2
Do not show nomination info if hype info not present to match web
2021-11-07 21:33:42 +01:00
Bartłomiej Dach
1f405a7e71
Display extended statistics on card hover
2021-11-07 21:33:41 +01:00
Bartłomiej Dach
04c2a9cd59
Display basic statistics on card hover
2021-11-07 21:03:06 +01:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename
2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c
Rename User to APIUser and move to correct namespace
2021-11-07 11:26:01 +09:00
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null
2021-11-06 15:36:15 +01:00
Dean Herbert
b8fb22b769
Add missing test coverage of score import process being tracked correctly
2021-11-06 16:45:55 +09:00
Chinmay Patil
77e853ce25
Optimized UR Counter and removed redundant code
2021-11-05 12:16:58 -06:00
Dean Herbert
54f72d68ca
Revert weird event flow in model manager/importers
2021-11-05 19:12:49 +09:00
smoogipoo
7bbb2a7a67
Fix post-merge issues
2021-11-05 15:57:32 +09:00
smoogipoo
e6deb0c873
Merge branch 'master' into multi-queueing-modes
2021-11-05 15:57:25 +09:00
Salman Ahmed
b723975767
Replace pragma with add/remove => throw
2021-11-05 09:10:38 +03:00
Dean Herbert
ba74dd93b2
Remove weird fetchOnline logic
2021-11-05 13:55:34 +09:00
Dean Herbert
1f5ca122b0
Merge branch 'master' into user-class-cleanup
2021-11-05 13:55:22 +09:00
Dean Herbert
ead64282dd
Split out a couple more nested classes
2021-11-05 13:40:44 +09:00
Dan Balasescu
acb06d4a99
Merge branch 'master' into beatmap-refactor/remove-online-info
2021-11-05 12:46:02 +09:00
Salman Ahmed
2764ad90ea
Merge branch 'master' into fix-more-null
2021-11-05 05:14:22 +03:00
Salman Ahmed
af6ae1cce5
Remove hacky code with explicit pragma disable
2021-11-05 03:49:35 +03:00
Bartłomiej Dach
9246adc349
Add failing test coverage for labelled drawable description visible
2021-11-04 21:43:20 +01:00
Chinmay Patil
8923561b05
Removed Unnessicary class in the Test file, and optimized UR counter
2021-11-04 14:27:48 -06:00
Dean Herbert
7049d0de66
Merge branch 'master' into beatmap-refactor/remove-online-info
2021-11-05 01:16:11 +09:00
Chinmay Patil
a76878e053
A bit more formatting
2021-11-04 09:52:16 -06:00
Chinmay Patil
c568888500
Edited to remove unessicary blank lines
2021-11-04 09:47:52 -06:00
Chinmay Patil
223efe55d5
Added Tests for UR counter
2021-11-04 09:23:29 -06:00
Dean Herbert
ed07ee8c61
Update all existing usages of AuthorString/AuthorId
...
Unfortunately the getters need to be left in place else EF breaks.
2021-11-04 18:59:37 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended
2021-11-04 18:59:04 +09:00
Dean Herbert
86540d1fb6
Update existing usages of Author as string to access Username directly
2021-11-04 18:57:54 +09:00
Dean Herbert
b9983add15
Rename User to APIUser and move to correct namespace
2021-11-04 18:21:31 +09:00
Dean Herbert
d2831b1152
Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2
2021-11-04 17:09:50 +09:00
Dean Herbert
77be610b26
Revert "Clean up DirectDownloadButton test scene"
...
This reverts commit baabe99f78
2021-11-04 17:09:20 +09:00
Dean Herbert
5a078da4d9
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:50:14 +09:00
Dean Herbert
8f459e6ce8
Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
2021-11-04 16:44:17 +09:00
Dean Herbert
baabe99f78
Clean up DirectDownloadButton test scene
2021-11-04 16:28:29 +09:00
Dean Herbert
0f4f1349db
Merge branch 'master' into editor-context-menu-on-select
2021-11-04 15:59:06 +09:00
Dean Herbert
9c926e5514
Remove BeatmapSetInfo.OnlineInfo and all usages
2021-11-04 15:23:04 +09:00
Dean Herbert
66f4516eee
Allow creating sample API models without specifying a ruleset
2021-11-04 15:23:04 +09:00
Dean Herbert
d1e6d1cb98
Update some other missed incorrect null/empty usages
2021-11-04 14:50:43 +09:00
Bartłomiej Dach
6e33fa088f
Add test case for drawable room with too long beatmap name
2021-11-03 17:32:53 +01:00
Bartłomiej Dach
cf7545e36c
Merge branch 'master' into beatmap-card-basics
2021-11-03 00:11:03 +01:00
Dean Herbert
1bfa1365a0
Rename "null user" tests to better explain purpose
2021-11-02 17:13:37 +09:00
Dean Herbert
e472656b37
Add test coverage of room participants updating on room join
2021-11-02 17:13:37 +09:00
Bartłomiej Dach
5962f16b1c
Implement basic card appearance
2021-11-01 19:41:11 +01:00
Bartłomiej Dach
d82564aab6
Add test scene for beatmap cards
2021-11-01 19:41:10 +01:00
Dean Herbert
caa9d8997b
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 22:59:11 +09:00
Bartłomiej Dach
0d65493b56
Mark test usages of Ruleset.CreateInstance() as returning non-null
2021-11-01 12:12:21 +01:00
Bartłomiej Dach
5dcff7d8b7
Merge branch 'master' into score-refactor/less-create-score-info
2021-11-01 11:41:20 +01:00
smoogipoo
887fa54988
Add FFA queueing mode tests
2021-11-01 19:25:47 +09:00
smoogipoo
1564048d8d
Add one more test
2021-11-01 18:55:42 +09:00
smoogipoo
3db199292f
Fix queue mode not passed from room to settings overlay
2021-11-01 18:52:57 +09:00
smoogipoo
65b920e4c1
Merge branch 'master' into multi-queueing-modes
2021-11-01 18:37:16 +09:00
Dean Herbert
b21e0e7efb
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-11-01 18:07:51 +09:00
Bartłomiej Dach
6a44cf3ff1
Add missing beatmap spec in test scene
2021-11-01 09:44:08 +01:00
Bartłomiej Dach
f5feed138d
Merge branch 'master' into score-refactor/isolated-serialisation
2021-11-01 09:43:51 +01:00
Dean Herbert
90a0a5e0b7
Fix attempting to set properties of null BeatmapSets in tests
2021-11-01 17:12:15 +09:00
Dean Herbert
63c9512ab1
Update dashboard components to use APIBeatmapSet
2021-11-01 16:04:01 +09:00
Dean Herbert
269a8df0ec
Fix HasReplay not being corrrectly implemented by APIScoreInfo
2021-11-01 13:20:37 +09:00
Bartłomiej Dach
8053b2c320
Merge branch 'master' into score-refactor/isolated-serialisation
2021-10-30 15:07:34 +02:00
Dean Herbert
bb9769aa17
Fix null ruleset in another place
2021-10-29 20:12:12 +09:00
Dean Herbert
22c2f48e4d
Fix more null rulesets
2021-10-29 19:05:42 +09:00
Dean Herbert
a16c8f1ebc
Update all beatmap overlay views to use APIBeatmap/APIBeatmapSet
2021-10-29 18:50:55 +09:00
Dean Herbert
993a28b37e
Merge branch 'beatmap-refactor/difficulty-icons' into beatmap-refactor/beatmap-overlays
2021-10-29 18:35:26 +09:00
Dean Herbert
04acc7601c
Fix one more missed case
2021-10-29 18:35:15 +09:00
Dean Herbert
07e3ced315
Fix test scene and remove "impossible" nullable coalesce
2021-10-29 18:22:23 +09:00
Dean Herbert
8ad33d43d0
Merge branch 'beatmap-refactor/get-and-present' into beatmap-refactor/beatmap-overlays
2021-10-29 18:01:17 +09:00
Dean Herbert
3598adb344
Fix test implementing old version of class
2021-10-29 17:04:56 +09:00
smoogipoo
7c6b3cb080
Rename test scene
2021-10-29 16:45:40 +09:00
smoogipoo
2408011c81
Don't replace identical playlist items
2021-10-29 16:44:51 +09:00
smoogipoo
e667ef4eea
Add basic tests
2021-10-29 15:44:48 +09:00
Dean Herbert
31403daa20
Change DrawableProfileScore to use APIScoreInfo
2021-10-29 15:14:52 +09:00
Dean Herbert
17a83f701a
Store mods as APIMods for the time being
2021-10-29 15:13:49 +09:00
smoogipoo
746f4a49c1
Add base test scene
2021-10-29 13:56:07 +09:00
Dean Herbert
1944c255a7
Implement score interfaces
2021-10-29 13:49:30 +09:00
Dean Herbert
817369903a
Rename API score classes
2021-10-29 13:40:56 +09:00
smoogipoo
f076b72fbe
Merge branch 'master' into multi-queueing-modes
2021-10-29 10:48:16 +09:00
smoogipoo
c96b07c625
Remove unnecessary/wrong code
2021-10-28 18:24:04 +09:00
smoogipoo
2b3e63470d
Merge branch 'master' into always-unique-test-online-ids
2021-10-28 18:23:45 +09:00
Dan Balasescu
6e79a0947a
Merge pull request #15340 from peppy/add-number-setting-source-test
...
Add visual test for `SettingsNumberBox` usage in settings source context
2021-10-28 18:19:45 +09:00
Dean Herbert
4f4f2503aa
Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests
...
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 17:28:26 +09:00
Dean Herbert
c0848486d6
Add missing test coverage for attempt count display
2021-10-28 17:27:16 +09:00
Dean Herbert
8076e22e70
Replace weird import handling
2021-10-28 17:27:16 +09:00
Dan Balasescu
b21f42ec76
Merge branch 'master' into add-number-setting-source-test
2021-10-28 17:25:52 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
...
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
b096bf6cd1
Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts
...
The order of operation of imports means that the already-imported
instances are considered most correct (they have usually been populated
using an online source, although that is skipped in tests), so on two
consecutive test imports in a test scene, the second will lose its
online IDs completely.
This aims to ensure that all test beatmaps will have online IDs, which
is the general expected behaviour.
2021-10-28 16:56:31 +09:00
Dean Herbert
6f5040722a
Merge branch 'master' into beatmap-refactor/uncontested
2021-10-28 16:37:26 +09:00
Dean Herbert
1e1f8c472a
Add icons to various progress notification states
2021-10-28 16:34:12 +09:00
Dean Herbert
dce19cf7e4
Add visual test for SettingsNumberBox usage in settings source context
2021-10-28 15:42:06 +09:00
smoogipoo
e2c08fb2e5
Create room by clicking button
2021-10-28 15:41:59 +09:00
smoogipoo
b0b27a47d5
Rename test scene
2021-10-28 15:28:16 +09:00
smoogipoo
cf15282077
Merge branch 'master' into fix-playlists-room-subscreen-tests
2021-10-28 15:26:48 +09:00
Dean Herbert
56e3a42abe
Remove unused using statement
2021-10-28 15:14:29 +09:00
smoogipoo
0e293471c2
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 14:29:49 +09:00
Dean Herbert
aaabaaa5dd
Merge pull request #15320 from smoogipoo/fix-online-play-request-handling
...
Fix online play request handling in tests
2021-10-28 14:24:00 +09:00
smoogipoo
1213c5553a
Remove forgotten attribute
2021-10-28 13:16:50 +09:00
Bartłomiej Dach
798349243f
Cache test request handler in screen navigation test
2021-10-27 20:38:52 +02:00
Bartłomiej Dach
cd04ca1240
Remove unused using statement
2021-10-27 20:35:19 +02:00
Dean Herbert
7245baba69
Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
2021-10-28 00:50:45 +09:00
smoogipoo
72bb72a559
Fix a case of missed base.SetUpSteps()
2021-10-27 20:56:11 +09:00
smoogipoo
a87d8d0359
Fix dependency missing in a few TestScenes
...
Hopefully these are rather temporary cases until a better solution is
found for these dependency-loading screens.
2021-10-27 20:47:40 +09:00
smoogipoo
48f280440c
Fix incorrect clearing of room
2021-10-27 19:36:43 +09:00
smoogipoo
f3dba49aae
Rename room managers
2021-10-27 19:36:32 +09:00
Dean Herbert
d19580cf60
Fix incorrectly changed difficulty count in recently updated test
2021-10-27 16:44:11 +09:00
smoogipoo
676070946c
Fix missed base.SetUpSteps()
2021-10-27 15:25:26 +09:00
Dean Herbert
58237f6fee
Fix weird import flows
2021-10-27 14:26:37 +09:00
Dean Herbert
84bb3a962b
Centralise room "creation"
2021-10-27 14:11:57 +09:00
Dean Herbert
c4a253cc75
Replace local instantiation of TestBeatmap with helper method
2021-10-27 13:55:14 +09:00
Dean Herbert
2bc2420012
Rename test scene
...
It's not testing the sub-screen. It's testing creating playlists.
2021-10-27 13:54:21 +09:00
Dean Herbert
95837990f3
Apply some second-pass inspections that appeared after previous changes
2021-10-27 13:09:30 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Bartłomiej Dach
3de994449d
Add support for changing dimensions of difficulty spectrum display
2021-10-26 23:06:52 +02:00
