71427 Commits

This Branch

This Branch

All Branches

• Merge pull request #31747 from bdach/do-not-reset-online-info-on-save

  Do not reset online information when saving beatmap

  Dean Herbert · 2025-02-02 22:24:56 +09:00
  f65be009a3
• Merge pull request #31368 from frenzibyte/mobile-fix-mania

  Improve osu!mania playability on mobile devices

  Dean Herbert · 2025-02-01 14:49:46 +09:00
  cf3a379b1c
• Remove pointless comment
  Dean Herbert · 2025-02-01 14:48:13 +09:00
  cc3bb590c9
• Merge pull request #31733 from bdach/bss/abstract-out-wizard

  Abstract out `WizardOverlay` for multi-step wizard type screens

  Dean Herbert · 2025-02-01 14:10:35 +09:00
  334b578fb6
• Fix broken user-facing messaging when beatmap hash mismatch is detected
  Bartłomiej Dach · 2025-01-31 12:22:05 +01:00
  7ef8616703
• Do not reset online info on beatmap save
  Bartłomiej Dach · 2025-01-31 12:21:42 +01:00
  c3981f1097
• Merge pull request #31732 from KareVulli/fix-timeline-selection

  Fix stacked objects selection order on editor timeline

  Bartłomiej Dach · 2025-01-30 14:31:42 +01:00
  d3b233b08f
• Enable NRT on Column
  Salman Alshamrani · 2025-01-30 08:22:35 -05:00
  64b67252a2
• Merge pull request #31731 from bdach/prosecuting-mirror-directions

  Change mirror mod direction setting description & tooltip to hopefully be less confusing

  Dean Herbert · 2025-01-30 20:33:13 +09:00
  d673344b30
• Merge pull request #31663 from nekodex/friend-notification-samples

  Add unique samples for friend online/offline notifications

  Dean Herbert · 2025-01-30 19:45:30 +09:00
  8a887abe51
• Merge pull request #31685 from frenzibyte/two-factor-authentication-code

  Do not display autocorrect suggestions in two factor verification code text box

  Bartłomiej Dach · 2025-01-30 11:15:09 +01:00
  d8c63a443f
• Merge branch 'master' into friend-notification-samples
  Dean Herbert · 2025-01-30 18:29:26 +09:00
  5f2532932e
• Abstract out WizardOverlay for multi-step wizard type screens

  To be used in the editor, for the beatmap submission wizard.
  
  I've recently been on record for hating "abstract" as a rationale to do
  anything, but seeing this commit ~3 months after I originally made it,
  it still feels okay to do for me in this particular case. I think the
  abstraction is loose enough, makes sense from a code reuse and UX
  consistency standpoint, and doesn't seem to leak any particular
  implementation details. That said, it is both a huge diffstat and also
  potentially controversial, which is why I'm PRing first separately.

  Bartłomiej Dach · 2025-01-30 09:39:08 +01:00
  31c4461fbb
• Move ApplySelectionOrder override from EditorBlueprintContainer to ComposeBlueprintContainer
  Marvin Helstein · 2025-01-30 10:27:36 +02:00
  ec99fc1141
• Change mirror mod direction setting tooltip to hopefully be less confusing

  See https://github.com/ppy/osu/issues/29720,
  https://discord.com/channels/188630481301012481/188630652340404224/1334294048541904906.
  
  This removes the tooltip due to being zero or negative information, and
  also changes the description of the setting to not contain the word
  "mirror", which will hopefully quash the "this is where I would place a
  mirror to my screen to achieve what I want" interpretation which seems
  to be a minority interpretation.
  
  The first time this was complained about I figured this was probably a
  one guy issue, but now it's happened twice, and I never want to see this
  conversation again.

  Bartłomiej Dach · 2025-01-30 08:59:33 +01:00
  bad2959d5b
• Merge pull request #31655 from bdach/deabstractify-editor-snap

  Refactor editor object snapping to remove bad abstractions

  Dan Balasescu · 2025-01-30 01:38:42 +09:00
  48b1c7398e
• Merge pull request #31726 from peppy/room-settings-button

  Make multiplayer change room settings more obvious as to what it does

  Dan Balasescu · 2025-01-30 00:42:00 +09:00
  7750468e31
• Merge pull request #31723 from peppy/fix-unstable-rate-incrementatl

  Fix incremental unstable rate calculation not matching expectations

  Dan Balasescu · 2025-01-29 23:54:59 +09:00
  007bf87a6b
• Remove unused usings
  Dan Balasescu · 2025-01-29 23:32:44 +09:00
  ca7a36d3d6
• Merge branch 'master' into two-factor-authentication-code
  Bartłomiej Dach · 2025-01-29 13:15:30 +01:00
  75ef67e959
• Merge pull request #31590 from frenzibyte/fix-editor-textbox-regressions

  Fix recent editor textbox regressions

  Bartłomiej Dach · 2025-01-29 12:08:42 +01:00
  9a9f42c3ff
• Make multiplayer change room settings more obvious as to what it does

  "Edit" felt really weird.

  Dean Herbert · 2025-01-29 19:48:04 +09:00
  a6814d1a8a
• Merge branch 'master' into fix-editor-textbox-regressions
  Bartłomiej Dach · 2025-01-29 11:25:16 +01:00
  d87720da1b
• Merge pull request #31417 from peppy/enable-sentry-caching

  Enable sentry caching to avoid sentry writing outside of game directory

  Bartłomiej Dach · 2025-01-29 11:19:56 +01:00
  c079969e72
• Fix reference hashsets getting emptied before used
  Dean Herbert · 2025-01-29 19:15:28 +09:00
  facc9a4dc3
• Fix skin SourceChanged event never being unbound
  Dean Herbert · 2025-01-29 18:16:04 +09:00
  e8d20fb402
• Merge branch 'master' into friend-notification-samples
  Dean Herbert · 2025-01-29 17:43:56 +09:00
  9db8e0b7ac
• Code quality pass
  Dean Herbert · 2025-01-29 17:43:49 +09:00
  bf40f071eb
• Update resources
  Dean Herbert · 2025-01-29 17:34:03 +09:00
  4c83ef83ee
• Update framework

  Update framework

  Dean Herbert · 2025-01-29 17:32:05 +09:00
  fd1d90cbd9
• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Add fail cases to unstable rate incremental testing
  Dean Herbert · 2025-01-29 17:10:05 +09:00
  6c4b4166ac
• Merge branch 'master' into enable-sentry-caching
  Dean Herbert · 2025-01-29 11:55:23 +09:00
  a3685da250
• Merge pull request #31711 from peppy/change-friend-notification-icons

  Change friend online notifications' icon and colours

  Bartłomiej Dach · 2025-01-28 15:38:27 +01:00
  b84a9f7820
• Merge pull request #31709 from peppy/catch-od-hide

  Remove "Accuracy" from osu!catch editor setup

  Bartłomiej Dach · 2025-01-28 15:33:50 +01:00
  99d898326c
• Add keywords to make lighten-during-breaks setting discoverable to stable users

  See https://github.com/ppy/osu/discussions/31671.

  Dean Herbert · 2025-01-28 21:31:51 +09:00
  a3a08832b4
• Change friend online notifications' icon and colours

  The previous choices made it seem like potentially destructive actions
  were being performed. I've gone with neutral colours and more suiting
  icons to attempt to avoid this.
  
  ---
  
  Addresses concerns in
  https://github.com/ppy/osu/discussions/31621#discussioncomment-11948377.
  
  I chose this design even though it wasn't the #1 most popular because I
  personally feel that using green/red doesn't work great for these.

  Dean Herbert · 2025-01-28 21:29:17 +09:00
  017d38af3d
• Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup
  Dean Herbert · 2025-01-28 21:22:51 +09:00
  1aa1137b09
• Merge pull request #31696 from bdach/do-not-bundle-explicit-beatmaps

  Do not bundle explicit beatmaps

  Dean Herbert · 2025-01-28 20:39:21 +09:00
  6d39ee2918
• Merge pull request #31697 from bdach/corrupt-mp3s-should-not-crash-game

  Catch and display user-friendly errors regarding corrupted audio files

  Dan Balasescu · 2025-01-28 14:00:01 +09:00
  a863230983
• Merge pull request #31698 from bdach/weird-zips

  Work around rare sharpcompress failure to extract certain archives

  Dan Balasescu · 2025-01-28 13:21:58 +09:00
  a075f76344
• Work around rare sharpcompress failure to extract certain archives

  Closes https://github.com/ppy/osu/issues/31667.
  
  See https://github.com/ppy/osu/issues/31667#issuecomment-2615483900 for
  explanation.
  
  For whatever it's worth, I see rejecting this change and telling
  upstream to fix it as an equally agreeable outcome, but after I spent an
  hour+ tracking this down, writing this diff was nothing in comparison.

  Bartłomiej Dach · 2025-01-27 12:28:53 +01:00
  bb8f58f6d6
• Fix infinite loop when switching audio tracks fails on an existing beatmap

  Bit ugly, but appears to work in practice...

  Bartłomiej Dach · 2025-01-27 10:27:06 +01:00
  be9c96c041
• Catch and display user-friendly errors regarding corrupted audio files

  Addresses lack of user feedback as indicated by
  https://github.com/ppy/osu/issues/31693.

  Bartłomiej Dach · 2025-01-27 10:25:22 +01:00
  01ae1a58f1
• Add inline comments for sets that are not marked FA but should be
  Bartłomiej Dach · 2025-01-27 09:40:53 +01:00
  e24af4b341
• Remove explicit beatmap set from list of bundled beatmap sets
  Bartłomiej Dach · 2025-01-27 09:40:20 +01:00
  836a9e5c25
• Specifiy second-factor authentication code text box with Code type
  Salman Alshamrani · 2025-01-25 23:58:56 -05:00
  4d7b071027
• Remove OrientationManager and the entire mobile namespace
  Salman Alshamrani · 2025-01-25 20:01:18 -05:00
  c18128e974
• Simplify orientation locking code magnificently
  Salman Alshamrani · 2025-01-25 19:12:43 -05:00
  bb7daae080
• Avoid extra unnecessary DI

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2025-01-25 19:12:42 -05:00
  ffc37cece0