3308 Commits

• Code cleanup
  Henry Lin · 2021-06-14 21:34:34 +08:00
  04c0db6dce
• Extract seed setting contorl to IHasSeed
  Henry Lin · 2021-06-10 15:31:20 +08:00
  12a17d0983
• Merge branch 'ppy:master' into osu-target-mod
  Henry Lin · 2021-06-10 15:13:27 +08:00
  80f38b347b
• Display results after fail
  Henry Lin · 2021-06-10 10:58:42 +08:00
  7815b3c72b
• Fix incorrect method referenced in xmldco

  Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>

  Dean Herbert · 2021-06-09 14:20:01 +09:00
  b8df3fff9e
• Add one missing obsoletion removal date
  Dean Herbert · 2021-06-09 14:11:50 +09:00
  62199a38a8
• Remove more obsoleted members
  Dean Herbert · 2021-06-09 14:10:48 +09:00
  f41e34ae2c
• Remove obsoleted DrawableJudgement methods

  Undated, but change was made on 2020-11-18.

  Dean Herbert · 2021-06-09 14:09:23 +09:00
  a87226ab10
• Merge branch 'master' into fix-spectator-frame-conversion
  Dan Balasescu · 2021-06-04 21:17:40 +09:00
  57a38374db
• Merge branch 'master' into factor-out-hoc
  Dan Balasescu · 2021-06-04 15:31:35 +09:00
  b283c48abb
• Merge branch 'master' into fix-spectator-frame-conversion
  Dean Herbert · 2021-06-04 15:06:15 +09:00
  23096c58bb
• Merge pull request #13322 from Pasi4K5/seed-for-all-random-mods

  Add seed option for all random mods

  Dan Balasescu · 2021-06-04 11:26:13 +09:00
  50c60c791f
• Detach gameplay score from replay recorder before importing

  Closes #13320.

  Dean Herbert · 2021-06-04 02:00:02 +09:00
  d444fed46f
• Move seed to base class
  Pasi4K5 · 2021-06-03 18:16:11 +02:00
  7a4fc9ffc8
• Apply review fixes
  smoogipoo · 2021-06-03 18:32:05 +09:00
  e887807ae7
• Merge branch 'master' into fix-spectator-frame-conversion
  smoogipoo · 2021-06-03 17:42:01 +09:00
  c3280083a2
• Merge pull request #11857 from Syriiin/diffcalc/refactor/catch-clockrate-effects

  Refactor catch Movement skill to not require explicit clockrate usage

  Dan Balasescu · 2021-06-03 17:29:27 +09:00
  15b43beef1
• Add framestable-bypassing seek for spectator
  smoogipoo · 2021-06-03 17:27:21 +09:00
  420df124b5
• Refactor to pass clockrate in constructor rather than deriving from mods
  Samuel Cattini-Schultz · 2021-06-03 16:09:42 +10:00
  f51413ead9
• Remove OnAdd/OnRemove of HitObjectContainer

  Instead, override `AddDrawable`/`RemoveDrawable`.

  ekrctb · 2021-06-03 15:00:16 +09:00
  b321b20e9d
• Make HitObjectContainer.Clear non-virtual

  It just call `Remove` for all entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  0ce7baa3f3
• Replace EntryCrossedBoundary with more useful RemoveRewoundEntry property

  It can be used for dynamically added entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  2c9e5b6c7e
• Factor out lifetime management logic of HitObjectContainer
  ekrctb · 2021-06-03 14:57:28 +09:00
  fe2934db1d
• Merge branch 'master' into autoplay-pause-support
  Dan Balasescu · 2021-06-03 13:26:00 +09:00
  44b1102241
• Make method internal
  smoogipoo · 2021-06-02 11:11:41 +09:00
  d3d8941ec8
• Merge branch 'master' into fix-scrolling-lifetime
  smoogipoo · 2021-06-02 11:08:28 +09:00
  8ee2b3a2d2
• Merge pull request #13256 from ekrctb/update-lifetime-2

  Update DHO lifetime on entry lifetime change

  Dan Balasescu · 2021-06-02 11:07:54 +09:00
  ac83450791
• Remove replay logic from DrawableRuleset (and implement in DrawableEditorRulesetWrapper)
  Dean Herbert · 2021-06-02 11:06:30 +09:00
  8a76d97b63
• Fix editor no longer creating autoplay frames
  Dean Herbert · 2021-06-01 17:28:41 +09:00
  f14c0eae99
• Simplify lifetime setter

  Setting entry lifetime will cause `LifetimeChanged` event and `base.LifetimeStart`/`End` will be modified in the callback.

  ekrctb · 2021-06-01 14:46:43 +09:00
  40949f6c1b
• Fix wrong code
  ekrctb · 2021-06-01 14:38:02 +09:00
  0f381f7758
• Revert invalid code transformation
  ekrctb · 2021-06-01 14:28:23 +09:00
  86020adf64
• Merge branch 'master' into autoplay-pause-support
  Dean Herbert · 2021-06-01 14:19:21 +09:00
  14570b6fb1
• Apply code styling suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  ekrctb · 2021-06-01 13:17:30 +09:00
  d5714e63b9
• Remove unused IScrollingHitObject interface
  ekrctb · 2021-05-31 23:17:26 +09:00
  86d1ba7ef2
• Change timing of HitObjectContainer.OnAdd/OnRemove

  Now, `OnAdd` is always invoked after the DHO is added to the container.
  This change is required by `ScrollingHitObjectContainer` to compute origin adjusted lifetime when origin position is relative to the parent drawable size.

  ekrctb · 2021-05-31 20:56:25 +09:00
  ff04942295
• Merge branch 'simplify-shoc' into fix-scrolling-lifetime

  # Conflicts:
  #	osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs

  ekrctb · 2021-05-31 16:50:47 +09:00
  948a14a627
• Reset lifetime to initial lifetime when layout is invalidated
  ekrctb · 2021-05-31 16:47:10 +09:00
  86d1225aad
• Remove scrollLength caching field

  It was not clear when the field is updated.

  ekrctb · 2021-05-31 16:28:02 +09:00
  6d96846776
• Remove delay of lifetime update

  The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.

  ekrctb · 2021-05-31 16:24:13 +09:00
  742c5b442b
• Don't add nested hit objects to the sets

  Only top-level hit objects are checked for layout computation caching.
  Also, lifetime of nested hit objects are not managed by the HitObjectContainer.

  ekrctb · 2021-05-31 16:20:35 +09:00
  3cedc0824d
• Make SetInitialLifetime public
  ekrctb · 2021-05-31 15:33:28 +09:00
  56a0a24cba
• Update drawable lifetime on entry lifetime change
  ekrctb · 2021-05-31 14:45:29 +09:00
  e25cca6fbe
• Merge pull request #13235 from ekrctb/update-lifetime-1

  Update hit object lifetime on `HitObject.DefaultsApplied`

  Dan Balasescu · 2021-05-31 14:44:40 +09:00
  8c6277f0d8
• Apply comment rewording suggestion

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  ekrctb · 2021-05-31 13:41:49 +09:00
  0c101d2859
• Fix comment grammar
  ekrctb · 2021-05-30 13:06:28 +09:00
  abb77b95b4
• Add test case of DHO setting LifetimeStart in OnApply
  ekrctb · 2021-05-28 21:51:48 +09:00
  265dfe5416
• Reset lifetime on HitObject.DefaultsApplied
  ekrctb · 2021-05-28 21:35:26 +09:00
  43bf734816
• Fix wrong/misleading comment of InitialLifetimeOffset
  ekrctb · 2021-05-28 17:19:36 +09:00
  1d5e8f4a91
• Add a mention that OnApply/OnFree is performed after ApplyDefaults
  Dean Herbert · 2021-05-27 15:20:35 +09:00
  122bb05aa8