65 Commits

• Fix HitWindows getting serialized alongside HitObjects

  These were being serialized as the base type. On deserialization, due to
  the HitWindow of objects being non-null, they would not get correctly
  initialised by the CreateHitWindows() virtual method.
  
  - Closes #10403

  Dean Herbert · 2020-10-07 13:45:42 +09:00
  a8151d5c63
• Add missing obsoletion notice
  smoogipoo · 2020-09-17 17:04:44 +09:00
  73a7b759cb
• Move some suggestions to warnings, resolve issues
  smoogipoo · 2020-06-03 16:48:44 +09:00
  f3b5149648
• Rename to IHasDuration
  Dean Herbert · 2020-05-27 12:38:39 +09:00
  cbd563e80b
• Drop obsoletion status for now
  smoogipoo · 2020-05-25 16:50:49 +09:00
  6f4cd6111c
• Add cancellation token support to CreateNestedHitObjects()
  smoogipoo · 2020-05-15 18:07:41 +09:00
  98125102a7
• Add HitObject to DefaultsApplied event
  smoogipoo · 2020-05-08 18:49:19 +09:00
  efff2bf15d
• Remove pointless comment

  Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2020-02-25 19:22:51 +09:00
  36079236e6
• Revert changes to make HitObject abstract
  Dean Herbert · 2020-02-25 19:07:15 +09:00
  a047456354
• Fix hitobjects with unknown lifetimes by enforcing non-null judgement

  We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
  due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
  CreateJudgement() must be implemented and return a non-null judgement.
  
  This fixes BananaShower and JuiceStreams in osu!catch.
  
  This also makes HitObject abstract and cleans up convert HitObject implementations.

  Dean Herbert · 2020-02-23 13:49:06 +09:00
  ffc7eaa3f2
• Use Bindable{Float,Double}s everywhere

  To avoid further floating-point comparison bugs, remove all usages of
  Bindable<{float,double}>, replacing them with their
  Bindable<Float,Double> counterparts.

  Bartłomiej Dach · 2020-02-01 22:50:29 +01:00
  434c0d92e4
• Use GetEndTime in Taiko and Mania
  Huo Yaoyuan · 2019-12-14 18:16:13 +08:00
  ddb2cfc46d
• Centralise End/StartTime retrieval to extension method
  Dean Herbert · 2019-11-25 19:09:14 +09:00
  709ec1404f
• Make hitobject samples a bindable list
  smoogipoo · 2019-11-08 14:04:57 +09:00
  6fc1be64c2
• Fix nested hitobjects not updating
  smoogipoo · 2019-10-18 13:18:41 +09:00
  9a896d52bf
• Use empty hitwindows instead of null
  Dean Herbert · 2019-10-09 19:08:31 +09:00
  51bf600ea7
• Add start time tracking to EditorBeatmap
  smoogipoo · 2019-10-03 14:23:48 +09:00
  897b3233af
• Fix combo bindings not being bound to nested hitobjects
  smoogipoo · 2019-09-26 17:39:19 +09:00
  45f2bcc440
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Add attribute to catch potential future nullrefs
  smoogipoo · 2019-09-02 17:48:41 +09:00
  f20e07136a
• Adjust xmldoc
  smoogipoo · 2019-09-02 17:15:36 +09:00
  f6102b4d92
• Fix skinning support for combobreak
  Dean Herbert · 2019-06-30 21:58:30 +09:00
  60ea3d4e1a
• Turn on warnings, resolve issues
  smoogipoo · 2019-04-25 17:36:17 +09:00
  0bd35ab7bb
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Add 1ms offset to controlpoint lookup times
  smoogipoo · 2018-12-04 12:08:46 +09:00
  9fdd48ded2
• Fix incorrect controlpoint being applied to samples
  smoogipoo · 2018-12-03 17:21:27 +09:00
  eb88768bd0
• Sort nested hitobjects post-creation
  smoogipoo · 2018-11-05 12:15:45 +09:00
  1fffa48aa0
• Use SortedList again
  smoogipoo · 2018-10-11 20:49:12 +09:00
  d282d16e1c
• Remove unnecessary lambda allocation
  smoogipoo · 2018-10-10 14:58:54 +09:00
  f53bb81723
• Reduce hitobject size by removing lazy
  smoogipoo · 2018-10-10 13:03:18 +09:00
  417ebaeb85
• Use list with post-sort for nested hitobjects
  smoogipoo · 2018-10-10 13:02:27 +09:00
  1125075b37
• Make HitObject not store the judgement
  smoogipoo · 2018-08-06 11:50:18 +09:00
  3a7488767c
• More xmldocs
  smoogipoo · 2018-08-06 11:31:54 +09:00
  0d6a8a2bf5
• More xmldocs to hitobject/drawablehitobject
  smoogipoo · 2018-08-06 10:55:38 +09:00
  b35817c877
• Make hitobjects only have one judgement + result
  smoogipoo · 2018-08-03 15:38:48 +09:00
  2a4994e5ce
• Initial structure for new hitobject judgement system
  smoogipoo · 2018-08-01 21:45:59 +09:00
  d51d0e8547
• Don't create nested hitobjects unless absolutely required
  smoogipoo · 2018-05-17 12:29:33 +09:00
  c67f372560
• Make HitWindows not return null by default
  smoogipoo · 2018-05-11 15:52:51 +09:00
  97a523584d
• Add info about when CreateHitWindows is invoked
  smoogipoo · 2018-05-11 15:36:53 +09:00
  5245d2d426
• Restructure HitWindows to allow outside setting
  smoogipoo · 2018-05-11 15:30:26 +09:00
  8216bc311a
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Remove "keypress" from comment
  smoogipoo · 2018-02-08 17:38:46 +09:00
  0511728fbe
• Make HitWindows settable by derived HitObjects
  smoogipoo · 2018-02-02 18:53:05 +09:00
  70462ebee3
• Give HitObject some HitWindows
  smoogipoo · 2018-02-02 18:47:10 +09:00
  558c53a6ba
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• Make HitObject.Samples non-nullable
  smoogipoo · 2017-12-25 16:41:18 +09:00
  0fb620a8d3
• Remove SampleInfoList
  smoogipoo · 2017-12-25 15:40:01 +09:00
  d288d8a51f
• Make Samples null by default and prepopulate in mania
  Dean Herbert · 2017-12-23 18:06:46 +09:00
  aeafa5645a
• SoundControlPoint -> SampleControlPoint
  Dean Herbert · 2017-12-23 16:34:34 +09:00
  5026c7a95e
• Make HitObjects construct nested hit objects
  smoogipoo · 2017-12-22 21:42:54 +09:00
  6a29f6020a