358 Commits

• Pass a score to the replay recorder to allow reading more general scoring data
  Dean Herbert · 2020-12-14 16:52:14 +09:00
  1793385e96
• Replace CatchHitObject.X usage to EffectiveX and OriginalX
  ekrctb · 2020-12-14 11:03:14 +09:00
  96f3e0dad8
• Combine DisplayRadius and Scale to DisplaySize
  ekrctb · 2020-12-10 20:43:01 +09:00
  2634c6b8d9
• Remove unneeded check of caught object removal

  The logic was public but now it is private
  so the condition is ensured by the caller

  ekrctb · 2020-12-09 10:50:35 +09:00
  a8e2f35b62
• Reword exception message
  ekrctb · 2020-12-09 10:38:11 +09:00
  b52e279702
• Remove unnecessary copy
  ekrctb · 2020-12-09 10:36:54 +09:00
  86445e7c23
• Rename caughtFruitContainer -> caughtObjectContainer
  ekrctb · 2020-12-09 10:35:36 +09:00
  c8b0934573
• more specific type droppedObjectContainer
  ekrctb · 2020-12-09 10:35:01 +09:00
  ccca7e0b25
• Revert rename error
  ekrctb · 2020-12-09 10:25:35 +09:00
  b80204642e
• Rename to CopyStateFrom, and add comment
  ekrctb · 2020-12-08 23:35:24 +09:00
  1212ffd24f
• Fix dropped objects not removed on revert result
  ekrctb · 2020-12-08 23:07:30 +09:00
  1f36bbecd1
• Pool caught objects and dropped objects
  ekrctb · 2020-12-08 22:38:10 +09:00
  749d5380ca
• Introduce IHasCatchObjectState implemented by DHO and CaughtObject
  ekrctb · 2020-12-08 21:29:26 +09:00
  a32dac00dd
• Make object on the catcher plate separate CaughtObject class
  ekrctb · 2020-12-08 21:11:40 +09:00
  c301223d8c
• Make catch hit lighting logic not dependent on caught object
  ekrctb · 2020-12-08 20:41:26 +09:00
  94a59ac3b2
• Compute object position in stack via a pure function
  ekrctb · 2020-12-08 20:36:59 +09:00
  56721a6fa9
• Merge pull request #11126 from ekrctb/fix-catcher-trail-sprite-pooled

  Clear all transforms of catcher trail sprite before returned to pool

  Dan Balasescu · 2020-12-08 17:59:23 +09:00
  c3241f163d
• Clear all transforms of catcher trail sprite before returned to pool
  ekrctb · 2020-12-08 17:31:00 +09:00
  22a5df6309
• Remove hit explosion on revert result
  ekrctb · 2020-12-08 15:43:17 +09:00
  02571ec7ae
• Remove caught objects on revert result
  ekrctb · 2020-12-08 15:24:39 +09:00
  1a66d8f2bc
• Restore hyper dash state on revert judgement result
  ekrctb · 2020-12-08 15:21:47 +09:00
  100b365c98
• Restore catcher state on revert judgement result
  ekrctb · 2020-12-08 15:03:03 +09:00
  cb76a2d7b5
• Move catcher state changing logic to OnNewResult method
  ekrctb · 2020-12-08 14:28:30 +09:00
  0213f77b4b
• Pool catcher trail sprite
  ekrctb · 2020-12-07 18:12:55 +09:00
  12c6b3c1fb
• Move public methods upwards
  Dean Herbert · 2020-12-04 14:36:40 +09:00
  d3a17b65d5
• Tidy up code formatting and remove unnecessarily publicly exposed methods
  Dean Herbert · 2020-12-04 14:35:56 +09:00
  8988023407
• Invert if
  ekrctb · 2020-12-04 10:24:25 +09:00
  23af70dd32
• Fix depth of dropped objects
  ekrctb · 2020-12-04 10:21:54 +09:00
  e82ca66d3e
• Use ApplyCustomUpdateState for dropping transformation

  We cannot just apply the transforms because DHO clears transforms when state is updated

  ekrctb · 2020-12-03 18:46:58 +09:00
  7e66714c2f
• Make DroppedObjectAnimation private
  ekrctb · 2020-12-03 18:46:58 +09:00
  be456f9c6b
• Move more logic to Catcher from CatcherArea
  ekrctb · 2020-12-03 16:44:36 +09:00
  5a5c956ced
• Refactor fruit dropping code

  - The repeated `Remove` call was quadratic complexity.
    Now it is linear time.

  ekrctb · 2020-12-03 16:44:36 +09:00
  2eb2c934cc
• Simplify the fruit stacking code

  It is now more clear that
  the expression of distance checking is probably unintended (a bug)

  ekrctb · 2020-12-03 16:44:36 +09:00
  873f2363c1
• Use more specific type for caught object
  ekrctb · 2020-12-03 16:44:36 +09:00
  8d32cca5d6
• Remove unused method
  ekrctb · 2020-12-03 16:44:36 +09:00
  a231a4aa6d
• Don't delay caught fruit loading

  It is not needed anymore because
  some code in DCHO is moved from `load` to constructor.

  ekrctb · 2020-12-03 16:44:36 +09:00
  af45e8d97b
• Create children in the constructor
  ekrctb · 2020-12-03 16:44:36 +09:00
  e5c8e06c4b
• Merge pull request #11011 from ekrctb/catch-pooling-initial

  Initial implementation of hit object pooling in osu!catch ruleset

  Dan Balasescu · 2020-12-02 13:02:22 +09:00
  2e0fdf9bca
• Use bigger initial capacity for catch hit object pool
  ekrctb · 2020-12-01 14:50:42 +09:00
  e8842eed81
• Apply suggested styling changes
  ekrctb · 2020-12-01 14:46:04 +09:00
  a16b265090
• A few code standard cleanups
  smoogipoo · 2020-12-01 12:57:37 +09:00
  5945c088cb
• Pool osu!catch hit explosion
  ekrctb · 2020-12-01 11:32:20 +09:00
  08cb84b325
• Convert switch expression to switch statement
  ekrctb · 2020-12-01 09:50:52 +09:00
  d1076778fd
• Use hit object pooling for BananaShower.
  ekrctb · 2020-11-30 19:22:40 +09:00
  70628235e3
• Use hit object pooling for JuiceStream.

  - Use `Clear(false)` to not dispose pooled children.
  - Don't set nested DHO `Origin`.
  - Simplify the layout (remove custom `Origin`).

  ekrctb · 2020-11-30 19:19:14 +09:00
  9611aaf09e
• Use hit object pooling for Fruit and Banana.
  ekrctb · 2020-11-30 19:07:50 +09:00
  b76ae525b2
• Use hit object pooling for Droplet and TinyDroplet.
  ekrctb · 2020-11-30 19:04:09 +09:00
  94fd607a7c
• Don't use CreateDrawableRepresentation in CatcherArea
  ekrctb · 2020-11-30 19:02:49 +09:00
  05aaa377e7
• Add comment explaining requirement
  Dean Herbert · 2020-11-30 15:22:55 +09:00
  9fbfb1aa9f
• Fix osu!catch combo counter not showing after 1 combo
  Dean Herbert · 2020-11-30 15:20:52 +09:00
  73990a6674