3515 Commits

• Merge branch 'master' into skin-per-ruleset-layouts
  Bartłomiej Dach · 2023-02-17 22:58:38 +01:00
  6b9472c367
• Merge branch 'master' into skinnable-clean-up-documentation
  Bartłomiej Dach · 2023-02-17 20:59:18 +01:00
  6afa65bd3d
• Fix tests which rely on HUDOverlay's DrawableRuleset being nullable
  Dean Herbert · 2023-02-17 19:27:09 +09:00
  a01c3090e4
• Use RulesetInfo instead of Ruleset in skin components lookup
  Dean Herbert · 2023-02-17 18:24:05 +09:00
  209d41ee9d
• Add optional ruleset identifier to SkinComponentsContainerLookup
  Dean Herbert · 2023-02-17 14:19:19 +09:00
  4cc6664dc7
• Remove redundant conditional access qualifier

  It is impossible for the callback passed to `ApplyToBackground()` to
  receive a null reference. See `OsuScreen.ApplyToBackground()` - if the
  background to call the callback on were `null`, then an
  `InvalidOperationException` would be thrown instead.

  Bartłomiej Dach · 2023-02-16 20:47:51 +01:00
  ad5132ed41
• Fix song select potentially updating background parameters when not the current screen
  Dean Herbert · 2023-02-16 18:45:22 +09:00
  394d368f16
• Rename SkinnableTargetContainer to SkinComponentsContainer

  Also use full `SkinComponentsContainerLookup` instead of the sub-type.
  This will potentially be useful once we bring in per-ruleset targets.

  Dean Herbert · 2023-02-15 18:37:41 +09:00
  a92e42bb84
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Move SkinnableInfo to better namespace
  Dean Herbert · 2023-02-15 18:23:10 +09:00
  6010dde86e
• Merge pull request #22628 from EVAST9919/letterbox-no-containers

  Remove unnecessary containers in `LetterboxOverlay`

  Bartłomiej Dach · 2023-02-13 23:54:48 +01:00
  939144fb6c
• Remove not needed containers
  Andrei Zavatski · 2023-02-13 15:14:25 +03:00
  2dee783401
• Make user activity class names more specific
  Joseph Madamba · 2023-02-12 12:32:17 -08:00
  afb66d8af4
• Merge pull request #22529 from ItsShamed/dsc/presence

  Add support for `Watching` and `Spectating` activities in `ReplayPlayer` and `SoloSpectatingPlayer`

  Dean Herbert · 2023-02-11 17:29:47 +09:00
  0c5dae5f26
• Fixed timeLeft counter in SongProgressInfo being out of bounds after rotation
  Terochi · 2023-02-10 17:58:48 +01:00
  81c3e0da31
• Merge branch 'master' into skin-editor-undo-support
  Dean Herbert · 2023-02-08 15:41:58 +09:00
  3a3c2e78a1
• Merge pull request #22432 from mk56-spn/sheared_slider_implementation_clean_ii

  Implement a sheared slider for the updated design

  Dean Herbert · 2023-02-08 15:01:00 +09:00
  b6809e156b
• feat: add name and rulset verb display support
  tsrk · 2023-02-06 12:44:00 +00:00
  bc89f8dc5b
• Fix potential nullref in tests
  Dean Herbert · 2023-02-06 19:31:45 +09:00
  aaf3ad805c
• Ensure pause sample loop is stopped on exiting player
  Dean Herbert · 2023-02-06 18:24:31 +09:00
  b83c8443ea
• Merge branch 'master' into sheared_slider_implementation_clean_ii
  Dean Herbert · 2023-02-06 17:49:33 +09:00
  c691a0d3af
• Fix default settings not being serialised / state tracked correctly
  Dean Herbert · 2023-02-06 15:00:42 +09:00
  778b8a9bf7
• feat: actually support status also for Replays
  tsrk · 2023-02-06 00:41:10 +00:00
  bf273597ea
• feat: add support for spectating status
  tsrk · 2023-02-05 23:58:08 +00:00
  d5b2d9ce97
• Use ``GetTrueGameplayRate()`` to remove need for jank
  mk56-spn · 2023-02-04 00:53:54 +01:00
  88872cf1cf
• Stop ``BPMCounter.cs``'s value from going to 0 after failing.
  mk56-spn · 2023-02-03 23:56:34 +01:00
  d9bee958dd
• Move skin component localisations to namespaces
  Dean Herbert · 2023-02-03 15:34:57 +09:00
  cf8cfe0d2c
• Fix incorrectly applied enum localisation
  Dean Herbert · 2023-02-03 15:27:11 +09:00
  50559643bb
• Merge branch 'master' into locale/skin-editor-components
  Dean Herbert · 2023-02-03 15:24:00 +09:00
  32207dc9dd
• Rename NormalSliderBar.cs to RoundedSliderBar.cs
  mk56-spn · 2023-02-02 17:24:45 +01:00
  3f0ce75bf5
• Merge branch 'master' into middle-click-replay-pause
  Dean Herbert · 2023-02-02 15:25:51 +09:00
  edecd2ee25
• refactor: change namespacing to allow osu-localisation-analyzer to process all strings
  tsrk · 2023-02-02 00:46:14 +00:00
  0fb6a63709
• feat: add localisation for Skin editor components
  tsrk · 2023-02-01 23:48:05 +00:00
  8645e705fd
• Fix nub naming in OsuCheckbox.cs and associated classes
  mk56-spn · 2023-01-26 16:10:02 +01:00
  091cc155d3
• Rename nub object in NormalSliderBar.cs class
  mk56-spn · 2023-01-26 15:03:51 +01:00
  a630f1113f
• Rename Nub.cs to NormalNub.cs
  mk56-spn · 2023-01-26 15:03:11 +01:00
  374c3b56f6
• Rename OsuSliderBar.cs as NormalSliderBar.cs
  mk56-spn · 2023-01-26 12:12:56 +01:00
  3988131475
• Fix default health bar having a very weird anchor point in the skin editor
  Dean Herbert · 2023-01-26 16:56:37 +09:00
  e5d4979bc3
• Rename Stop{SampleAndRemoveFilters -> }()

  Now that just one method for stopping samples is left, let's just
  repurpose st as the general "stop global effects" method rather than
  have it there with a hyperspecific name. It also has good symmetry, as
  there already was a `Start()` method in the class.

  Bartłomiej Dach · 2023-01-22 09:29:22 +01:00
  06aa3f7798
• Inline StopSample() into StopSampleAndRemoveFilters()

  The first method no longer has any callers except for the second one.

  Bartłomiej Dach · 2023-01-22 09:26:01 +01:00
  9e4e85e3e3
• Remove unnecessary sample stop in Restart()

  It is unnecessary, as a successful restart will exit the current player
  screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
  call, which means that in the restart flow the sample was actually
  getting stopped twice.
  
  Standard exit flow is fine, it only stopped the sample once.

  Bartłomiej Dach · 2023-01-22 09:24:12 +01:00
  0edfd24410
• Replace RemoveFilters call with StopSampleAndRemoveFilters
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:44:16 -03:00
  5b1a23c697
• Create StopSampleAndRemoveFilters method and change RemoveFilters to private
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:43:40 -03:00
  2e1ba6ef49
• Fix failSample still playing after player left FailOverlay
  Matheus Filipe dos Santos Reinert · 2023-01-22 01:14:33 -03:00
  a746cbc6ed
• Refactor update logic to be easier to follow
  Dean Herbert · 2023-01-19 19:27:05 +09:00
  2ce32e3209
• Fix JudgementCounterDisplay.cs max judgement always showing upon changing display mode
  mk56-spn · 2023-01-19 10:31:02 +01:00
  b22363ed8c
• Merge pull request #22284 from bdach/judgement-counter-broken

  Fix "show max judgement" setting not applying initially on judgement counter display

  Dean Herbert · 2023-01-19 09:09:06 +09:00
  e58abf7d1a
• Merge branch 'master' into skin/argon-song-progress-cleaner
  Bartłomiej Dach · 2023-01-18 23:52:12 +01:00
  b62ff8d644
• Make SongProgressInfo.ShowProgress init-only (and remove duplicate init)
  Bartłomiej Dach · 2023-01-18 23:35:40 +01:00
  b8b7442eb8
• Fix ShowMaxJudgement callback conflicting with JudgementCounter.Pop{In,Out}

  Both `JudgementCounterDisplay` (via the `ShowMaxJudgement` callback)
  and the `JudgementCounter.Pop{In,Out}` methods were operating on the
  alpha of the `JudgementCounter`. This meant that if the counter display
  was created with max judgement initially hidden, it would be hidden
  by the `ShowMaxJudgement` callback first, but then _unhidden_
  by `PopIn()`.

  Bartłomiej Dach · 2023-01-18 21:46:28 +01:00
  769f8c6190