Dean Herbert
1b9942cb30
Mark BeatmapSets as internal
2024-08-30 18:44:04 +09:00
Dean Herbert
291dd5b101
Remove TODO
2024-08-30 18:37:27 +09:00
Dean Herbert
c013974790
Merge branch 'master' into detached-beatmap-cache
2024-08-29 22:49:11 +09:00
Dan Balasescu
fec8fa46fa
Merge pull request #29533 from bdach/fix-sample-bank-stuff-again
...
Fix incorrect bank set / sample addition logic
2024-08-29 21:36:26 +09:00
Dean Herbert
def1abaeca
Fix some tests not always waiting long enough for beatmap loading
...
These used to work because there was a huge blocking load operation,
which is now more asynchronous.
Note that the change made in `SongSelect` is not required, but defensive
(feels it should have been doing this the whole time).
2024-08-29 18:42:43 +09:00
Dean Herbert
1776d38809
Remove loadedTestBeatmaps flag
2024-08-28 23:28:44 +09:00
Dean Herbert
e04b5bb3f2
Tidy up test beatmap loading
2024-08-28 23:28:44 +09:00
Dean Herbert
9123d2cb7f
Fix multiple test failures
2024-08-28 23:28:43 +09:00
Dean Herbert
dd4a1104e4
Always debounce external Filter requests (except for tests)
...
The only exception to the rule here was "when screen isn't active apply
without debounce" but I'm not sure we want this. It would cause a
stutter on returning to song select and I'm not even sure this is a
common scenario.
I'd rather remove it and see if someone finds an actual case where this
is an issue.
2024-08-28 19:13:50 +09:00
Dean Herbert
336abadbd1
Allow running initial filter criteria asynchronously
...
This reverts a portion of https://github.com/ppy/osu/pull/9539 .
The rearrangement in `SongSelect` is required to get the initial filter
into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
causing a delayed/scheduled filter application).
2024-08-28 19:13:50 +09:00
Dean Herbert
5ed0c6e91a
Remove song select preloading
...
Really unnecessary now.
2024-08-28 19:13:49 +09:00
Dean Herbert
b1f653899c
Fix enumeration over modified collection
2024-08-28 19:13:49 +09:00
Dean Herbert
81b36d897d
Fix null reference in change handling code
2024-08-28 19:13:49 +09:00
Dean Herbert
081c9eb21b
Fix incorrect cancellation / disposal handling of DetachedBeatmapStore
2024-08-28 17:21:19 +09:00
Dean Herbert
4d42274771
Use bindable list implementation
2024-08-28 16:03:37 +09:00
Dean Herbert
466ed5de78
Add basic detached beatmap store
2024-08-28 16:03:37 +09:00
Bartłomiej Dach
321e509f11
Merge pull request #29615 from peppy/break-overlay-improvements
...
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 11:16:08 +02:00
Bartłomiej Dach
8d7053d367
Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display
...
Fix mod icons potentially showing incorrectly at daily challenge intro
2024-08-27 09:37:11 +02:00
Dean Herbert
98faa07590
Apply NRT to BreakOverlay
2024-08-27 15:01:51 +09:00
Dean Herbert
797b020747
Add shadow around break overlay middle content to make sure it remains visible
2024-08-27 15:01:50 +09:00
Dean Herbert
abdbe510b8
Move break overlay (and cursor) further forward in depth
...
I didn't really want to move the cursor in front of the HUD, but we face
a bit of an impossible scenario otherwise (it should definitely be in
front of the break overlay for visibility).
So I'll deal with it for now.
2024-08-27 14:52:11 +09:00
Dean Herbert
84bceca778
Assume we can always fetch the ruleset
2024-08-26 15:38:58 +09:00
Dean Herbert
60271fb0f7
Merge pull request #29564 from peppy/skinnable-components-what-2
...
Remove requirement of `base` calls to ensure user skin container layouts are retrieved
2024-08-23 17:52:46 +09:00
Bartłomiej Dach
bd6943ebc2
Merge pull request #29537 from normalid-awa/feature/song-select/allow-copy-url-from-context-menu
...
Allow copying beatmap link in song select carousel context menu
2024-08-22 14:03:39 +02:00
Dean Herbert
58552e9768
Add missing user ruleset to link copying for beatmap panels
2024-08-22 19:18:41 +09:00
Dean Herbert
9a21174582
Move GlobalSkinnableContainers to global scope
2024-08-22 18:46:07 +09:00
Dean Herbert
f37cab0c6e
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
2024-08-22 18:39:36 +09:00
Dean Herbert
41756520b1
Rename SkinComponentsContainer to SkinnableContainer
2024-08-22 17:42:50 +09:00
Bartłomiej Dach
df94c22a29
Merge pull request #29545 from peppy/timeline-redesign-in-circles
...
Further timeline usability tweaks
2024-08-22 08:39:34 +02:00
Bartłomiej Dach
d33f4837fa
Merge pull request #29532 from bdach/redesign-timing-table-tracking
...
Redesign timing table tracking
2024-08-22 08:21:39 +02:00
Dean Herbert
9df12e3d87
Move seek button to left to differentiate mutating operations
2024-08-22 14:15:36 +09:00
Dean Herbert
54e5f1c9f0
Merge pull request #29556 from frenzibyte/kiai-star-bursts
...
Add star fountains/bursts when entering kiai mode in gameplay
2024-08-22 14:14:25 +09:00
Dean Herbert
f068b7a521
Move copy-to-url method to OsuGame to centralise toast popup support
2024-08-22 14:03:41 +09:00
Dean Herbert
7f5f3a4589
Fix mod icons potentially showing incorrectly at daily challenge intro
...
Prefer using the beatmap's rulesets over the current user selection.
Closes https://github.com/ppy/osu/issues/29559 .
2024-08-22 13:57:19 +09:00
Dean Herbert
ac5a3a0959
Remove one unused parameter
2024-08-22 02:17:11 +09:00
Dean Herbert
87123d99bf
Move URL implementation to extension methods and share with other usages
2024-08-22 02:08:01 +09:00
Dean Herbert
18a3ab2ffd
Use "link" instead of "URL"
2024-08-22 01:45:43 +09:00
Dean Herbert
a943000579
Merge pull request #29435 from OliBomby/improve-snaps
...
Fix timeline snapping ignoring nearby timing points
2024-08-22 01:36:30 +09:00
Dean Herbert
fb5fb78fd3
Move zero marker below control points to avoid common overlap scenario
2024-08-22 01:09:22 +09:00
Dean Herbert
843b10ef34
Add back incorrectly removed control point display toggle
2024-08-22 01:05:47 +09:00
Dean Herbert
2876cb73bd
Merge pull request #28991 from Layendan/master
...
Add collection and favourite buttons to results screen
2024-08-21 23:59:26 +09:00
Bartłomiej Dach
28d0a24555
Fix the fix
...
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546 , but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Salman Ahmed
c92af71029
Add in-gameplay version of kiai star fountains/burst
2024-08-21 17:34:38 +09:00
jkh675
3d5b57454e
Fix null reference
2024-08-21 16:21:49 +08:00
Dean Herbert
fef56cc29e
Remove expanding behaviour of timeline completely
2024-08-21 16:57:52 +09:00
Dean Herbert
7e6490133d
Adjust visuals of tick display (and fine tune some other timeline elements)
2024-08-21 16:46:14 +09:00
Dean Herbert
1a48a6f654
Reduce size of hit objects on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
3065f808a7
Simplify timing point display on timeline
2024-08-21 16:46:13 +09:00
Dean Herbert
a0002943a1
Adjust centre marker visuals a bit
2024-08-21 16:46:12 +09:00
Bartłomiej Dach
c4f08b42ab
Use colours to distinguish buttons better
2024-08-21 09:05:33 +02:00
