5694 Commits

• Decouple rankings table test from online API
  Bartłomiej Dach · 2022-01-09 14:42:19 +01:00
  82d6639a3b
• Add basic test scene for scoreboard time
  Bartłomiej Dach · 2022-01-07 19:18:16 +01:00
  881fa2b86b
• Wait for async continuation in score submission test

  The previous assert step was optimistically assuming that the async
  continuation that writes the value of
  `FakeImportingPlayer.ImportedScore` always completes before it, but
  that's not necessarily true even if the continuation is instant (it is
  still subject to things like task scheduling and TPL thread pool
  limits).
  
  To ensure no spurious failures, swap out the assert step for an until
  step instead.

  Bartłomiej Dach · 2022-01-06 13:09:25 +01:00
  66613cbaa4
• Handle score submission request in submission test scene

  Was previously not handled at all, therefore displaying request failures
  in the test log output. While that was mostly a red herring and
  shouldn't have caused any actual *test* failures, it is still better to
  handle this explicitly in a realistic manner.

  Bartłomiej Dach · 2022-01-06 12:57:26 +01:00
  84765b99b3
• Add omission of pages when there are too many
  Dean Herbert · 2022-01-04 19:05:14 +09:00
  5ed69338a6
• Prepare tests and general structure to support omission of pages
  Dean Herbert · 2022-01-04 18:46:44 +09:00
  86f72b71b1
• Use OverlayColourProvider and fix font weight
  Dean Herbert · 2022-01-04 18:14:42 +09:00
  5a11ee7810
• Remove pointless test coverage of DrawablePage
  Dean Herbert · 2022-01-04 17:53:24 +09:00
  d10b8c79b3
• Rename button classes to make more sense
  Dean Herbert · 2022-01-04 17:52:40 +09:00
  ee4f5c0e79
• Fix post-merge issues
  Dean Herbert · 2022-01-04 16:46:42 +09:00
  1c899e4402
• Merge branch 'master' into page-selector
  Dean Herbert · 2022-01-04 16:44:22 +09:00
  69e7ee0f48
• Merge branch 'master' into fix-listing-terminal-breakage
  Dean Herbert · 2022-01-04 11:49:02 +09:00
  f6b1405fa0
• Add test coverage of score submission if player is exited during import
  Bartłomiej Dach · 2022-01-03 22:00:47 +01:00
  7cdba2f7c3
• Add failing test case for old cards not expiring correctly
  Bartłomiej Dach · 2022-01-03 19:28:14 +01:00
  2660f41339
• Improve reliability of TestStoryboardSkipOutro

  Aims to resolve failures as seen at
  https://github.com/peppy/osu/runs/4677353822?check_suite_focus=true.
  
  Have run quite a lot locally with no failures (while removing the skip step 100% fails).

  Dean Herbert · 2022-01-01 15:32:39 +09:00
  04d8fd3a58
• Fix TestSceneMultiSpectatorLeaderboard not waiting for user population
  Dean Herbert · 2021-12-31 00:48:31 +09:00
  f53a675ca3
• Fix most open compound words in identifiers being closed
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  7de43e3aba
• Fix clear identifier typos
  Joseph Madamba · 2021-12-27 20:26:28 -08:00
  98524d60a4
• Add visual test coverage of "hidden by ruleset" combo option
  Bartłomiej Dach · 2021-12-26 16:49:18 +01:00
  34b0101ff4
• Merge pull request #16234 from smoogipoo/fix-initial-button-colour

  Fix OsuAnimatedButton animating when initially disabled

  Dean Herbert · 2021-12-25 15:34:40 +09:00
  8ad53138a6
• Merge branch 'master' into beatmap-card/extra-on-listing
  Dean Herbert · 2021-12-24 19:02:51 +09:00
  2ee3e61983
• Fix OsuButton event binding + inital-enablement colour
  Dan Balasescu · 2021-12-24 11:56:12 +09:00
  c973739b08
• Refactor OsuAnimatedButton test scene
  Dan Balasescu · 2021-12-24 11:56:12 +09:00
  03d159d723
• Use extracted ruleset config cache implementation in DI
  Bartłomiej Dach · 2021-12-23 19:02:10 +01:00
  5cbaa028eb
• Add testing for beatmap card size switching
  Bartłomiej Dach · 2021-12-23 15:55:51 +01:00
  27c5cc5bd8
• Implement beatmap card size tab control
  Bartłomiej Dach · 2021-12-23 15:55:36 +01:00
  1876617d8e
• Adjust testing methodology to improve reliability of mosue wheel volume adjust tests

  There was previously a potential in headless runs for timing
  discrepancies to cause the volume to never get adjusted.
  
  As seen at https://github.com/peppy/osu/runs/4604610951?check_suite_focus=true.

  Dean Herbert · 2021-12-23 13:25:24 +09:00
  d31c9db08b
• Merge pull request #16213 from peppy/working-beatmap-live

  Tidy up `WorkingBeatmap`

  Dan Balasescu · 2021-12-23 13:02:37 +09:00
  e1b539fa9e
• Adjust existing placeholder test to demonstrate failure case
  Bartłomiej Dach · 2021-12-22 15:03:20 +01:00
  02fa1c21b7
• Remove unused load checks
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  f3f491374b
• Remove BeatmapSetInfo and Metadata from interface

  There were very few accesses to this, and after realm they should all be
  done via the `BeatmapInfo`, so let's remove this.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  967419c9ac
• Merge pull request #16205 from smoogipoo/fix-multiplayer-tests

  Fix multiplayer test failures when checking for parted room

  Dean Herbert · 2021-12-22 13:42:05 +09:00
  cfdfe81afb
• Merge pull request #16198 from smoogipoo/fix-current-item-before-population

  Fix delete button showing on current item before beatmap retrieval

  Dean Herbert · 2021-12-22 13:15:07 +09:00
  a88800c99a
• Fix multiplayer test failures when checking for parted room
  Dan Balasescu · 2021-12-22 12:55:37 +09:00
  24c6f8fafa
• Fix delete button test failures

  Can be tested by adding a Thread.Sleep() in
  DrawableRoomPlaylistItem.load().

  Dan Balasescu · 2021-12-22 09:55:19 +09:00
  ee64ab6383
• Merge pull request #16197 from bdach/beatmap-card/renames

  Rename beatmap card-related classes

  Dean Herbert · 2021-12-21 18:51:34 +09:00
  0bda7892f7
• Fix test
  Dan Balasescu · 2021-12-21 18:38:31 +09:00
  e2f8c71081
• Merge pull request #16194 from peppy/fix-results-screen-wait-test

  Fix intermittent test failures on `TestSceneResultsScreen` due to long delay step

  Dan Balasescu · 2021-12-21 16:56:49 +09:00
  a53c67b2ea
• Rename BeatmapCard{ => Normal}
  Bartłomiej Dach · 2021-12-21 08:26:21 +01:00
  88d4e95ad8
• Merge pull request #16012 from bdach/beatmap-card/extra

  Implement "extra" beatmap card size

  Dean Herbert · 2021-12-21 15:40:33 +09:00
  2707b2fbda
• Fix intermittent test failures on TestSceneResultsScreen due to long delay step

  Using real time delays of 3 seconds doesn't play well with headless runs.

  Dean Herbert · 2021-12-21 15:15:05 +09:00
  c0a8758839
• Merge pull request #16189 from peppy/fix-beatmap-listing-overlay-test-failure

  Fix intermittent failures on `TestSceneBeatmapListingOverlay`

  Dan Balasescu · 2021-12-21 15:11:25 +09:00
  a8cd96278d
• Fix intermittent failures on TestSceneBeatmapListingOverlay

  In the specific method, there was no wait step after the initial fetch
  (unlike all of the rest), meaning the fetch may not have finished in
  time for the follow-up steps.
  
  As seen at
  https://github.com/ppy/osu/runs/4588058438?check_suite_focus=true.

  Dean Herbert · 2021-12-21 14:12:06 +09:00
  0f8a6a3f64
• Add note about local button clicking usage
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  bb3f375958
• Remove unused method in TestSceneMultiplayerQueueList
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  aad55ef89e
• Centralise all multiplayer button clicking test logic

  This adds the "wait for enabled" check in a way that can be easily
  reused, as it keeps getting missed in test implementations.
  
  This particular commit hopefully fixes
  https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.

  Dean Herbert · 2021-12-21 13:49:51 +09:00
  9aff646ff4
• Merge branch 'master' into beatmap-card/extra
  Bartłomiej Dach · 2021-12-20 15:49:00 +01:00
  f1a03aced5
• Merge branch 'master' into fix-song-select-test-failure
  Bartłomiej Dach · 2021-12-20 11:36:49 +01:00
  0b7daf542f
• Ensure presence of at least 1 difficulty for each ruleset
  Bartłomiej Dach · 2021-12-20 11:34:39 +01:00
  f492cf84d9
• Merge branch 'master' into fix-ready-button-test
  Bartłomiej Dach · 2021-12-20 11:02:43 +01:00
  d8be455a43