2698 Commits

• Replace calls to defective Humanizer methods with correct version
  Bartłomiej Dach · 2022-07-18 22:34:58 +02:00
  6f37487528
• Fix audio/background equality not correctly using BeatmapInfo local filenames
  Dean Herbert · 2022-07-18 17:05:21 +09:00
  22a9e7e275
• Don't show "missing background" messages to user

  Bit of an oversight.
  
  As reported on [twitter](https://twitter.com/emyl___/status/1548627793075998720) and somewhere else i forgot.

  Dean Herbert · 2022-07-17 21:20:51 +09:00
  51071be315
• Ensure that multiple BeatmapSetInfo already in realm don't cause import failures

  Really this shouldn't happen but I managed to make it happen. Until this
  comes up again in a way that matters, let's just fix the LINQ crash from
  `SingleOrDefault`.
  
  I've tested this to work as expected in the broken scenario.

  Dean Herbert · 2022-07-14 18:21:41 +09:00
  ebe0cfefd8
• Merge pull request #19098 from peppy/last-played

  Add "last played" sort mode to song select

  Dan Balasescu · 2022-07-13 22:44:50 +09:00
  7ed05277f8
• Fix audio and background file equality incorrectly comparing BeatmapSet.Hash
  Dean Herbert · 2022-07-13 19:41:38 +09:00
  1cfdea911b
• Add last played date to BeatmapInfo
  Dean Herbert · 2022-07-13 16:36:43 +09:00
  8820ea4006
• Fix editor saving not updating BeatmapSetInfo's hash
  Dean Herbert · 2022-07-08 02:33:14 +09:00
  c53dd4a703
• Remove unused using statement
  Dean Herbert · 2022-07-07 17:59:55 +09:00
  b5c703b62c
• Simplify BeatmapUpdater transaction handling using nested transaction support
  Dean Herbert · 2022-07-07 17:37:46 +09:00
  e2c4c94993
• Merge branch 'realm-nested-writes' into metadata-client
  Dean Herbert · 2022-07-07 17:37:06 +09:00
  79bed0abdf
• Change storyboard parsing logic to not completely fail if only .osb read fails

  Changes to allow the storyboard to exist if only the `.osu` is
  available. Reads better IMO.

  Dean Herbert · 2022-07-07 14:33:20 +09:00
  e81cebf27d
• Add local handling of cases where a beatmap's file cannot be found on disk
  Dean Herbert · 2022-07-07 14:29:19 +09:00
  c4b6893709
• Enable NRT and simplify LineBufferedReader
  Dean Herbert · 2022-07-06 14:57:56 +09:00
  a52ea3cabe
• Hook up update flow to metadata stream
  Dean Herbert · 2022-07-05 21:32:00 +09:00
  59d0bac728
• Remove unnecessary invalidation handling flow
  Dean Herbert · 2022-06-30 17:13:26 +09:00
  aab4dcefbd
• Move BeatmapOnlineLookupQueue to inside BeatmapUpdater
  Dean Herbert · 2022-06-30 17:03:19 +09:00
  0698471627
• Add missing xmldoc
  Dean Herbert · 2022-06-30 16:51:31 +09:00
  ef42c6ecdf
• Remove unnecessary nullable-enable
  Dean Herbert · 2022-06-30 16:47:26 +09:00
  e34c2f0aca
• Allow null parameter to GetWorkingBeatmap for now
  Dean Herbert · 2022-06-30 16:46:28 +09:00
  82134ad1a6
• Merge branch 'master' into beatmap-update-flow
  Dean Herbert · 2022-06-30 16:44:17 +09:00
  98938821e5
• Guard against NaN star difficulty results
  Dean Herbert · 2022-06-29 21:02:29 +09:00
  18d465eff7
• Merge pull request #18862 from peppy/empty-beatmap-file-fix-2

  Fix second case of empty beatmaps being reported to sentry as errors

  Dan Balasescu · 2022-06-27 20:37:57 +09:00
  396e7fc166
• Add more properties to IBeatmapOnlineInfo
  Dan Balasescu · 2022-06-27 16:07:15 +09:00
  f6a6538e96
• Fix second case of empty beatmaps being reported to sentry as errors
  Dean Herbert · 2022-06-27 15:29:01 +09:00
  13c8d33009
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Simplify refetch (and ensure to invalidate after processing)
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  7692bac35a
• Fix reprocessing not working on import due to realm threading woes
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  0c3d890f76
• Difficulty cache invalidation flow
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  30b3973c9f
• Allow song select to refresh the global WorkingBeatmap after an external update
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  66a01d1ed2
• Split updater process into realm transaction and non-transaction
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  6999933d33
• Ensure WorkingBeatmap is invalidated after update
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  021b16f2f3
• Queue beatmaps for update after editing
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  fe570d8052
• Move beatmap processing tasks to new BeatmapUpdater class
  Dean Herbert · 2022-06-24 21:02:37 +09:00
  06d59b717c
• Merge pull request #18834 from bdach/ban-implicit-to-lower-upper

  Disallow usage of `string.To{Upper,Lower}()` without explicit culture

  Dean Herbert · 2022-06-24 20:39:58 +09:00
  2ca4184eda
• Merge pull request #18832 from peppy/bdc-remove-unused-path

  Remove unused bindable retrieval flow in `BeatmapDifficultyCache`

  Dan Balasescu · 2022-06-24 20:20:23 +09:00
  7eb49dac7a
• Ensure WorkingBeatmap is always using a detached instance
  Dean Herbert · 2022-06-24 19:07:54 +09:00
  823b3c1c0f
• Rename incorrect parameter name in BeatmapManager.GetWorkingBeatmap
  Dean Herbert · 2022-06-24 19:07:54 +09:00
  2ae48d5a87
• Replace usages of string.To{Lower,Upper}()
  Bartłomiej Dach · 2022-06-24 11:57:45 +02:00
  26c5b59f6d
• Remove unused bindable retrieval flow
  Dean Herbert · 2022-06-24 17:09:56 +09:00
  c179127670
• Use AddOnce for update calls
  Dean Herbert · 2022-06-24 17:09:56 +09:00
  0755430006
• Merge branch 'master' into difficulty-icon-refactor-pass
  Dean Herbert · 2022-06-24 16:34:35 +09:00
  8912f07745
• Nuke calculating everything

  The whole component is pointless so I'm just going to nuke for now I
  guess. Kind of makes the whole refactor effort pointless but oh well?
  
  To expand on this, the implementation was actually incorrect as pointed
  out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.

  Dean Herbert · 2022-06-24 14:24:06 +09:00
  28837693e5
• Update retriever to be relatively sized
  Dean Herbert · 2022-06-24 14:06:31 +09:00
  12ea8369ee
• Use new property to specify no tooltip, rather than passing only ruleset
  Dean Herbert · 2022-06-24 14:06:18 +09:00
  d9c1a9d71f
• Remove unused parameters
  Dean Herbert · 2022-06-24 13:58:02 +09:00
  129c907092
• Move GetDifficultyRating helper method to StarDifficulty
  Dean Herbert · 2022-06-23 19:51:58 +09:00
  ef258122d2
• Enable NRT on BeatmapDiffiultyCache
  Dean Herbert · 2022-06-23 19:51:58 +09:00
  b068df2149
• Tidy up all remaining usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  01da6f20b3
• Split out simple DifficultyIcon with no calculation overhead and update usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  7dec530ca5