105 Commits

• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Substitute two jank interdependent bool flags for single tri-state enums
  Bartłomiej Dach · 2024-02-22 12:05:50 +01:00
  d06c67ad8f
• Allow choosing "Edit" from any beatmap carousel item
  Dean Herbert · 2023-12-19 19:58:49 +09:00
  bbfdd6892d
• Reduce some allocations in SongSelect in the mania ruleset
  Dan Balasescu · 2023-12-15 11:01:15 +09:00
  fbef40bb1f
• Add keycount to song select details panel and carousel panels
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  b36db3518c
• Fix collections not being sorted correctly in context menus
  Dean Herbert · 2023-10-16 16:03:12 +09:00
  7139592e43
• Rename and document method to limit scope
  Dean Herbert · 2023-02-03 15:04:47 +09:00
  f7094567d7
• Refactor into a method rather than property
  Dean Herbert · 2023-02-02 14:53:58 +09:00
  500e9c7944
• Fix merge issues
  OliBomby · 2023-01-16 01:09:04 +01:00
  832d033777
• Merge remote-tracking branch 'upstream/master' into carousel
  OliBomby · 2023-01-16 00:27:56 +01:00
  ab6bf6e1dc
• Added custom menu items in DrawableCarouselBeatmap
  OliBomby · 2023-01-16 00:13:12 +01:00
  87ee9ab813
• remove unnecessary usages of nullable forgiveness, add asserts for debugging
  mk56-spn · 2023-01-09 18:36:55 +01:00
  69260ca3c3
• Remove nullable disabling in carousel
  mk56-spn · 2023-01-08 19:02:48 +01:00
  47fb467012
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Convert realm data propagation to more correctly use Live<T>

  wip

  Dean Herbert · 2022-07-27 19:35:09 +09:00
  438067a18b
• Replace BeatmapCollection with RealmBeatmapCollection
  Dean Herbert · 2022-07-27 19:35:09 +09:00
  41393616d8
• Remove CollectionManager
  Dean Herbert · 2022-07-27 18:45:33 +09:00
  9c543fef48
• Add beatmap update button
  Dean Herbert · 2022-07-19 18:29:36 +09:00
  eaf4f6dbb7
• Split collection toggle menu item to own class
  Salman Ahmed · 2022-07-08 01:39:45 +03:00
  a94fb62be3
• Nuke calculating everything

  The whole component is pointless so I'm just going to nuke for now I
  guess. Kind of makes the whole refactor effort pointless but oh well?
  
  To expand on this, the implementation was actually incorrect as pointed
  out at https://github.com/ppy/osu/pull/18819#pullrequestreview-1017886035.

  Dean Herbert · 2022-06-24 14:24:06 +09:00
  28837693e5
• Tidy up all remaining usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  01da6f20b3
• Split out simple DifficultyIcon with no calculation overhead and update usages
  Dean Herbert · 2022-06-23 19:27:35 +09:00
  7dec530ca5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename Beatmaps to BeatmapHashes for clarity
  Dean Herbert · 2022-06-10 14:03:51 +09:00
  4a5e86e451
• Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo
  Dean Herbert · 2022-06-08 18:23:09 +09:00
  42cd7d9e6e
• Add back hide common string using new ToSentence() extension method
  Joseph Madamba · 2022-06-03 20:09:20 -07:00
  4b54fedd88
• Remove localisation of "hide" string to fix incorrect case
  Dean Herbert · 2022-04-24 16:37:11 +09:00
  999b4505d1
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Revert "Merge pull request #16716 from peppy/carousel-less-invalidations"

  This reverts commit 8d13e0514b, reversing
  changes made to 95582a9023.

  Dean Herbert · 2022-02-05 16:12:58 +09:00
  eb25730b61
• Reduce overhead of ApplyState by tracking previous values

  Even with pooling applied, there are overheads involved with transforms
  when quickly cycling through the carousel.
  
  The main goal here is to reduce the transforms in cases the reuse is
  still in the same state. Avoiding firing `FadeIn` and `FadeOut` are the
  main areas of saving.

  Dean Herbert · 2022-01-31 14:46:20 +09:00
  c3e3b2019d
• Remove DrawableCarouselItem.Update updating of height

  Marginal from a performance aspect, but reads better.

  Dean Herbert · 2022-01-31 14:46:20 +09:00
  a06287e76a
• Simplify binding/invalidation in TopLocalRank
  Dean Herbert · 2022-01-19 13:20:52 +09:00
  9be5bf38c6
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Update null fallback cases involving OnlineID
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  213d89b479
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Update existing usages of Author as string to access Username directly
  Dean Herbert · 2021-11-04 18:57:54 +09:00
  86540d1fb6
• Update some other missed incorrect null/empty usages
  Dean Herbert · 2021-11-04 14:50:43 +09:00
  d1e6d1cb98
• Rename all remaining cases
  Dean Herbert · 2021-10-03 00:55:29 +09:00
  ec61c3c5ee
• Rename BeatmapInfo variables which were named beatmap for clarity
  Dean Herbert · 2021-10-02 12:45:34 +09:00
  973c31132b
• Allow determining a BeatmapDifficultyCache's bindable return's completion state via nullability
  Dean Herbert · 2021-02-25 16:19:01 +09:00
  03771ce8ec
• Rename BeatmapDifficultyManager to BeatmapDifficultyCache
  Dean Herbert · 2020-11-06 13:14:29 +09:00
  5113d4af8f
• Simplify vertical position calculations by including spacing in height definition
  Dean Herbert · 2020-10-13 18:13:36 +09:00
  69650c16fc
• Fix masking issues with certain aspect ratio displays
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  f3b937e358
• Extract header element from base DrawableCarouselItem class
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  cfec4f4fc1
• Add back difficulty panel spacing
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  fd8654cff3
• Fix multiple difficulties being expanded at once
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  5c29aa8cce
• Add basic pooling setup
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  0a978c6131
• Refactor how drawable carousel items are constructed
  Dean Herbert · 2020-10-13 17:37:33 +09:00
  3143224e5b