2518 Commits

• Make "Hold Off" and "No Release" mod incompatible
  Dean Herbert · 2024-07-19 14:08:39 +03:00
  f500abd4f7
• Fix hold note light lingering with No Release

  Turns out endHold() is not called in the Tail.IsHit branch of the
  hold notes' CheckForResult method.

  Nathan Du · 2024-07-18 16:08:30 +08:00
  00ed7a7a2f
• Merge pull request #28809 from bdach/mania-timeline-zooms-composer

  Match mania editor playfield time range with timeline zoom

  Dan Balasescu · 2024-07-11 15:41:26 +09:00
  00cab0ec0a
• Match mania editor playfield time range with timeline zoom
  Bartłomiej Dach · 2024-07-10 17:36:39 +02:00
  92dc125d39
• Enable NRT on ManiaHitObjectComposer
  Bartłomiej Dach · 2024-07-10 15:12:03 +02:00
  fa749d317e
• Remove setup screen controls that do nothing useful

  Before I go with a hammer to redesign these, I want to remove stuff that
  does nothing first.
  
  Hard-breaks API to allow rulesets to specify an enumerable of custom
  sections rather than two specific weird ones.
  
  For specific rulesets:
  
  - osu!:
    - Stack leniency slider merged into difficulty section.
  - osu!taiko:
    - Approach rate and circle size sliders removed.
    - Colours section removed.
  - osu!catch:
    - No functional changes.
  - osu!mania:
    - Special style toggle merged into difficulty section.
    - Colours section removed.

  Bartłomiej Dach · 2024-07-10 14:53:16 +02:00
  c8a64c5950
• Remove unnecessary null-conditional operators
  Salman Ahmed · 2024-07-04 05:43:43 +03:00
  371ca4cc4b
• Update HasFlag usages
  Dean Herbert · 2024-07-03 00:19:04 +09:00
  5350945340
• Rewrite no release mod

  Per the request of spaceman_atlas, the No Release mod is rewritten to
  avoid modifications to DrawableHoldNoteTail. The approach is based
  on that of the Strict Tracking mod for the osu!(standard) ruleset,
  injecting the mod behavior by replacing the normal hold note with
  the mod's variant. The variant inherits most bevaior from the normal
  hold note, but when creating nested hitobjects, it creates its own
  hold note tail variant instead, which in turn is used to instantiate
  the mod's variant of DrawableHoldNoteTail with a new behavior.
  
  The time a judgement is awarded is changed from the end of its
  Perfect window to the time of the tail itself.

  Nathan Du · 2024-07-01 20:29:30 +08:00
  1eb10e029c
• Initial implemention of the No Release mod

  This commit adds a new osu!mania mod No Release that relaxes tail
  judgements. The current implementation automatically awards Perfect
  (or Meh if the hold note is broken midway) for a hold note tail at
  the end of its Perfect window, as long as it is held by then.
  
  Tests are pending for the next commit.

  Nathan Du · 2024-06-28 22:21:08 +08:00
  960d552dc1
• Fix legacy skin hold note bodies not appearing when scrolling upwards

  - Closes https://github.com/ppy/osu/issues/28567.
  - Regressed in https://github.com/ppy/osu/pull/28466.
  
  Bit of a facepalm moment innit...

  Bartłomiej Dach · 2024-06-25 10:35:36 +02:00
  1eac0c622a
• Fix nullability insepction
  Dean Herbert · 2024-06-18 15:13:52 +08:00
  e6187ebec0
• Adjust calls to DrawableExtensions.With<T>()
  Bartłomiej Dach · 2024-06-18 07:41:20 +02:00
  366ba26cb6
• Merge pull request #28466 from smoogipoo/fix-long-hold-length

  Fix missing texture on extremely long hold notes

  Bartłomiej Dach · 2024-06-13 09:13:03 +02:00
  fdb63bd7cd
• Fix missing texture on extremely long hold notes
  Dan Balasescu · 2024-06-13 15:19:41 +09:00
  1ff20cc13d
• Allow modifying hold note start/end time via mania composer playfield
  Bartłomiej Dach · 2024-06-12 15:30:27 +02:00
  feadf7a56e
• Fix failing tests due to missing DI pieces
  Dean Herbert · 2024-06-12 11:23:56 +08:00
  2a8bd8d968
• Attempt full editor reload on key count change
  Bartłomiej Dach · 2024-06-11 11:31:49 +02:00
  da53a11d3c
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Implement flip operations in mania editor
  Bartłomiej Dach · 2024-06-07 09:01:41 +02:00
  629e7652c0
• Fix legacy mania note body animation not resetting sometimes

  Hopefully closes https://github.com/ppy/osu/issues/28284.
  
  As far as I can tell this is a somewhat difficult one to reproduce
  because it relies on a specific set of circumstances (at least the
  reproduction case that I found does). The reset to frame 0 would
  previously be called explicitly when `isHitting` changed:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game.Rulesets.Mania/Skinning/Legacy/LegacyBodyPiece.cs#L144
  
  However, it can be the case that `bodyAnimation` is not loaded at the
  point of this call. This is significant because
  `SkinnableTextureAnimation` contains this logic:
  
      https://github.com/ppy/osu/blob/182ca145c78432f4b832c8ea407e107dfeaaa8ad/osu.Game/Skinning/LegacySkinExtensions.cs#L192-L211
  
  which cannot be moved any earlier (because any earlier the `Clock` may
  no longer be correct), and also causes the animation to be seeked
  forward while it is stopped.
  
  I can't figure out a decent way to layer this otherwise (by scheduling
  or whatever), so this commit is just applying the nuclear option of just
  seeking back to frame 0 on every update frame in which the body piece is
  not being hit.

  Bartłomiej Dach · 2024-05-28 15:29:15 +02:00
  bf0040447c
• Do not change mania column width on mobile platforms

  - Closes https://github.com/ppy/osu/issues/25852
  - Reverts https://github.com/ppy/osu/pull/25336 /
    https://github.com/ppy/osu/pull/25777
  
  With the columns not being directly touchable anymore after
  https://github.com/ppy/osu/pull/28173 I see very little point to this
  continuing to exist.

  Bartłomiej Dach · 2024-05-16 08:21:52 +02:00
  97de73b99c
• Remove redundant cast
  Bartłomiej Dach · 2024-05-14 18:41:15 +02:00
  3d190f7e88
• Remove touch mod addition to mania

  Feels a bit pointless? I dunno.

  Dean Herbert · 2024-05-14 22:38:31 +08:00
  f781dc3300
• Tidy class and change to be a VisibilityContainer similar to taiko implementation
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  5c9a90cb40
• Rename touch area class to match existing usage (see taiko)
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  390557634a
• Move out of playfield so touch overlay is not affected by playfield position
  Dean Herbert · 2024-05-14 22:34:05 +08:00
  12e98fe55d
• Hook up touch device mod
  Dan Balasescu · 2024-05-14 19:14:58 +08:00
  a761a7bced
• Add opacity setting
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  e3f2e1ba08
• Hook up input manager
  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  39337f5189
• Add mania touch overlay

  Adjust default anchor/origin

  Dan Balasescu · 2024-05-14 19:14:50 +08:00
  ef40197713
• Remove existing per-column touch input
  Dan Balasescu · 2024-05-14 19:10:14 +08:00
  4f6777a0a1
• Remove unused members from GameplaySkinComponentLookup
  Dan Balasescu · 2024-04-19 18:03:13 +09:00
  362a7b2c77
• Don't re-filter unless mods may change the filter
  Dan Balasescu · 2024-04-15 21:07:36 +09:00
  343b3ba0e6
• Fully qualify LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-04-01 17:02:32 +09:00
  8e0ca11d1c
• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Refactor score simulator to use GetColumnCount()
  Dan Balasescu · 2024-03-28 22:58:39 +09:00
  c08a4898b2
• Remove unused OriginalTargetColumns
  Dan Balasescu · 2024-03-28 22:51:13 +09:00
  ce21235db4
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Refactor pattern generation to not require ManiaBeatmap
  Dan Balasescu · 2024-03-28 22:32:27 +09:00
  64399e9dd9
• Merge branch 'master' into verify-abnormal-difficulty-settings
  Bartłomiej Dach · 2024-03-26 11:13:16 +01:00
  b74f8dba41
• Refactor abstract check to reduce duplication
  Bartłomiej Dach · 2024-03-26 11:13:03 +01:00
  1866b4b6b1
• Make check ruleset specific
  Arthur Araujo · 2024-03-22 14:48:22 -03:00
  6fa663c8ca
• Remove warning for 10K+
  Arthur Araujo · 2024-03-20 16:51:27 -03:00
  2d6a3b8e2b
• Add mania keycount check
  Arthur Araujo · 2024-03-20 15:52:16 -03:00
  c605e463a4
• Merge branch 'master' into tcm-resume
  Dan Balasescu · 2024-03-14 12:22:46 +09:00
  0beaa8e8c5
• Fix missing event unbinds
  Dan Balasescu · 2024-03-07 21:10:11 +09:00
  ca92a31cf9
• Clamp only on horizontal sides
  Salman Ahmed · 2024-03-06 18:40:20 +03:00
  672f645cba
• Add comments
  Salman Ahmed · 2024-03-01 22:57:13 +03:00
  f1b66da469
• Fix osu!mania key images potentially showing gaps between columns
  Salman Ahmed · 2024-03-01 22:49:12 +03:00
  e0c73eb362