2759 Commits

Author	SHA1	Message	Date
Jérémiah DÉCOMBE	d783998c81	using BindValueChanged and IsCurrentScreen for setting binding	2023-01-24 09:09:05 +01:00
Dean Herbert	bb15ee50e0	Fix beatmap leaderboard potentially showing incorrect leaderboard	2023-01-24 13:52:59 +09:00
Jeremiah DECOMBE	c1876aac88	removing parameter name abbreviations	2023-01-24 00:36:38 +01:00
Jeremiah DECOMBE	b573e42cc2	BeatmapSelectionBackgroundBlurLevel renamed to SongSelectBackgroundBlurLevel	2023-01-24 00:08:11 +01:00
Jeremiah DECOMBE	26adc28943	missing blank line between methods	2023-01-23 23:15:37 +01:00
Jeremiah DECOMBE	f13a5465ba	variable naming and loc modifications	2023-01-23 23:07:50 +01:00
Jérémiah DÉCOMBE	6daa364779	adding setting to adjust blur of the background of the song select screen	2023-01-23 13:53:31 +01:00
Dean Herbert	e3932c077b	Merge pull request #22032 from frenzibyte/fix-potential-difficulty-failure-alt ... Fix advanced statistics display potentially performing invalid difficulty calculation	2023-01-23 15:39:47 +09:00
Bartłomiej Dach	4a6f6300c5	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-18 17:15:20 +01:00
Bartłomiej Dach	7ba448b13c	Update comment to match implementation	2023-01-18 17:12:57 +01:00
Dean Herbert	3b27774561	Remove OnlineID sort consideration	2023-01-18 19:21:02 +09:00
Dean Herbert	4ad79a8a0a	Move IsLoaded check inside BeatmapCarousel	2023-01-18 12:00:47 +09:00
mk56-spn	92a755c5da	adjust colourbar to position itself in a more simple fashion	2023-01-17 22:16:59 +01:00
Bartłomiej Dach	6f11fbdeed	Merge branch 'master' into fix-carousel-sort-change-after-play	2023-01-17 20:46:06 +01:00
Dean Herbert	8e1002b744	Fix song select potentially operating on Carousel before it is fully loaded ... Should fix test failures like https://github.com/ppy/osu/actions/runs/3939620830/jobs/6739690253.	2023-01-18 01:56:18 +09:00
Dean Herbert	a9ac28b504	Add fallback sorts to CarouselBeatmapSet to ensure stable sorting	2023-01-17 16:40:25 +09:00
Dean Herbert	ef35493864	Avoid need for weird null check by reordering initialisation process	2023-01-17 15:27:21 +09:00
OliBomby	832d033777	Fix merge issues	2023-01-16 01:09:04 +01:00
OliBomby	ab6bf6e1dc	Merge remote-tracking branch 'upstream/master' into carousel	2023-01-16 00:27:56 +01:00
OliBomby	1c0a650575	Fix typo	2023-01-16 00:17:26 +01:00
OliBomby	87ee9ab813	Added custom menu items in DrawableCarouselBeatmap	2023-01-16 00:13:12 +01:00
mk56-spn	9a29c9ae26	remove hacky method to check if carousel is null	2023-01-15 15:32:53 +01:00
Dean Herbert	c5775aa452	Merge branch 'master' into song_select_nullability	2023-01-15 22:44:13 +09:00
Dean Herbert	4cf4a66858	Make MusicController a required dependency of SongSelect	2023-01-15 22:43:30 +09:00
Dean Herbert	f7af5a8115	Revert some formatting changes	2023-01-15 22:39:00 +09:00
Dean Herbert	4906f37109	Merge pull request #22181 from frenzibyte/attempt-fix-song-select-test-failure ... Fix intermittent failure in beatmap carousel tests	2023-01-15 02:35:36 +09:00
ansel	515ada6815	Remove CanBeNull where it's no longer requered	2023-01-13 23:11:50 +03:00
ansel	a41a031909	Localise some notifications	2023-01-13 23:11:25 +03:00
Salman Ahmed	112cf403ec	Fix intermittent failure in certain beatmap carousel tests	2023-01-13 19:41:44 +03:00
mk56-spn	a6b6fb864e	Make carousel non nullable and ensure pre load usages of methods that reference it are protected against failure	2023-01-13 13:10:29 +01:00
mk56-spn	403ca05e5e	Enable nullability for song select	2023-01-13 00:52:14 +01:00
Bartłomiej Dach	aab84d50eb	Remove boxing overhead in CarouselItem comparator	2023-01-10 18:35:06 +01:00
Dean Herbert	b7e845201f	Fix whitespace around Debug.Assert	2023-01-10 18:03:17 +09:00
Dean Herbert	d53dafa29f	Revert Debug.Assert	2023-01-10 17:52:28 +09:00
Dean Herbert	93038ce496	Use OfType instead of forceful nullability	2023-01-10 17:52:21 +09:00
mk56-spn	6abbc7dc28	Further fix nullability	2023-01-09 20:59:28 +01:00
mk56-spn	69260ca3c3	remove unnecessary usages of nullable forgiveness, add asserts for debugging	2023-01-09 18:36:55 +01:00
mk56-spn	47fb467012	Remove nullable disabling in carousel	2023-01-08 19:02:48 +01:00
Dean Herbert	464f251c0c	Merge branch 'master' into beatmap-set-link-genre-language	2023-01-06 17:09:06 +08:00
Salman Ahmed	8f37e69dc4	Schedule difficulty calculation to avoid performing with incomplete state updates	2023-01-05 12:52:08 +03:00
Salman Ahmed	39221a52da	Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation	2023-01-05 12:52:08 +03:00
Dean Herbert	beb3b96aca	Harden request equality checks	2023-01-04 01:44:00 +08:00
Dean Herbert	8f7ae0395a	Fix song select leaderboard potentially showing wrong scores on quick beatmap changes ... Closes #22002.	2023-01-03 00:55:09 +08:00
mk56-spn	680646d3a6	Make offsetting of bottom bar more readable	2022-12-29 12:02:08 +01:00
Joseph Madamba	494886ef92	Rename Text to Metadata	2022-12-23 11:11:15 -08:00
Joseph Madamba	1d39e8d0ce	Refactor MetadataSection to use generics and inheritance	2022-12-21 10:18:47 -08:00
mk56-spn	626f4b0dfd	fix test failures, improve button logic	2022-12-19 16:35:20 +01:00
MK56	878e2f24c4	Merge branch 'master' into footer_V2_implementation	2022-12-19 13:19:23 +01:00
mk56-spn	407b0a0ad3	Address issues from Joehuu review	2022-12-19 11:30:23 +01:00
ansel	b66409bd37	Perform rewind with right click only if cursor didn't leave the button	2022-12-05 23:38:45 +03:00
mk56-spn	7373d79ba6	Use OsuColour instead of hex for button accent colour	2022-12-02 19:16:25 +01:00
mk56-spn	c5bad816db	Add button colouring whilst corresponding overlay is present	2022-12-02 18:44:21 +01:00
mk56-spn	ea882f6874	Add disabled button dimming.	2022-12-01 22:31:14 +01:00
mk56-spn	55a21a75a4	Add hover lightening	2022-12-01 22:07:28 +01:00
mk56-spn	d7cea51551	Add functionality of Random button	2022-12-01 16:29:52 +01:00
mk56-spn	1530495e7c	Add button "accent" colour, bottom bar, icon, text	2022-12-01 15:34:09 +01:00
mk56-spn	774eb178a1	Add basic button design and footer button addition flow	2022-12-01 13:13:37 +01:00
mk56-spn	18b4317e99	Create Basic V2 footer and test	2022-12-01 11:57:50 +01:00
mk56-spn	0aba119056	Merge remote-tracking branch 'origin/RangeSlider_implementation' into RangeSlider_implementation ... # Conflicts: # osu.Game.Tests/Visual/SongSelect/TestSceneDifficultyRangeFilterControl.cs # osu.Game/Screens/Select/DifficultyRangeFilterControl.cs	2022-11-27 10:40:29 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
mk56-spn	92ed2ed4ef	Refactor star "DifficultyRangeFilterControl" into generic range slider class	2022-11-26 12:19:08 +01:00
Dean Herbert	de163b2bb5	Change song select to only allow volume adjusting if alt is held while scrolling	2022-11-22 19:48:55 +09:00
Dean Herbert	4a79141824	Merge pull request #21338 from RATCM/fix-leaderboard-filter ... Match leaderboard filter behaviour to web	2022-11-21 14:01:55 +09:00
RATCM	f5fbb7c8de	Changed comments	2022-11-20 19:27:40 +01:00
RATCM	d20a357c0e	Fixed ordering bug	2022-11-20 19:24:51 +01:00
RATCM	9040dfbd4e	Match leaderboard filter behaviour to web	2022-11-20 17:39:46 +01:00
Bartłomiej Dach	7b274083d3	Fix phantom beatmap sets appearing on carousel after delete/update ... Regressed in c40c70509e. As it turns out, `item.Item.Filtered.Value` is not the only condition that should be checked to determine if a carousel item should be hidden or not - `item.Item.State.Value != CarouselItemState.Collapsed` should also be true. This was even available as the `item.Item.Visible` convenience property, which is used in this commit. Failing to check `item.Item.State.Value` led to setting non-zero alpha on collapsed carousel items, leading to phantom beatmap sets appearing, as the alpha was set in the entire carousel's `Update()` method, thus firing every frame.	2022-11-20 10:08:34 +01:00
nanashi-1	4773979e52	add condition	2022-11-17 16:15:34 +08:00
Salman Ahmed	87b4fee10f	Remove leftover constant	2022-11-17 04:05:21 +03:00
Salman Ahmed	55beaf5d93	Revert buttons order change	2022-11-17 04:05:15 +03:00
Salman Ahmed	039ab83a46	Disable beatmap options button when none selected	2022-11-17 04:00:23 +03:00
Salman Ahmed	0e46614c57	Revert beatmap option button state changes	2022-11-17 03:57:01 +03:00
nanashi-1	5d8d8ffce5	fix naming	2022-11-16 10:09:51 +08:00
nanashi-1	55edd6c907	add space	2022-11-16 09:58:49 +08:00
nanashi-1	1fb8357e93	change disabledAlpha from readonly to const	2022-11-16 09:58:32 +08:00
nanashi-1	9101ad0cbd	fixed naming	2022-11-16 09:42:40 +08:00
nanashi-1	5973bb1956	AddButton now returns the button	2022-11-15 20:57:31 +08:00
nanashi-1	1186ed3e32	add disable	2022-11-15 20:56:18 +08:00
nanashi-1	e8d170e772	disable certain options when no beatmap is selected	2022-11-15 20:55:55 +08:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	e75c3b3f94	Rename SkinnableTarget to GlobalSkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	391840404d	Play exiting transition in both directions	2022-11-07 11:59:43 +09:00
Dean Herbert	c40c70509e	Improve song select transition to gameplay	2022-11-04 15:24:37 +09:00
Dean Herbert	20dd405c2b	Merge branch 'master' into maintain-common-mod-selection	2022-11-03 15:32:40 +09:00
Dean Herbert	d9d083752a	Clamp backwards index to total current items to fix edge case of item removal	2022-10-26 11:03:11 +09:00
Dean Herbert	cf3bf41b49	Harden and simplify logic to avoid weird issues	2022-10-25 18:57:15 +09:00
Dean Herbert	22ea9a8ab4	Add early return of carousel group has no items	2022-10-25 13:34:22 +09:00
Dean Herbert	2456a18bc1	Rewrite implementation to avoid duplicated LINQ returns	2022-10-25 12:48:17 +09:00
Endrik Tombak	5a118cfdc3	Merge branch 'master' of https://github.com/ppy/osu into carousel-perform-selection ... Conflicts: osu.Game.Tests/Visual/SongSelect/TestSceneBeatmapCarousel.cs	2022-10-24 21:40:48 +03:00
Salman Ahmed	01c65d3cc1	Remove seemingly unnecessary/leftover code	2022-10-14 02:16:36 +03:00
Salman Ahmed	964ed01abb	Add confirmation dialog for updating locally modified beatmaps	2022-10-13 02:40:15 +03:00
Dean Herbert	a44ba579c5	Fix beatmap update button not respecting user "prefer no video" setting ... Closes #20701.	2022-10-11 14:27:40 +09:00
Dean Herbert	d9f678d942	Change song select random key binding to not handle key repeat	2022-10-03 18:16:54 +09:00
Dean Herbert	5fc836d1f0	Apply NRT to BeatmapLeaderboard / MatchLeaderboard	2022-09-26 16:17:28 +09:00
Dean Herbert	32d56fe3a9	Use request cancellation and IsDisposed guard instead of more Schedule	2022-09-26 16:02:33 +09:00
Dean Herbert	0fa5e1b28e	Fix intermittent leaderboard crash due to request finishing after drawable is disposed	2022-09-23 20:18:44 +09:00
Dean Herbert	5b73f24864	Fix outdated scores being held by BeatmapLeaderboard after external beatmap switch	2022-09-21 15:21:32 +09:00
Dean Herbert	68c040175a	Ensure Leaderboard.Scores is updated immediately via request flow	2022-09-20 17:02:57 +09:00
Dean Herbert	46db3ad96d	Move implementation to individual classes	2022-09-20 00:06:02 +09:00
Dean Herbert	4c4fdfd153	Provide scores directly to Player instance rather than relying on DI	2022-09-16 18:15:17 +09:00