13065 Commits

• Rename variable and ensure timestamp is updated even when not saving
  Dean Herbert · 2023-06-10 02:19:34 +09:00
  38fda7ac7d
• Use LastEditTime in Editor
  timiimit · 2023-06-10 02:19:34 +09:00
  aa0e4e16f7
• Merge branch 'master' into tidy-results-grid-usage
  Bartłomiej Dach · 2023-06-03 19:45:23 +02:00
  331e90f720
• Simplify column dimensions code

  `dimensions` would always receive exactly one item, so might as well
  inline it.
  
  And yes, at this point the grid container is mostly a glorified
  `FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
  touching that in this pull pending further decisions with respect to
  direction.

  Bartłomiej Dach · 2023-06-03 19:40:01 +02:00
  602d5db3bb
• Merge branch 'master' into update-multiplayer-room-diff-range
  Bartłomiej Dach · 2023-06-03 16:50:09 +02:00
  a9d4556647
• Merge branch 'master' into editor-timeline-fix
  Bartłomiej Dach · 2023-06-01 21:18:08 +02:00
  8433813677
• Adjust inline comment
  Bartłomiej Dach · 2023-06-01 21:18:00 +02:00
  c2d89a32a9
• Fix nullability
  Andrei Zavatski · 2023-06-01 21:21:01 +03:00
  03eb7c7830
• Use combined area of children as a mask instead
  Andrei Zavatski · 2023-06-01 15:32:17 +03:00
  949fe32740
• Return StatisticItems rather than StatisticRows from ruleset

  There were no usages of more than one column being provided per row, so
  it seemed like unnecessarily complexity. I'm currently trying to reduce
  complexity so we can improve the layout of the results screen, which
  currently has up to three levels of nested `GridContainer`s.
  
  Of note, I can't add backwards compatibility because the method
  signature has not changed in `Ruleset` (only the return type). If we do
  want to keep compatibility with other rulesets, we could designate a new
  name for the updated method.

  Dean Herbert · 2023-06-01 14:35:15 +09:00
  985604fab5
• Remove unused Dimension specification from StatisticItem
  Dean Herbert · 2023-06-01 14:25:18 +09:00
  dc595b83f1
• Merge pull request #23661 from peppy/fix-multiplayer-present-crash

  Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen

  Dean Herbert · 2023-05-31 19:43:30 +09:00
  812def124f
• Apply same comment & reworded condition to suspend too
  Bartłomiej Dach · 2023-05-30 21:54:56 +02:00
  62d1774407
• Fix editor timeline hitobjects popping in
  Andrei Zavatski · 2023-05-30 16:41:42 +03:00
  d119447a10
• Add comment and use full conditional similar to extension method

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-05-30 18:38:28 +09:00
  741ee84ed6
• Merge branch 'master' into scorev2
  Dean Herbert · 2023-05-30 14:34:43 +09:00
  14a376c041
• Merge branch 'master' into scorev2
  Dean Herbert · 2023-05-29 20:06:32 +09:00
  1558723420
• Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling

  I don't feel too confident with the default scoring function being
  assigned in the constructor to a publicly settable delegate. This just
  feels a bit more elegant, and handles the (likely-never-used) case where
  we need to restore the default function.
  
  An alternative would be to provide the function as a `ctor` argument,
  but I believe that wasn't done here to allow using the
  `ILeaderboardScore` interface.

  Dean Herbert · 2023-05-29 20:00:29 +09:00
  1a6d9e9ff0
• Move GetDisplayScore xmldoc to interface and remove getter
  Dean Herbert · 2023-05-29 19:41:53 +09:00
  fcd7a1d51a
• Ensure GameplayScoreCounter's display score is updated on ScoringMode change

  This isn't strictly required, but only because of a kind of hacky
  behaviour where `HUDOverlay` will recreate all components on a scoring
  mode change currently (see
  https://github.com/ppy/osu/blob/8f6df5ea0f7f721c630fc8cad93bb3eef869d1d9/osu.Game/Screens/Play/HUDOverlay.cs#L410-L418).
  
  Best we do this just in case that happens to go away in the future.

  Dean Herbert · 2023-05-29 19:00:02 +09:00
  9a886125ad
• Apply NRT to GameplayScoreCounter
  Dean Herbert · 2023-05-29 18:48:17 +09:00
  22be045de3
• Actually use paused header
  Dean Herbert · 2023-05-29 10:24:59 +09:00
  b0501c4e5c
• GameplayMenuOverlay.cs: add translatable strings for Retry count: and Song progress:

  This makes the assumption that languages will prefer having the number on the right

  Robin Oger · 2023-05-27 12:47:05 +02:00
  cfa1280028
• Adapt changes to fit master
  Robin Oger · 2023-05-27 12:29:14 +02:00
  a01577cba5
• Merge pull request #23647 from peppy/pause-screen-progress

  Show current progress on pause screen

  Bartłomiej Dach · 2023-05-26 19:36:30 +02:00
  574ecf939c
• Merge pull request #23649 from peppy/keep-selection-buttons-on-screen

  Ensure editor selection buttons remain on screen when selection is near edge

  Dean Herbert · 2023-05-26 20:51:45 +09:00
  725734bc03
• Add (int) flooring and handle potential NaN value
  Dean Herbert · 2023-05-26 20:44:13 +09:00
  6b0e215246
• Merge branch 'master' into sample-set-controls
  Bartłomiej Dach · 2023-05-25 21:58:16 +02:00
  96fe7cbe54
• Fix ComposeBlueprintContainer briefly assigning auto bank

  Seems to have had no consequence due to the way
  `AutomaticBankAssignment` works (that flag is checked in
  `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially
  every frame), but let's avoid putting it there at all ever.

  Bartłomiej Dach · 2023-05-25 21:49:29 +02:00
  7d8f08c0ea
• Merge branch 'master' into pause-screen-progress
  Bartłomiej Dach · 2023-05-25 20:34:11 +02:00
  b9be886ae1
• Merge branch 'master' into beatmap-length-calcualtions
  Bartłomiej Dach · 2023-05-25 17:44:15 +02:00
  6425a33b45
• Merge pull request #23660 from peppy/simplify-deselect

  Fix crash when deleting dragged object in skin editor

  Bartłomiej Dach · 2023-05-25 17:27:41 +02:00
  b59f4aee99
• Polish a few extreme edge cases
  Bartłomiej Dach · 2023-05-25 16:39:54 +02:00
  3ad5f8b9c9
• Ensure selection is reset after immediately deleting objects

  Closes https://github.com/ppy/osu/issues/23518.

  Dean Herbert · 2023-05-25 23:20:32 +09:00
  949de35664
• Use alternative layouting implementation
  Bartłomiej Dach · 2023-05-25 16:17:44 +02:00
  beeca5a8dd
• Fix OnResume / OnSuspending potentially getting called before OnEntering on a sub screen
  Dean Herbert · 2023-05-25 20:39:11 +09:00
  b3c2d120bf
• Merge branch 'master' into organize-room-pills
  Dean Herbert · 2023-05-25 19:57:28 +09:00
  a6a380dd41
• Fix changes to font weight in a couple of combined implementations
  Dean Herbert · 2023-05-25 19:55:11 +09:00
  609c7227ee
• Add xmldoc for GetDisplayScore
  Dean Herbert · 2023-05-25 19:24:15 +09:00
  57c63dbb29
• Simplify SelectionHandler's DeselectAll implementation

  We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match

  Dean Herbert · 2023-05-25 18:46:31 +09:00
  1049257b56
• Fix bindable feedback loop
  Dean Herbert · 2023-05-25 17:58:38 +09:00
  1e14b02493
• Switch to using new extension method for length calculations
  Dean Herbert · 2023-05-25 17:38:35 +09:00
  37c6e632d0
• Merge branch 'beatmap-length-calcualtions' into pause-screen-progress
  Dean Herbert · 2023-05-25 17:34:08 +09:00
  cf9fda0cf2
• Centralise beatmap playable duration and bounds lookups
  Dean Herbert · 2023-05-25 17:32:48 +09:00
  058edb5d5f
• Merge branch 'master' into beat-divisor-visual-improvements
  Bartłomiej Dach · 2023-05-24 22:28:26 +02:00
  578a0e7494
• Mention fallback default in GetDivisorForBeatIndex()
  Bartłomiej Dach · 2023-05-24 22:17:51 +02:00
  6ec4ecfdd7
• Merge branch 'master' into pause-screen-progress
  Bartłomiej Dach · 2023-05-24 21:57:26 +02:00
  133c954c93
• Merge branch 'master' into editor-escape-deselects
  Bartłomiej Dach · 2023-05-24 20:18:44 +02:00
  8b6cd1310a
• Remove unused using directive
  Bartłomiej Dach · 2023-05-24 18:54:48 +02:00
  cd3602406b
• Allow deselecting any selection in the editor using the Back binding (escape key)
  Dean Herbert · 2023-05-24 19:24:14 +09:00
  b14b1072c2