60914 Commits

This Branch

This Branch

All Branches

• Merge pull request #23975 from peppy/skin-editor-beatmap-skin-disable

  Disable beatmap skinning support when entering the skin editor

  Bartłomiej Dach · 2023-06-22 22:45:44 +02:00
  bede12a3e8
• Merge branch 'master' into skin-editor-beatmap-skin-disable
  Bartłomiej Dach · 2023-06-22 20:30:51 +02:00
  a11b3a67fb
• Remove unused using directive
  Bartłomiej Dach · 2023-06-22 20:24:44 +02:00
  aea5eb37dc
• Merge pull request #23967 from peppy/save-replay-hotkey

  Add hotkey to save replay

  Bartłomiej Dach · 2023-06-22 19:50:57 +02:00
  2b9cbaa4da
• Merge branch 'master' into save-replay-hotkey
  Bartłomiej Dach · 2023-06-22 18:51:30 +02:00
  65d4506ef2
• Merge pull request #23972 from peppy/notifications-during-pause

  Allow notifications while the game is paused (or in break time)

  Bartłomiej Dach · 2023-06-22 18:31:39 +02:00
  28dc5640a3
• Fix potential null ref in ResultsScreen
  Dean Herbert · 2023-06-21 17:50:06 +09:00
  655491ae2d
• Add FireAndForget to stray Task.Run
  Dean Herbert · 2023-06-21 17:48:55 +09:00
  1907beb0c9
• Improve and combine logic that exists in two classes
  Dean Herbert · 2023-06-21 17:48:12 +09:00
  9ca772421d
• Change skin editor flow to always save on toggle

  This also moves the beatmap skin disable toggle to on toggle, in line
  with review feedback.
  
  I've decided to always apply the disable, not just on the `Player`
  screen. It should be assumed that if a user is in the skin editor they
  are never going to need access to this anyway.

  Dean Herbert · 2023-06-21 16:14:47 +09:00
  cb0f642ad7
• Use bindable lease instead of reimplementing the same thing locally
  Dean Herbert · 2023-06-21 16:09:54 +09:00
  366dd96875
• Disable beatmap skinning when entering the skin editor
  Dean Herbert · 2023-06-20 19:18:17 +09:00
  d7b486e2ac
• Merge pull request #23973 from peppy/update-framework

  Update framework

  Dean Herbert · 2023-06-20 18:53:55 +09:00
  c815f8cd23
• Update framework
  Dean Herbert · 2023-06-20 17:43:52 +09:00
  ff8350bac6
• Allow notifications while the game is paused (or in break time)

  RFC. This is to allow notifications to show at the pause screen
  (specifically for #23967, where exports are now happening).
  
  Not sure about the break time part of this, but might be fine? The
  toasts are immediately flushed before break time ends.

  Dean Herbert · 2023-06-20 16:57:35 +09:00
  7b69b92eab
• Also add hotkey to export replays
  Dean Herbert · 2023-06-20 16:54:37 +09:00
  4bd121d3b8
• Fix OsuAnimatedButton not flashing when triggered via code
  Dean Herbert · 2023-06-20 16:34:22 +09:00
  7c5813c05a
• Apply NRT and hotkey support to save replay button at results screen
  Dean Herbert · 2023-06-20 16:29:15 +09:00
  1e0e29847f
• Merge pull request #23969 from Joehuu/fix-beatmap-info-bpm

  Fix beatmap info not showing individual difficulty bpm

  Bartłomiej Dach · 2023-06-19 22:57:17 +02:00
  c467e6ba1f
• Merge pull request #23938 from peppy/fix-distance-snap-grid-centering

  Fix distance snap grid circles not correctly being centred on snap point

  Bartłomiej Dach · 2023-06-19 21:36:33 +02:00
  a600eb5f36
• Fix beatmap info not showing individual difficulty bpm
  Joseph Madamba · 2023-06-19 11:05:29 -07:00
  362fe62b4b
• Merge branch 'master' into fix-distance-snap-grid-centering
  Bartłomiej Dach · 2023-06-19 18:45:06 +02:00
  ecc5915ab3
• Fix test failure due to relying on implementation detail
  Bartłomiej Dach · 2023-06-19 18:42:30 +02:00
  9bcd86d66d
• Merge pull request #23520 from jtbiddle/snap-colour-mod

  Add "Synesthesia" mod for osu! ruleset

  Bartłomiej Dach · 2023-06-19 18:31:58 +02:00
  2d8a74d776
• Fix slider tails receiving wrong colours

  Only visually apparent on legacy skins.

  Bartłomiej Dach · 2023-06-19 17:47:01 +02:00
  6d32206a08
• Add hotkey to save replay

  Defaults to `F2` aka stable.

  Dean Herbert · 2023-06-19 20:45:29 +09:00
  69526f25bb
• Fix slightly incorrect calculations
  Dean Herbert · 2023-06-19 20:23:46 +09:00
  84fc6e92db
• Merge branch 'master' into fix-distance-snap-grid-centering
  Dean Herbert · 2023-06-19 20:22:09 +09:00
  4314f9f46a
• Avoid doing expensive colour fetch operation every update
  Dean Herbert · 2023-06-19 20:12:17 +09:00
  0900cebc0d
• Merge branch 'master' into snap-colour-mod
  Dean Herbert · 2023-06-19 20:01:36 +09:00
  aa96fefae2
• Merge pull request #23414 from Cootz/add-mod-search-option

  Add mod search

  Dean Herbert · 2023-06-19 02:07:00 +09:00
  f8b94ed033
• Avoid resolving realm Live more than once
  Dean Herbert · 2023-06-19 01:06:45 +09:00
  db445660e7
• Fix some code layout and NRT some classes
  Dean Herbert · 2023-06-19 01:03:43 +09:00
  425d3c23f5
• Add TODO for future support of typical search shortcuts
  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  b4c1266fc5
• Dynamically change placeholder to convey how to activate search
  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  b87acfa66f
• Switch search box to initially unfocused

  Done primarily to keep mod hotkeys working without any behavioural
  changes when mod select is opened.

  Bartłomiej Dach · 2023-06-18 15:58:50 +02:00
  75300ca229
• Merge branch 'master' into add-mod-search-option
  Bartłomiej Dach · 2023-06-18 15:06:21 +02:00
  9ba4bf5fb7
• Merge pull request #23882 from peppy/focused-overlay-container-override-fixes

  Apply osu! side changes in line with `FocusedOverlayContainer.PopIn` `abstract` change

  Bartłomiej Dach · 2023-06-18 15:05:58 +02:00
  5dc675ab65
• Fix bugged initial state of matching filter flag

  Was preventing mod preset panels from refiltering correctly on ruleset
  change due to the `matchingFilter == value` guard.

  Bartłomiej Dach · 2023-06-18 14:51:52 +02:00
  d4c9eb013e
• Add failing test case for mod preset filtering not working after ruleset change
  Bartłomiej Dach · 2023-06-18 14:51:16 +02:00
  0b6c0592e4
• Reword comments in ModSelectOverlay
  Bartłomiej Dach · 2023-06-18 14:34:33 +02:00
  a49af06e88
• Remove yet another redundant guard
  Bartłomiej Dach · 2023-06-18 14:28:26 +02:00
  28f929dc4d
• Reword/rename some stuff in test
  Bartłomiej Dach · 2023-06-18 14:24:35 +02:00
  b9156b1df3
• Do not use ?? true pattern

  Universally disliked. `!= false` is preferred.

  Bartłomiej Dach · 2023-06-18 14:19:38 +02:00
  76f509a1db
• Fix utterly broken test

  - Was on wrong ruleset, so the mod/free mod sets did literally nothing
  - `assertHasFreeModButton` had a param that did nothing
  - Was checking `MatchingFilter` rather than `Visible`

  Bartłomiej Dach · 2023-06-18 14:16:38 +02:00
  9758e5f840
• Remove obvious comment
  Bartłomiej Dach · 2023-06-18 14:04:00 +02:00
  4c78144d10
• Fix duplicate linq and reword comment
  Bartłomiej Dach · 2023-06-18 14:03:26 +02:00
  64e96c6d82
• Remove duplicated xmldoc and move into relevant region
  Bartłomiej Dach · 2023-06-18 13:59:36 +02:00
  a1015b4145
• Remove redundant guard

  `Bindable` has one of those already.

  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  1b4d7db1e6
• Remove unused property
  Bartłomiej Dach · 2023-06-18 13:58:25 +02:00
  c7e8990576