Nathan Du
a62a84a30f
fix code style
2025-01-31 20:48:29 +08:00
Nathan Du
2a5540b392
remove ISkinnableSwell
...
This commit removes ISkinnableSwell for taiko swell animations. In place
of it, an event named UpdateHitProgress is added to DrawableSwell, and
the skin swells are converted to listen to said event and
ApplyCustomUpdateState, like how spinner skinning is implemented for
std.
2025-01-31 18:10:50 +08:00
Nathan Du
4fd8a4dc5a
Merge taiko swell components
...
Per <https://github.com/ppy/osu/pull/21601/files#r1064167756 >, taking a
variation of the "Make all swell main pieces implement
ISkinnableSwellPart" path. Should clean the interface up enough for
further refactors.
2025-01-31 16:55:39 +08:00
Joppe27
e2196e8b9b
Rename methods and skin component + add comments
2025-01-31 10:24:45 +08:00
Joppe27
4a164b7b14
Add legacy taiko swell
2025-01-31 10:24:45 +08:00
Salman Ahmed
d4fef99e1f
Define constant input drum width for osu!taiko
2024-01-20 01:46:15 +03:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Dean Herbert
3585c3f1d5
Apply required nullability changes
2023-06-24 09:58:36 +09:00
Dean Herbert
b986d1cee1
Rename variables to give more context
2023-06-12 14:18:26 +09:00
Xinnoh
0c42aa7f3b
lower kiai pulse brightness
2023-06-09 22:51:45 -07:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
233d45e185
Fix argon swells incorrectly flashing on every hit
2022-11-15 18:28:13 +09:00
Bartłomiej Dach
7379f6fe20
Merge branch 'master' into argon-taiko
2022-11-12 01:56:30 +09:00
Dan Balasescu
fe58329478
Merge pull request #21151 from peppy/taiko-judgement-fixes
...
Fix various issues surrounding hit judgements
2022-11-11 16:41:46 +09:00
Dan Balasescu
8063dcd74a
Merge pull request #21148 from peppy/taiko-barline-separation
...
Move major barline portion to default implementation to allow for further customisation
2022-11-11 16:40:51 +09:00
Dan Balasescu
5bdbf56f43
Merge branch 'master' into taiko-judgement-fixes
2022-11-11 15:48:33 +09:00
Dan Balasescu
1a1a186d22
Merge branch 'master' into taiko-barline-separation
2022-11-11 15:47:06 +09:00
Dan Balasescu
f25a8ee4a6
Merge branch 'master' into taiko-tick-trackiung
2022-11-11 15:41:06 +09:00
Susko3
6303b88e56
Fix NRT causing CI failure
2022-11-10 14:31:24 +01:00
Dan Balasescu
20520e7290
Merge pull request #21171 from peppy/unpollute-taiko-drawable-hit
...
Remove triangles skin specific implementation from base osu!taiko `DrawableHit`
2022-11-10 12:47:36 +09:00
Dean Herbert
20b8ab324f
Apply nullability to osu!taiko skinning classes
2022-11-09 13:37:06 +09:00
Dean Herbert
aa7d0e2c96
Remove triangles skin specific implementation from base DrawableHit
2022-11-08 15:22:00 +09:00
Dean Herbert
37cb187d2e
Move strong hit scale to DefaultHitExplosion
2022-11-07 18:32:12 +09:00
Dean Herbert
2648175275
Merge branch 'taiko-barline-separation' into taiko-fixes-combined
2022-11-07 18:32:09 +09:00
Dean Herbert
688f50e086
Merge branch 'taiko-tick-trackiung' into taiko-fixes-combined
2022-11-07 18:32:07 +09:00
Dean Herbert
564d078517
Fix much brokenness with kiai and justment sizing
2022-11-07 17:19:32 +09:00
Dean Herbert
8745c2f016
Split out taiko DefaultJudgementPiece and move animations across
2022-11-07 17:19:32 +09:00
Dean Herbert
1975385cc7
Move first tick tracking logic inside TickPiece
2022-11-07 15:26:34 +09:00
Dean Herbert
c69a4f9333
Move major barline portion to default implementation to allow for further customisation
...
Of note, this removes the "major" barline triangles from legacy skins. I
think this is more correct, as they did not display in stable.
2022-11-07 14:29:58 +09:00
Dean Herbert
bfa5d41d89
Fix one more case
2022-11-02 17:39:45 +09:00
Dean Herbert
bc3382f373
Apply NRT to many taiko classes
2022-11-02 17:15:25 +09:00
Dean Herbert
910dd3ad01
Move more default classes to correct namespace
2022-11-02 17:15:25 +09:00
Dean Herbert
2407eb063d
Simplify Circle usage in default CentreHitCirclePiece
2022-11-02 17:15:25 +09:00
Dean Herbert
9c758e5425
Move DefaultInputDrum to correct location
2022-11-02 17:15:25 +09:00
Dean Herbert
d441e98af7
Adjust kiai flash period in line with stable
2022-10-21 15:34:25 +09:00
Joppe27
d83c398b58
Apply review: changed DelayUntilTransformsFinished to ArmedState check
2022-10-19 23:31:23 +02:00
Joppe27
9b123e7365
Adjust flash intensity and fade values to feel better
2022-10-19 00:51:44 +02:00
Joppe27
003e4247f9
Implement kiai flashing for "triangles" taiko skin
2022-10-18 23:55:40 +02:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Salman Ahmed
4ce69890d4
Use TaikoHitObject.DEFAULT_SIZE for default circle piece symbol size
2022-04-03 00:21:23 +03:00
Bartłomiej Dach
735414bc49
Replace TimeSignatures enum with struct for storage of arbitrary meter
2022-01-22 20:50:31 +01:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
9c34cb0777
Share colour constants with default drawable piece implementations
2021-06-11 14:20:08 +09:00
ekrctb
c70b13ecc2
Adjust namespace
2020-12-07 12:30:25 +09:00
ekrctb
f78bd7c739
Move piece files of Taiko ruleset
2020-12-07 12:29:14 +09:00
