Dean Herbert
ce29d6fd81
Change scroll speed adjust defaults to F3/F4
...
Not the most obvious keys, but does match stable expectations so let's
go with it for now.
Rationale for not using +/- is that local audio offset was bound to
those, and people will expect it to be when we get to implementing
eventually.
Also, adjust the scroll speed is a pretty rare thing to do since it's
been constant across beatmaps for years now.
2021-10-29 11:13:07 +09:00
Bartłomiej Dach
9199f2b337
Merge branch 'master' into ui-scaling-keybind
2021-10-28 18:20:34 +02:00
smoogipoo
2b3e63470d
Merge branch 'master' into always-unique-test-online-ids
2021-10-28 18:23:45 +09:00
Dean Herbert
d8d4839e43
Merge pull request #15339 from smoogipoo/fix-test-crash
...
Fix playlists room creation test crash
2021-10-28 17:28:46 +09:00
Dean Herbert
4f4f2503aa
Merge pull request #15335 from smoogipoo/cleanup-multiplayer-screen-tests
...
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 17:28:26 +09:00
Dan Balasescu
e5a7589859
Merge pull request #15317 from peppy/beatmap-refactor/uncontested
...
Update `UpdateableBeatmapBackgroundSprite` to accept `IBeatmapInfo`
2021-10-28 17:24:49 +09:00
Dean Herbert
b096bf6cd1
Ensure all test beatmaps have unique OnlineIDs to avoid import conflicts
...
The order of operation of imports means that the already-imported
instances are considered most correct (they have usually been populated
using an online source, although that is skipped in tests), so on two
consecutive test imports in a test scene, the second will lose its
online IDs completely.
This aims to ensure that all test beatmaps will have online IDs, which
is the general expected behaviour.
2021-10-28 16:56:31 +09:00
smoogipoo
bacaa9d201
Fix playlists test crash
2021-10-28 16:48:17 +09:00
Dean Herbert
6f5040722a
Merge branch 'master' into beatmap-refactor/uncontested
2021-10-28 16:37:26 +09:00
Dean Herbert
1e1f8c472a
Add icons to various progress notification states
2021-10-28 16:34:12 +09:00
Dan Balasescu
44ba4419a2
Merge branch 'master' into beatmap-refactor/tournament
2021-10-28 15:25:34 +09:00
smoogipoo
0e293471c2
Clean up multiplayer-screen tests by removing intermediate screen
2021-10-28 14:29:49 +09:00
Dean Herbert
5c7623e68e
Merge pull request #15255 from goodtrailer/node-samples-ilist
...
Change IHasRepeats.NodeSamples to IList from List
2021-10-28 14:24:26 +09:00
Dean Herbert
aaabaaa5dd
Merge pull request #15320 from smoogipoo/fix-online-play-request-handling
...
Fix online play request handling in tests
2021-10-28 14:24:00 +09:00
Dean Herbert
3905ecd18b
Use retrieval of bindable and tidy up code slightly
2021-10-28 13:09:03 +09:00
Dean Herbert
ad1bd4e48e
Merge branch 'master' into ui-scaling-keybind
2021-10-28 13:03:21 +09:00
Dean Herbert
add39fbd4f
Merge branch 'master' into fix-skin-layout-editor-crash
2021-10-28 06:24:24 +09:00
Dean Herbert
65a7b6776e
Add note regarding OnlineInfo being temporary
2021-10-28 05:50:22 +09:00
Dean Herbert
a9208838a9
Merge pull request #15307 from peppy/playlist-remaining-attempt-display
...
Show remaining attempts again on playlist screen
2021-10-28 05:28:20 +09:00
Dean Herbert
290f583ae0
Fix incorrect initial state
2021-10-28 00:59:48 +09:00
Dean Herbert
7245baba69
Remove IBeatmapSetOnlineInfo implementation from BeatmapSetInfo to avoid null cases
2021-10-28 00:50:45 +09:00
Dean Herbert
746d6a4c16
Fix some oversights and test failures
2021-10-27 23:42:27 +09:00
Dean Herbert
f014ceaead
Update remaining usages of download tracking
2021-10-27 21:00:46 +09:00
Dean Herbert
dd06c617b1
Update OnlinePlayBeatmapAvailabilityTracker in line with new download tracker
...
The structure here has changed a bit - rather than deriving from the
donwload tracker I moved the additional logic into the callbacks. I
think this feels better?
2021-10-27 21:00:46 +09:00
Dean Herbert
6339064dbd
Remove old versions of DownloadTrackingComposite
2021-10-27 21:00:46 +09:00
Dean Herbert
692db9a9ec
Remove unnecessary verification flow from score download tracking
2021-10-27 21:00:46 +09:00
Dean Herbert
617e6febb6
Refactor ModelDownloader to allow for different OnlineID matching
2021-10-27 21:00:46 +09:00
Dean Herbert
9015ac6ba8
Implement new version of download tracker
2021-10-27 21:00:46 +09:00
smoogipoo
f3dba49aae
Rename room managers
2021-10-27 19:36:32 +09:00
Dean Herbert
db6343c44c
Correctly redirect BPM from API to interface
2021-10-27 17:09:51 +09:00
Dean Herbert
40d963fc8a
Allow setting of APIBeatmap.Length (and don't serialise twice)
2021-10-27 16:44:21 +09:00
Dean Herbert
f268363924
Update UpdateableBeatmapBackgroundSprite to accept IBeatmapInfo
2021-10-27 16:38:48 +09:00
smoogipoo
85b21174dd
Fix online play test request handling
2021-10-27 14:49:50 +09:00
Dean Herbert
95837990f3
Apply some second-pass inspections that appeared after previous changes
2021-10-27 13:09:30 +09:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Bartłomiej Dach
3de994449d
Add support for changing dimensions of difficulty spectrum display
2021-10-26 23:06:52 +02:00
Bartłomiej Dach
1a77e98537
Implement difficulty spectrum display
2021-10-26 23:06:52 +02:00
Dean Herbert
70f432805e
Merge branch 'master' into ui-scaling-keybind
2021-10-27 01:06:14 +09:00
Dean Herbert
411586bac3
Update resources
2021-10-26 22:12:56 +09:00
Dean Herbert
c15bfb2cf4
Handle bindable changes to fix new playlist creation not showing correct details
2021-10-26 18:19:05 +09:00
Dean Herbert
42d8d4fd38
Add tooltips to start button to explain why it's not clickable
2021-10-26 18:06:08 +09:00
Dean Herbert
1c578f285a
Disable playlist start button when attempts have been exhausted
2021-10-26 18:06:08 +09:00
Dean Herbert
bffd9162ba
Tint attempt count red when no attempts remain
2021-10-26 18:06:08 +09:00
Dean Herbert
708d40931b
Add back remaining attempt display on playlist room screen
2021-10-26 18:06:08 +09:00
Dean Herbert
d5b4c68d3a
Merge branch 'master' into fix-slider-path-extension-incorrectness
2021-10-26 17:36:50 +09:00
Dean Herbert
e92def0ba2
Fix LegacyBeatmapEncoder using incorrect path length value
2021-10-26 17:34:52 +09:00
Dan Balasescu
6a6d3a5e8a
Merge pull request #15304 from peppy/fix-editor-new-beatmap-sample-change-crash
...
Fix editor crash when attempting to change sample/velocity from timeline on new beatmap
2021-10-26 17:13:56 +09:00
Dean Herbert
4cef86dd12
Merge pull request #15301 from jaswon/reverse-slider-symmetric
...
Fix slider shape not always being maintained when reversing
2021-10-26 16:17:29 +09:00
Dean Herbert
ea55ba7ba9
Remove unused using statement
2021-10-26 16:08:21 +09:00
Dean Herbert
dae7cdc4c5
Ensure HitObject-local control points are non-default after ApplyDefaults
...
We will probably want to make this whole flow more efficient in the
future, but this should suffice for now.
2021-10-26 16:06:03 +09:00
Dean Herbert
5e5b86a1f4
Merge pull request #15156 from Susko3/use-ShowFileInNativeExplorer
...
Update usages of `OpenInNativeExplorer` to use `PresentFileExternally` / `PresentExternally`
2021-10-26 15:53:03 +09:00
Dean Herbert
81fee02c2b
Fix slider paths being extended even when the last two points are equal
2021-10-26 15:47:59 +09:00
Dan Balasescu
f687ed8599
Merge pull request #15283 from peppy/test-api-beatmap-set
...
Add ability to make test `APIBeatmapSet`s from test scenes
2021-10-26 15:34:19 +09:00
Dan Balasescu
7b8982c87c
Merge pull request #15302 from peppy/fix-multiplayer-chat-escape-focus
...
Fix gameplay chat display not losing focus on escape key press
2021-10-26 15:34:05 +09:00
Dan Balasescu
efe6763226
Merge branch 'master' into move-online-beatmap-metrics
2021-10-26 14:24:40 +09:00
Dean Herbert
370775af68
Fix some surrounding code formatting
2021-10-26 14:05:07 +09:00
Dean Herbert
53ff0802cb
Merge branch 'master' into use-ShowFileInNativeExplorer
2021-10-26 13:58:30 +09:00
Dean Herbert
26fb9af021
Update framework
2021-10-26 13:58:07 +09:00
Dean Herbert
6c38028d06
Fix gameplay chat display not losing focus on escape key press
...
Closes #15293 .
2021-10-26 13:55:08 +09:00
Dan Balasescu
1e3c84b34b
Merge branch 'master' into use-beatmap-interfaces-more-uncontested
2021-10-26 13:51:55 +09:00
Dan Balasescu
676e7ff2a6
Merge pull request #15287 from peppy/get-beatmap-request-via-interface
...
Allow API beatmap requests using interface type
2021-10-26 13:50:46 +09:00
Jason Won
a582976851
reversing slider maintains shape
2021-10-26 00:05:46 -04:00
Dean Herbert
d7ac94038a
Update GetBeatmapRequest to use AddParameter
2021-10-26 12:05:31 +09:00
Dean Herbert
5d1170aaf4
Remove unnecessary null check
2021-10-26 11:57:51 +09:00
Bartłomiej Dach
a49a1f41cb
Merge branch 'master' into move-online-beatmap-metrics
2021-10-25 20:33:49 +02:00
Bartłomiej Dach
5a03e1736e
Merge branch 'master' into update-beatmap-set-status-pill-appearance
2021-10-25 20:26:49 +02:00
Bartłomiej Dach
6802e9ec10
Remove FixedWidth and add AutoSizeAxes specs to all usages
2021-10-25 20:24:48 +02:00
Dean Herbert
b65d199f6a
Fix incorrect length when calling APIBeatmap.ToBeatmapInfo
2021-10-25 17:01:47 +09:00
Dean Herbert
6adb0f068b
Fix multiple issues with json serialisation of online info (causing tournament failures)
2021-10-25 16:52:50 +09:00
Dean Herbert
67ef1c40e6
Allow API beatmap requests using interface type
2021-10-25 15:59:40 +09:00
Dean Herbert
2c308f3008
Rename BeatmapMetrics to APIFailTimes
2021-10-25 15:34:41 +09:00
Dean Herbert
4969ab0599
Add forgotten JsonIgnore rules on interface types
...
Just to avoid them getting serialised as part of the "new" .osu
serialisation format.
2021-10-25 15:32:18 +09:00
Dean Herbert
20baae9094
Move online metrics out of BeatmapInfo model
2021-10-25 15:32:18 +09:00
Dean Herbert
045dd94a6e
Move online metrics out of BeatmapSetInfo model
2021-10-25 15:12:39 +09:00
Dean Herbert
94175bfb4a
Update PreviewTrackManager to use IBeatmapSetInfo
2021-10-25 14:25:01 +09:00
Dean Herbert
19312435d0
Add ability to make test APIBeatmaps from test scenes
...
Allow tests to create a sample `APIBeatmapSet`
One step towards removing calls to `ToBeatmap` / `ToBeatmapSet`.
2021-10-25 14:18:13 +09:00
Dean Herbert
78edc7554e
Fix BeatmapSetInfo's Status value being marked as non-databased
2021-10-25 12:05:34 +09:00
Bartłomiej Dach
feedd53a53
Add support for setting fixed size of status pill
2021-10-24 21:37:00 +02:00
Bartłomiej Dach
5ab3337a10
Update beatmap set status pill appearance
2021-10-24 20:40:34 +02:00
Dean Herbert
26cf5370c3
Remove unused reader parameter
2021-10-24 23:48:46 +09:00
Dean Herbert
5303cae044
Add mention of stream close logic
2021-10-24 23:43:37 +09:00
Susko3
51c5d0aec7
Update to be in line with framework changes
2021-10-24 13:21:41 +02:00
Bartłomiej Dach
d24fbc6ade
Merge branch 'master' into fix-skin-layout-editor-crash
2021-10-24 12:58:56 +02:00
Bartłomiej Dach
051cc2cd92
Update reference to configuration population process in comment
2021-10-24 12:47:17 +02:00
goodtrailer
0affe7b79d
Remove unnecessary using
2021-10-23 02:25:20 -07:00
goodtrailer
4440b9ca11
Change IHasRepeats.NodeSamples to IList from List
2021-10-23 01:59:07 -07:00
Susko3
4a425b5c3e
Merge remote-tracking branch 'upstream/master' into use-ShowFileInNativeExplorer
2021-10-23 10:01:24 +02:00
Joseph Madamba
1ae6621c85
Fix a missed toast shortcut string not localising correctly
2021-10-22 15:45:48 -07:00
Dan Balasescu
c6ca0e5895
Merge branch 'master' into fix-password-popover-focus
2021-10-22 22:52:46 +09:00
Dan Balasescu
9bb0d32fda
Merge pull request #15247 from peppy/beatmap-metadata-container-interface
...
Refactor `BeatmapMetadataContainer` and usages to use interface types
2021-10-22 22:42:23 +09:00
Dan Balasescu
e8fbb19c63
Merge branch 'master' into remove-unused-classes
2021-10-22 22:25:22 +09:00
Dean Herbert
c701579c69
Refactor BeatmapMetadataContainer and usages to use interface types
2021-10-22 21:38:50 +09:00
Dean Herbert
28d8820976
Merge pull request #15224 from peppy/no-more-beatmap-metadata-base
...
Remove `BeatmapMetadata` base class from API classes
2021-10-22 21:07:29 +09:00
Dean Herbert
90477e3788
Remove unused BeatmapTypeInfo class
...
Helps reduce the scope of upcoming changes.
2021-10-22 19:13:50 +09:00
Dan Balasescu
14a7b00f58
Merge pull request #15242 from peppy/fix-low-pass-sticking-after-fail
...
Fix low-pass filter continuing to take effect after fail animation has already ended
2021-10-22 19:04:03 +09:00
Dean Herbert
cc1d759290
Remove unnecessary setters from IBeatmapSetOnlineInfo interface
2021-10-22 17:48:09 +09:00
Dean Herbert
91cc77407d
Fix low-pass filter continuing to take effect after fail animation has already ended
2021-10-22 17:02:02 +09:00
Dean Herbert
ea473428e8
Fix incorrect length mapping in APIBeatmap
2021-10-22 15:54:40 +09:00
Dean Herbert
de33b2f45a
Return set metadata if available before falling back to empty object
2021-10-22 15:00:31 +09:00
Dean Herbert
eef9949a0a
Remove unnecessary branching around EF logic
2021-10-22 14:48:20 +09:00
