77 Commits

• Revert "Merge pull request #36102 from bdach/move-check-to-better-place"

  This reverts commit 2cb2167765, reversing
  changes made to 0bcb3c5839.

  Dean Herbert · 2025-12-26 22:36:16 +09:00
  56ef5eae14
• Only perform replace-on-import based on online beatmap set ID after it's validated

  Even without the ID resetting logic before `Populate()` getting broken
  and annotated with a TODO, this was kinda stupid. Why was purging logic
  allowed to run *using a not-yet-completely-validated online ID of the
  set*?
  
  This is the other part of hopefully fixing scenarios like
  https://osu.ppy.sh/community/forums/topics/2162457?n=8 (hopefully with
  no babies poured out in the mean time, but only time will tell).

  Bartłomiej Dach · 2025-12-22 12:27:29 +01:00
  44df9047ae
• Move online ID validation check into its proper location

  The end of `Populate()` is too early to do any validation of online IDs,
  as population happens in `PostImport()` via `ProcessBeatmap`.
  
  Additionally, this modifies the check to also include the set's ID. This
  is one part of curtailing issues like
  https://osu.ppy.sh/community/forums/topics/2162457?n=8 - the featured
  artist template beatmap in question has a single difficulty with a bogus
  positive beatmap set ID and a beatmap ID of 0, and my opinion is that
  this sort of situation should for all intents and purposes cause the
  beatmap set's ID to be reset.

  Bartłomiej Dach · 2025-12-22 12:22:04 +01:00
  17143ca0a8
• Ignore .osu files not placed at top level of beatmap archive on import

  Closes https://github.com/ppy/osu/issues/34677.

  Bartłomiej Dach · 2025-09-02 14:50:31 +02:00
  79f7f0ecad
• Improve logging around import-as-update flow

  - It was logging success before actually succeeding.
  - It appears in practice that this code can somehow actually nullref.
    Unfortunately logs provided in that instance were not enough to
    pinpoint what (because of lack of line numbers). I'm hoping that by
    logging as error, and therefore to sentry, we can actually retrieve
    this information so that there's no need to work blind.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  588c171978
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-11-22 18:47:32 +09:00
  086a34f5c0
• Add inline comments for iOS locals
  Dean Herbert · 2024-09-26 16:48:42 +09:00
  89e8baf1d3
• Fix Realm-related iOS crashes by removing object references
  Dan Balasescu · 2024-09-25 16:45:37 +09:00
  3ab04d98f6
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-09-15 04:53:35 +09:00
  58fe502af4
• Fix original date not being restored when no changes are made on an import-as-update operation
  Dean Herbert · 2024-08-02 20:46:03 +09:00
  dc73856f76
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Fix incorrect continuation in ImportAsUpdate causing UI blockage
  Dean Herbert · 2024-07-11 13:42:24 +09:00
  2eb6cf57af
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• Move GridSize out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  6685c5ab74
• Move DistanceSpacing out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:14:58 +02:00
  3634307d7c
• Move SamplesMatchPlaybackRate out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:32:23 +02:00
  c216283bf4
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5
• Move WidescreenStoryboard out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:23:53 +02:00
  1ab86ebd24
• Move LetterboxInBreaks out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:18:44 +02:00
  a6b7600bf2
• Move SpecialStyle out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:12:30 +02:00
  011c2e3651
• Move StackLeniency out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:33 +02:00
  0a4560a03e
• Move AudioLeadIn out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:28 +02:00
  4339e2dc4a
• Remove redundant string interpolation
  Bartłomiej Dach · 2024-03-29 10:37:49 +01:00
  2d3b273974
• Avoid reporting an import as successful when all beatmaps failed to import
  Dean Herbert · 2024-03-29 17:11:55 +08:00
  233b9eb172
• Use new LINQ Order() instead of OrderBy() when possible
  Berkan Diler · 2024-02-08 18:01:00 +01:00
  6adf0ac01e
• Move object counts to BeatmapInfo
  Dan Balasescu · 2023-12-13 17:33:24 +09:00
  0171078052
• Add object counts to IBeatmapDifficultyInfo
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  767d5c8018
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Rename ArchiveReader implementations to read better
  Dean Herbert · 2023-09-14 13:36:07 +09:00
  541cd972e1
• Rename GetPath to GetFullPath to better match expectations
  Dean Herbert · 2023-08-18 17:56:43 +09:00
  5e0b89a1a8
• Move population of import time to the Populate method

  Feels like a better place to be doing this. I think we want to keep any
  kind of potentially expensive work in the `Populate` method.

  Dean Herbert · 2023-08-18 17:56:11 +09:00
  864f1bdb3e
• Remove dead metadata transfer code
  Dean Herbert · 2023-08-18 17:40:00 +09:00
  eb2460d180
• Set correct date added value when importing stable beatmapsets
  Krzysztof Gutkowski · 2023-08-17 00:49:48 +02:00
  59abb59ee8
• Merge remote-tracking branch 'upstream/master' into legacy-export
  OliBomby · 2023-07-18 12:18:49 +02:00
  5d82190b70
• change .osz2 to .olz (osu lazer zip)
  OliBomby · 2023-07-12 15:04:06 +02:00
  3052c317e1
• Export legacy converted beatmaps as .osz and non-converted beatmaps as .osz2
  OliBomby · 2023-07-11 21:04:09 +02:00
  b577b6b6ae
• Merge pull request #24114 from peppy/editor-save-local-score-management

  Ensure scores always have the correct linked `BeatmapInfo`

  Dean Herbert · 2023-07-07 15:40:54 +09:00
  d72765b6f8
• Bring realm library up-to-date
  Dean Herbert · 2023-07-06 13:37:43 +09:00
  a98a36872e
• Move score attach logic to a helper method and call during editor save
  Dean Herbert · 2023-07-04 15:07:40 +09:00
  64fc5e40e8
• Rewrite comments further
  Bartłomiej Dach · 2023-07-01 20:37:33 +02:00
  1ce60378be
• Tidy up comments and code
  Dean Herbert · 2023-07-01 23:37:22 +09:00
  5bd91a531d
• Move score re-attach to PostImport
  Dean Herbert · 2023-07-01 23:12:04 +09:00
  a4a9223726
• Reword comment
  Cootz · 2023-06-29 08:08:10 +03:00
  47ccbddfb1
• Reassign existing scores to new/re-exported beatmap
  Cootz · 2023-06-29 08:07:43 +03:00
  351f217c8c
• Remove usages of [ExcludeFromDynamicCompile]
  Dan Balasescu · 2023-05-08 18:12:56 +09:00
  d2380bd840
• Do not look up metadata for locally-modified beatmaps on save
  Bartłomiej Dach · 2023-04-11 23:14:35 +02:00
  e72f103c17
• Fix incorrect ConfigureAwait call in ImportAsUpdate
  Dean Herbert · 2022-12-16 18:54:56 +09:00
  de079e08dc
• Merge branch 'master' into guard-url-protocols
  Dean Herbert · 2022-12-16 18:23:16 +09:00
  ba54551313
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Hook up ImportParameter flow with IModelImporter caller methods
  Dean Herbert · 2022-12-13 21:29:32 +09:00
  cb16d62700