13989 Commits

Author	SHA1	Message	Date
Dean Herbert	7e9c1b2acb	Use sender's realm (because we can)	2023-12-19 17:27:52 +09:00
Bartłomiej Dach	7c05d66bd7	Add more detail to exception	2023-12-19 08:57:18 +01:00
Dean Herbert	44efa2c540	Fix incorrect ordering of items at song select when certain sort modes are used	2023-12-19 15:09:03 +09:00
Dean Herbert	d81cabc063	Revert "Improve performance of attemptSelection using new cached count and LastSelected" ... This reverts commit 25df42630e.	2023-12-18 22:46:02 +09:00
Dean Herbert	25e3a8e82e	Fix a few of silly issues	2023-12-18 22:45:58 +09:00
Dean Herbert	25df42630e	Improve performance of attemptSelection using new cached count and LastSelected	2023-12-18 20:47:08 +09:00
Dean Herbert	5755fa214a	Cache non-filtered beatmap counts to massively improve count performance	2023-12-18 20:44:08 +09:00
Dean Herbert	034c5cd654	Debounce count updates for good measure	2023-12-18 20:43:23 +09:00
Dean Herbert	6fa1f5ef9b	Simplify invalidation logic ... The only case where this was checking is guaranteed by realm to only be called once.	2023-12-18 20:31:02 +09:00
Dean Herbert	87b7699fcc	Avoid calling invalidation logic per beatmap set updated ... Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.	2023-12-18 20:31:02 +09:00
Dean Herbert	32cc3f9ef7	Combine multiple similar invalidation logic into single event	2023-12-18 20:31:02 +09:00
Dan Balasescu	d7aca2f641	Add IApplicableHealthProcessor	2023-12-17 19:27:03 +09:00
Bartłomiej Dach	b3c6e80f5c	Merge pull request #25770 from peppy/show-back-button-spectator ... Show back button when spectating	2023-12-15 09:08:24 +01:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dean Herbert	27296c59de	Show back button when spectating ... Avoids getting stuck at some screens. It's a bit ugly having the back button visible like this, but is the best approach we have for now.	2023-12-15 11:26:17 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Dean Herbert	e296730b37	Merge pull request #24642 from Givikap120/arod_rate_adjust ... Show adjusted AR/OD when using DT/HT	2023-12-13 22:17:10 +09:00
Dean Herbert	76c4931f3a	Merge pull request #25673 from frenzibyte/fix-argon-initial-display ... Fix `ArgonHealthDisplay` not displaying miss correctly during initial transition	2023-12-13 22:16:34 +09:00
Dean Herbert	9235f3d935	Merge pull request #25747 from peppy/fix-hit-error-clear ... Fix hit error displays not clearing on seek	2023-12-13 17:36:24 +09:00
Dean Herbert	5062c53e36	Refactor everything for sanity	2023-12-13 17:33:39 +09:00
Dean Herbert	3131d37621	Clear transformations with more fire	2023-12-13 17:00:21 +09:00
Dean Herbert	fb44fb18e0	Update in line with upstream changes	2023-12-13 16:42:20 +09:00
Dean Herbert	0259ab761b	Merge branch 'master' into arod_rate_adjust	2023-12-13 16:35:18 +09:00
Dean Herbert	fdcf87569c	Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount ... Display osu!mania keycount in song select carousel panels and details	2023-12-13 16:31:25 +09:00
Dean Herbert	ec6200b4ad	Merge pull request #25743 from peppy/merge-everything-at-once ... Merge everything at once	2023-12-13 16:17:06 +09:00
Dean Herbert	f2c6c348be	Fix HitError Clear methods not correctly returning pooled drawables	2023-12-13 16:13:23 +09:00
Dean Herbert	110749205d	Cache GameplayClockContainer to allow usage of OnSeek	2023-12-13 16:13:08 +09:00
Dean Herbert	5e10f9f899	Fix failing tests due to more textboxes being present with searchable dropdowns	2023-12-13 15:11:47 +09:00
Dean Herbert	eb30a603d9	Fix typo in argument name	2023-12-13 15:01:36 +09:00
Dean Herbert	0be6743e87	Apply Bindable.Parse refactorings	2023-12-13 14:07:38 +09:00
Dean Herbert	5b00cf283d	Merge branch 'master' into drawnode-subtree-draw-cleanup	2023-12-13 14:01:01 +09:00
Dan Balasescu	c31ff84417	Fix possible nullref	2023-12-13 13:32:27 +09:00
Givikap120	2d94841929	fixed one test	2023-12-10 02:00:32 +02:00
Givikap120	faf54bca43	Merge branch 'master' into arod_rate_adjust	2023-12-10 01:49:18 +02:00
Givikap120	1d0c37e138	fixed test errors	2023-12-10 00:40:05 +02:00
Dan Balasescu	b36db3518c	Add keycount to song select details panel and carousel panels	2023-12-09 22:31:51 +09:00
Dean Herbert	a500f55ec6	Merge pull request #25688 from peppy/match-default-sv ... Change default slider velocity for new beatmaps to match osu!stable	2023-12-07 11:52:16 +09:00
Bartłomiej Dach	f69a5b44cc	Merge branch 'master' into fix-argon-initial-display	2023-12-06 09:30:28 +01:00
Bartłomiej Dach	4585a169b1	Merge pull request #25686 from peppy/fix-song-select-match ... Fix searching at song select matching incorrect ruleset	2023-12-06 09:25:47 +01:00
Dean Herbert	0af16732b8	Change default slider velocity to 1.4 ... This is the default in osu!stable and plays better than 1.0.	2023-12-06 13:38:46 +09:00
Dean Herbert	4da6d53c72	Merge pull request #25672 from frenzibyte/fix-argon-health-display-2 ... Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)	2023-12-06 12:24:39 +09:00
Dean Herbert	8286d3896f	Fix searching at song select matching incorrect ruleset ... Regressed with https://github.com/ppy/osu/pull/25679.	2023-12-06 11:32:26 +09:00
Salman Ahmed	20fd458fac	Perserve miss animation when followed by a hit at same frame	2023-12-05 21:59:28 +03:00
Salman Ahmed	9496cdf42b	Add explanatory note for scheduling	2023-12-05 21:59:28 +03:00
Salman Ahmed	927cfe4257	Fix health processor event leaks	2023-12-05 21:59:28 +03:00
Bartłomiej Dach	88095aaefa	Merge pull request #25637 from smoogipoo/multiplayer-abort ... Add ability for the host to abort an in-progress match	2023-12-05 13:51:00 +01:00
Bartłomiej Dach	4644c4e7a2	Remove unused class	2023-12-05 12:43:32 +01:00
Bartłomiej Dach	566d336470	Merge pull request #25679 from peppy/song-select-search-performance ... Improve song select search performance	2023-12-05 11:06:31 +01:00
Dean Herbert	5a2240838b	Merge branch 'master' into multiplayer-abort	2023-12-05 17:01:54 +09:00
Dean Herbert	02178d8e61	Remove usage of case-when	2023-12-05 16:58:16 +09:00
Dean Herbert	f317e06da1	Use DangerousActionDialog	2023-12-05 16:54:44 +09:00
Dean Herbert	45e499778f	Search terms before performing other criteria checks ... Very minor, but putting the more common case towards the start of the method allows early return.	2023-12-05 15:28:56 +09:00
Dean Herbert	42010574b5	Avoid list construction when doing filtering	2023-12-05 15:26:14 +09:00
Dean Herbert	27e778ae09	Avoid sorting items when already in the correct sort order	2023-12-05 14:47:32 +09:00
Dean Herbert	7fda38d0b0	Use ordinal comparison when searching at song select ... Bypasses various overheads. In theory should be fine? (until it's not on some language)	2023-12-05 14:14:13 +09:00
Guido	8756dd25c6	Changed file chooser in resource selection to show file name when file is selected	2023-12-04 22:51:56 +01:00
Salman Ahmed	629e64d50a	Fix ArgonHealthDisplay not displaying miss correctly during initial transition	2023-12-04 23:55:31 +03:00
Salman Ahmed	4d82a55594	Remove method for being unused	2023-12-04 23:24:28 +03:00
Salman Ahmed	5723715ea0	Fix ArgonHealthDisplay sometimes behaving weirdly on miss judgements	2023-12-04 23:24:28 +03:00
Dan Balasescu	8587652869	Fix countdown button being enabled	2023-12-04 11:00:11 +09:00
Dan Balasescu	c2644a5d5e	Correctly implement button enabled state	2023-12-04 10:18:37 +09:00
Dan Balasescu	b56a78c6ec	Adjust with framework changes	2023-12-04 08:51:21 +09:00
Dan Balasescu	1b0fc8ca9d	Refactor	2023-12-01 20:41:41 +09:00
Dan Balasescu	15c9416244	Rename method	2023-12-01 18:47:40 +09:00
Dan Balasescu	a94180c8c6	Rename LoadAborted -> GameplayAborted, AbortGameplayReal -> AbortMatch	2023-12-01 18:26:59 +09:00
Dan Balasescu	894c31753b	Add initial support for aborting multiplayer games	2023-12-01 15:31:06 +09:00
Dean Herbert	1cfcaee121	Reorder badges so that SS shows above others ... This isn't perfect and probably needs much more consideration, but let's at least give the "better" ranks more visibility by bringing them to the front. Of note, this is only important due to the changes to osu!catch accuracy-grade cutoffs, which brings things closer in proximity than ever before.	2023-11-29 20:29:52 +09:00
Dan Balasescu	295a1b01d6	Adjust catch score grade cutoffs	2023-11-29 19:05:31 +09:00
Dean Herbert	537c9e031d	Merge pull request #25522 from bdach/no-concurrent-connections ... Implement flow allowing disconnection from online services when another client instance for same user is detected	2023-11-28 19:09:38 +09:00
Dean Herbert	a4be28a2ae	Don't show buttons on fail overlay when player interaction is disabled	2023-11-27 12:25:24 +09:00
Bartłomiej Dach	98ab9853ce	Merge branch 'master' into show-spectator-fail-2	2023-11-27 12:24:59 +09:00
Bartłomiej Dach	19639de299	Merge branch 'master' into fix-spectator-quit-2	2023-11-27 11:36:10 +09:00
Dean Herbert	a6cf1e5d2e	Make osu! logo do something when in edit submenu	2023-11-25 00:53:25 +09:00
Dean Herbert	a44edfdedd	Fix incorrect sample for top level edit button	2023-11-24 19:37:57 +09:00
Dan Balasescu	289cda71b2	Fix inspections	2023-11-24 15:06:51 +09:00
Dean Herbert	7ceb49fbc0	Add extra test coverage and handle case where still at loading screen	2023-11-24 15:05:39 +09:00
Dean Herbert	d3a55d83c0	Schedule FailScore inside onFail instead of onFailComplete	2023-11-24 14:44:57 +09:00
Dean Herbert	ef5dd24589	Update failing test coverage and fix onFail being called too often	2023-11-24 14:44:57 +09:00
Dean Herbert	4ad3cb3b49	Submit and send failed spectator state more aggressively	2023-11-24 14:44:57 +09:00
Dean Herbert	8375dd72d6	Add xmldoc to new AllowFail method	2023-11-24 14:44:57 +09:00
Dean Herbert	ca93fdc94b	Add visualisation of when a spectated player fails ... Create a new stack each time for isolation and safety	2023-11-24 14:44:57 +09:00
Dean Herbert	b024065857	Remove implicit schedule of abstract methods in SpectatorScreen ... This allows each implementation to have control over scheduling. Without this, the solo implementation would not be able to handle quit events while watching a player, as it would push a child (gameplay) screen to the stack where the `SpectatorScreen` would usually be.	2023-11-24 14:26:09 +09:00
Dean Herbert	335e8efff7	Apply NRT to SoloSpecatorScreen	2023-11-24 14:26:09 +09:00
Dean Herbert	dabbdf674b	Rename SoloSpectator to SoloSpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	4c7d2bb0fb	Apply NRT to SpectatorScreen	2023-11-24 14:26:08 +09:00
Dean Herbert	b8179aa875	Use better(?) icons and full strings	2023-11-24 13:23:47 +09:00
Dean Herbert	a069a673fa	Allow buttons to be displayed on more than one state (and share the back button)	2023-11-24 13:18:17 +09:00
Dean Herbert	1d1b3ca982	Apply NRT to MainMenuButton	2023-11-24 13:18:17 +09:00
Dean Herbert	8ad414488a	Play out previous transforms immediately to avoid flow issues with multiple sub menus	2023-11-24 13:18:17 +09:00
Dean Herbert	7e59a1d0be	Apply NRT to ButtonSystem	2023-11-24 13:18:17 +09:00
Dean Herbert	5905ca6492	Add second level menu for skin editors	2023-11-24 13:18:17 +09:00
Dean Herbert	340227a06d	Replace all hexacon lookups with strongly typed properties	2023-11-24 13:17:39 +09:00
Dean Herbert	95c00f9666	Add HexaconIcons lookup to allow usage with SpriteIcon	2023-11-24 13:17:39 +09:00
Dean Herbert	537b0ae870	Add silly annotation for now (more new r# rules)	2023-11-24 12:47:42 +09:00
Givikap120	c2a44cf118	Made custom tooltip	2023-11-23 23:30:18 +02:00
Dean Herbert	5239fee947	Allow use of skin username/flag/avatar components outside of gameplay	2023-11-23 17:15:03 +09:00