85 Commits

• Automatically refresh the verify screen's issue list on re-entering it

  Addresses https://github.com/ppy/osu/discussions/25365.

  Dean Herbert · 2023-11-06 19:34:36 +09:00
  51c891e2e4
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Rename method to be more in line with project naming
  Dean Herbert · 2022-11-30 14:17:49 +09:00
  0659c84341
• Don't use verbatim string literals
  Jai Sharma · 2022-11-29 18:22:07 +00:00
  7dbf379351
• Code quality
  Jai Sharma · 2022-11-27 03:23:08 +00:00
  218c04c174
• Correctly select issue row
  Jai Sharma · 2022-11-27 03:08:54 +00:00
  6000e14668
• Add OnRowSelected event to EditorTable
  Jai Sharma · 2022-11-27 02:47:54 +00:00
  3c56b9c93a
• Remove #nullable disabled from EditorTable and it's derived classes
  Jai Sharma · 2022-11-27 02:45:56 +00:00
  b6d7bec240
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Move GetDifficultyRating helper method to StarDifficulty
  Dean Herbert · 2022-06-23 19:51:58 +09:00
  ef258122d2
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge pull request #18445 from frenzibyte/editor-background-colour

  Darken background colour in "setup" and "verify" screens

  Dean Herbert · 2022-05-28 10:56:22 +09:00
  4f2910cdb1
• Increase usable width slightly further
  Dean Herbert · 2022-05-28 10:51:39 +09:00
  93a8092da6
• Increase editor verify settings width to give more breathing space
  Salman Ahmed · 2022-05-28 03:09:04 +03:00
  d12e4928e6
• Darken background colour in "setup" and "verify" screens
  Salman Ahmed · 2022-05-28 02:10:18 +03:00
  eec9248cde
• Remove remaining usage of EditorRoundedScreen
  Dean Herbert · 2022-05-24 18:43:22 +09:00
  c02ec05056
• Remove TriangleButton usage in editor
  Dean Herbert · 2022-05-24 18:13:09 +09:00
  a346990a8c
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Bartłomiej Dach · 2022-01-15 14:45:42 +01:00
  03e4ec4214
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Fix some null inspections
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  3811bd8520
• Various updates to ruleset and primary key usages to move closer to realm support
  Dean Herbert · 2022-01-12 16:57:13 +09:00
  b8cd3cdbbc
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Remove null checks on CreateInstance() calls
  Dean Herbert · 2021-11-24 12:23:09 +09:00
  0eea026afb
• Fix one more issue
  smoogipoo · 2021-09-16 18:34:13 +09:00
  e8dea0138c
• Tidy bindable changed code up
  Dean Herbert · 2021-05-14 16:24:52 +09:00
  67a99c83a3
• Move IBeatmap arg into context
  Naxess · 2021-05-13 11:24:22 +02:00
  19800f5f7f
• Change interpreted difficulty from bindable to regular value

  There's no reason for why checks would need this to be bindable. A 1-directional binding is more appropriate.

  Naxess · 2021-05-13 09:00:30 +02:00
  b37cb3bdbe
• Keep track of local bound copy
  Naxess · 2021-05-13 07:57:32 +02:00
  4eeeaf6a1a
• Merge branch 'master' into beatmap-verifier-context
  Naxess · 2021-05-13 07:40:33 +02:00
  e7c7786db3
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576
• Add interpreted difficulty info to BeatmapVerifierContext

  Enables checks to make use of the difficulty level as shown in the settings UI.

  Naxess · 2021-05-12 02:30:21 +02:00
  64d96b06a6
• Replace IWorkingBeatmap arg with BeatmapVerifierContext in checks

  This simplifies passing of contextual information by enabling addition without needing to refactor lots of classes.
  
  See next commit for example.

  Naxess · 2021-05-12 02:29:18 +02:00
  c13b93e6f1
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Refresh IssueList on changes in VisibilitySection
  Naxess · 2021-05-12 01:30:45 +02:00
  ad78aec1ef