392 Commits

• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Clean up DrawableHitObject events on Dispose

  This is just general safeties to avoid cases where
  components don't correctly unbind events.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  de32e7815b
• Reduce precision of audio balance adjustments during slider sliding
  Dean Herbert · 2024-01-05 02:26:30 +09:00
  e9289cfbe7
• Use better fallback

  Seems better to use the rate from a non-gameplay clock than to arbitrarily apply 1.

  Poyo · 2023-11-21 15:18:04 -08:00
  0cf925dadf
• Use rate fallback in DrawableHitObject
  Poyo · 2023-11-18 12:09:37 -08:00
  d9cd546377
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Use soft-cast to access IGameplayClock
  Poyo · 2023-11-14 13:51:55 -08:00
  f5e1734de9
• Allow gameplayClock to be null
  Poyo · 2023-11-12 13:29:40 -08:00
  f794d4dc83
• Use IGameplayClock for rate
  Poyo · 2023-11-12 12:14:19 -08:00
  e67725f5d6
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Enforce minimum gameplay sample volume of 5%
  Bartłomiej Dach · 2023-10-20 15:50:13 +02:00
  b321d556b6
• Move validation to DHO.ApplyResult()
  Dan Balasescu · 2023-10-10 21:42:37 +09:00
  a1a46e58fc
• Reword comment to be better
  Bartłomiej Dach · 2023-08-22 09:37:54 +02:00
  5be5335784
• Update inline comments
  OliBomby · 2023-08-21 13:09:31 +02:00
  e283aa2843
• Fix DrawableHitObject state not synchronizing with hitobject edits
  OliBomby · 2023-08-11 22:34:04 +02:00
  d2f5e696e7
• Replace various local implementations of rewinding checks with new property
  Dean Herbert · 2023-07-07 15:21:24 +09:00
  e0fc97bb93
• Fix fallback for Judged to be more correct

  Without this change, when the `Judged` value is checked on an
  `HitObjectLifetimeEntry` it would return `true` if a `DrawableHitObject`
  has not yet been associated with the entry. Which is completely wrong.
  
  Of note, the usage in `DrawableHitObject` will have never fallen through
  to this incorrect value as they always have a result populated:
  
  https://github.com/ppy/osu/blob/f26f001e1d01ca6bb53225da7bf06c0ad21153c5/osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs#L721-L726

  Dean Herbert · 2023-07-05 18:03:58 +09:00
  3f8dfc7cb0
• Redirect judgement-related flags from DHO to HOLE
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  6c4e52821d
• Ensure synthetic entries from non-pooled DHO are linked to parents
  Bartłomiej Dach · 2023-07-04 23:45:08 +02:00
  0ceaf3c451
• Add an IAnimationTimeReference to DrawableHitObject to synchronise all animations
  Dean Herbert · 2023-05-08 18:56:29 +09:00
  64498e95a4
• remove other usages of hitobject SampleControlPoint
  OliBomby · 2023-04-25 16:01:43 +02:00
  ebe1d852f5
• Invoke RevertResult on parent DHO when nested DHO is reverted

  The behaviour described above was removed in
  812a4b412a, thus henceforth
  contradicting `RevertResult`'s xmldoc. As it is relied on by some
  external rulesets, bring it back to unbreak them.

  Bartłomiej Dach · 2023-04-11 18:29:08 +02:00
  db86ced4b4
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Move taiko-specific property out of DrawableHitObject
  Dean Herbert · 2023-02-12 16:09:28 +09:00
  9d09141ab7
• Change snapping to only apply to classic mod
  Dean Herbert · 2023-02-09 18:22:14 +09:00
  34d1890f1c
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Rename method
  Bartłomiej Dach · 2022-11-30 22:54:14 +01:00
  2e19e93036
• Update state based on result during LoadComplete
  Derrick Timmermans · 2022-11-27 20:57:00 +01:00
  cff3e06ad6
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-11 18:24:39 +09:00
  106f1cf90b
• Move gameplay configuration to interface to allow editor overriding
  Dean Herbert · 2022-11-08 18:25:24 +09:00
  dd4cd3cf8e
• Move major barline portion to default implementation to allow for further customisation

  Of note, this removes the "major" barline triangles from legacy skins. I
  think this is more correct, as they did not display in stable.

  Dean Herbert · 2022-11-07 14:29:58 +09:00
  c69a4f9333
• Remove unused bindable
  Dean Herbert · 2022-11-06 23:34:04 +09:00
  51078bddf9
• Fix test failures and rename configuration value to match better
  Dean Herbert · 2022-11-02 18:15:18 +09:00
  3ec9686e58
• Change range to 0-100% and rename to "normalisation"
  Dean Herbert · 2022-11-02 13:47:11 +09:00
  99ba7c29dd
• Remove toggle and change method of application to blend with original colour
  Dean Herbert · 2022-11-02 13:08:29 +09:00
  2f3c80f884
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-02 12:09:27 +09:00
  a01602e63c
• Fix DrawableHitObject.AccentColour not being updated if object entry is not attached
  Dean Herbert · 2022-11-01 19:34:53 +09:00
  f014acfc8d
• Merge branch 'master' into combo-colour-brightness-limit
  Dean Herbert · 2022-11-01 17:50:26 +09:00
  27af91003b
• Remove various simple obsoletions
  Dean Herbert · 2022-10-28 13:20:58 +09:00
  42eafe318c
• Allow combo colour normalisation to be disabled
  Dan Balasescu · 2022-10-14 14:37:24 +09:00
  8a88339e78
• Extract to struct, add dictionary term
  Dan Balasescu · 2022-10-14 14:12:53 +09:00
  15db65c037
• Limit minimum brightness of combo colours
  Dan Balasescu · 2022-10-13 14:05:33 +09:00
  4149235e63