48145 Commits

This Branch

This Branch

All Branches

• Merge pull request #16499 from peppy/realm-integration/faster-migration

  Improve performance of migration to realm

  Dan Balasescu · 2022-01-19 14:43:33 +09:00
  aa6466dfa4
• Merge pull request #16497 from peppy/top-local-rank-optimisation

  Rewrite `TopLocalRank` to use realm subscriptions

  Dan Balasescu · 2022-01-19 14:22:12 +09:00
  581873f944
• Merge pull request #16331 from stanriders/continuous-effective-misscount

  Don't floor `effectiveMissCount`

  Dan Balasescu · 2022-01-19 14:13:12 +09:00
  58bae9bda3
• Merge branch 'master' into realm-integration/faster-migration
  Dan Balasescu · 2022-01-19 13:54:14 +09:00
  0b1736def6
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Merge pull request #16510 from peppy/optimise-set-detach-part-2

  Avoid file retrieval overhead when detaching `BeatmapSetInfo`

  Dan Balasescu · 2022-01-19 13:53:34 +09:00
  9c8f7795b7
• Add comprehensive test coverage for TopLocalRank
  Dean Herbert · 2022-01-19 13:48:00 +09:00
  201f2d7813
• Merge pull request #16495 from peppy/realm-integration/reinit-on-corrupt

  Add support for starting with a fresh realm database if the existing one is not usable

  Dan Balasescu · 2022-01-19 13:30:14 +09:00
  a0336c6fc2
• Simplify binding/invalidation in TopLocalRank
  Dean Herbert · 2022-01-19 13:20:52 +09:00
  9be5bf38c6
• Merge branch 'master' into optimise-set-detach-part-2
  Dan Balasescu · 2022-01-19 13:20:38 +09:00
  2556f1cb87
• Merge pull request #16508 from peppy/optimise-set-detach

  Create separate automapper configurations to reduce cyclic detach overhead

  Dan Balasescu · 2022-01-19 13:20:25 +09:00
  d663fcd045
• Merge branch 'master' into top-local-rank-optimisation
  Dean Herbert · 2022-01-19 13:04:14 +09:00
  e60fd358d0
• Merge branch 'master' into realm-integration/faster-migration
  Dean Herbert · 2022-01-19 12:56:42 +09:00
  d440197fb3
• Add back BaseDifficulty with obsoletion counter to account for custom rulesets
  Dean Herbert · 2022-01-19 12:33:56 +09:00
  2363130f8b
• Merge branch 'master' into realm-integration/reinit-on-corrupt
  Dean Herbert · 2022-01-19 12:31:56 +09:00
  ad4d9789ad
• Merge pull request #16507 from peppy/more-ingore-rules

  Add some missing `IgnoredAttributes` to reduce automapper overhead

  Dan Balasescu · 2022-01-19 12:26:37 +09:00
  f6f44029e8
• Merge branch 'master' into realm-integration/reinit-on-corrupt
  Dean Herbert · 2022-01-19 12:26:24 +09:00
  fb558a3189
• Merge pull request #16491 from peppy/realm-integration/safer-migration

  Improve safety and logging of realm migration process

  Dan Balasescu · 2022-01-19 12:23:48 +09:00
  8c120c6bfb
• Rename property
  Dan Balasescu · 2022-01-19 11:56:44 +09:00
  c52899b1fb
• Only catch RealmExceptions to avoid blocking the nested TimeoutException
  Dean Herbert · 2022-01-19 10:58:59 +09:00
  261b4988f9
• Only output "successful" messages when copy actually occurred
  Dean Herbert · 2022-01-19 10:31:13 +09:00
  195534a1d2
• Add notification for debug builds when database migration occurs
  Dean Herbert · 2022-01-19 10:31:10 +09:00
  e1a35714be
• Freshen some comments
  Dean Herbert · 2022-01-19 10:20:56 +09:00
  04e9ffa966
• Avoid taking more than one backup per migration run
  Dean Herbert · 2022-01-19 10:20:56 +09:00
  64a023665e
• Add ignore rules on more helper properties
  Dean Herbert · 2022-01-19 09:46:45 +09:00
  3bc091fe6d
• Add comment explaining ignore rule
  Dean Herbert · 2022-01-19 09:44:21 +09:00
  761e161eec
• Merge pull request #16490 from peppy/playlist-test-coverage

  Fix `TestScenePlaylistsScreen` crashing on entering room

  Bartłomiej Dach · 2022-01-18 23:47:56 +01:00
  5809ce6951
• Merge branch 'master' into playlist-test-coverage
  Bartłomiej Dach · 2022-01-18 20:17:48 +01:00
  7df18c7767
• Merge pull request #16511 from peppy/revert-nunit-test-adaptor
  Salman Ahmed · 2022-01-18 20:50:54 +03:00
  b3983db69d
• Revert nunit test adaptor version bump until console output bug is resolved

  Tests have started to output too much log content, causing viewing CI
  failures to be painfully impossible. Roll back for now.
  
  Fix may be related to
  https://github.com/nunit/nunit3-vs-adapter/issues/941, although we don't
  use filter.

  Dean Herbert · 2022-01-19 02:18:58 +09:00
  96d07e20ed
• Update tests to match new behaviour
  Dean Herbert · 2022-01-19 01:05:47 +09:00
  1db2135d70
• Avoid file retrieval overhead when detaching BeatmapSetInfo

  It seems that no usages of `BeatmapSetInfo` detaches require files - a
  `WorkingBeatmap` is always obtained before doing further lookups.
  
  Therefore we can omit this include unless the detaching object is a
  `BeatmapInfo`. A refetch is performed when retrieving a
  `WorkingBeatmap` to complete the equation.

  Dean Herbert · 2022-01-19 00:49:18 +09:00
  60b80c88b6
• Create separate automapper configurations to reduce cyclic detach overhead

  This optimises the `BeatmapSetInfo` detach operation by avoiding
  detaching `BeatmapSetInfo.Beatmaps[].BeatmapSetInfo` a second time over.

  Dean Herbert · 2022-01-19 00:03:24 +09:00
  f2b151023e
• Remove all usage of AuthorString
  Dean Herbert · 2022-01-18 23:30:40 +09:00
  67bf95bc91
• Add some missing IgnoredAttributes to reduce automapper overhead
  Dean Herbert · 2022-01-18 23:25:30 +09:00
  3596c6ed5d
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Use a single EF context to avoid scores getting cascade deleted along the way
  Dean Herbert · 2022-01-18 20:47:53 +09:00
  6b0bf38c93
• Add spaces to query string
  Dean Herbert · 2022-01-18 19:28:09 +09:00
  f5b8653491
• Don't bother with removing from EF as the file is going to be deleted anyway
  Dean Herbert · 2022-01-18 19:17:47 +09:00
  519f7e6ad2
• Use IQueryable directly to avoid insane overheads
  Dean Herbert · 2022-01-18 19:17:47 +09:00
  3b0977903b
• Merge pull request #16488 from peppy/global-bindable-thread-safety

  Ensure global beatmap/ruleset are always mutated from the update thread

  Dan Balasescu · 2022-01-18 19:09:15 +09:00
  66ed4270c0
• Rewrite TopLocalRank to use realm subscriptions

  This addresses the number one performance concern with realm (when
  entering song select). Previous logic was causing instantiation and
  property reads of every score in the database due to the `AsEnumerable`
  specfication.

  Dean Herbert · 2022-01-18 18:17:53 +09:00
  27ea37c690
• Merge branch 'master' into global-bindable-thread-safety
  Dean Herbert · 2022-01-18 18:12:00 +09:00
  02baad30d7
• Merge pull request #16421 from Susko3/textbox-AllowIme-false

  Add `AllowIme => false` to text boxes where applicable

  Dean Herbert · 2022-01-18 18:02:47 +09:00
  d10d657073
• Merge branch 'master' into realm-integration/reinit-on-corrupt
  Dean Herbert · 2022-01-18 18:02:23 +09:00
  49fcff190a
• Merge branch 'master' into realm-integration/safer-migration
  Dean Herbert · 2022-01-18 18:01:46 +09:00
  7baada2fa6
• Merge pull request #16428 from peppy/realm-integration/score-and-beatmaps

  Migrate scores and beatmaps to realm

  Dan Balasescu · 2022-01-18 18:01:08 +09:00
  5b9d095e35
• Merge branch 'master' into realm-integration/score-and-beatmaps
  Dan Balasescu · 2022-01-18 17:31:37 +09:00
  73a1f27ce5
• Merge branch 'master' into textbox-AllowIme-false
  Dean Herbert · 2022-01-18 17:03:51 +09:00
  39c9c4985b
• Fix PLaylistsResultsScreen tests falling over due to missing beatmap
  Dean Herbert · 2022-01-18 16:48:27 +09:00
  3e9e7a8fb6