1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 03:05:10 +08:00
Commit Graph

982 Commits

Author SHA1 Message Date
Dean Herbert
58d5c26bcd
Merge pull request #24601 from peppy/fix-tournament-song-bar-crash
Fix crash in tournament client when pick/ban is activated
2023-08-21 17:32:59 +09:00
Bartłomiej Dach
f03c64462e
Better convey meaning of zero last year placement via tooltip 2023-08-21 08:58:49 +02:00
Dean Herbert
1067769b24 Remove masking on song bar
Turns out this breaks when a border style is applied for picks/bans, and it wasn't doing much for visuals anyway.
2023-08-21 15:34:03 +09:00
FreezyLemon
8d84ea3712 Allow "none" value in LastYearPlacing
This "none" value (zero) will be the default value for
any new team and will display as "N/A" in the SeedingScreen.
2023-08-18 21:05:12 +02:00
Bartłomiej Dach
ed84be2f26
Merge pull request #24566 from peppy/multiplayer-spectator-score-diff
Add score difference display to multiplayer spectator
2023-08-16 12:57:17 +02:00
Dean Herbert
d309865b0d Update TournamentMatchScoreDisplay to share base implementation 2023-08-16 17:26:10 +09:00
Dean Herbert
f02416f877 Improve visuals of tournament song bar
This is a stop-gap until we add new versions (and share between game and tournament client).
2023-08-16 17:16:36 +09:00
cdwcgt
5ad80879b7
let MatchIPCInfo .Beatmap be nullable 2023-08-09 19:13:49 +09:00
cdwcgt
5898a9986b
Revert "use no null when true"
This reverts commit 6ad8339c66.
2023-08-09 19:11:36 +09:00
Dean Herbert
c88045dfc7 Fix weird usage of Cast 2023-08-09 18:21:57 +09:00
cdwcgt
99dd156d53
remove useless using 2023-07-30 02:50:16 +09:00
cdwcgt
ba80d1e2d5
remove nullable for Box 2023-07-30 02:49:13 +09:00
cdwcgt
0590121309
string mod should not null
Already assigned in the constructor
2023-07-30 02:41:45 +09:00
cdwcgt
bc2ca11bb0
move to initialiser 2023-07-30 02:41:45 +09:00
cdwcgt
a1f0e59784
remove null check for b.Beatmap 2023-07-30 02:41:44 +09:00
cdwcgt
6ad8339c66
use no null when true 2023-07-30 02:41:25 +09:00
cdwcgt
88a1cf4005
remove all canBeNull from attribute 2023-07-30 01:57:54 +09:00
cdwcgt
9482f74456
fix nullable for TeamList 2023-07-30 01:49:57 +09:00
cdwcgt
cb4adf115c
RemoveTeam shouldn't have nullable arg 2023-07-30 01:40:13 +09:00
cdwcgt
625ed729ee
debug assert closest != null 2023-07-30 01:39:56 +09:00
cdwcgt
033c9091c0
use cast instead AsNonNull 2023-07-30 01:39:31 +09:00
cdwcgt
8a06914438
remove #nullable disable in tournament 2023-07-29 22:25:06 +09:00
Bartłomiej Dach
0c10d875ce
Merge branch 'master' into ladder-grid-expand 2023-07-28 22:51:33 +02:00
Dean Herbert
f58c69e639 Fix potential startup crash due to early application of animations
This was always haphazard code, but by luck it never triggered before
drawable load until now. With the recently nullability changes, this
would be triggered when `flash` is not yet constructed.

Switching to `AddOnce` seems safer to avoid multiple applications,
regardless.
2023-07-28 17:17:15 +09:00
Dean Herbert
aa91000505 Always place first match at (0,0) 2023-07-28 16:29:55 +09:00
Dean Herbert
b5c3e2a648 Fix placing new match via right click not using original click position 2023-07-28 16:29:39 +09:00
Dean Herbert
b5f0d739e6 Allow ladder editor grid to scale with content
Closes https://github.com/ppy/osu/issues/24378.
2023-07-28 16:26:03 +09:00
Dean Herbert
57e51f4d5b
Merge pull request #24357 from peppy/tournament-fix-null-population
Fix startup tournament population not recovering from null beatmaps
2023-07-28 14:31:48 +09:00
Dao Heng Liu
c7717da232 make SetupScreen scrollable 2023-07-28 14:18:48 +09:00
Bartłomiej Dach
780b8f0ec8
Merge branch 'master' into tournament-fix-null-population 2023-07-27 22:36:11 +02:00
Bartłomiej Dach
b7ddb5c946
Remove fallbacks to empty APIBeatmap on population failure
Was causing there to be two kinds of missing `TournamentBeatmap`s: one
with missing `Beatmap == null`, and one with `Beatmap == new
APIBeatmap()`. In particular, they would appear differently in UI
(either as "unknown - unknown", or the intensely enigmatic " - ").
2023-07-27 22:33:00 +02:00
Bartłomiej Dach
3c923b9e81
Fix even more missed nullability-related inspections 2023-07-27 22:10:41 +02:00
Dean Herbert
1e9b927b50 Fix some missed null checks 2023-07-27 17:41:27 +09:00
Dean Herbert
fa4992f05a Apply NRT and avoid throws from null RoundBeatmap.Beatmaps 2023-07-26 17:49:07 +09:00
Bartłomiej Dach
72db0c17ca
Merge branch 'master' into fix-scheduler-screen-selection-alignment 2023-07-25 18:44:44 +02:00
Bartłomiej Dach
43876ba2b0
Privatise currentMatchSelectionBox
Because nobody else should need to do anything as cursed as what
`ScheduleScreen` was doing (which is 95% of the reason why the selection
box even broke there).
2023-07-25 18:41:54 +02:00
Dean Herbert
0130c356ed Cache IDialogOverlay in a simpler way 2023-07-25 18:33:41 +09:00
Dean Herbert
2c5a329b04 Merge branch 'master' into tourney-dangerous-action-confirm 2023-07-25 18:27:58 +09:00
Dean Herbert
7d5305c5e8
Merge branch 'master' into tourney-fix-screen-auto-switch 2023-07-25 17:18:43 +09:00
Dean Herbert
c84381d802 Separate out each type of scheduled operation and refactor tidy-up code 2023-07-25 17:18:13 +09:00
Dean Herbert
219ba00fb2 Fix startup tournament population not recovering from null beatmaps 2023-07-25 16:35:00 +09:00
Dean Herbert
d41fb98350 Fix misalignment of selection box on schedule screen 2023-07-25 16:32:48 +09:00
Dean Herbert
04c1333b59
Merge pull request #24346 from cdwcgt/tournament-no-unload-cover
Use `DelayedLoadWrapper` in `TournamentBeatmapPanel` to avoid beatmap cover unload in map pool
2023-07-25 16:27:52 +09:00
Dean Herbert
7b3bd0b042 Reword comments to make more sense 2023-07-25 16:15:16 +09:00
Dean Herbert
718d94a937 Fix typo in xmldoc 2023-07-25 14:51:51 +09:00
Dean Herbert
0cdf07ab12
Merge pull request #24353 from bdach/fix-uneven-connectors
Fix uneven spacing on match connectors in tournament ladder screen
2023-07-25 08:21:04 +09:00
cdwcgt
6f66e2fdd7
set LoadDelay to 0 2023-07-25 07:45:48 +09:00
Bartłomiej Dach
e3560d2a10
Fix uneven spacing on match connectors in tournament ladder screen
Noticed in passing during review of #24347.
2023-07-24 23:39:01 +02:00
Bartłomiej Dach
3ccd0ca1b0
Merge branch 'master' into tournament-resolution-fixes 2023-07-24 21:27:20 +02:00
Bartłomiej Dach
3af5c2b4f3
Merge pull request #24349 from peppy/tournament-bindable-fixes
Fix tournament client crashing occasionally when editing bracket
2023-07-24 21:21:39 +02:00
Dean Herbert
4fdf885959 Fix crash when switching ladder match selection multiple times 2023-07-25 01:46:45 +09:00
Dean Herbert
e0c0797f55 Fix dodgy implementation of current bindable in DateTextBox 2023-07-25 01:46:45 +09:00
Dean Herbert
62121ea14c Add non-black background to right of tournament system 2023-07-25 01:44:32 +09:00
Dean Herbert
b7f706ad2b Set a fixed minimum window size for the tournament client 2023-07-25 01:44:32 +09:00
Dean Herbert
e46385ee6a Automatically select new match in ladder editor after adding 2023-07-25 01:39:56 +09:00
Dean Herbert
dd32b771cf Adjust borders/layout to better align with grid 2023-07-25 01:39:56 +09:00
Dean Herbert
fd1bd0c88a Add grid to show ladder editor snapping 2023-07-25 01:39:56 +09:00
Dean Herbert
b1484e6973 Improve bracket selection box visuals
Fix border around selected match being uneven
2023-07-25 01:39:56 +09:00
cdwcgt
fd4d3a6d66
Use DelayedLoadWrapper to avoid beatmap cover unload in map pool 2023-07-25 00:52:02 +09:00
Dao Heng Liu
7813a3162b
run stateChanged upon unhiding of GameplayScreen 2023-07-23 15:12:11 +01:00
Dao Heng Liu
5a568eacb6
remove unused using directive 2023-07-23 10:44:00 +01:00
Dao Heng Liu
3049d159d8
avoid potentially cancelling contract when switching away from GameplayScreen 2023-07-23 10:39:47 +01:00
Dean Herbert
7e4e96a4a9 Adjust spacing and clean up code 2023-07-23 17:05:04 +09:00
Dean Herbert
3b47949ace Avoid transform overhead on every frame 2023-07-23 17:04:57 +09:00
cdwcgt
1a76f6441a
add MatchScoreDiffCounter
Intuitively show the score difference between the two teams
2023-07-23 15:33:40 +09:00
Dao Heng Liu
647f2b6715
fix auto advance screens sometimes not working 2023-07-22 23:08:20 +01:00
Dean Herbert
0170894d18
Merge pull request #24327 from ILW8/tourney-reload-tourneys-list
Add reload tournaments list button to tourney setup screen
2023-07-22 21:04:12 +09:00
Dean Herbert
a59876ce13 Remove unnecessary enable call 2023-07-22 21:03:13 +09:00
Dean Herbert
101f3eca25 Rename button slightly 2023-07-22 21:01:32 +09:00
Dao Heng Liu
ef74084a2e
make list of tournaments in SetupScreen dropdown alphabetically sorted 2023-07-22 09:59:00 +01:00
Dao Heng Liu
e0fe5c77d5
add reload tournaments list button to tourney setup screen 2023-07-22 09:44:02 +01:00
Bartłomiej Dach
92c40c9ced
Remove superfluous container 2023-07-21 21:20:28 +02:00
Bartłomiej Dach
d055d16ba7
Remove superfluous CanBeNull dependency specs
As stated before, not required in NRT-annotated files if auto-properties
are already marked nullable.
2023-07-21 21:19:40 +02:00
Bartłomiej Dach
7ace50f442
Touch up dialogs a bit 2023-07-21 21:17:14 +02:00
Bartłomiej Dach
f197703fe1
Merge branch 'master' into tourney-dangerous-action-confirm 2023-07-21 21:13:48 +02:00
Dean Herbert
cfcfe20221 Reduce scale and better align user panel 2023-07-21 15:46:28 +09:00
Dean Herbert
9d71e8f20d Merge branch 'master' into tournament-team-editor-improvements 2023-07-21 15:30:02 +09:00
Dao Heng Liu
bf9c25f429 add confirmation dialog to delete team/round buttons in tourney editor screens 2023-07-20 23:28:31 +01:00
Dao Heng Liu
2825671e28 pass action instead of storage to TournamentClearAllDialog 2023-07-20 23:01:14 +01:00
Dao Heng Liu
3c05246baf fix weird handling of dialogOverlay in tourney client 2023-07-20 22:52:02 +01:00
Dao Heng Liu
fa480cc27b remove #nullable disable, pass action instead of container to DangerousActionDialog 2023-07-20 22:52:02 +01:00
Dao Heng Liu
68495c937d fix ResetBracketTeams tests
also fixes formatting and var naming issues
2023-07-20 22:52:02 +01:00
Dao Heng Liu
e67253ed1e remove unused code 2023-07-20 22:52:02 +01:00
Dao Heng Liu
e3a7b6969a add confirmation dialog for Clear All button in TournamentEditorScreen 2023-07-20 22:52:02 +01:00
Dao Heng Liu
41638ff4b7 move LadderResetTeamsDialog.cs into editor screens components 2023-07-20 22:52:02 +01:00
Dao Heng Liu
e7795296e2 refactor LadderResetTeamsDialog.cs 2023-07-20 22:52:02 +01:00
Dao Heng Liu
2833497e5b add dialogoverlay to tournament client, confirmation dialog for resetting bracket teams 2023-07-20 22:52:00 +01:00
Dean Herbert
f0cec04619 Fix nullability warning 2023-07-21 03:47:32 +09:00
Dean Herbert
97e572d4da Make dragging ladder more snappy 2023-07-21 03:34:41 +09:00
Dean Herbert
fb4eaaeae9 Add grid snapping to ladder editor 2023-07-21 03:34:41 +09:00
Dean Herbert
ca14b4a35f Move ladder editor controls to control panel 2023-07-21 03:34:41 +09:00
Dean Herbert
ac6a103721 Add masking around ladder view 2023-07-21 03:34:41 +09:00
Dean Herbert
f9742c3c34 Increase button size of setup screen buttons 2023-07-21 03:34:36 +09:00
Dean Herbert
cfc4575490 Fix save changes button gone somewhere else 2023-07-21 03:34:36 +09:00
Dean Herbert
427045fdaf Further layout improvements to TeamEditorScreen 2023-07-21 03:34:36 +09:00
Dean Herbert
b712b19539 Update all tournament buttons to use new design 2023-07-21 03:34:36 +09:00
Dean Herbert
0284fa1fc1 Tidy up TeamEditorScreen 2023-07-21 03:34:36 +09:00
Dean Herbert
a16d7e6cc5 Add more padding around editor screen content 2023-07-21 03:34:36 +09:00
Dean Herbert
b40532dde1 Fix tournament bracket parsing regression
Closes #24136.
Regressed in #24037.
2023-07-06 17:17:17 +09:00
Dean Herbert
34f53965c4 Never remove significant digits from stsar rating displays
Closes https://github.com/ppy/osu/issues/24079.
2023-06-29 13:55:04 +09:00