1488 Commits

• Merge pull request #12750 from peppy/skin-serialisation

  Add skin editor saving / loading support

  Dan Balasescu · 2021-05-13 20:58:03 +09:00
  746862dcb1
• Merge branch 'master' into skin-serialisation
  Dan Balasescu · 2021-05-13 19:49:55 +09:00
  3c471837f8
• Merge branch 'master' into fix-two-hovered-handles
  Dan Balasescu · 2021-05-13 19:24:42 +09:00
  a3869c02f4
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Fix rotation handle visibility logic not handling two handles hovered at once
  Salman Ahmed · 2021-05-12 11:42:55 +03:00
  96d3586294
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Refresh IssueList on changes in VisibilitySection
  Naxess · 2021-05-12 01:30:45 +02:00
  ad78aec1ef
• Add IssueList filtering based on those bindables
  Naxess · 2021-05-12 01:29:46 +02:00
  1bb7d412da
• Add VisibilitySection and its bindables in IssueList
  Naxess · 2021-05-12 01:27:21 +02:00
  2e4399f0c1
• Add abstract Section class

  Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
  
  So there's a lot of things that differ, hence new class instead of factoring that out.

  Naxess · 2021-05-12 01:26:12 +02:00
  01b8794757
• Separate IssueList into own class
  Naxess · 2021-05-12 01:23:31 +02:00
  1de35f880b
• Take IssueList in IssueSettings constructor

  We'll be using this for bindables later.

  Naxess · 2021-05-12 01:22:32 +02:00
  d3c1ec55ee
• Factor out load from settings into new Settings class
  Naxess · 2021-05-12 01:21:38 +02:00
  97bd482d4d
• Replace polling logic with direct bindable reactions
  Dean Herbert · 2021-05-11 18:39:15 +09:00
  a4e0529617
• Merge pull request #12570 from frenzibyte/corner-rotation-controls

  Add rotation controls to editor selection box corners

  Dean Herbert · 2021-05-10 23:09:44 +09:00
  6bb52ebcf8
• Revert "Guard against potentially null track if ever"

  This reverts commit b1134c3857.

  Salman Ahmed · 2021-05-07 09:57:08 +03:00
  fc2a527e9d
• Unrevert null-colaescing/conditionals removal
  Salman Ahmed · 2021-05-07 09:54:14 +03:00
  7c4e54a1d4
• Guard against potentially null track if ever
  Salman Ahmed · 2021-05-07 08:30:50 +03:00
  b1134c3857
• Revert wrong not-null track changes

  This reverts commit f9d99a9882.
  This reverts commit 71547bece0.

  Salman Ahmed · 2021-05-07 08:28:44 +03:00
  37f44d2e37
• Remove any null-coalescing/conditionals in WorkingBeatmap.Track usages
  Salman Ahmed · 2021-05-07 07:46:23 +03:00
  71547bece0
• Set loadable beatmap track to clock immediately in BDL

  This reverts commit 84da247002.
  
  Use loadable beatmap track for clock directly in BDL

  Salman Ahmed · 2021-05-07 07:21:56 +03:00
  539643c72b
• Fix editor clock using the wrong beatmap track on creation
  Salman Ahmed · 2021-05-07 05:32:55 +03:00
  84da247002
• OnOperation -> TriggerOperation
  Salman Ahmed · 2021-05-05 21:50:16 +03:00
  2a67361dc0
• Merge branch 'master' into skin-bindables
  Bartłomiej Dach · 2021-05-05 20:16:27 +02:00
  3cac837acf
• Merge branch 'master' into corner-rotation-controls
  Salman Ahmed · 2021-05-04 23:53:23 +03:00
  1ac80d42f9
• Merge branch 'master' into fix-selection-handler-visibility
  Bartłomiej Dach · 2021-05-04 20:21:05 +02:00
  4185053120
• Hide the corresponding rotation handle when holding scale handle
  Salman Ahmed · 2021-05-04 07:31:55 +03:00
  8abff4881b
• Consider drag handles active using mouse down instead of when dragged
  Salman Ahmed · 2021-05-04 06:41:26 +03:00
  b2a0c2b563
• Move selection box control internal events to drag handles
  Salman Ahmed · 2021-05-04 06:37:22 +03:00
  5f33c3514e
• Finish transforms on controls load complete
  Salman Ahmed · 2021-05-04 06:37:20 +03:00
  fd7a6b3a7c
• Remove no-longer-relevant matching comment
  Dean Herbert · 2021-05-03 20:09:50 +09:00
  b28e1569ca
• Add back mis-removed fade transform
  Salman Ahmed · 2021-05-03 12:16:40 +03:00
  840c22a3b1
• Merge branch 'master' into corner-rotation-controls
  Dean Herbert · 2021-05-03 18:02:23 +09:00
  4f8240f19a
• Merge branch 'fix-selection-handler-visibility' into skin-bindables
  Dean Herbert · 2021-05-03 17:40:03 +09:00
  fdd0713988
• Remove intermediate container to fix tests
  Dean Herbert · 2021-05-03 17:35:56 +09:00
  3268a75f05