101 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	fb80d76b4a	Apply further changes to remove remaining weirdness	2024-02-05 13:37:38 +01:00
Bartłomiej Dach	efe6bb25b1	Refactor result application around again to remove requirement for fields ... Co-authored-by: Dean Herbert <pe@ppy.sh>	2024-02-05 13:21:01 +01:00
Chandler Stowell	93bd3ce5ae	update DrawableHitCircle.ApplyResult to pass this to its callback	2024-01-25 11:25:41 -05:00
Chandler Stowell	d2775680e6	use stack to pass action state when applying hit results ... this removes closure allocations	2024-01-24 13:13:45 -05:00
Bartłomiej Dach	7e98d319d8	Use update-invariant way of checking for second press on same frame ... Fixes the same issue that 970ea50269 did, but with no `AlwaysPresent` usage.	2023-07-25 20:07:03 +02:00
Dean Herbert	a9587fd1aa	Move strong hit handling to DrumSamplePlayer and separte trigger sources	2023-07-05 18:44:27 +09:00
Dean Herbert	e87cf6d256	Move all remaining osu!taiko sample playback logic out of DrawableHitObjects	2023-06-30 15:21:34 +09:00
Dean Herbert	34d1890f1c	Change snapping to only apply to classic mod	2023-02-09 18:22:14 +09:00
OpenSauce	df1355ea4b	Taiko hit objects now snap to hit target	2023-02-08 10:59:08 +00:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Dan Balasescu	606d42c679	Merge pull request #21184 from peppy/skinnable-things-cleanup ... Skinnable class naming pass	2022-11-10 12:52:08 +09:00
Dean Herbert	1aa0e40f2f	Add "Component" prefix to lookup naming	2022-11-09 17:46:43 +09:00
Dean Herbert	c908969d9b	Rename ISkinComponent to ISkinLookup	2022-11-09 17:46:43 +09:00
Dean Herbert	aa7d0e2c96	Remove triangles skin specific implementation from base DrawableHit	2022-11-08 15:22:00 +09:00
Dan Balasescu	f8830c6850	Automated #nullable processing	2022-06-17 16:37:17 +09:00
Dean Herbert	6944151486	Apply batch fixing of built-in types using var	2021-10-27 13:04:41 +09:00
smoogipoo	f9d5abff8a	Update with keybinding changes	2021-09-16 18:26:12 +09:00
Dean Herbert	6471ce902d	Run RecreatePieces using AddOnce to avoid multiple unnecessary calls	2021-05-21 16:45:28 +09:00
Dean Herbert	7bc8a4bb5f	Apply same logic changes to IsStrong status	2021-05-21 16:15:27 +09:00
Dean Herbert	a5ca736e37	Fix RecreatePieces being called more than once	2021-05-21 16:10:48 +09:00
Dean Herbert	40c8378d81	Fix type-to-sample mapping being applied too late	2021-05-21 14:37:22 +09:00
Bartłomiej Dach	370f56eadb	Make strong hit DHOs public for pool registration	2020-12-20 18:02:34 +01:00
Bartłomiej Dach	ae6dedacaf	Implement nested strong hit application	2020-12-20 16:26:39 +01:00
Bartłomiej Dach	e32b1c34ca	Implement hit application	2020-12-20 16:26:16 +01:00
Bartłomiej Dach	512549b4ea	Rename DrawableTaikoStrong{-> able}HitObject	2020-12-14 21:47:31 +01:00
Bartłomiej Dach	091b08b507	Scope drawable nested hits more closely to models	2020-12-13 14:38:16 +01:00
Bartłomiej Dach	4d444df6b3	Rename DHO CreateStrong{-> Nested}Hit	2020-12-13 13:08:32 +01:00
Bartłomiej Dach	b1635ecd16	Reflect can-be-strong split in DHO structure	2020-12-13 13:08:30 +01:00
Bartłomiej Dach	1ddc896b76	Rename Strong{-> Nested}HitObject	2020-12-13 12:34:14 +01:00
ekrctb	c70b13ecc2	Adjust namespace	2020-12-07 12:30:25 +09:00
smoogipoo	5760e1c1fc	Make HitSampleInfo immutable	2020-12-01 15:37:51 +09:00
Dean Herbert	a3dc1d5730	Update existing implementations	2020-11-04 17:14:23 +09:00
Bartłomiej Dach	1f0620ffd4	Replace assignment references to HitResult.Miss with Judgement.MinResult	2020-10-02 23:31:24 +02:00
smoogipoo	c45b5690cf	Use new hit results in taiko	2020-09-29 16:33:38 +09:00
Dean Herbert	33fad27ec2	Avoid API change to DrawableHitObject	2020-09-24 13:28:29 +09:00
Dean Herbert	156edf24c2	Change properties to methods and improve naming	2020-09-24 13:22:31 +09:00
Dean Herbert	9a0e5ac154	Handle type/strength changes from samples changes	2020-09-23 18:09:40 +09:00
Dean Herbert	8f3eb9a422	Fix taiko sample selection not updating when changing strong/rim type	2020-09-23 17:59:11 +09:00
Dean Herbert	4e9631b546	Support HitType bindable changes	2020-05-29 16:45:47 +09:00
Dean Herbert	db4e3047dd	Add test for final sample output	2020-05-19 23:28:13 +09:00
Dean Herbert	013683c23b	Fix taiko rim markers incorrectly playing as whistle samples	2020-05-19 00:17:13 +09:00
Dean Herbert	77041bdbb5	Move implementation to DrawableHit to avoid "breaking" legacy encoding	2020-05-11 16:29:50 +09:00
Dean Herbert	b4d790c076	Fix taiko sample mapping for strong hits	2020-05-11 12:53:54 +09:00
Dean Herbert	b9f28c8373	Combine hit types and remove old drumroll hits using a more efficient method	2020-04-27 16:13:28 +09:00
Dean Herbert	58bf288595	Remove DrawableHit's custom sizing logic ... Turns out this was unnecessary and never actually being used.	2020-04-23 12:17:52 +09:00
Dean Herbert	eb165840cb	Add remaining taiko hitobject skinnables and expose as SkinnableDrawable for safety	2020-04-15 18:03:23 +09:00
smoogipoo	7b2f58eb30	Apply OnRelease method signature refactorings	2020-01-22 13:22:34 +09:00
Dean Herbert	f21e47d6d2	Move expire to DrawableHitObject	2019-09-12 19:29:08 +09:00
Dean Herbert	f925e781a9	Refactor HitWindows for legibility	2019-09-06 15:24:14 +09:00
smoogipoo	8302658186	Fix other potential nullref cases that rider missed	2019-09-02 18:31:33 +09:00