normalid
56143de2c6
Update offset factor
2024-07-24 12:39:36 +08:00
normalid
e2beacb3dd
Remove logging
2024-07-24 12:31:01 +08:00
normalid
395f8424b5
Match the stable animation
2024-07-24 12:30:08 +08:00
normalid
95f287104e
Add visual test seane
2024-07-24 12:24:58 +08:00
normalid
661f58a397
Add test coverage
2024-07-24 12:18:05 +08:00
normalid
c52a993607
Support custom input overlay color
2024-07-23 23:35:25 +08:00
normalid
c7b110a471
* Fix the default position
...
* Make the font match stable style
2024-07-23 22:11:28 +08:00
Dean Herbert
a9ccb50b98
Merge pull request #29020 from bdach/drag-selection-tolerance
...
Add tolerance when drag-scrolling editor timeline
2024-07-23 22:28:29 +09:00
normalid
989ac56cbb
Fix the return button being squshed
2024-07-23 21:12:55 +08:00
normalid
9fe369b7f4
Replace SkinnableSprite with Sprite
2024-07-23 21:08:08 +08:00
normalid
a015fde014
Change the default height to match the stable
2024-07-23 20:53:06 +08:00
normalid
dce894108a
Remove unused blending mode
2024-07-23 20:50:08 +08:00
normalid
f7dc0b65da
Clean up the code
2024-07-23 20:47:49 +08:00
normalid
5dcc8b7a8f
Make the text are always horizontal
2024-07-23 19:56:43 +08:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
normalid
777a0deb0f
Update the offset formula
2024-07-23 19:45:53 +08:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time
2024-07-23 13:38:50 +02:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time
2024-07-23 13:38:25 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
...
Closes https://github.com/ppy/osu/issues/28703 .
2024-07-23 13:30:13 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
...
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
normalid
ad1a86ebdc
Implement the overlay
2024-07-23 19:05:14 +08:00
Dean Herbert
40b171f544
Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued
...
Fix duration fluctuations and one-frame jitters when editing juice streams
2024-07-23 19:02:30 +09:00
Dean Herbert
cc4ed0ff3f
Use non-screen-space coordinates and add time-based drag ramping for better control
2024-07-23 18:59:22 +09:00
Bartłomiej Dach
38fc6f70f6
Add tolerance when drag-scrolling editor timeline
...
Closes https://github.com/ppy/osu/issues/28983 .
While the direct cause of this is most likely mouse confine in
full-screen, it shouldn't/can't really be disabled just for this,
and I also get this on linux in *windowed* mode.
In checking other apps, adding some tolerance to this sort of
drag-scroll behaviour seems like a sane UX improvement anyways.
2024-07-23 11:10:18 +02:00
Dean Herbert
aba05a21aa
Merge branch 'master' into catch-juice-stream-editing-weirdness-continued
2024-07-23 17:05:40 +09:00
Dean Herbert
5911c42116
Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness
...
Fix various shortcomings in juice stream selection blueprint
2024-07-23 16:43:39 +09:00
Bartłomiej Dach
6100f5269d
Fix tests
2024-07-23 09:13:43 +02:00
Bartłomiej Dach
f3617eadad
Fix editing juice stream path sometimes changing its duration
...
I'm not *super* sure why this works, but it appears to, and my educated
guess as to why is that it counteracts the effects of a change in the SV
of the juice stream by artificially increasing or decreasing the
velocity when running the appropriate path conversions and expected
distance calculations. The actual SV change takes effect on the next
default application, which is triggered by the `Update()` call at the
end of the method.
2024-07-22 15:14:45 +02:00
Bartłomiej Dach
56af009e77
Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object
...
This is important because the editable path conversions heavily depend
on the value of `JuiceStream.Velocity` being correct. The value is only
guaranteed to be correct after an `ApplyDefaults()` call, which is
triggered by updating the object via `EditorBeatmap`.
2024-07-22 14:50:25 +02:00
Bartłomiej Dach
f86ab1a64e
Fix filename
2024-07-22 13:49:52 +02:00
Bartłomiej Dach
1d91201c43
Fix tests
2024-07-22 13:37:24 +02:00
Bartłomiej Dach
6b3c1f4e47
Unify juice stream piece UX with osu! control point pieces
...
- Use same hover state
- Use shift-right click for quick delete rather than shift-left click
2024-07-22 13:30:15 +02:00
Bartłomiej Dach
47964f33d7
Fix catch juice stream vertex remove operation not undoing
2024-07-22 13:21:49 +02:00
Bartłomiej Dach
64381d4087
Fix catch juice stream vertex add operation not undoing
2024-07-22 12:18:53 +02:00
Dean Herbert
7e5fda4539
Merge pull request #28996 from bdach/fix-dim-again
...
Fix editor UI dimming when hovering over expanded part of toolboxes
2024-07-22 19:11:31 +09:00
OliBomby
c57232c220
enforce minimum duration based on snap
2024-07-22 11:58:53 +02:00
Bartłomiej Dach
57fa502786
Fix editor UI dimming when hovering over expanded part of toolboxes
...
Closes https://github.com/ppy/osu/issues/28969 .
2024-07-22 11:57:46 +02:00
OliBomby
9fb9a54a4d
hold shift to adjust velocity instead of duration
2024-07-22 11:34:07 +02:00
Bartłomiej Dach
636e965868
Remove no-longer-valid test remark & adjust test
2024-07-22 11:29:39 +02:00
Bartłomiej Dach
157cc884f4
Fix swells not being correctly treated in editor gameplay test
...
Closes https://github.com/ppy/osu/issues/28989 .
Because swell ticks are judged manually by their parenting objects,
swell ticks were not given a start time (with the thinking that there
isn't really one *to* give). This tripped up the "judge past objects"
logic in `EditorPlayer`, since it would enumerate all objects
(regardless of nesting) that are prior to current time and mark them as
judged. With all swell ticks having the default start time of 0 they
would get judged more often than not, leading to behaviour weirdness.
To resolve, give swell ticks a *relatively* sane start time equal to
the start time of the swell itself.
2024-07-22 11:27:56 +02:00
Bartłomiej Dach
e2fe1935a9
Add failing test case
2024-07-22 11:22:36 +02:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
...
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Bartłomiej Dach
088b8aff11
Merge pull request #28881 from smoogipoo/fix-judgement-cut
...
Fix judgement animation getting cut early
2024-07-22 09:24:57 +02:00
Layendan
6a4872faa8
Remove nullable disable
2024-07-21 23:56:47 -07:00
Layendan
6bb562db14
Fix collection popover
2024-07-22 12:22:52 +09:00
Layendan
e4cccb5e31
Fix lint errors
2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests
2024-07-22 12:22:51 +09:00
Layendan
c16b7c5c70
Update favorite button
2024-07-22 12:22:51 +09:00
Layendan
3296beb003
Added collection button to result screen
2024-07-22 12:22:50 +09:00
Dean Herbert
15220f3bf4
Merge pull request #28954 from frenzibyte/fix-pause-input-handling
...
Fix held gameplay keys stuck after pausing and resuming
2024-07-20 15:45:19 +09:00
