45041 Commits

This Branch

This Branch

All Branches

• Merge pull request #14919 from smoogipoo/realtime-pp-display

  Implement real-time PP counter

  Dean Herbert · 2021-10-05 20:50:03 +09:00
  2021.1005.0 6f7b8293af
• Handle judgement reverts with actual display updates
  Dean Herbert · 2021-10-05 19:08:30 +09:00
  98fef6ece2
• Merge pull request #14907 from peppy/remove-local-realm-thread-switch-handling

  Remove local handling of realm when switching thread modes

  Dean Herbert · 2021-10-05 19:00:19 +09:00
  5c62d3b6cb
• Add various logging output in an atttempt to figure multiplayer test failure
  Dean Herbert · 2021-10-05 18:53:20 +09:00
  e6efdae7c9
• Merge branch 'new-interfaces' into beatmap-difficulty-more-interface-usage
  Dean Herbert · 2021-10-05 18:21:21 +09:00
  bd84a8b749
• Fix delete local score test not waiting for "fetch" to complete

  Even though this is a completely local operation in this case, there's
  still a level of asynchronous operation which was recent introduced with
  the score ordering:
  
  https://github.com/ppy/osu/blob/853cf6feaa165e833ecb7ca18c6cdffe8ca6e005/osu.Game/Screens/Select/Leaderboards/BeatmapLeaderboard.cs#L159
  
  This means there is a brief period where the `Scores` property is null,
  after `Reset()` is called in the re-fetch procedure.

  Dean Herbert · 2021-10-05 18:17:22 +09:00
  5d708b612d
• Fix TestDifficultyIconSelectingForDifferentRuleset potentially failing due to async load
  Dean Herbert · 2021-10-05 18:06:24 +09:00
  94153e8bba
• Add missing null checks
  Dean Herbert · 2021-10-05 17:59:38 +09:00
  2be44188ef
• Merge pull request #14955 from peppy/fix-import-notifications

  Fix import notifications not showing correct text

  Dan Balasescu · 2021-10-05 17:55:04 +09:00
  f8156b0df9
• Also dim counter during initial calculation phase
  Dean Herbert · 2021-10-05 17:24:36 +09:00
  0859c336de
• Fix import notifications not showing correct text
  Dean Herbert · 2021-10-05 17:14:09 +09:00
  1e4da81120
• Fix display not displaying correctly after initial load
  Dean Herbert · 2021-10-05 17:10:32 +09:00
  f64226ded6
• Add assert tests
  Dean Herbert · 2021-10-05 17:10:24 +09:00
  04538a69e4
• Avoid returning a live IEnumerable
  Dean Herbert · 2021-10-05 17:01:07 +09:00
  599d82e383
• Add easing to rolling counter value
  Dean Herbert · 2021-10-05 16:51:49 +09:00
  fa7f11d906
• Add basic test scene
  Dean Herbert · 2021-10-05 16:51:43 +09:00
  eeb5f3d519
• Tidy up attribute retrieval code
  Dean Herbert · 2021-10-05 16:40:07 +09:00
  565e888f58
• Remove unnecessary dependency
  smoogipoo · 2021-10-05 16:03:25 +09:00
  45b63cbad9
• Fade display out during rewind (as the value displayed is no longer valid)
  Dean Herbert · 2021-10-05 15:39:29 +09:00
  676df55a0e
• Adjust default location slightly, fix alignment of "pp" subtext
  Dean Herbert · 2021-10-05 15:28:03 +09:00
  81a13566bc
• Apply some code quality refactoring
  Dean Herbert · 2021-10-05 15:14:49 +09:00
  b6af93d434
• Revert Player.Score to protected
  Dean Herbert · 2021-10-05 14:55:40 +09:00
  7176dc95e5
• Make GameplayState.Score immutable
  Dean Herbert · 2021-10-05 14:55:40 +09:00
  e19be8ebe4
• Remove null check suppression and add non-null fallback
  Dean Herbert · 2021-10-05 14:49:59 +09:00
  a5aa32811a
• Move common interface implementations to extension methods
  Dean Herbert · 2021-10-05 14:41:14 +09:00
  d3b9660148
• Rename APIRequest.Result to Response
  Dean Herbert · 2021-10-05 14:28:56 +09:00
  b41fa41c85
• Fix incorrect CancellationToken usage

  Apparently I wrote the BDL system and don't know how this works. I
  believe you need `CancellationToken?` or CanBeNull=true, however that doesn't actually
  play well when actually using the token in code...

  smoogipoo · 2021-10-05 12:07:41 +09:00
  5624dd9af6
• Further asyncify load process
  smoogipoo · 2021-10-05 11:26:13 +09:00
  593da79bbc
• Fix skin fallbacks test
  smoogipoo · 2021-10-05 11:06:26 +09:00
  86df4919f7
• Fix test runs hanging due to missing ConfigureAwait
  Dean Herbert · 2021-10-05 02:07:00 +09:00
  15ec315ec6
• Fix redundant default value
  smoogipoo · 2021-10-04 21:13:14 +09:00
  d120678e30
• Pass score into GameplayState
  smoogipoo · 2021-10-04 20:59:51 +09:00
  d1e7191f94
• Fix missing CanBeNull
  smoogipoo · 2021-10-04 20:59:31 +09:00
  0b0316e27e
• Merge branch 'master' into remove-local-realm-thread-switch-handling
  Dean Herbert · 2021-10-04 20:52:44 +09:00
  57c5be39d3
• Merge branch 'master' into new-interfaces
  Dean Herbert · 2021-10-04 20:42:40 +09:00
  1d99bc280f
• Share rounding with PerformanceStatistic
  smoogipoo · 2021-10-04 20:35:53 +09:00
  1837e1bf3c
• Add todo
  smoogipoo · 2021-10-04 20:35:26 +09:00
  fb63e5ed87
• Drop "default" prefix
  smoogipoo · 2021-10-04 20:34:28 +09:00
  221cc1747c
• Use GameplayState
  smoogipoo · 2021-10-04 20:33:54 +09:00
  5aae673240
• Make Mods readonly
  smoogipoo · 2021-10-04 20:20:24 +09:00
  2e3450b3f5
• Merge branch 'master' into realtime-pp-display
  smoogipoo · 2021-10-04 20:19:37 +09:00
  031c5a441e
• Merge pull request #14903 from peppy/importer-returns-live

  Add `ILive<T>` and use as return type of `Import` methods

  Dan Balasescu · 2021-10-04 20:16:32 +09:00
  4bd1083388
• Merge pull request #14950 from peppy/rename-score-beatmap

  Rename last remaining `BeatmapInfo Beatmap` usage

  Dan Balasescu · 2021-10-04 19:45:08 +09:00
  1935c9e93d
• Merge branch 'master' into importer-returns-live
  smoogipoo · 2021-10-04 19:42:36 +09:00
  4871db2f86
• Rename last remaining BeatmapInfo Beatmap usage
  Dean Herbert · 2021-10-04 17:35:53 +09:00
  853cf6feaa
• Merge pull request #14949 from peppy/login-error-display

  Show login failure messages on login form

  Dan Balasescu · 2021-10-04 17:23:11 +09:00
  5937a93e2d
• Merge pull request #14932 from peppy/rename-beatmap-info-beatmap-fields

  Rename `BeatmapInfo` variables which were named `beatmap` for clarity

  Dan Balasescu · 2021-10-04 17:22:06 +09:00
  c1540c137a
• Fix incorrect csproj merge
  Dean Herbert · 2021-10-04 17:18:08 +09:00
  6ac0601d2c
• Merge branch 'master' into remove-local-realm-thread-switch-handling
  Dean Herbert · 2021-10-04 17:17:10 +09:00
  ae5d1e8ac0
• Update framework
  Dean Herbert · 2021-10-04 17:12:40 +09:00
  95f1cc85d4