71042 Commits

This Branch

This Branch

All Branches

• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Merge pull request #31418 from peppy/intro-file-integrity

  Ensure intro files exist in storage during startup

  Bartłomiej Dach · 2025-01-07 08:14:40 +01:00
  01e9c0f15e
• Merge pull request #31306 from bdach/aspire-slider-breakage

  Fix slider event generator incorrectly not generating repeats when tick distance is zero

  Dan Balasescu · 2025-01-07 11:50:18 +09:00
  77d9c955ea
• Merge pull request #31436 from EVAST9919/editor-alloc

  Reduce allocations in the editor caused by `TimelineBlueprintContainer`

  Dan Balasescu · 2025-01-07 11:31:39 +09:00
  638128ba88
• Use cleaner array creation expression
  Andrei Zavatski · 2025-01-07 01:23:19 +03:00
  d35b308745
• Fix allocations in updateSamplePointContractedState
  Andrei Zavatski · 2025-01-07 00:48:58 +03:00
  791ca915e4
• Reduce HitSampleInfo constants allocations
  Andrei Zavatski · 2025-01-07 00:36:58 +03:00
  e8dc09f5bc
• Merge pull request #31433 from bdach/romanised-metadata-ascii-only

  Constrain range of usable characters in romanised metadata to ASCII only

  Dean Herbert · 2025-01-07 03:29:44 +09:00
  1ca28d74a3
• Constrain range of usable characters in romanised metadata to ASCII only

  Closes https://github.com/ppy/osu/issues/31398.
  
  Rationale given in issue.
  
  Compare stable logic:
  
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!/GameModes/Edit/Forms/SongSetup.cs#L118-L122
  - https://github.com/peppy/osu-stable-reference/blob/2280c4c436f80d04f9c79d3c905db00ac2902273/osu!common/Helpers/GeneralHelper.cs#L410-L423
  
  The control character check is a bit gratuitous (text boxes will already
  not allow insertion of those, see
  https://github.com/ppy/osu-framework/blob/e05cb86ff64abd343de49a143ada9734fd160a0a/osu.Framework/Graphics/UserInterface/TextBox.cs#L92),
  but as it's a general helper I figured might as well.

  Bartłomiej Dach · 2025-01-06 14:04:47 +01:00
  3a4497af32
• Don't require track to be playing to fix test failures on some platforms
  Dean Herbert · 2025-01-06 18:27:00 +09:00
  ca9e16387a
• Merge pull request #31386 from peppy/fix-applying-offset

  Fix not being able to apply last play offset after returning to song select

  Dan Balasescu · 2025-01-06 11:40:12 +09:00
  448790a76f
• Merge pull request #31414 from frenzibyte/fix-display

  Fix mobile release dialog obstructed by the software keyboard

  Dean Herbert · 2025-01-05 00:37:29 +09:00
  d6e73d75d2
• Reduce nesting slightly
  Dean Herbert · 2025-01-05 00:32:06 +09:00
  37da72d764
• Ensure intro files exist in storage

  Guards against user interdiction.
  
  See
  [https://discord.com/channels/188630481301012481/1097318920991559880/1324765503012601927](recent)
  but not only case of this occurring.

  Dean Herbert · 2025-01-04 15:27:49 +09:00
  72dfdac2e2
• Add test coverage of user deleting intro files
  Dean Herbert · 2025-01-04 15:26:42 +09:00
  e15978cc65
• Fix mobile release dialog obstructed by the software keyboard
  Salman Alshamrani · 2025-01-03 22:01:06 -05:00
  3fc86f60ee
• Merge pull request #31403 from frenzibyte/mobile-disclaimer
  Dean Herbert · 2025-01-04 02:35:36 +09:00
  b4698851a3
• Localise text
  Dean Herbert · 2025-01-04 01:28:33 +09:00
  2cd86cbf91
• Adjust popup icon animation slightly
  Dean Herbert · 2025-01-04 01:28:09 +09:00
  da85517036
• Make popup body text left aligned when multiple lines of text are provided
  Dean Herbert · 2025-01-04 01:19:56 +09:00
  60fd0be481
• Update copy and require actually clicking button to confirm
  Dean Herbert · 2025-01-04 01:13:03 +09:00
  1d81dade25
• Only flip value if popup was definitely shown
  Dean Herbert · 2025-01-04 00:58:19 +09:00
  97d065d887
• Flip navigation test expectations in line with new behaviour
  Dean Herbert · 2025-01-04 00:55:12 +09:00
  1161b7b3c0
• Move dialog class location
  Salman Alshamrani · 2025-01-03 00:27:26 -05:00
  c40371c052
• Display popup disclaimer about game state and performance on mobile platforms
  Salman Alshamrani · 2025-01-03 00:20:50 -05:00
  039800550c
• Merge pull request #31354 from bdach/show-hit-markers-for-repeats

  Fix slider repeats not properly respecting "show hit markers" setting

  Dean Herbert · 2025-01-02 18:45:55 +09:00
  2d4a3aa4f9
• Add static memory of last applied offset score

  I don't really like adding this new session static, but we don't have a
  better place to put this.

  Dean Herbert · 2025-01-02 16:20:25 +09:00
  2a28c5f4de
• Add test covering required behaviour

  See https://github.com/ppy/osu/issues/30885.

  Dean Herbert · 2025-01-02 16:20:09 +09:00
  2d3595f768
• Revert "Clear previous LastLocalUserScore when returning to song select"

  This reverts commit ced8dda1a2.

  Dean Herbert · 2025-01-02 15:59:00 +09:00
  58dcb25bd5
• Merge pull request #31383 from peppy/editor-toolbar-scrolling-weird

  Always block scroll input above editor toolbox areas

  Dan Balasescu · 2025-01-02 15:11:11 +09:00
  1cb2c86104
• Merge pull request #31381 from peppy/auto-start-10-seconds

  Add auto-start setting for 10 seconds

  Dan Balasescu · 2025-01-02 15:09:23 +09:00
  6546dc0969
• Always block scroll input above editor toolbox areas

  Originally this was an intentional choice (see
  https://github.com/ppy/osu/pull/18088) when these controls were more
  transparent and didn't for a solid toolbox area.
  
  But this is no longer the case, so for now let's always block scroll to
  match user expectations.
  
  Closes #31262.

  Dean Herbert · 2025-01-02 14:31:27 +09:00
  cca63b599e
• Add auto-start setting for 10 seconds

  As touched on in
  https://github.com/ppy/osu/discussions/31205#discussioncomment-11671185.
  
  Doesn't require server-side changes as the server just uses a
  `TimeSpan`.

  Dean Herbert · 2025-01-02 13:06:34 +09:00
  1211f6cf4c
• Merge pull request #31305 from bdach/round-coordinates-on-legacy-export

  Round object coordinates to nearest integers on legacy export rather than truncating

  Dan Balasescu · 2025-01-01 21:05:18 +09:00
  9da27b5fe5
• Merge pull request #31363 from hrfarmer/game-mode
  Dean Herbert · 2025-01-01 11:11:30 +09:00
  8196325815
• Add explanatory note
  Salman Alshamrani · 2024-12-31 20:44:50 -05:00
  3ac2d90f19
• Merge pull request #31342 from minetoblend/feature/speedy-metronome

  Speed up metronome in timing screen when pressing control key

  Bartłomiej Dach · 2024-12-31 14:49:48 +01:00
  2025.101.0 929173c971
• Merge pull request #31362 from CuNO3/master

  Ignore whitespace while 2FA authentication

  Dean Herbert · 2024-12-31 21:14:42 +09:00
  b09a34cfa8
• Consolidate variable
  Dean Herbert · 2024-12-31 21:14:15 +09:00
  6ff3110433
• Add game mode key to plist
  aychar · 2024-12-31 00:29:36 -06:00
  333ae75a82
• Merge branch 'ppy:master' into master
  Unili · 2024-12-31 11:35:55 +08:00
  acd51c8e9d
• Ignore whitespace while 2FA authentication
  CuNO3 · 2024-12-31 10:43:48 +08:00
  22c8229993
• Remove turboweird function and update displayed bpm text
  Marvin Schürz · 2024-12-30 19:12:21 +01:00
  0641d2b510
• Merge pull request #31350 from bdach/fix-slider-drag-marker-blocking-context-menu

  Fix slider end drag marker blocking open of control point piece context menus

  Dean Herbert · 2024-12-30 22:27:30 +09:00
  73083e1337
• Fix slider repeats not properly respecting "show hit markers" setting

  Closes https://github.com/ppy/osu/issues/31286.
  
  Curious on thoughts about how the instant arrow fade looks on
  non-classic skins. On argon it's probably fine, but it does look a
  little off on triangles...

  Bartłomiej Dach · 2024-12-30 13:52:50 +01:00
  06879eee39
• Merge pull request #31287 from stanriders/change-relax-leniency

  Change `OsuModRelax` hit leniency to be the same as in stable

  Dan Balasescu · 2024-12-30 21:42:48 +09:00
  11a4e3beb4
• Merge branch 'master' into fix-slider-drag-marker-blocking-context-menu
  Dan Balasescu · 2024-12-30 21:34:11 +09:00
  643e849029
• Merge pull request #31348 from bdach/fix-slider-quick-delete

  Fix quick-deleting unselected slider path control point also deleting all selected control points

  Dan Balasescu · 2024-12-30 21:33:57 +09:00
  c56a6ed595
• Merge pull request #31352 from bdach/collapse-sample-point-indicators-better

  Take custom bank name length into account when collapsing sample point indicators

  Dan Balasescu · 2024-12-30 21:32:07 +09:00
  ab111178d0
• Take custom bank name length into account when collapsing sample point indicators

  Would close https://github.com/ppy/osu/issues/31312.
  
  Not super happy with the performance overhead of this, but this is
  already a heuristic-based implementation to avoid every-frame
  `.ChildrenOfType<>()` calls or similar, so not super sure how to do
  better. The `Array.Contains()` check stands out in profiling, but
  without it the indicators can collapse *too* eagerly sometimes.

  Bartłomiej Dach · 2024-12-30 12:04:41 +01:00
  693db097ee