8908 Commits

• Merge branch 'master' into fix-results-exit-transition
  Bartłomiej Dach · 2021-06-09 19:40:56 +02:00
  89cdea8123
• Merge pull request #13381 from smoogipoo/improve-hit-error-judgements

  Improve hit error judgement displays

  Dean Herbert · 2021-06-09 19:40:17 +09:00
  b02b8ae2bc
• Add a simple fade to the results screen

  Stops it from immediately disappearing.

  Dean Herbert · 2021-06-09 17:19:37 +09:00
  a65b76bdbf
• Fix results screen changing applied colour to background on exit

  The general rule is that screens should only apply colours and the likes
  on enter / resume, and leave the outwards transition to whatever screen
  is coming next.

  Dean Herbert · 2021-06-09 17:18:55 +09:00
  7b0c5e9d32
• Ensure PlayerLoader restores the background colour to its own value on resume
  Dean Herbert · 2021-06-09 17:17:39 +09:00
  258d05d1e0
• Add safety to ensure background is correct tint when entering gameplay
  Dean Herbert · 2021-06-09 17:07:28 +09:00
  a7ef0173e9
• Ensure background rotation on default skins
  Bartłomiej Dach · 2021-06-09 07:59:47 +02:00
  a801a9a14d
• Reduce unnecessary background changes via IEquatable implementation
  Bartłomiej Dach · 2021-06-08 22:37:18 +02:00
  97204b6f27
• Bring back skin background source
  Bartłomiej Dach · 2021-06-08 22:04:59 +02:00
  a98c302211
• Move skin background to separate file
  Bartłomiej Dach · 2021-06-08 21:57:08 +02:00
  5bf4dd6358
• Add colours for tick judgements
  smoogipoo · 2021-06-08 23:10:21 +09:00
  00efed2c39
• Ignore non-scorable and bonus judgements
  smoogipoo · 2021-06-08 23:09:23 +09:00
  c8e14d7710
• Fix DT being doubled in multiplayer spectator
  smoogipoo · 2021-06-08 22:51:42 +09:00
  c3ea1b26e1
• Fix a similar case with online play sub-screens
  smoogipoo · 2021-06-08 17:54:54 +09:00
  ab9290772b
• Only call OnBackButton() if the screen has finished loading
  smoogipoo · 2021-06-08 17:38:12 +09:00
  860f1aebb3
• Fix possible nullref when exiting song select too fast
  smoogipoo · 2021-06-08 17:03:50 +09:00
  7fa0ac6ed7
• Move empty window check to bar error meter

  It's not valid in the base `HitErrorMeter`, as the colour meter only
  displays colour for a given judgement, so it is still valid to add new
  items to it even if the hit window is 0, as misses are still possible.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  0531c2dcd9
• Add failing assertions to hit error meter test
  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  37d062c7cd
• Fix switching storyboard mode not triggering a reload
  Dean Herbert · 2021-06-07 17:32:04 +09:00
  59130be99c
• Stop BackgroundScreenDefault from reloading beatmap background when already correct
  Dean Herbert · 2021-06-07 17:22:36 +09:00
  f677f9b5f4
• Fix potential race incorrectly pausing the source clock
  smoogipoo · 2021-06-04 21:58:51 +09:00
  009aa994d0
• Merge branch 'master' into fix-spectator-frame-conversion
  Dan Balasescu · 2021-06-04 21:17:40 +09:00
  57a38374db
• Merge pull request #13303 from LeNitrous/mainmenu-storyboard-backgrounds

  Add storyboards as a main menu background source

  Dean Herbert · 2021-06-04 19:50:40 +09:00
  840f084dc4
• Merge branch 'master' into fix-spectator-frame-conversion
  Dean Herbert · 2021-06-04 15:06:15 +09:00
  23096c58bb
• Detach gameplay score from replay recorder before importing

  Closes #13320.

  Dean Herbert · 2021-06-04 02:00:02 +09:00
  d444fed46f
• Apply review fixes
  smoogipoo · 2021-06-03 18:32:05 +09:00
  e887807ae7
• Fix multiple calls to seek method potentially not working
  smoogipoo · 2021-06-03 17:47:22 +09:00
  be03a2d7d2
• Merge branch 'master' into fix-spectator-frame-conversion
  smoogipoo · 2021-06-03 17:42:01 +09:00
  c3280083a2
• Fix seeking to gameplay too soon
  smoogipoo · 2021-06-03 17:38:51 +09:00
  662bbed5d1
• Add framestable-bypassing seek for spectator
  smoogipoo · 2021-06-03 17:27:21 +09:00
  420df124b5
• prevent scaling container from creating a storyboard background
  Nathan Alo · 2021-06-03 13:24:21 +08:00
  d00fb21188
• Merge branch 'master' into autoplay-pause-support
  Dan Balasescu · 2021-06-03 13:26:00 +09:00
  44b1102241
• Fix beatmap statistics with value of zero not displaying correctly at song select

  Closes #13307.

  Dean Herbert · 2021-06-03 01:58:51 +09:00
  d6656047e3
• Remove unnecessary bind in ReplayPlayer
  Dean Herbert · 2021-06-02 18:32:14 +09:00
  e0eb0adb0a
• add new background type in BackgroundScreenDefault
  Nathan Alo · 2021-06-02 15:51:43 +08:00
  dde64adcb5
• Change the way Score is initialised in Player to better lend to population of metadata
  Dean Herbert · 2021-06-02 15:44:04 +09:00
  a15cac6f53
• Merge branch 'master' into autoplay-pause-support
  Dean Herbert · 2021-06-01 16:50:44 +09:00
  289dc00f38
• Fix incorrect beatmap being parsed down for autoplay generation
  Dean Herbert · 2021-06-01 15:44:24 +09:00
  3ba0d29108
• Fix newly found inspections from 2021.1EAP1
  Dean Herbert · 2021-06-01 14:33:21 +09:00
  6ef9b346e1
• Create replay via the ICreateReplay interface instead of explicitly ModAutoplay
  Dean Herbert · 2021-06-01 14:22:16 +09:00
  cbf3ef5400
• Fix potential nullref is beatmap load failed
  Dean Herbert · 2021-06-01 14:19:23 +09:00
  9221213fe5
• Merge branch 'master' into autoplay-pause-support
  Dean Herbert · 2021-06-01 14:19:21 +09:00
  14570b6fb1
• Fix spectator crashing when converting mania replay frames
  smoogipoo · 2021-05-31 19:24:22 +09:00
  7f24518004
• Expose GameplayBeatmap and GameplayRuleset from Player
  smoogipoo · 2021-05-31 19:22:20 +09:00
  d2d0896298
• Merge pull request #13230 from peppy/non-nullable-beatmapset-files

  Make `BeatmapSet.Files` non-nullable

  Dan Balasescu · 2021-05-31 19:10:03 +09:00
  46b6f49a92
• Merge pull request #12826 from frenzibyte/catch-hide-combo-workaround

  Hide legacy HUD combo counters on osu!catch ruleset

  Dean Herbert · 2021-05-31 19:04:25 +09:00
  d1ef5483bc
• ContentVisible -> HiddenByRulesetImplementation
  Salman Ahmed · 2021-05-31 09:24:26 +03:00
  4e186b0cf5
• Remove previous consumption logic in GetWorkingBeatmap

  This should not be required since the introduction of `workingCache`,
  which does the same thing in a more global way.

  Dean Herbert · 2021-05-31 14:11:58 +09:00
  06bd696cc2
• Remove "temporarily"
  Salman Ahmed · 2021-05-31 07:24:59 +03:00
  fb111e23d8
• Add simple xmldoc
  Salman Ahmed · 2021-05-31 00:07:29 +03:00
  3fbd4e276d