Dean Herbert
37e370e654
Fix crash at results screen when hidden is enabled and S rank becomes A due to miss
...
Closes https://github.com/ppy/osu/issues/26692 .
2024-01-25 15:02:44 +09:00
Dean Herbert
0cf90677e6
Apply more correct visual offset adjustment
...
Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>
2024-01-23 19:16:55 +09:00
Bartłomiej Dach
45dc9de1e0
Remove remnant of old implementation of showing "A due to misses"
2024-01-22 19:58:11 +01:00
Dean Herbert
83f9118b22
Adjust results screen to handle S->A rank adjustment when misses are present
2024-01-22 21:43:32 +09:00
Dean Herbert
1cfcaee121
Reorder badges so that SS shows above others
...
This isn't perfect and probably needs much more consideration, but let's
at least give the "better" ranks more visibility by bringing them to the
front.
Of note, this is only important due to the changes to osu!catch
accuracy-grade cutoffs, which brings things closer in proximity than
ever before.
2023-11-29 20:29:52 +09:00
Dan Balasescu
295a1b01d6
Adjust catch score grade cutoffs
2023-11-29 19:05:31 +09:00
Dean Herbert
cf009432cc
Centralise accuracy cutoff constants and add lookup helper methods
2023-02-09 15:41:58 +09:00
Walavouchey
57312279f0
adjust RankNotch gap size to match original value
2023-02-09 02:20:05 +01:00
Walavouchey
fd93bd3f50
move rank accuracy requirements to class-local constants
2023-02-09 00:46:24 +01:00
Walavouchey
ee40444fd3
use Precision.AlmostEquals for bounds check
2023-02-08 23:59:19 +01:00
Walavouchey
0531c010eb
display RankBadges on on their sector centres
...
the D `RankBadge` does this anyway. the A and S badges are slightly off
centre to prevent overlap with the SS badge
2023-02-08 14:01:40 +01:00
Walavouchey
6ace6bfee1
ensure AccuracyCircle doesn't land in gaps created by RankNotches
2023-02-08 13:20:53 +01:00
Andrei Zavatski
97b6d88f00
Remove SmoothCircularProgress usage in AccuracyCircle
2022-12-03 16:39:44 +03:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Salman Ahmed
f958010d29
Fix AccuracyCircle storing accuracy values in float
2022-04-26 04:52:48 +03:00
Susko3
19467e58c1
Remove unused params from BDL methods
2022-01-15 01:06:39 +01:00
Dean Herbert
0667354fbd
Remove unused resolved skin
2021-06-10 17:30:04 +09:00
Dean Herbert
4f8000a574
Combine cases which return the same value
2021-06-10 17:29:36 +09:00
Dean Herbert
31b46afa71
Fix wrong naming scheme for applause samples
2021-06-09 19:35:05 +09:00
Dean Herbert
7d86dafd4f
Simplify tick calculation/playback method
2021-06-09 19:31:53 +09:00
Dean Herbert
57bc34f224
Move consts closer to usage
2021-06-09 19:24:35 +09:00
Dean Herbert
cb4f366651
Move forgotten private function down more
2021-06-09 19:15:55 +09:00
Dean Herbert
81cecac90b
Move tick rate initialisation to earlier
2021-06-09 19:09:00 +09:00
Dean Herbert
499aba95c0
Simplify sample construction logic and move private functions down
2021-06-09 19:06:37 +09:00
Dean Herbert
21a63efd78
Rename variable back to withFlair to match parent class
2021-06-09 18:55:29 +09:00
Dean Herbert
330bb7cb45
Remove unnecessary skin lookup logic
2021-06-09 18:55:29 +09:00
Jamie Taylor
054de675ff
allow skinned 'applause' sample to override results screen sfx
2021-06-03 18:35:55 +09:00
Jamie Taylor
582360d0c8
only load the required impact/applause samples
2021-06-03 18:35:51 +09:00
Jamie Taylor
ed012a724b
refactor from using public variables
2021-06-03 18:35:46 +09:00
Jamie Taylor
8dc595d201
move result screen samples to DefaultSkin
2021-06-03 18:35:27 +09:00
Jamie Taylor
63e5bc4543
update sample names and timings
2021-06-03 18:34:33 +09:00
Jamie Taylor
9ad87ee5dc
add sfx for results screen + sound design tool
2021-06-03 18:34:22 +09:00
Dean Herbert
b2c736b42a
Combine and move const closer to usage
2021-05-19 18:09:46 +09:00
Vinicius Barbosa
d05ffdf120
Added constants for delay value
2021-05-18 20:19:18 +02:00
Vinicius Barbosa
06fffc499b
Removed unused variables and directives
2021-05-18 16:56:07 +02:00
Vinicius Barbosa
76a377f3e0
Fixed applause sound stopping after switching scores
2021-05-18 15:30:45 +02:00
Dean Herbert
f1b8a8f7f5
Remove unused using
2020-10-29 18:16:04 +09:00
Dean Herbert
5d5b0221e5
Add skinning support for legacy applause playback
2020-10-29 16:32:29 +09:00
Dean Herbert
fb82c043a5
Add rank appear sound (new default)
2020-10-29 16:11:37 +09:00
Dean Herbert
a8e9c62583
Make results panels aware of whether they are a local score that has just been set
2020-10-29 16:11:25 +09:00
Joehu
718f06c690
Use Mod.AdjustRank() instead
2020-07-02 12:35:32 -07:00
Joehu
fa252d5e95
Fix score panel not showing silver s/ss badges on hd/fl plays
2020-07-01 17:37:38 -07:00
Dean Herbert
c50784da93
Show 'D' rank badge on accuracy circle
2020-03-19 11:58:52 +09:00
Tina
100c9d422f
Re-use colors defined for each rank in result screen accuracy circle
2020-03-17 18:55:30 +01:00
Dean Herbert
f06c170d63
Display SS badge earlier (when entering virtual ss area)
2020-03-17 18:04:15 +09:00
smoogipoo
dca2e1d816
Implement the accuracy circle
2020-03-17 16:37:56 +09:00
