Dan Balasescu
8f82ceefe8
Merge pull request #13774 from LumpBloom7/fix-incorrect-first-window
...
Fix nested HitWindows not being considered if parent HitWindow is empty
2021-07-05 13:54:00 +09:00
Dan Balasescu
6b76c54aee
Merge pull request #13756 from PercyDan54/playlist-empty-romanised
...
Fix playlist item displays empty string if no unicode title is present
2021-07-05 13:53:50 +09:00
Dan Balasescu
b82afaddc1
Merge pull request #13767 from peppy/fix-realm-refresh-race
...
Fix thread safety of realm `Refresh` operation
2021-07-05 13:53:29 +09:00
Henry Lin
3c37140426
Remove an unused local variable
2021-07-05 09:52:13 +08:00
Henry Lin
bfb603cfeb
Change the test for unimplemented mod to use a mock ruleset and mod
2021-07-05 09:51:24 +08:00
Dan Balasescu
5f10edee39
Merge branch 'master' into playlist-empty-romanised
2021-07-05 10:20:33 +09:00
smoogipoo
cc877f88e2
Fix inspection (create a new ruleset every time)
2021-07-05 10:13:01 +09:00
Derrick Timmermans
1facdcf483
Apply changes to tests
2021-07-04 23:23:24 +02:00
Derrick Timmermans
6d2ffe3a94
Add basic tests
2021-07-04 22:51:35 +02:00
PercyDan54
356f5dceef
Add more test case
2021-07-04 22:34:31 +08:00
PercyDan54
44d540eb53
Add test
2021-07-04 22:09:23 +08:00
Bartłomiej Dach
c143a50b73
Merge branch 'master' into fix-zero-hit-score-submit
2021-07-04 15:31:38 +02:00
Bartłomiej Dach
19f02dc3d9
Ensure tests with no token have at least one hit
...
Because submission can be prevented by both not having been issued a
correct submission token, and by not actually registering any hits in
gameplay, ensure that tests that don't receive a token register at least
one hit, to avoid potentially having test cases that test the "no token"
flow pass erroneously because they never had any hits in the first
place.
2021-07-04 14:34:52 +02:00
Dean Herbert
3ec7dc3bb9
Update tests in line with thread safety check
2021-07-04 17:59:39 +09:00
Dean Herbert
2a74b1c539
Add test coverage of new scenarios
2021-07-04 17:27:02 +09:00
Dean Herbert
ec71deec51
Remove some mentions of "lazer"
...
I am aware there are more throughout the codebase but intentionally left
the remaining mentioned for one reason or another. The intention here is
to mainly change user-facing versioning to change the positioning of the
"lazer" term (to be where we would expect "cuttingedge" or "beta" to
be).
2021-07-04 12:41:27 +09:00
Dean Herbert
b0f257fa04
Merge pull request #13685 from gagahpangeran/wiki-image-block
...
Fix image overflow in wiki overlay
2021-07-02 20:21:20 +09:00
Dan Balasescu
9eb6ae4d45
Merge pull request #13721 from peppy/submit-on-player-exit
...
Submit scores on player exit
2021-07-02 18:25:26 +09:00
Dean Herbert
4e52aee5a0
Merge branch 'master' into wiki-image-block
2021-07-02 18:19:46 +09:00
Dan Balasescu
211c248692
Merge pull request #13744 from peppy/fix-async-void-calls
...
Fix some incorrectly invoked `async` calls
2021-07-02 18:10:30 +09:00
Dean Herbert
d67fc87dcb
Add some basic testability of external colour setting
2021-07-02 17:24:15 +09:00
Dean Herbert
7b0f970e7d
Fix ongoing operation being begun in an async context
2021-07-02 16:09:02 +09:00
Dean Herbert
f2d9d78455
Fix some incorrectly invoked async calls
2021-07-02 14:43:48 +09:00
Dean Herbert
30467191b2
Remove local handling of NoFail addition
2021-07-02 14:21:48 +09:00
Bartłomiej Dach
434c048d87
Merge branch 'master' into colour-picker
2021-07-02 01:03:00 +02:00
dependabot[bot]
0d3de488de
Bump NUnit3TestAdapter from 3.17.0 to 4.0.0
...
Bumps [NUnit3TestAdapter](https://github.com/nunit/nunit3-vs-adapter ) from 3.17.0 to 4.0.0.
- [Release notes](https://github.com/nunit/nunit3-vs-adapter/releases )
- [Commits](https://github.com/nunit/nunit3-vs-adapter/compare/V3.17...V4.0.0 )
---
updated-dependencies:
- dependency-name: NUnit3TestAdapter
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-07-01 17:02:17 +00:00
smoogipoo
4c95af4b16
Add star rating range display
2021-07-01 20:35:31 +09:00
Dean Herbert
a6323b7d87
Use APIException
2021-07-01 17:54:59 +09:00
Dean Herbert
74c63e15be
Mark score failed on fail and exit
2021-07-01 17:48:09 +09:00
Dean Herbert
6e8d4e382e
Add test coverage of token failure scenarios
2021-07-01 17:20:40 +09:00
Dean Herbert
397d2491b3
Update test scenes to actually cover submission logic
2021-07-01 16:55:44 +09:00
Dean Herbert
719852435f
Fix intermittent PerformFromScreen test failures due to incorrect screen sequence
...
These tests were manually pushing the `PlayerLoader` / `Player`
instances to `SongSelect`, which bypasses safeties in place which avoid
the exact issue that came up in https://github.com/ppy/osu/runs/2951759236
(see `AllowSelection` flag specifically).
2021-07-01 15:10:29 +09:00
Bartłomiej Dach
583242d96d
Add osu!-styled colour picker control
2021-06-30 23:25:50 +02:00
Dean Herbert
4a54e7cdb8
Add tests covering score preparation flow
2021-06-30 20:23:24 +09:00
smoogipoo
aa7405afa1
Increase number of sent frames to prevent timing issues
2021-06-30 20:16:57 +09:00
Dean Herbert
4a71a4bb21
Merge pull request #13450 from smoogipoo/spectator-start-at-end-2
...
Start spectator at the end of gameplay
2021-06-30 16:09:35 +09:00
Dean Herbert
094cd31361
Merge pull request #13441 from frenzibyte/ruleset-resources-skin
...
Provide access to ruleset resources during `ISkinSource` lookups
2021-06-30 15:26:37 +09:00
Dean Herbert
741ecbb2df
Merge branch 'master' into spectator-start-at-end-2
2021-06-30 15:06:30 +09:00
Dean Herbert
4337577448
Remove unused private methods
2021-06-30 14:31:27 +09:00
Dean Herbert
a019f2cc5c
Merge branch 'master' into rework-multiplayer-test-scenes
2021-06-30 13:49:05 +09:00
Dean Herbert
825181121d
Merge branch 'master' into spectator-start-at-end-2
2021-06-30 01:50:14 +09:00
Dean Herbert
5031707048
Merge pull request #13690 from smoogipoo/fix-action-posting
...
Fix commands posted to the wrong channel
2021-06-30 00:39:02 +09:00
smoogipoo
331b7237ab
Attempt to fix one more intermittent test failure
2021-06-29 23:02:20 +09:00
smoogipoo
6dd3c6fe93
Make MultiSpectatorScreen and tests more resillient to timing
2021-06-29 22:45:51 +09:00
smoogipoo
1b2d00f796
Trigger successes
2021-06-29 20:13:39 +09:00
Dean Herbert
8bcb4d13fb
Fix multiple tests eating host exceptions
2021-06-29 17:21:09 +09:00
smoogipoo
8e04d73b67
Merge branch 'rework-multiplayer-test-scenes' into spectator-start-at-end-2
2021-06-29 17:06:57 +09:00
smoogipoo
ca0eaab8e2
Add test
2021-06-29 16:30:46 +09:00
smoogipoo
bcdf36e77b
Merge branch 'master' into spectator-start-at-end-2
2021-06-29 15:53:58 +09:00
smoogipoo
92fa99700e
Merge branch 'master' into rework-multiplayer-test-scenes
2021-06-29 15:39:59 +09:00
smoogipoo
06beeee4d8
Cleanup match header test
2021-06-29 15:39:01 +09:00
Gagah Pangeran Rosfatiputra
a1fe9df378
add test to check sprite image width
2021-06-29 10:14:51 +07:00
Dan Balasescu
697b07acb1
Merge branch 'master' into fix-beatmap-import-fk-failure
2021-06-29 11:36:31 +09:00
Gagah Pangeran Rosfatiputra
0e29ae037b
add wide image test
2021-06-28 20:50:29 +07:00
Gagah Pangeran Rosfatiputra
ab977d91f0
fix image test not load
...
looks like forgot to change this after `CurrentPath` shenanigan
2021-06-28 20:40:22 +07:00
Dan Balasescu
92fcf90768
Merge branch 'master' into import-early-checksum-abort
2021-06-28 19:29:08 +09:00
Salman Ahmed
035fe2ad49
Mark ruleset skin provider test scene as headless
2021-06-28 11:29:43 +03:00
Salman Ahmed
177bfe1234
Merge branch 'master' into ruleset-resources-skin
2021-06-28 11:16:37 +03:00
Dean Herbert
a8597b6213
Merge pull request #13658 from frenzibyte/fix-initial-ruleset-skin-loading
...
Fix `RulesetSkinProvidingContainer` being potentially late in setting up skin sources
2021-06-28 17:03:56 +09:00
Dean Herbert
f939e2603a
Merge branch 'master' into localisable-tooltips
2021-06-28 15:29:42 +09:00
Dean Herbert
73bd88cb31
Simplify caching in test
2021-06-28 14:44:52 +09:00
Dean Herbert
fdd6778f36
Merge branch 'master' into fix-initial-ruleset-skin-loading
2021-06-28 14:35:34 +09:00
Dean Herbert
128f08ccba
Fix test oversights
2021-06-28 10:42:28 +09:00
Dan Balasescu
9c0840268a
Merge pull request #13598 from JimmyC7834/supporter-only-filter-content
...
Add supporter required placeholder in beatmap listing overlay
2021-06-28 10:27:56 +09:00
Dean Herbert
90b87cbb9e
Add back unidirectional online id check
2021-06-28 10:11:27 +09:00
Dean Herbert
9a96cd4a1d
Revert "Remove comparison of online beatmap IDs during dedupe checks"
...
This reverts commit 15af28d2a0
2021-06-28 09:54:18 +09:00
Dean Herbert
a1e8cc5444
Merge pull request #13669 from Naxesss/hitsound-checks
...
Add hitsound checks
2021-06-28 03:13:43 +09:00
Naxess
b58644106c
Add nested hitobject tests for few hitsounds check
2021-06-27 15:58:00 +02:00
Naxess
1dbac76da5
Use local variables for common sample lists
2021-06-27 15:57:41 +02:00
Naxess
1d5bff1660
Add concurrent hitobjects test for few hitsounds check
...
See https://github.com/ppy/osu/pull/13669#discussion_r659314980
2021-06-27 15:26:52 +02:00
Naxess
c2ceb83bbb
Move MockNestedHitObject to own class
2021-06-27 15:16:40 +02:00
Dean Herbert
cd9aa38d3d
Add back ignore cases for intentionally broken tests
2021-06-27 20:24:16 +09:00
Dean Herbert
15af28d2a0
Remove comparison of online beatmap IDs during dedupe checks
2021-06-27 14:48:57 +09:00
Naxess
5642d321b7
Fix comments in few hitsounds check tests
2021-06-26 23:43:08 +02:00
Bartłomiej Dach
709e555566
Rename test steps for legibility
2021-06-26 20:27:15 +02:00
Bartłomiej Dach
b7c4fe2052
Rewrite test helpers to also handle clearing filters
2021-06-26 20:25:43 +02:00
Bartłomiej Dach
51888d0d5a
Rename test methods
2021-06-26 20:24:42 +02:00
Naxess
82b64f5589
Add hitsounded with break test
2021-06-26 19:57:12 +02:00
Naxess
a5abc664f3
Add few hitsounds check tests
2021-06-26 19:21:15 +02:00
Naxess
7b9569a117
Add muted object check tests
2021-06-26 19:21:01 +02:00
Gagah Pangeran Rosfatiputra
4df4afe533
add test for overall difficulty filter query
2021-06-26 21:02:57 +07:00
Bartłomiej Dach
50c27d2635
Update usages of IHasTooltip in line with framework localisation changes
2021-06-25 19:10:04 +02:00
smoogipoo
d035633f95
Load participants list after joining room
2021-06-25 20:56:13 +09:00
smoogipoo
3e5ae7ea58
Don't join room in participants test
2021-06-25 20:44:00 +09:00
smoogipoo
1ed61b9b98
Fix up dependencies class names
2021-06-25 20:11:38 +09:00
smoogipoo
57f2b4f812
Fix incorrect parent class
2021-06-25 20:09:03 +09:00
Salman Ahmed
84c9ede966
Fix incorrect pushed changes
...
This should've been in the original commit, but for some reason got
deleted out.
2021-06-25 13:17:15 +03:00
smoogipoo
04cc390c41
Fix TestSceneMultiplayer resolving the wrong client
2021-06-25 19:16:54 +09:00
Salman Ahmed
8387acfe15
Merge branch 'master' into fix-initial-ruleset-skin-loading
2021-06-25 12:22:51 +03:00
Salman Ahmed
ff5e590d32
Add local source for testing
2021-06-25 12:09:07 +03:00
smoogipoo
a27a647ae7
Rename RoomDependencies -> OnlinePlayDependencies
2021-06-25 18:07:47 +09:00
smoogipoo
c0d2b41d4c
Move SpectatorClient into multiplayer dependencies
2021-06-25 17:55:16 +09:00
Dean Herbert
51dd7fc238
Merge pull request #13622 from aitani9/mod-settings-dropdown-height
...
Decrease the max dropdown height in mod settings
2021-06-25 17:42:47 +09:00
smoogipoo
7aefbe3da1
Move UserLookupCache inside dependencies
2021-06-25 17:37:02 +09:00
Salman Ahmed
13ed52a990
Fix weird license misindent
...
No idea how the hell that happened... R# silent about it, of course.
2021-06-25 11:16:29 +03:00
Salman Ahmed
8d7705dc92
Test using a simple GetTexture lookup instead
...
Presumes that `RulesetSkinProvidingContainer` doesn't allow falling back
to parent skins, whatsoever.
2021-06-25 10:55:24 +03:00
Salman Ahmed
06e357647a
OnBdl -> OnLoadAsync
2021-06-25 10:40:42 +03:00
Dean Herbert
5883922177
Remove mod multiplier completely
2021-06-25 16:36:31 +09:00
Salman Ahmed
8241fee4a8
Add failing test case
2021-06-25 10:05:50 +03:00
smoogipoo
d6ab08c958
Remove manual dependencies in TestSceneMultiplayerGameplayLeaderboard
2021-06-25 15:30:28 +09:00
