1998 Commits

• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Fix edge case allowing almost-zero-length sliders to be placed during distance snapping
  Dean Herbert · 2025-03-11 16:17:44 +09:00
  23891b1994
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Mark MathHelper.Clamp() as banned API

  See previous commit for partial rationale.
  
  There's an argument to be made about the `NaN`-spreading semantics being
  desirable because at least something will loudly fail in that case, but
  I'm not so sure about that these days. It feels like either way if
  `NaN`s are produced, then things are outside of any control, and chances
  are the game can probably continue without crashing. And, this move
  reduces our dependence on osuTK, which has already been living on
  borrowed time for years now and is only awaiting someone brave to go
  excise it.

  Bartłomiej Dach · 2025-02-28 13:48:22 +01:00
  35b0ff80bb
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-27 00:08:43 +09:00
  87b6dddd11
• Scale catch down to remain playable on mobile
  Salman Alshamrani · 2025-02-21 01:21:10 +09:00
  440a776bd7
• Fix nudge operations incurring FP error from coordinate space conversions

  Closes https://github.com/ppy/osu/issues/31915.
  
  Reproduction of aforementioned issue requires 1280x720 resolution, which
  should also be a good way to confirm that this does anything.
  
  To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
  because tell me: what on earth was this code ever doing at
  `ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
  doesn't even *make sense* in something like taiko or mania.

  Bartłomiej Dach · 2025-02-17 15:21:07 +01:00
  f37a56c307
• Rename buzz variable per review
  Dean Herbert · 2025-02-10 18:05:08 +09:00
  340e081965
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 14:09:25 +09:00
  6c069b3373
• Refactor IDistanceSnapProvider to accept slider velocity objects as a reference

  Method signatures are also changed to be a lot more explicit as to what
  inputs they expect.

  Bartłomiej Dach · 2025-02-03 14:00:57 +01:00
  a1185df2eb
• Merge pull request #31655 from bdach/deabstractify-editor-snap

  Refactor editor object snapping to remove bad abstractions

  Dan Balasescu · 2025-01-30 01:38:42 +09:00
  48b1c7398e
• Remove "Accuracy" and "Stack Leniency" from osu!catch editor setup
  Dean Herbert · 2025-01-28 21:22:51 +09:00
  1aa1137b09
• Refactor further to avoid weird non-virtual common method
  Bartłomiej Dach · 2025-01-24 13:14:31 +01:00
  daec91f61d
• Remove dependence of placement blueprints on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:07 +01:00
  a6987f5c95
• Remove dependence of blueprint containers on IPositionSnapProvider
  Bartłomiej Dach · 2025-01-24 11:59:05 +01:00
  15b6e28ebe
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-01-21 13:19:01 +09:00
  aeca37c230
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b
• Fix osu!catch "buzz slider" SR abuse (#31126)

  * Implement fix for catch buzz sliders SR abuse
  
  * Run formatting
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Bastien D. · 2025-01-18 22:26:23 +03:00
  67723b3e52
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Add skinnable spectator list to default skins
  Bartłomiej Dach · 2025-01-15 14:29:53 +01:00
  99c7e164dc
• Merge pull request #31446 from EVAST9919/new-combo-editor

  Fix performance degradation while trying to place object with a new combo in the editor.

  Dean Herbert · 2025-01-15 12:56:06 +09:00
  ef7982fbfa
• Merge branch 'master' into new-combo-editor
  Bartłomiej Dach · 2025-01-10 14:13:14 +01:00
  933f5db208
• Merge conditionals
  Bartłomiej Dach · 2025-01-10 14:13:03 +01:00
  0d9a3428ae
• Add combo colour override control to editor

  Closes https://github.com/ppy/osu/issues/25608.
  
  Logic mostly matching stable. All operations are done on `ComboOffset`
  which still makes overridden combo colours weirdly relatively dependent
  on each other rather than them be an "absolute" choice, but alas...
  
  As per stable, two consecutive new combos can use the same colour only
  if they are separated by a break:
  
      https://github.com/peppy/osu-stable-reference/blob/52f3f75ed7efd7b9eb56e1e45c95bb91504337be/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4564-L4571
  
  This control is only available once the user has changed the combo
  colours from defaults; additionally, only a single new combo object
  must be selected for the colour selector to show up.

  Bartłomiej Dach · 2025-01-10 13:40:56 +01:00
  48196949e0
• Merge pull request #31462 from bdach/ternary-button-is-bad

  Simplify editor "ternary button" structure

  Dan Balasescu · 2025-01-10 14:24:41 +09:00
  38d95abc24
• Merge pull request #31453 from bdach/fix-juice-stream-placement-offset

  Fix juice stream placement blueprint being initially visually offset

  Dean Herbert · 2025-01-10 01:51:24 +09:00
  2133ac6d01
• Simplify editor "ternary button" structure

  As I look into re-implementing the ability to choose combo colour for an
  object (also known as "colourhax") from the editor UI, I stumble upon
  these wretched ternary items again and sigh a deep sigh of annoyance.
  
  The structure is overly rigid. `TernaryItem` does nothing that
  `DrawableTernaryItem` couldn't, except make it more annoying to add
  specific sub-variants of `DrawableTernaryItem` that could do more
  things.
  
  Yes you could sprinkle more levels of virtuals to
  `CreateDrawableButton()` or something, but after all, as Saint Exupéry
  says, "perfection is finally attained not when there is no longer
  anything to add, but when there is no longer anything to take away."
  So I'm leaning for taking one step towards perfection.

  Bartłomiej Dach · 2025-01-09 13:41:22 +01:00
  5c8ae6f851
• Fix juice stream placement blueprint being initially visually offset

  - Closes https://github.com/ppy/osu/issues/31423.
  - Regressed in https://github.com/ppy/osu/pull/30411.
  
  Admittedly, I don't completely understand all of the pieces here,
  because code quality of this placement blueprint code is ALL-CAPS
  ATROCIOUS, but I believe the failure mode to be something along the
  lines of:
  
  - User activates juice stream tool, blueprint gets created in initial
    state. It reads in a mouse position far outside of the playfield, and
    sets internal positioning appropriately.
  - When the user moves the mouse into the bounds of the playfield, some
    positions update (the ones inside `UpdateTimeAndPosition()`, but the
    fruit markers are for *nested* objects, and
    `updateHitObjectFromPath()` is responsible for updating those...
    however, it only fires if the `editablePath.PathId` changes, which it
    won't here, because there is only one path vertex until the user
    commits the starting point of the juice stream and it's always at
    (0,0).
  - Therefore the position of the starting fruit marker remains bogus
    until left click, at which point the path changes and everything
    returns to *relative* sanity.
  
  The solution essentially relies on inlining the broken method and only
  guarding the relevant part of processing behind the path version check
  (which is actually updating the path). Everything else that can touch
  positions of nesteds (like default application, and the drawable piece
  updates) is allowed to happen unconditionally.

  Bartłomiej Dach · 2025-01-09 09:37:57 +01:00
  18f1d62182
• Delete entire juice stream when only one vertex remains after deleting another vertex

  Closes https://github.com/ppy/osu/issues/31425.

  Bartłomiej Dach · 2025-01-08 11:47:25 +01:00
  9058fd9739
• Fix combo properties multiple reassignments
  Andrei Zavatski · 2025-01-07 14:00:31 +03:00
  8f4eafea4e
• Add setters to hitobject coordinate interfaces
  Bartłomiej Dach · 2024-12-27 11:01:47 +01:00
  0d16ed028b
• Add comments backreferences to copies of duplicated code for future use
  Bartłomiej Dach · 2024-12-11 16:26:11 +09:00
  5a0b732ee3
• Merge branch 'master' into catch-convert-to-stream
  Bartłomiej Dach · 2024-12-11 16:24:45 +09:00
  1f43ad3928
• Do not show distance to next/previous object if said object is a banana shower

  The results of such a display were a little bit nonsensical.

  Bartłomiej Dach · 2024-11-21 12:17:43 +01:00
  2138729c02
• Align inspector info more to how it is shown for osu
  Darius Wattimena · 2024-11-19 19:54:12 +01:00
  a8e14b6625
• Added a custom hitobject inspector for catch additionally show the x value of prev and next
  Darius Wattimena · 2024-11-18 23:53:01 +01:00
  111f029ead
• Made reading of ReadCurrentDistanceSnap public
  Darius Wattimena · 2024-11-18 23:49:40 +01:00
  16158710f9
• Change text to stream instead of fruits as that is the term by catch mappers
  Darius Wattimena · 2024-11-18 22:30:15 +01:00
  00e3b20ff0
• Adds an option to the catch editor to convert sliders to fruits
  Darius Wattimena · 2024-11-18 22:19:08 +01:00
  5ac3bb73ee
• Merge branch 'master' into resizable-catcher
  Bartłomiej Dach · 2024-11-01 13:08:06 +01:00
  37c2ab9e6f
• Use alternative method of resizing the catcher trails

  This one preserves the catcher afterimage, which I'd count as a win.

  Bartłomiej Dach · 2024-11-01 13:07:32 +01:00
  488fabcd54
• Hide the after image instead as the effect can't be resized easily
  Darius Wattimena · 2024-10-24 23:40:23 +02:00
  2b14d78f04
• Apply code feedback and also resize catcher trails when any is shown
  Darius Wattimena · 2024-10-24 23:17:47 +02:00
  5e642cbce7
• Merge branch 'master' into auto-addition2
  Dean Herbert · 2024-10-23 15:53:07 +09:00
  5939c78760
• Fix an issue where changing the CircleSize wouldn't adjust the catcher size and represent hyperdashes incorrectly
  Darius Wattimena · 2024-10-15 21:47:22 +02:00
  b75437ee13
• Ensure columns collapse into one correctly if no space
  Bartłomiej Dach · 2024-10-03 15:01:23 +02:00
  1bab2236fe
• Redo the layout of sections based on discord feedback

  See
  https://discord.com/channels/188630481301012481/188630652340404224/1291358770064130140
  and everything after.

  Bartłomiej Dach · 2024-10-03 13:53:21 +02:00
  99eb26b7d5
• Fix banana override
  Dean Herbert · 2024-10-01 16:48:20 +09:00
  861da968d4