Alden Wu
9d54467145
Make smoke skinnable lifetime more robust
2022-10-05 19:13:06 -07:00
Alden Wu
49e023f861
Rename OsuSkinComponents.SmokeTrail to CursorSmoke
2022-10-05 19:11:38 -07:00
Alden Wu
2c0cd9ea52
Add more smoke tests
2022-10-05 19:09:34 -07:00
ekrctb
2a7476cc4a
Add test for timeline drag selection
2022-10-05 23:29:45 +09:00
ekrctb
b0213c29e9
Use mid time instead of start time
...
It is closer to the old blueprint-based behavior
2022-10-05 22:19:22 +09:00
ekrctb
6753f6b01a
Move AllowDeselectionDuringDrag down
...
Because it is now ignored in the timeline implementation anyways
2022-10-05 22:14:11 +09:00
ekrctb
3108c42ece
Fix inspect issues
2022-10-05 22:04:43 +09:00
ekrctb
00b3d97f69
Improve timeline selection performance
...
But selecting a large number of hit objects is still very slow
because all DHOs must be added
and also `AddBlueprintFor` has quadratic behaviors
2022-10-05 21:58:05 +09:00
ekrctb
0613388aaa
Make sure all selected items get deleted
2022-10-05 21:58:05 +09:00
ekrctb
0ffde02f79
Use hit object time for timeline selection
2022-10-05 21:51:01 +09:00
ekrctb
8d29e9e76b
Move selection logic from DragBox to BlueprintContainer
2022-10-05 21:51:01 +09:00
Dan Balasescu
35d04fe33c
Merge pull request #20582 from peppy/fix-being-playing-unobserved
...
Silence unobserved exceptions in `BeginPlayingInternal`
2022-10-05 20:51:55 +09:00
Dan Balasescu
c52ddb0e50
Merge pull request #20570 from ekrctb/scrolling-lifetime
...
Compute lifetime start from entry for scrolling hit objects
2022-10-05 20:45:43 +09:00
Dan Balasescu
234c6ac799
Pin taiko PP calculator accuracy to osu-stable values
2022-10-05 20:21:15 +09:00
Dean Herbert
590af4cb7c
Merge branch 'master' into argon-mania
2022-10-05 19:37:59 +09:00
Dan Balasescu
b6db36dcca
Merge pull request #20580 from peppy/approach-circle-fade-out
...
Hide approach circles immediate on successful hit
2022-10-05 19:17:57 +09:00
Dean Herbert
365a78d358
Merge branch 'master' into smoke
2022-10-05 18:58:18 +09:00
Dean Herbert
64858cfb8e
Update resources
2022-10-05 18:55:49 +09:00
Dean Herbert
8f0ef99e10
Privatise some fields
2022-10-05 18:54:14 +09:00
Dean Herbert
bd82dfc333
Remove custom radius implementation
2022-10-05 18:53:07 +09:00
Dan Balasescu
52dfca48b9
Merge pull request #20564 from peppy/fix-gameplay-leaderboard-overlap
...
Adjust leaderboard score panels sizing based on accuracy/combo width
2022-10-05 18:52:11 +09:00
Dean Herbert
91d877e893
Set LifetimeEnd once rather than computing on every access
2022-10-05 18:52:01 +09:00
Dean Herbert
71edd314b1
Simplify SmokeContainer lifetime logic
2022-10-05 18:51:02 +09:00
Dan Balasescu
61753ac809
Merge pull request #20572 from peppy/add-osu-hit-object-dim
...
Add osu! hit object dim
2022-10-05 18:46:11 +09:00
Dean Herbert
6628ab5190
Refactor to avoid DI / event flow
...
There's always one active smoke segment and it's the direct child of
`SmokeContainer`. This can be simplified as such.
2022-10-05 18:37:14 +09:00
Dean Herbert
1e5ff2679b
Rename classes to better emphasise that Smoke is a single trail segment
2022-10-05 18:29:16 +09:00
Dean Herbert
04abb2ce8f
Update default cursor smoke implementation to use a texture
2022-10-05 18:26:17 +09:00
Dean Herbert
52002d91dd
Only apply dim at top level objects
2022-10-05 17:48:56 +09:00
Dean Herbert
74db42394a
Silence unobserved exceptions in BeginPlayingInternal
...
Closes #20526 .
2022-10-05 14:31:13 +09:00
Dean Herbert
56d424003d
Fix sliders not dimming correctly due to modified miss window
2022-10-05 14:25:04 +09:00
Dean Herbert
276021dd85
Remove now unnecessary ScheduleAfterChildren
2022-10-05 14:20:01 +09:00
Dean Herbert
e06ece7531
Update framework
2022-10-05 14:19:51 +09:00
Dean Herbert
c7d645b086
Merge branch 'master' into fix-gameplay-leaderboard-overlap
2022-10-05 14:15:50 +09:00
Dean Herbert
44b99444a7
Hide approach circles immediate on successful hit
2022-10-05 13:42:04 +09:00
Dan Balasescu
d9c3f5834c
Merge pull request #20567 from peppy/fix-show-replay-crash
...
Fix potential crash when attempting to display an imported score at song select
2022-10-04 19:46:15 +09:00
Dean Herbert
d3f1d387ef
Merge pull request #20506 from smoogipoo/intel-exclusive-warning
...
Always show exclusive fullscreen as enabled on Intel platforms
2022-10-04 19:39:13 +09:00
Dean Herbert
75b9bf2cf9
Merge branch 'master' into intel-exclusive-warning
2022-10-04 19:02:01 +09:00
Dan Balasescu
7293ad751e
Update packages
2022-10-04 18:59:35 +09:00
Dan Balasescu
41082ab928
Fix misplaced parenthesis
2022-10-04 18:21:29 +09:00
Dean Herbert
c2956c6e1e
Add osu! hit object dim
...
Stable would dim objects when they can't be hit (ie. the "miss" window
is not active yet). This was never implemented in lazer, and causes
quite large visual differences.
No one has mentioned this yet, but it will definitely be one of those
missing pieces which makes lazer feel different to stable.
2022-10-04 17:28:17 +09:00
Alden Wu
33f33a6845
Remove things that should've been removed before push
2022-10-04 00:53:03 -07:00
Dean Herbert
395ab58892
Attempt to fix code style infractions
2022-10-04 16:17:38 +09:00
Alden Wu
b0a948df45
Move LegacySmoke animation implementation to Smoke
2022-10-04 00:17:00 -07:00
Dean Herbert
345430ab39
Fix argon hit target area not being aligned correctly
2022-10-04 16:16:09 +09:00
ekrctb
15d159a97e
Fix tests
2022-10-04 16:10:18 +09:00
Dean Herbert
1ffa0afafc
Tweak visuals and fix up code quality
2022-10-04 16:05:36 +09:00
Dean Herbert
c44e99d6c4
Merge pull request #20569 from smoogipoo/fix-deadlock
...
Attempt to fix deadlock in `TestSceneOnlinePlayBeatmapAvailabilityTracker`
2022-10-04 15:39:21 +09:00
ekrctb
2aa4d21c75
Remove code that is not needed anymore
2022-10-04 15:17:14 +09:00
ekrctb
1cccd03480
Fix scrolling nested hit object lifetime not set
2022-10-04 15:17:14 +09:00
ekrctb
781f5420b0
Add test for scrolling hit object lifetime
2022-10-04 15:17:11 +09:00
