Owen Young
fc632fd48a
Added WindowSetting setting to OsuSetting enum so that it can be set by default at startup. Modified LayoutSettings.cs so that when it is changed in the settings, it is written to the local settings as well.
2021-03-22 01:30:20 -05:00
Dean Herbert
073dba5330
Remove local workarounds to attempt to avoid crashes on skin change
2021-03-22 14:05:37 +09:00
owen-young
f7bf23dbe9
first attempt at changing windowMode to be fullscreen on default
2021-03-21 21:50:19 -05:00
Joehu
9bc6cdf042
Fix singular format regression on forum post text
2021-03-21 11:19:07 -07:00
Joehu
e31d583a7f
Add comments count to user profile overlay
2021-03-21 11:16:59 -07:00
Bartłomiej Dach
a16c0641b2
Revert EF Core to version 2.2
...
This reverts commit f3faad74d5712e7bc7bf
2021-03-21 11:05:15 +01:00
Bartłomiej Dach
86b569f5f7
Fix typo in identifier
2021-03-20 12:37:51 +01:00
Bartłomiej Dach
d28bed6ed2
Schedule adding transforms on tablet changes
...
Fixes `InvalidThreadForMutationException`s that pop up when
disconnecting/reconnecting tablets during the game's operation. In those
cases the value change callback executes from an OpenTabletDriver
thread.
2021-03-20 12:37:48 +01:00
Dean Herbert
b9b351311a
Merge pull request #11824 from peppy/fix-unsafe-skinnable-sample-play
...
Fix playing skinned samples being unsafe during skin changes
2021-03-20 11:29:34 +09:00
Dean Herbert
ca943a897a
Fix back to front initialisation order
2021-03-20 10:51:58 +09:00
Bartłomiej Dach
dd48b68f8a
Ensure selected blueprints are given selection priority
2021-03-19 22:44:33 +01:00
Dean Herbert
71a361337d
Add comment regarding usage of Reverse()
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-03-19 21:57:48 +09:00
Dan Balasescu
d54e9ab481
Merge pull request #12077 from peppy/tablet-configuration
...
Add tablet configuration section
2021-03-19 21:49:32 +09:00
Dan Balasescu
5a6ff53837
Merge pull request #12073 from peppy/fix-crash-toggle-overlay-before-loaded
...
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 21:38:47 +09:00
Dean Herbert
03592fa696
Merge branch 'master' into realm-migration-operation-blocking
2021-03-19 21:33:26 +09:00
Dan Balasescu
e72205eea2
Merge pull request #12080 from peppy/add-25-playback-editor
...
Change editor speed adjust to adjust frequency (and restore 25% option)
2021-03-19 21:04:12 +09:00
Dean Herbert
68aaf90702
Fix disposal rather than performing some weird hack
2021-03-19 20:30:52 +09:00
Dean Herbert
f59327cc3e
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-19 20:29:44 +09:00
Dean Herbert
b2d8db3a92
Rename incorrect variable
2021-03-19 20:25:21 +09:00
Dean Herbert
63cbac3bd0
Ensure aspect ratio slider gets an initial value
2021-03-19 20:15:29 +09:00
Dean Herbert
6f32c302eb
Add checkbox to optionally disable tablet handling
2021-03-19 20:13:51 +09:00
Dan Balasescu
4da9089b00
Merge branch 'master' into tablet-configuration
2021-03-19 20:09:25 +09:00
Dean Herbert
095b7f8668
Rewrite code to account for non-loaded edge case
2021-03-19 20:09:12 +09:00
Dean Herbert
4795170c60
Add back the default json converter locally to ensure it's actually used
2021-03-19 20:07:13 +09:00
Dean Herbert
86b229b1c9
Increase maximum usable aspect ratio to account for ultrawide monitors
2021-03-19 20:05:18 +09:00
Dean Herbert
8955071703
Change editor speed adjust to adjust frequency
2021-03-19 20:01:45 +09:00
Dean Herbert
9be7981e0d
Adjust timeline ticks to be more visible
2021-03-19 19:45:00 +09:00
Dean Herbert
c0c8b3e46c
Fix regression meaning SkinnableSound initialisation may never happen
2021-03-19 19:22:50 +09:00
Dean Herbert
bd1e2da1c2
Always hide other overlays, even if the new one is not loaded
2021-03-19 19:09:39 +09:00
Dan Balasescu
0736679016
Merge pull request #12072 from peppy/include-default-skin-in-random-rotation
...
Include the bundled skins when selecting a random skin
2021-03-19 19:08:42 +09:00
Dean Herbert
baf4e4e8f6
Merge branch 'master' into tablet-configuration
2021-03-19 19:06:58 +09:00
Dean Herbert
fefb007805
Remove no longer relevant comment
2021-03-19 19:01:32 +09:00
Dean Herbert
1e82033c84
Move bindings to LoadComplete to avoid cross-thread issues
2021-03-19 19:01:32 +09:00
Dean Herbert
b1c4ac9f42
Remove local implementation of Vector2Converter
...
This has been moved to framework in
https://github.com/ppy/osu-framework/pull/4285 .
2021-03-19 19:01:32 +09:00
Dean Herbert
c624aa9397
Only update tablet values on commit
2021-03-19 19:01:32 +09:00
Dean Herbert
6285dcd1a1
Add arbitrary value to fix FP contains check failures
2021-03-19 19:01:32 +09:00
Dean Herbert
e8c20bdcb1
Add centre crosshair
2021-03-19 19:01:32 +09:00
Dean Herbert
fb7d095e4a
Show aspect ratio for current usable area
2021-03-19 19:01:32 +09:00
Dean Herbert
196f95ae54
Update to use new bindables and centered area offset
2021-03-19 19:01:32 +09:00
Dean Herbert
9d0c8902a6
Fix margins and spacing between sub flowed items
2021-03-19 19:01:32 +09:00
Dean Herbert
d422a65900
Fix initial tablet size not being initialised
2021-03-19 19:01:32 +09:00
Dean Herbert
9a6a0f3df5
Add test coverage and better UI handling of no tablet connected scenario
2021-03-19 19:01:32 +09:00
Dean Herbert
bba25a0182
Tidy up draw hierarchy and bindable logic
2021-03-19 19:01:31 +09:00
Dean Herbert
932745e5c4
Fix remaining feedback loops
2021-03-19 19:01:31 +09:00
Dean Herbert
e3bed4c97d
Simplify aspect ratio application, add window conforming and direct adjustment
2021-03-19 19:01:31 +09:00
Dean Herbert
43359553c1
Add aspect ratio display and limiting
2021-03-19 19:01:31 +09:00
Dean Herbert
9b70f0ee1f
Tidy up visual appearance of settings and add a reset button
2021-03-19 19:01:31 +09:00
Dean Herbert
2dc2cb04c3
Fix bounds check becoming false when using full area
2021-03-19 19:01:31 +09:00
Dean Herbert
382109c7a2
Make test scene feel more like settings (width-wise)
2021-03-19 19:01:31 +09:00
Dean Herbert
464702182d
Consume device name
2021-03-19 19:01:31 +09:00
Dean Herbert
94f184d113
Add feedback when area extends beyond tablet size
2021-03-19 19:01:31 +09:00
Dean Herbert
0a6525baee
Fix slider bars reloading each time the tablet size is changed
2021-03-19 19:01:31 +09:00
Dean Herbert
926e40925e
Add exclude rule to fix dynamic compilations issues with settings sections
2021-03-19 19:01:31 +09:00
Dean Herbert
3b7edf1333
Make tablet display always fit to size of settings area
2021-03-19 19:01:31 +09:00
Dean Herbert
d026c8da85
Initial pass of configuration interface
2021-03-19 19:01:31 +09:00
Dean Herbert
563a0584d5
Implement editor timeline stacking support
2021-03-19 18:48:51 +09:00
Dean Herbert
32c571fc94
Adjust keyboard step to be something sensible
2021-03-19 17:13:30 +09:00
Dean Herbert
0195d654ca
Increase the precision of speed multiplier to match osu-stable
2021-03-19 17:09:49 +09:00
Dean Herbert
a9c4fa442a
Avoid potential crash if an overlay is toggled before it has been loaded
2021-03-19 16:49:09 +09:00
Dean Herbert
711d895a04
Merge pull request #8238 from voidedWarranties/editor-song-end
2021-03-19 16:32:23 +09:00
Dean Herbert
9491e6394a
Include the bundled skins when selecting a random skin
2021-03-19 15:46:43 +09:00
Dean Herbert
bf4317d3f0
Ensure looping is disabled on old samples when switching skins
2021-03-19 15:34:21 +09:00
Dean Herbert
0e821e857e
Remove unnecessary duplicated skin changed handling
...
For some reason we were handling this both in `DrawableSkinnableSound`
and `PoolableSkinnableSample` in very similar ways. Only one seems
required.
2021-03-19 15:23:32 +09:00
voidedWarranties
b9761c8196
Further simplify logic
2021-03-18 16:20:31 -07:00
Bartłomiej Dach
b419d2c2e2
Fix invalid xmldoc indent
2021-03-18 19:52:38 +01:00
Bartłomiej Dach
aec859b4d1
Merge branch 'master' into fix-unsafe-skinnable-sample-play
2021-03-18 19:51:46 +01:00
Dan Balasescu
d9ec3c327e
Merge branch 'master' into input-handler-configuration
2021-03-18 22:17:48 +09:00
Dean Herbert
a8cc3a3b44
Implement enable state changes locally for InputHandlers which should be toggleable
2021-03-18 21:17:04 +09:00
Dean Herbert
c694deb7d6
Revert changes to SettingsSourceAttribute class
2021-03-18 21:16:50 +09:00
smoogipoo
917717686a
Expand explanatory comment
2021-03-18 19:26:29 +09:00
smoogipoo
b68dc686ee
Fix converted mania scores not accounting for GREATs
2021-03-18 19:19:53 +09:00
Dan Balasescu
53ae24db9b
Merge pull request #12058 from peppy/fix-whitespace-in-ini
...
Fix skin parser not stripping whitespace before parsing
2021-03-18 18:46:28 +09:00
Dean Herbert
5b0d75ee56
Only trim trailing spaces to avoid breakage in storyboard parsing
2021-03-18 16:30:30 +09:00
Dean Herbert
bb3c3f302a
Fix skin parser not stripping whitespace before parsing
2021-03-18 15:36:11 +09:00
Dan Balasescu
b3e96c8385
Merge pull request #12043 from bdach/fix-reverse-crash
...
Fix selection box operation hotkeys not registering in change handler
2021-03-18 13:30:33 +09:00
voidedWarranties
df6570ebf5
Improve logic and add previously failing test
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-17 15:48:55 -07:00
Bartłomiej Dach
f95ce90c95
Adjust kudosu count formatting
2021-03-17 23:32:08 +01:00
Joehu
08ffe425f9
Update kudosu description color in line with web
2021-03-17 14:46:23 -07:00
Bartłomiej Dach
2e63c2ce20
Fix selection box operation hotkeys not registering in change handler
...
Could lead to crashes after reversing a note cluster and playing it
back.
The root cause of the crash was that the hotkey operations were not ran
inside of an editor change handler operation. This, in turn, caused the
autoplay replay to not be regenerated after flipping an object cluster,
therefore finally manifesting as a hard crash due to negative time
offsets appearing in judgement results, which interfered with the
default implementation of note lock.
Note that this incidentally also fixes the fact that selection box
hotkey operations (reverse and flip) did not handle undo/redo.
2021-03-17 22:17:42 +01:00
Joehu
599c55fca5
Update total kudosu earned description text in line with web
2021-03-17 13:22:00 -07:00
Joehu
6cea74f0fa
Remove available kudosu section from user profile overlay in line with web
2021-03-17 13:21:41 -07:00
Bartłomiej Dach
a691291ae8
Merge branch 'master' into editor-song-end
2021-03-17 18:18:19 +01:00
Dan Balasescu
5a7e416495
Merge pull request #12027 from peppy/new-beatmap-empty-fields
...
Don't fill beatmap metadata with template values on creating a new beatmap
2021-03-17 19:36:21 +09:00
Nathan Alo
51e0304c54
properly format strings per ruleset
2021-03-17 18:31:09 +08:00
Nathan Alo
133ff085a5
refactor code
2021-03-17 18:06:40 +08:00
Nathan Alo
8046b5a818
set text to platform clipboard on copy
2021-03-17 17:35:49 +08:00
Dean Herbert
e0c0107461
Merge branch 'update-config-usages' into input-handler-configuration
2021-03-17 18:08:13 +09:00
Dean Herbert
fccd495f27
Remove obsoleted setting for now
2021-03-17 18:07:51 +09:00
Dean Herbert
577d40d8d1
Update framework
2021-03-17 18:05:18 +09:00
Dean Herbert
249ab8ab3d
Merge branch 'master' into input-handler-configuration
2021-03-17 18:05:14 +09:00
Dean Herbert
a1a0074c32
Revert "Local framework"
...
This reverts commit b9b095ee75
2021-03-17 18:05:11 +09:00
Dean Herbert
d0e61e5b4d
Put back the label
2021-03-17 17:14:04 +09:00
Dean Herbert
3b6a1180b6
Remove non-accessed field
2021-03-17 17:02:11 +09:00
Dean Herbert
5adc675862
Focus artist textbox on entering song setup if fields are empty
2021-03-17 16:57:14 +09:00
Dean Herbert
26d6f96c4e
Fix LabelledTextBox not correctly forwarding focus to its underlying TextBox component
2021-03-17 16:56:58 +09:00
Dean Herbert
eda891223c
Start the editor with empty artist/creator/difficulty name fields
2021-03-17 16:47:12 +09:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
Dean Herbert
c7740d1181
Fix opening the editor occasionally causing a hard crash due to incorrect threading logic
...
Setting one of the global screen `Bindable`s (in this case, `Beatmap`)
is not valid from anywhere but the update thread. This changes the order
in which things happen during the editor startup process to ensure
correctness.
Closes #11968 .
2021-03-17 15:52:25 +09:00
smoogipoo
b495504cae
Merge branch 'master' into fix-mouse-disable-default-indicator
2021-03-16 10:58:56 +09:00
smoogipoo
da3dc61aae
Remove newline
2021-03-16 10:58:42 +09:00
Joehu
393f1fbd3f
Remove skype
2021-03-15 10:07:50 -07:00
Dean Herbert
f3faad74d5
Merge pull request #12003 from UselessToucan/ef_core_5
2021-03-15 15:05:32 +09:00
Joehu
3dd72d6f7d
Fix disable mouse buttons setting not showing default indicator when using keybind
2021-03-14 22:47:05 -07:00
Dean Herbert
1e519f0d31
Fix seemingly innocent logic change causing breakage in score imports
2021-03-15 14:20:59 +09:00
Dean Herbert
6d4c1ba2ae
Fix a couple of new inspections introduced in Rider EAPs
2021-03-15 13:35:08 +09:00
Dean Herbert
fce21f23d6
Add comments marking workarounds required for EFcore 5
2021-03-15 13:29:26 +09:00
Dean Herbert
2904f479c6
Share file lookup workaround in ArchiveModelManager with workaround extensions class
2021-03-15 13:26:14 +09:00
Dean Herbert
79d3379f55
Reformat application of configuration
2021-03-15 13:20:22 +09:00
Dean Herbert
8a35533889
Add fall-through case to catch a potential requery for unsupported model type
2021-03-15 13:11:58 +09:00
Dean Herbert
2bdffd1004
Move skin requery logic into extension methods
2021-03-15 13:11:58 +09:00
Dean Herbert
900da7b891
Rename and refactor extenion methods to be easier to read
2021-03-15 13:11:58 +09:00
Roman Kapustin
28ef64b62a
Explicitly specify SingleQuery behavior
2021-03-14 21:43:27 +03:00
Roman Kapustin
0a1e325fc7
Extract requerying of navigational properties from DbContext
2021-03-14 19:34:53 +03:00
Bartłomiej Dach
6438a7ee12
Merge branch 'master' into user-hide-toolbar-forever
2021-03-13 17:31:37 +01:00
Dean Herbert
a227b0a581
Build on xmldoc with rationale
2021-03-13 23:29:47 +09:00
Dean Herbert
e70ba2d005
Remove unnecessary second variable
2021-03-13 23:29:01 +09:00
Dean Herbert
4afbccfcff
Fix initial operation potentially running before DI is completed
2021-03-13 19:30:40 +09:00
Dean Herbert
b13f193c8d
Fix incorrect task being returned for changelog continuations
2021-03-13 19:26:38 +09:00
Joehu
0ba5312a40
Move blocking show logic to UpdateState
2021-03-13 00:05:26 -08:00
Joehu
5999e4ba33
Add xmldoc for hiddenbyuser bool
2021-03-12 20:18:32 -08:00
Salman Ahmed
43c1e1d217
Update existing usages
...
Resolve post-conflict issues
2021-03-13 06:09:07 +03:00
Salman Ahmed
2a2ee3fa5e
Update legacy sprite text constructor
2021-03-13 06:05:36 +03:00
Salman Ahmed
64d1cb5193
Remove text skin components in favour of plain LegacySpriteTexts
2021-03-13 06:05:36 +03:00
Salman Ahmed
91741564e8
Add legacy font enum and extensions
2021-03-13 06:05:36 +03:00
Salman Ahmed
115c186cb7
Move hit circle font from osu! ruleset
2021-03-13 06:05:36 +03:00
Joehu
62f2a823f6
Hide toolbar forever when the user hides it
2021-03-12 15:48:50 -08:00
Joehu
6c0734a09f
Handle global action in toolbar instead of osugame
2021-03-12 15:48:49 -08:00
Dean Herbert
86164c027a
Update the method we use to reset input settings
2021-03-12 18:44:10 +09:00
Dean Herbert
3458dcc33a
Use whitelist to avoid exposing settings to user that shouldn't be
2021-03-12 18:40:38 +09:00
Dean Herbert
03230edcb1
Update bindings settings to handle the new structure and show all handlers
2021-03-12 18:38:16 +09:00
Dean Herbert
8635abbc4a
Add the ability to not get controls for disabled bindables
2021-03-12 18:37:55 +09:00
Dean Herbert
3c21c83cc8
Rename KeyboardSection to BindingSection
2021-03-12 18:36:28 +09:00
Dean Herbert
4374e7da81
Convert bindable names to human readable sentences
2021-03-12 18:34:22 +09:00
Dean Herbert
a33ffd56b8
Allow CreateSettingsControls to work with all bindables in target class
2021-03-12 18:34:22 +09:00
Dean Herbert
b9b095ee75
Local framework
2021-03-12 18:34:22 +09:00
Dean Herbert
e7707eee94
Switch RestoreDefaultsValueButton to use HasPendingTasks to avoid tooltip always showing
2021-03-12 15:23:11 +09:00
Roman Kapustin
a60ff80c04
Use expression body in ModsJson get accessor
2021-03-12 00:02:29 +03:00
Roman Kapustin
5a4b0174b1
Ignore MultipleCollectionIncludeWarning
2021-03-11 22:40:35 +03:00
Roman Kapustin
d2f943395d
Hotfix importing scores from stable
2021-03-11 22:12:47 +03:00
Roman Kapustin
c6c616f244
Actualize tests
2021-03-11 21:02:40 +03:00
Roman Kapustin
47b80d2474
Workaround InvalidOperation exceptions
2021-03-11 20:51:54 +03:00
Roman Kapustin
f1302d1600
Update Microsoft.EntityFrameworkCore
2021-03-11 19:23:56 +03:00
Dan Balasescu
023af75cc3
Merge branch 'master' into fix-storyboard-alpha-start-time-woes
2021-03-11 22:09:56 +09:00
Dean Herbert
efb4a366d4
Fix xmldoc explaining incorrect behaviour
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2021-03-11 12:15:59 +09:00
Dean Herbert
8aaba32431
Fix storyboard commands occurring before the earliest point of visibility delaying gameplay
...
In osu-stable, storyboard intros start from the first command, but in
the case of storyboard drawables which have an initial hidden state, all
commands before the time at which they become visible (ie. the first
command where `Alpha` increases to a non-zero value) are ignored.
This brings lazer in line with that behaviour. It also removes several
unnecessary LINQ calls.
Note that the alpha check being done in its own pass is important, as
it must be the "minimum present alpha across all command groups,
including loops". This is what makes the implementation slightly
complex.
Closes #11981 .
2021-03-09 15:55:12 +09:00
Dean Herbert
dc9028d24a
Update framework
2021-03-09 14:27:29 +09:00
Dean Herbert
9b5d11f2a5
Merge pull request #11958 from bdach/ruleset-filter-v3
...
Allow rulesets to specify custom song select filtering criteria
2021-03-08 23:23:24 +09:00
Dan Balasescu
ff2327ffac
Merge branch 'master' into configure-await-false
2021-03-08 22:24:29 +09:00
Dean Herbert
b1cd01ceb8
Apply ConfigureAwait changes to game side
2021-03-08 14:36:35 +09:00
Dean Herbert
765cc5cf37
Remove iOS multiplayer blocking code
2021-03-08 14:35:22 +09:00
