Naxess
6d50d01186
Make IssueTemplate.Check
readonly
2021-04-12 16:23:05 +02:00
Naxess
caaaba5950
Rename Check
-> ICheck
2021-04-12 16:20:53 +02:00
Naxess
008dbc7dd6
Reverse IssueType
ordering
...
Reversed both in the enum and where it's displayed, so ends up the same in the end.
2021-04-12 15:49:13 +02:00
Naxess
1c69829ad4
Fix Template.Origin
-> Check
2021-04-12 15:47:58 +02:00
Naxess
7c4f6d2b62
Rework template usage
...
Includes moving the origin check back to templates, constructing nested template classes in each check, and making parameterized template usage.
2021-04-12 15:47:26 +02:00
Naxess
a2fc9c398f
Rename CreateChecker
-> CreateBeatmapVerifier
2021-04-12 10:08:30 +02:00
Naxess
65ebdd8f7a
Move check origin from IssueTemplate
to Issue
...
As a result we can also make check an interface, and need to provide the check itself when constructing an issue.
2021-04-12 10:08:08 +02:00
Dean Herbert
42604afcdc
Add binding for verify mode (and move enum entry to end)
2021-04-12 16:15:27 +09:00
Dean Herbert
8bf85d737c
Change Metadata into a get property
2021-04-12 15:52:29 +09:00
Dean Herbert
78bbc8f5c8
Tidy some remaining code
2021-04-12 15:52:18 +09:00
Dean Herbert
8c31e96cdf
Change some methods to get properties
2021-04-12 15:52:18 +09:00
Dean Herbert
f78239c7f2
Move enums out of nesting
2021-04-12 15:52:18 +09:00
Dean Herbert
3551322f1d
Fix formatting of colour getter
2021-04-12 15:52:18 +09:00
Dean Herbert
257acf9cd8
Colour constants to private
2021-04-12 15:52:18 +09:00
Dean Herbert
136627b9ac
Wrap xmldoc less and make a few fixes
2021-04-12 15:52:18 +09:00
Dean Herbert
1c553b5d48
Checker -> BeatmapVerifier
2021-04-12 15:29:05 +09:00
Dean Herbert
14bd5bdc77
Merge branch 'master' into verify-tab
2021-04-12 15:14:37 +09:00
Dean Herbert
4853ac802c
Merge pull request #12367 from Joehuu/lazy-flashlight
...
Add follow delay setting to osu! flashlight mod
2021-04-11 19:07:06 +09:00
Joseph Madamba
a42714540b
Add follow delay setting to osu! flashlight mod
2021-04-10 23:04:15 -07:00
Naxess
dac733cced
Fix field name and accessibility
2021-04-10 15:49:57 +02:00
Naxess
7d40b01722
Remove old todo
2021-04-10 15:18:15 +02:00
Naxess
3289bb0379
Merge Check
and BeatmapCheck
...
We're probably not going to need GeneralChecks or BeatmapsetChecks.
The verify tab is only available to a single difficulty at a time, and we already have access to the rest of the set through `IBeatmap`.
2021-04-10 14:56:30 +02:00
Naxess
747e0f00dc
Improve table formatting
2021-04-10 13:10:05 +02:00
Naxess
3a4f2e3d7e
Show table even if no issues
2021-04-10 13:09:16 +02:00
Naxess
c995eca029
Remove todo
...
Doesn't really matter in the end, as only one checker will run at a time in this case.
2021-04-10 13:05:24 +02:00
Naxess
6d3cf78e4a
Add issue selection
...
This mainly helps with keeping track of which issue was clicked, since doing so switches tab.
2021-04-10 13:04:39 +02:00
Naxess
bc4f3351f3
Replace checks with realistic ones
2021-04-10 13:03:16 +02:00
Naxess
b30e41b805
Fix comment; mode -> ruleset
2021-04-10 13:02:36 +02:00
Naxess
d1007ff26a
Move components to more appropriate spot
2021-04-10 13:02:22 +02:00
Naxess
43174b708c
Remove visibility settings
...
Can look into this later, not really important for a first iteration.
2021-04-10 12:58:40 +02:00
Dean Herbert
ab49e84d17
Merge pull request #12356 from peppy/update-framework
...
Update framework
2021-04-10 03:34:24 +09:00
Dean Herbert
b66ef2fdec
Update framework
2021-04-10 02:14:28 +09:00
Dean Herbert
dfe3240b45
Merge pull request #12353 from nekodex/songselect-hoversamples
...
Add a hover sample type for SongSelect buttons
2021-04-10 01:45:47 +09:00
Dan Balasescu
9aa30fb323
Merge pull request #11688 from Syriiin/diffcalc/dynamic-history
...
Implement dynamic previous hitobject retention for Skill class
2021-04-10 01:25:07 +09:00
Dean Herbert
affc878db9
Update resources
2021-04-10 01:03:15 +09:00
Samuel Cattini-Schultz
bfd3d0cce9
Implement custom enumerator for ReverseQueue to avoid allocations
2021-04-10 01:16:54 +10:00
Dean Herbert
8bd972c525
Merge pull request #12354 from nekodex/reduce-sample-pitch-randomisation
...
Reduce the randomised pitch range of hover sounds
2021-04-09 23:43:51 +09:00
Jamie Taylor
ffacd38e57
Reduce the randomised pitch range of hover sounds
2021-04-09 23:03:14 +09:00
Jamie Taylor
8a0da06e89
Add a hover sample type for SongSelect buttons
2021-04-09 23:00:40 +09:00
Dean Herbert
cceb10cc85
Merge pull request #12337 from Naxesss/slider-path-segments
...
Improve UX of correcting invalid slider path types
2021-04-09 19:26:49 +09:00
Dean Herbert
c0837b1c88
Merge pull request #12340 from smoogipoo/add-slider-whistle
...
Add support for sliderwhistle
2021-04-09 18:12:46 +09:00
Naxess
f64b2095bf
Carry over the previous path type
2021-04-09 11:04:00 +02:00
Naxess
0af6d77192
Test for path type transfer
2021-04-09 11:03:38 +02:00
Dean Herbert
1dbc7e821e
Merge branch 'master' into add-slider-whistle
2021-04-09 17:11:48 +09:00
Dean Herbert
9b16e1c38d
Merge pull request #12349 from ekrctb/fix-catch-replay-delay-alternative
...
Fix catcher position update delayed one frame (alternative solution)
2021-04-09 16:44:02 +09:00
ekrctb
6d0dc62502
Make sure latest catcher position is used for catching logic
...
A replay frame processed in CatchInputManager is applied to catcher in `CatcherArea`.
The catcher position is then used for the catching logic for each hit object under `HitObjectContainer`.
Thus, if `HitObjectContainer` came before `CatcherArea`, the replay input is delayed one frame.
That was one reason why the catch autoplay misses hit objects (especially when fast-forwarded).
2021-04-09 16:04:45 +09:00
ekrctb
b10ee7482d
Add a failing test to check catch replay accuracy
2021-04-09 15:58:23 +09:00
Dan Balasescu
e3c75cd4aa
Merge pull request #12348 from peppy/fix-score-submission-ruleset-id-missing
...
Fix scores not being accepted due to missing ruleset ID
2021-04-09 15:54:19 +09:00
smoogipoo
9b0ce2999f
Fix legacy encoder
2021-04-09 15:28:42 +09:00
smoogipoo
f2e811928b
Rework slider hackery to not overwrite Samples
2021-04-09 15:28:08 +09:00