Dean Herbert
2a4f596f90
Merge branch 'master' into ios-beatmap-export
2024-12-10 23:59:15 -08:00
Dean Herbert
02c52e41bd
Merge pull request #31039 from frenzibyte/ios-temporary-export-storage
...
Use temporary storage for file exports on iOS
2024-12-10 23:53:40 -08:00
Dean Herbert
a868c33380
Remove BeatmapCarousel testing backdoor
2024-12-11 16:28:51 +09:00
Dean Herbert
c94b393e30
Access beatmap store via abstract base class
...
The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
2024-12-11 16:28:51 +09:00
Dean Herbert
bab9b9c937
Remove no-longer-correct comment
2024-12-11 16:28:50 +09:00
Dean Herbert
de31a48beb
Some Carousel classes can be abstract
2024-12-11 16:28:50 +09:00
Bartłomiej Dach
c4374c7315
Merge branch 'master' into medal-display-fix
2024-12-11 15:52:38 +09:00
Salman Alshamrani
e0aec6f907
Revert unnecessary complexity
2024-12-11 01:03:55 -05:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
...
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Bartłomiej Dach
b37a06c0fe
Hide "show playing rooms" toggle when in filter mode it doesn't make sense with
2024-12-11 13:24:54 +09:00
Bartłomiej Dach
3352571f2a
Add ability to filter out currently playing rooms
...
Addresses https://osu.ppy.sh/community/forums/topics/2013293?n=1 .
2024-12-11 13:24:08 +09:00
Bartłomiej Dach
637fe07b31
Rename Room{Status -> Mode}Filter
...
I need the "status" term free for an upcoming change. And web calls this
parameter "mode" as well:
642e973f91/app/Models/Multiplayer/Room.php (L184-L199)
2024-12-11 12:36:42 +09:00
Salman Alshamrani
e6e79cbd11
Merge branch 'master' into silly-thing
2024-12-10 03:00:53 -05:00
Dean Herbert
bbaa542d4a
Add note about expensive operation
2024-12-10 16:45:26 +09:00
Dean Herbert
3cac583754
Rewrite resource changing code to be more legible (to my eye)
2024-12-10 16:45:26 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
...
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Bartłomiej Dach
7fcfebf4b4
Use Alt-{Left,Right} as default bindings for bookmark navigation
2024-12-10 14:59:19 +09:00
Dean Herbert
d69f5fd4cf
Avoid beatmap lookup per bar in logo visualisation
...
Just noticed in passing.
2024-12-10 14:45:36 +09:00
Dean Herbert
92dfcae6eb
Adjust bad grammar
2024-12-10 14:35:09 +09:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-10 14:19:55 +09:00
Bartłomiej Dach
1febed66cf
Fix top score statistics section total score display being terminally broken
...
Closes https://github.com/ppy/osu/issues/31038 .
If you don't realise why this does anything, realise this: the drawable
creation callback runs for every created sprite text in the text flow.
ANd the created sprite texts are split by whitespace. And Russian /
Ukrainian / Polish etc. use spaces as thousands separators.
So on those languages the first encountered part of the score would
duplicate itself to the remaining parts.
I'm actively convinced it was _more difficult_ to produce what was in
place in `master` than to do it properly. Why did `TextColumn` even have
`LocalisableString Text` and `Bindable<string> Current` next to each
other?????
2024-12-09 23:51:57 +09:00
Salman Alshamrani
0c0dcb1e15
Use temporary storage for exported files on iOS
2024-12-09 08:16:37 -05:00
Salman Alshamrani
e9868c6318
Enable exporting beatmaps in iOS
2024-12-09 07:47:28 -05:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
...
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks
2024-12-07 22:22:04 +09:00
Endrik Tombak
b04f5ab6e4
Fix IPC not working in release
2024-12-07 14:13:14 +02:00
Dean Herbert
b9f1fef250
Update framework
2024-12-07 10:46:03 +09:00
Dean Herbert
e22f3b7d05
Merge branch 'master' into named-pipe
2024-12-07 10:42:55 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
...
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Salman Alshamrani
5cb6b86b1c
Fix reference effect point getting mutated
2024-12-06 05:47:41 -05:00
Dean Herbert
69014550b5
Remove unnecessary null checks
2024-12-06 12:48:06 +09:00
Dean Herbert
49f4b0e6ef
Update resources
2024-12-05 21:07:13 +09:00
Dean Herbert
84a85000af
Update framework
2024-12-05 21:07:08 +09:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback
2024-12-05 21:07:03 +09:00
Huo Yaoyuan
d92ea910cf
Merge branch 'master' into netcore-analyzer
2024-12-05 17:18:56 +08:00
Dean Herbert
3d6e766b32
Merge pull request #30976 from frenzibyte/hide-some-settings
...
Hide debug settings in release builds
2024-12-05 00:24:26 -08:00
Salman Alshamrani
1b1e7b63e9
Clean up code slightly
2024-12-05 02:48:51 -05:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
...
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
7c1be5eca2
Remove unnecessary localisations
2024-12-05 02:45:43 -05:00
Salman Alshamrani
7ab16a55e5
Make debug section only visible on debug builds
2024-12-05 02:42:08 -05:00
Salman Alshamrani
f83ec721fb
Move latency certifier and import files button outside debug section
2024-12-05 02:42:08 -05:00
Dean Herbert
72aa65206d
Merge pull request #30965 from Susko3/use-GetLocalisedString
...
Use `LocalisationManager.GetLocalisedString()` instead of bindable hack
2024-12-04 23:34:32 -08:00
Salman Alshamrani
a7586c52d0
Merge branch 'master' into results-screen-quick-retry-transition
2024-12-04 06:31:14 -05:00
Salman Alshamrani
fa87df6c6a
Move non-current handling to PerformExit
...
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-12-04 04:55:55 -05:00
Salman Alshamrani
8e0f6fc12d
Re-encode difficulties on resource change
2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-04 04:31:15 -05:00
Salman Alshamrani
e3abbf1177
Copy effect points across on blank difficulty creation
2024-12-04 02:32:00 -05:00
Dan Balasescu
ad4df82593
Improve multiplayer listing search by making it fuzzy
2024-12-04 16:26:36 +09:00
Dean Herbert
a4d58648e2
Fix quick retry transition from results screen
2024-12-04 14:31:39 +09:00
Dean Herbert
296fa69edd
Add "buttons" as a search term for key bindings
2024-12-04 14:30:59 +09:00
Susko3
837744b0aa
Use LocalisationManager.GetLocalisedString() instead of bindable hack
...
Made possible by https://github.com/ppy/osu-framework/pull/6377 .
2024-12-03 23:29:39 +00:00
Bartłomiej Dach
d60b7f4798
Implement basic bookmark support in editor
2024-12-03 15:14:22 +01:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
...
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473 ...
2024-12-03 14:17:14 +01:00
Dan Balasescu
f09d8f097a
Merge pull request #30953 from peppy/notification-while-chedcking-for-updates
...
Show an ongoing operation when checking for updates
2024-12-03 17:27:10 +09:00
Dean Herbert
75781e3436
Update usages of IPC in line with framework changes
2024-12-03 16:34:23 +09:00
Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
...
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Dean Herbert
457957d3b8
Refactor check-update flow to better handle unobserved exceptions
2024-12-03 14:23:10 +09:00
Dean Herbert
2ceb3f6f85
Show an ongoing operation when checking for updates
...
Addresses https://github.com/ppy/osu/discussions/30950 .
2024-12-03 13:43:20 +09:00
Tim Schumacher
e920cfa187
Move rate-changing TODO to a common place in CalculateRateWithMods
2024-12-02 23:49:51 +01:00
Huo Yaoyuan
7ece8ec1dc
Update for suggestions
2024-12-03 00:03:59 +08:00
Huo Yaoyuan
68f4fa5a57
Turn off CA1507
2024-12-03 00:00:31 +08:00
Bartłomiej Dach
b505ecc7ba
Do not deselect objects when control-clicking without hitting anything
...
As per feedback in
https://discord.com/channels/90072389919997952/1259818301517725707/1310270647187935284 .
2024-12-02 13:51:43 +01:00
Bartłomiej Dach
6c0ccc5ebe
Merge pull request #30863 from frenzibyte/improve-back-button-display
...
Delay back button appearance when performing a quick restart
2024-12-02 11:49:45 +01:00
Bartłomiej Dach
52b8753a12
Merge pull request #30749 from Sheppsu/multi-spectator-settings-sidebar
...
Add player settings to multi spectator screen
2024-12-02 11:34:57 +01:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
...
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Dean Herbert
23522b02d8
Use local instead of field for local only usage
2024-12-01 19:53:57 +09:00
Dean Herbert
6afe083ec9
Fix settings showing up during gameplay
2024-12-01 18:44:26 +09:00
Dean Herbert
ddac71628d
Merge branch 'master' into multi-spectator-settings-sidebar
2024-12-01 18:33:46 +09:00
Salman Alshamrani
53dce83b56
Fix restarting no longer working from results screen
...
Thanks to tests for pointing that out :blobsweat:
2024-12-01 02:13:20 -05:00
Salman Alshamrani
9140893249
Fix score no longer being saved when quick-restarting after pass
2024-11-30 23:36:02 -05:00
Tim Schumacher
164b809c89
Document ready button enable state with some comments
2024-11-30 23:02:22 +01:00
Tim Schumacher
f4e155bfa6
Account for rate changing mods when disabling the "Ready" button
2024-11-30 16:01:32 +01:00
Dean Herbert
1e2e364cd3
Stop loudly logging backwards seek bug to sentry
...
Several users have reported stutters when this happens. It's potentially
from the error report overhead. We now know that this is a BASS level
issue anyway, so having this logging is not helpful.
2024-11-30 21:01:22 +09:00
Huo Yaoyuan
fa3c95c296
Merge branch 'master'
2024-11-30 01:07:08 +08:00
Bartłomiej Dach
e92aa36f47
Merge pull request #30918 from peppy/expose-more-migration-helper-methods
...
Expose more migration helper methods
2024-11-29 14:55:45 +01:00
Dean Herbert
f56b2b9aef
Merge pull request #30793 from bdach/close-playlists
...
Add ability to close playlists within grace period after creation
2024-11-29 22:37:32 +09:00
Dean Herbert
a719693d10
Fix one remaining method call
2024-11-29 21:21:05 +09:00
Dean Herbert
0e1b62ef85
Expose more migration helper methods
...
For use in https://github.com/ppy/osu-queue-score-statistics/pull/305 .
Some of these might look a bit odd, but I personally still prefer having
them all in one central location.
2024-11-29 21:10:30 +09:00
Dean Herbert
58efed4ebe
Merge pull request #30915 from bdach/extension-checks
...
Centralise supported file extensions to one helper class
2024-11-29 20:55:28 +09:00
Bartłomiej Dach
5f092811cb
Use helper in one more place
2024-11-29 09:22:29 +01:00
Bartłomiej Dach
5a9127dfc6
Accidentally a word
2024-11-29 08:46:08 +01:00
Bartłomiej Dach
110e4fbb30
Centralise supported file extensions to one helper class
...
As proposed in
https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837 .
2024-11-29 08:42:45 +01:00
Dean Herbert
b697ddc6db
Simplify the dev footer display
2024-11-29 15:32:35 +09:00
Dean Herbert
276c37bcf7
Update framework
2024-11-29 13:47:56 +09:00
Salman Alshamrani
489d7a30ec
Perform a single Save call rather than doing it in each difficulty
2024-11-28 18:37:13 -05:00
Salman Alshamrani
311f0947e4
Abstractify resource change logic and share between background and audio
2024-11-28 17:57:47 -05:00
Salman Alshamrani
51bcde67aa
Remove no longer required comment
2024-11-28 17:55:15 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds
2024-11-28 17:46:55 -05:00
Salman Alshamrani
932afcde01
Make editor make sense
2024-11-28 17:43:32 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback
2024-11-29 06:54:48 +09:00
Huo Yaoyuan
fced254594
Enable selected rules for usage
2024-11-28 22:33:03 +08:00
Bartłomiej Dach
c93c549b05
Fix ready button not disabling on playlist close
2024-11-28 14:17:31 +01:00
Bartłomiej Dach
9926ffd326
Make button a little narrower
2024-11-28 14:06:12 +01:00
Bartłomiej Dach
ac2c4e81c7
Use switch
2024-11-28 14:04:39 +01:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists
2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509
Apply minor performance rules
2024-11-28 20:41:44 +08:00
Huo Yaoyuan
13d7c6a2d8
Enable recommended rules for maintainability
2024-11-28 20:41:41 +08:00
Huo Yaoyuan
c57ace0b5f
Enable recommended rules for documentation
2024-11-28 20:41:32 +08:00
Bartłomiej Dach
d0e80ce982
Merge pull request #30895 from peppy/watch-replay-reliability
...
Fix watch replay button sometimes not loading the replay on first click
2024-11-28 13:16:40 +01:00
Hiviexd
66093872e8
Adjust daily challenge tier thresholds to match expectations
2024-11-28 12:49:30 +01:00
