Bartłomiej Dach
320373e3e0
Rename method to match convention better
2024-03-19 18:28:13 +01:00
Bartłomiej Dach
feaf59e15f
Use HashSet instead of SortedSet
...
No need for it to be sorted.
2024-03-19 18:26:58 +01:00
Dean Herbert
0de5ca8d2d
Update incorrect xmldoc
2024-03-20 01:26:39 +08:00
Dean Herbert
35df381717
Merge branch 'master' into tcm-resume
2024-03-20 01:25:40 +08:00
Bartłomiej Dach
0180b25546
Merge pull request #27064 from smoogipoo/heatmap-misses
...
Display misses in the hit accuracy heatmap
2024-03-19 16:20:25 +01:00
Dan Balasescu
f6069d8d93
Compare against MaxCombo instead
2024-03-19 17:46:18 +09:00
Dan Balasescu
6e33509417
Remove added property, use local decoding instead
2024-03-19 17:44:37 +09:00
Dan Balasescu
af713a7869
Fix incorrectly encoded score IsPerfect value
2024-03-19 17:20:59 +09:00
Salman Ahmed
bbdcb38f5d
Merge branch 'master' into convert-path-string-new
2024-03-19 02:51:24 +03:00
Salman Ahmed
a8ce6a0bba
Use Slice method instead of index range operators for readability
2024-03-19 02:43:36 +03:00
Arthur Araujo
5241c999c1
Add different warning to maps with storyboard/video
2024-03-18 16:08:41 -03:00
Arthur Araujo
f6d7f18f25
Remove unused localisation file
2024-03-18 15:59:19 -03:00
Andrei Zavatski
7ca45c75b3
Don't iterate backwards on children without a reason
2024-03-18 20:46:38 +03:00
Andrei Zavatski
0edc249637
Make Timeline non-nullable
2024-03-18 20:38:19 +03:00
Andrei Zavatski
57399e9899
Merge branch 'master' into editor-performance
2024-03-18 20:34:48 +03:00
Arthur Araujo
c23212f4ef
Use GetLastObjectTime to calculate mapped length
2024-03-18 14:02:33 -03:00
Arthur Araujo
915a9682b5
Fix issue type and display percentage left
2024-03-18 13:51:36 -03:00
Arthur Araujo
a3f3dcf853
Inline percentage calculation
2024-03-18 13:27:43 -03:00
Vlad Frangu
77119b2cdb
chore: correct doc string
2024-03-18 16:44:42 +02:00
Bartłomiej Dach
c9bbeeb49a
Merge branch 'master' into heatmap-misses
2024-03-18 14:43:24 +01:00
Vlad Frangu
d0678bfbee
chore: requested changes
2024-03-18 15:30:43 +02:00
Dean Herbert
498948f17d
Merge pull request #27607 from Joehuu/fix-beatmap-card-lime-artifact
...
Fix noticeable masking artifact of beatmap cards when already downloaded
2024-03-18 00:38:56 +08:00
Arthur Araujo
f7aff76592
Fix codefactor issues
2024-03-16 23:03:06 -03:00
Arthur Araujo
63816adbc0
Add verify checks to unused audio at the end
2024-03-16 21:20:12 -03:00
Vlad Frangu
e1c1609271
chore: correct equal logic
2024-03-16 21:48:44 +02:00
Vlad Frangu
0a6960296e
feat: Support filtering for multiple statuses
2024-03-16 21:32:55 +02:00
Andrei Zavatski
34a5e2d606
Don't update subtree masking in TimelineTickDisplay
2024-03-16 15:20:37 +03:00
Andrei Zavatski
981ee54cdc
Fix transforms overhead in TimelineTickDisplay
2024-03-16 15:05:52 +03:00
Andrei Zavatski
e825db61ee
Fix enumerator allocation
2024-03-16 12:26:56 +03:00
Andrei Zavatski
854d7c6fb4
Merge branch 'master' into editor-performance
2024-03-16 12:26:39 +03:00
Andrei Zavatski
ea3a9314f9
Improve TimelineControlPointDisplay performance
2024-03-16 11:57:18 +03:00
Dean Herbert
15c0b1a2ec
Remove redundant cast
2024-03-16 13:18:42 +08:00
Dean Herbert
a49c4ebea6
Match settings panels' backgrounds visually and behaviourally
2024-03-16 10:23:21 +08:00
Dean Herbert
0f8d526453
Adjust timings and delay disclaimers the same as settings
2024-03-16 10:09:49 +08:00
Bartłomiej Dach
a78210c88f
Handle hover so that users can hover disclaimer to block load & read it
2024-03-15 11:45:27 +01:00
Bartłomiej Dach
e6883b8418
Tweak visuals further
2024-03-15 11:38:51 +01:00
Bartłomiej Dach
51568ba06a
Add background to disclaimers
2024-03-15 11:31:45 +01:00
Bartłomiej Dach
5513a72748
Improve hiding transition when multiple disclaimers are visible
2024-03-15 11:01:34 +01:00
Bartłomiej Dach
49a087f7fc
Add localisation support
2024-03-15 10:59:49 +01:00
Bartłomiej Dach
4688a53cf4
Stay on player loader a bit longer if disclaimers are present
...
Just to make reading the text easier.
2024-03-15 09:53:20 +01:00
Bartłomiej Dach
f3a444b7ac
Add disclaimer for loved/qualified status
2024-03-15 09:53:20 +01:00
Bartłomiej Dach
42ae18976f
Replace existing epilepsy warning with inline display
2024-03-15 09:53:20 +01:00
Bartłomiej Dach
1aa695add9
Implement alternate design of player loader disclaimers
2024-03-15 09:53:18 +01:00
Dean Herbert
23975d4dd1
Add flash and reduce overall time for countdown to 2 seconds
2024-03-14 22:49:53 +08:00
Dean Herbert
2845303a74
Fix non-matching scale outwards animation
2024-03-14 22:45:05 +08:00
Dean Herbert
888245b44f
Reorder methods
2024-03-14 22:44:26 +08:00
Dean Herbert
d7769ec3e2
Adjust animation
2024-03-14 22:44:23 +08:00
Dean Herbert
42bd558d7c
Only update text when necessary (reducing unnecessary string allocadtions)
2024-03-14 22:43:08 +08:00
Joseph Madamba
f8a841e907
Add comment explaining why width is limited to the button area
...
Same comment as a47ccb8edd/osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs (L91-L92)
2024-03-14 00:17:22 -07:00
Salman Ahmed
b4cee12db9
Use defined colours for counter background
2024-03-14 09:22:03 +03:00
Joseph Madamba
b309aad895
Fix noticeable masking artifact of beatmap cards when already downloaded
...
Had a similar fix before seeing https://github.com/ppy/osu/pull/20743#discussion_r994955470 , but using that diff instead so co-authoring.
Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-03-13 22:36:52 -07:00
Dan Balasescu
b431bb1176
Resolve post-merge issues
2024-03-14 12:24:12 +09:00
Dan Balasescu
0beaa8e8c5
Merge branch 'master' into tcm-resume
2024-03-14 12:22:46 +09:00
Dan Balasescu
789a9f4dfa
Initial redesign following flyte's design
2024-03-14 11:38:16 +09:00
Dean Herbert
a47ccb8edd
Merge pull request #27600 from bdach/dont-die-on-audio-in-video-check
...
Fix audio in video check crashing on unexpected failures
2024-03-14 10:28:45 +08:00
Bartłomiej Dach
d32f19b546
Fix first word bold not applying correctly after first language change
...
Closes https://github.com/ppy/osu/issues/27549 .
I'm not entirely sure why the old solution failed exactly, but also
think it's unimportant because I think past me was an idiot and was
playing stupid games with the juggling of indices between two callbacks
with no ordering guarantees and expecting not to win stupid prizes.
I'm not sure this requires any follow-up reconsiderations of that entire
text flow API, but if opinions differ, I'll re-examine.
2024-03-13 15:18:20 +01:00
Bartłomiej Dach
20c760835a
Fix audio in video check crashing on unexpected failures
2024-03-13 13:55:49 +01:00
Joseph Madamba
e2e99fc5cc
Rearrange rankings overlay tabs to match web
2024-03-12 21:15:59 -07:00
Dean Herbert
a4a433b92a
Remember login by default
...
Kinda what is expected from a user's perspective
2024-03-12 20:14:50 +08:00
Dean Herbert
5b2dd95fd6
Merge pull request #27586 from bdach/ignore-directory-zip-entries
...
Fix exports containing zero byte files after import from specific ZIP archives
2024-03-12 17:18:39 +08:00
Bartłomiej Dach
83e47b3c4c
Fix exports containing zero byte files after import from specific ZIP archives
...
Closes https://github.com/ppy/osu/issues/27540 .
As it turns out, some ZIP archivers (like 7zip) will decide to add fake
entries for directories, and some (like windows zipfolders) won't.
The "directory" entries aren't really properly supported using any
actual data or attributes, they're detected by sharpcompress basically
by heuristics:
ab5535eba3/src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (L19-L31)
2024-03-12 09:06:24 +01:00
Dean Herbert
83052fe1d9
Downgrade realm to work around crashes on latest release
...
See https://github.com/ppy/osu/issues/27577 .
2024-03-12 15:41:50 +08:00
Bartłomiej Dach
f30dfcb728
Fix ruleset medals not displaying due to deserialisation failure
...
🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦 🤦
Reported in
https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386 .
2024-03-11 21:34:10 +01:00
Bartłomiej Dach
9bc55be515
Merge pull request #27564 from EVAST9919/editor-blueprint-gradient
...
Fix incorrect gradient application in `TimelineHitObjectBlueprint`
2024-03-11 16:02:05 +01:00
Bartłomiej Dach
09179f99c0
Merge branch 'master' into wrap-beatmap-listing-filters
2024-03-11 14:59:48 +01:00
Bartłomiej Dach
e5e7c8f268
Wrap beatmap listing filter names too
...
While we're here fixing...
Addresses
https://github.com/ppy/osu/discussions/15452#discussioncomment-2734237 .
2024-03-11 14:58:28 +01:00
Andrei Zavatski
6ecef33fd7
Fic incorrect ExtendableCircle gradient
2024-03-10 22:45:29 +03:00
Andrei Zavatski
549a8d678e
Reduce allocations in ControlPointList
2024-03-09 20:50:54 +03:00
Dean Herbert
31739be499
Update resources
2024-03-09 20:48:57 +08:00
Dean Herbert
b8a362fcb6
Simplify assignment by using an auto property
2024-03-09 20:17:27 +08:00
Andrei Zavatski
58b6acde10
Further simplify tooltip text creation
2024-03-09 14:10:32 +03:00
Andrei Zavatski
dd36942508
Reduce allocations in DrawableFlag tooltip
2024-03-09 13:58:05 +03:00
Andrei Zavatski
26c97ef733
Fix WikiPanelContainer causing poor performance
2024-03-09 00:51:33 +03:00
Joseph Madamba
db1c59475b
Wrap beatmap listing filters and match web spacing
2024-03-08 12:13:54 -08:00
Dean Herbert
612bc66e86
Merge pull request #27535 from nekodex/argon-hitsounds
...
Add support for argon hitsounds
2024-03-09 01:47:35 +08:00
Jamie Taylor
27d78fdb08
Add fallback to find spinner samples without a bank prefix
2024-03-09 01:10:28 +09:00
Jamie Taylor
ad842b60f5
Add support for Argon hitsounds
2024-03-08 21:43:18 +09:00
Bartłomiej Dach
44d0dc6113
Fix 1px flashlight gaps when gameplay scaling mode is active
...
Closes https://github.com/ppy/osu/issues/27522 .
Concerns mostly taiko and catch.
Not much of a proper fix rather than a workaround but it is what it is.
I tried a few other things, including setting `MaskingSmoothness = 0` on
the scaling container itself, to no avail.
2024-03-08 11:07:30 +01:00
Dean Herbert
c9b4c684e5
Merge pull request #27403 from Gabixel/increase-modselect-initial-scroll
...
Change initial scroll effect to mod columns
2024-03-08 14:00:40 +08:00
Dean Herbert
5e7d9ea04a
Adjust scroll speed back to original
2024-03-08 13:59:04 +08:00
Dean Herbert
d9cc619693
Merge branch 'master' into argon-pp-counter
2024-03-08 10:32:16 +08:00
Dean Herbert
9286398633
Move naming migrations to more correct place
2024-03-08 10:26:08 +08:00
Dean Herbert
0ebb12f67f
Move skinnable interface specification to non-abstract classes
2024-03-08 10:23:46 +08:00
Dean Herbert
ae2ef8ee1e
Fix typo in wireframe description
2024-03-08 10:19:00 +08:00
Dean Herbert
f2753ef7a2
Decrease size of pp display relative to accuracy
2024-03-08 09:41:38 +08:00
Dean Herbert
87b4406bdc
Pad at minimum three digits for argon pp display
2024-03-08 09:41:28 +08:00
Dan Balasescu
ca92a31cf9
Fix missing event unbinds
2024-03-07 21:10:11 +09:00
Bartłomiej Dach
fba44e67a0
Merge pull request #27214 from Givikap120/freemod_mapinfo_fix
...
Fix mod selection in online-play rooms not accounting for mods of selected item
2024-03-07 12:45:14 +01:00
Bartłomiej Dach
3d8fdc52a4
Merge pull request #27501 from turbedi/throw_helper
...
Use ThrowHelper methods in more places
2024-03-07 11:36:21 +01:00
Bartłomiej Dach
e99030c515
Merge pull request #27516 from frenzibyte/editor-screen-selector
...
Change editor screen switcher control design and behaviour to act like a button
2024-03-07 11:04:18 +01:00
Bartłomiej Dach
644553d5b4
Merge branch 'master' into freemod_mapinfo_fix
2024-03-07 09:24:44 +01:00
Dan Balasescu
1cafb09977
Increase border thickness
2024-03-07 17:22:38 +09:00
Joseph Madamba
c36232bc02
Fix results screen accuracy circle not showing correctly for failed S with no flair
2024-03-07 00:10:30 -08:00
Dan Balasescu
e0fe33a7a7
Merge pull request #27513 from bdach/osu-score-conversion-bad-very-not-good
...
Fix osu! standardised score estimation algorithm violating basic invariants
2024-03-07 17:05:32 +09:00
Salman Ahmed
0fe139a189
Adjust editor screen switcher control design and behaviour
2024-03-07 08:20:46 +03:00
Salman Ahmed
336a6180e5
Expose TRANSITION_LENGTH from tab control
2024-03-07 08:20:20 +03:00
Bartłomiej Dach
aa3cd402ca
Fix broken english
2024-03-06 21:30:31 +01:00
Bartłomiej Dach
3121cf81e6
Bump score version
2024-03-06 21:30:09 +01:00
Dean Herbert
13f7480d79
Merge branch 'master' into sb-lifetime-improvements
2024-03-06 19:27:40 +08:00
Dean Herbert
5b6703ec0d
Move optimisation to isolated method
2024-03-06 19:25:13 +08:00
