Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dean Herbert
dc595b83f1
Remove unused Dimension specification from StatisticItem
2023-06-01 14:25:18 +09:00
Dean Herbert
e830b96e61
Add back required override to make AccuracyHeatmap work
2023-06-01 13:26:47 +09:00
Dean Herbert
310c54fe28
Add test coverage ensuring positional data is present in hit events
2023-06-01 13:26:47 +09:00
Dean Herbert
55a3847036
Merge pull request #23708 from peppy/labelled-slider-visibility
...
Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements
2023-06-01 13:08:17 +09:00
Bartłomiej Dach
d78df0b084
Merge pull request #23695 from peppy/realm-startup-error-handling
...
Adjust realm startup for added reliability
2023-05-31 22:46:58 +02:00
timiimit
a58426dab6
Use LastEditTime in Editor
2023-05-31 19:07:04 +02:00
timiimit
659fb80c16
Add BeatmapInfo.LastEditTime property
2023-05-31 19:06:41 +02:00
Cootz
5a1c3aeb7e
Fix SearchTerm set causing infinite loop
2023-05-31 19:36:42 +03:00
Cootz
6e00b21a32
Update framework version
2023-05-31 19:16:16 +03:00
Dean Herbert
7bc3b2072c
Update framework
2023-06-01 00:44:13 +09:00
Dean Herbert
20439e80f6
Adjust background colour used in LabelledDrawables to allow visibility of sliders
2023-05-31 23:24:21 +09:00
Dean Herbert
812def124f
Merge pull request #23661 from peppy/fix-multiplayer-present-crash
...
Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen
2023-05-31 19:43:30 +09:00
Dean Herbert
18eb15bfa5
Gracefully handle failures in cleaning up pending file deletions
2023-05-31 19:39:43 +09:00
Bartłomiej Dach
aaf50c47a7
Merge pull request #23696 from peppy/fix-autopilot-ripples
...
Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled
2023-05-30 23:29:30 +02:00
Bartłomiej Dach
2e81cae201
Move comment to more correct place
2023-05-30 23:18:34 +02:00
Bartłomiej Dach
62d1774407
Apply same comment & reworded condition to suspend too
2023-05-30 21:54:56 +02:00
Dan Balasescu
b6e407f348
Merge pull request #23697 from peppy/update-readme
...
Update readme with `UseLocalxxx` scripts mentioned
2023-05-30 23:01:01 +09:00
Andrei Zavatski
d119447a10
Fix editor timeline hitobjects popping in
2023-05-30 16:41:42 +03:00
Dean Herbert
741ee84ed6
Add comment and use full conditional similar to extension method
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-30 18:38:28 +09:00
John
ed850196d9
Reverted to applying the color change in OnUpdate, removed EnableComboColour flag from DrawableHitObject.cs
2023-05-30 01:43:08 -07:00
Dan Balasescu
b456c36f64
Migrate in InitialiseDefaults()
2023-05-30 17:27:48 +09:00
Dean Herbert
9d844f2381
Update documentation for local framework / resources
2023-05-30 15:38:19 +09:00
Dean Herbert
4d2c3f17e8
Remove outdated prerequisites
2023-05-30 15:38:15 +09:00
Dean Herbert
654940afb0
Update various text
2023-05-30 15:38:15 +09:00
Dean Herbert
1bde35c61b
Remove link to very dated blog post
2023-05-30 15:38:15 +09:00
Dean Herbert
a436f858df
Merge pull request #23638 from smoogipoo/scorev2
...
Replace lazer scoring with "ScoreV2"
2023-05-30 15:29:48 +09:00
Dean Herbert
3e94d4bb5a
Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled
2023-05-30 15:18:23 +09:00
Dean Herbert
14a376c041
Merge branch 'master' into scorev2
2023-05-30 14:34:43 +09:00
Dean Herbert
4e0f40bee5
Split out multiplier retrieval into a function and use a default multiplier for all rulesets
2023-05-30 14:20:26 +09:00
Dean Herbert
e35623df22
Update to use new Filter method and remove silly ForcedSearchTerm
2023-05-30 13:40:59 +09:00
Dean Herbert
e72aba05a8
Merge pull request #23317 from cdwcgt/acc-challenge
...
Provide more accuracy modes for accuracy challenge mod
2023-05-30 13:33:08 +09:00
Dean Herbert
fd919879c3
Merge branch 'master' into acc-challenge
2023-05-30 13:24:34 +09:00
Dean Herbert
a0be526266
Adjust realm backup procedure to hard fail if running out of attempts
...
Previously, if the backup procedure failed, startup would continue and
the user's realm database may be deleted. I think in such a fail case
I'd rather the game didn't startup so the user gets in touch (or reads
the log files themselves) rather than potentially losing data.
2023-05-30 13:04:34 +09:00
Dean Herbert
79694897be
Ensure a potential exception from cleanupPendingDeletions doesn't mark realm corrupt
...
The whole restructure here is to move the nested call out of the
`try-catch`. I noticed this while looking at a corrupt database issue a
user reported (https://github.com/ppy/osu/discussions/23694 ).
It's not the first time we've seen a corrupt database error where the
"corrupt" version works just fine on a second attempt.
Maybe this isn't the issue and it's just a transitive file access violation
but it definitely feels like this should be fixed regardless.
2023-05-30 13:00:17 +09:00
Dean Herbert
61d9b50993
Merge pull request #23640 from 17steen/make_pause_menu_translatable
...
Make GameplayMenuOverlay translatable
2023-05-30 09:36:19 +09:00
Bartłomiej Dach
5604dfb758
Merge branch 'master' into acc-challenge
2023-05-29 22:33:57 +02:00
Bartłomiej Dach
1b57b0d31c
Add testing
2023-05-29 22:33:46 +02:00
Bartłomiej Dach
314a0f80f3
Reword setting name & description
2023-05-29 22:12:37 +02:00
Bartłomiej Dach
36f60def6d
Merge pull request #23679 from cdwcgt/percentage-format-slider
...
Format percentage based on significant decimal digits
2023-05-29 21:18:23 +02:00
Dan Balasescu
1c199b83e3
Replace mania scroll "time" with scroll "speed"
2023-05-29 21:22:23 +09:00
Cootz
22c6d6c526
Prevent checkbox from toggle on when column have no valid panels
2023-05-29 14:22:40 +03:00
Dean Herbert
b3ca409339
Rename a few remaining CountAccuracyJudgement variable
2023-05-29 20:08:22 +09:00
Dean Herbert
1558723420
Merge branch 'master' into scorev2
2023-05-29 20:06:32 +09:00
Dean Herbert
df662afbd5
Pass ScoreProcessorStatistics to FrameHeader, rather than the full processor
2023-05-29 20:00:42 +09:00
Dean Herbert
1a6d9e9ff0
Apply NRT to GameplayLeaderboardScore and change GetDisplayedScore handling
...
I don't feel too confident with the default scoring function being
assigned in the constructor to a publicly settable delegate. This just
feels a bit more elegant, and handles the (likely-never-used) case where
we need to restore the default function.
An alternative would be to provide the function as a `ctor` argument,
but I believe that wasn't done here to allow using the
`ILeaderboardScore` interface.
2023-05-29 20:00:29 +09:00
Dean Herbert
fcd7a1d51a
Move GetDisplayScore xmldoc to interface and remove getter
2023-05-29 19:41:53 +09:00
Dean Herbert
9a886125ad
Ensure GameplayScoreCounter's display score is updated on ScoringMode change
...
This isn't strictly required, but only because of a kind of hacky
behaviour where `HUDOverlay` will recreate all components on a scoring
mode change currently (see
8f6df5ea0f/osu.Game/Screens/Play/HUDOverlay.cs (L410-L418)
2023-05-29 19:00:02 +09:00
Dean Herbert
22be045de3
Apply NRT to GameplayScoreCounter
2023-05-29 18:48:17 +09:00
Dean Herbert
a789d1e49c
Add xmldoc and change naming around ScoreProcessorStatistics a bit
2023-05-29 18:38:16 +09:00
