ekrctb
67d8e0059f
Use singular IApplicableToDrawableHitObject for consumers
2021-06-16 18:47:04 +09:00
ekrctb
e69bb67afe
Add IApplicableToDrawableHitObject that is taking a single DHO
...
Less cumbersome to implement than old version taking an enumerable. The implementation was always using `foreach` for the enumerable.
The new interface is not used yet.
2021-06-16 18:42:28 +09:00
Bartłomiej Dach
cc5145a131
Fix languages with a sub-language part not working properly
2021-06-16 11:10:03 +02:00
ekrctb
2b0e6b6b51
Don't invoke "completed" action for test scene virtual track
...
`MusicController` tries to play the next music when a track is completed.
In test scenes, we want to keep the virtual track, not random songs.
2021-06-16 17:44:21 +09:00
Bartłomiej Dach
d298e95df7
Limit maximum height of settings enum dropdowns
2021-06-16 10:25:50 +02:00
Bartłomiej Dach
64bb1f381b
Add more languages to settings dropdown
2021-06-16 10:25:30 +02:00
Dean Herbert
5944c45f55
Specify types explicitly and don't handle non-nullable values with fallbacks
2021-06-16 16:24:30 +09:00
smoogipoo
fafd936c93
Localise "sort by" string in overlays
2021-06-16 16:21:41 +09:00
smoogipoo
6d6604e2f0
Fix incorrect indentation
...
I used this for the o!f example.
2021-06-16 16:19:47 +09:00
Dean Herbert
b24730efdb
Merge pull request #13512 from smoogipoo/add-localisation-example
...
Localise parts of the beatmap listing overlay
2021-06-16 16:03:40 +09:00
ekrctb
117e94bc94
Allow setting Entry of PoolableDrawableWithLifetime
...
It is more convenient than using the constructor because the only limited kind of expression is allowed in a base constructor call.
Also, the object initializer syntax can be used.
2021-06-16 16:00:08 +09:00
smoogipoo
3c3ff8be0d
Localise beatmap listing enum values
2021-06-16 15:58:07 +09:00
Dean Herbert
cb80577922
Merge pull request #13509 from bdach/fix-seasonal-backgrounds
...
Fix seasonal backgrounds not cycling
2021-06-16 15:26:46 +09:00
Dean Herbert
68fa7d68cc
Merge pull request #13511 from smoogipoo/fix-possible-nullref-2
...
Fix possible nullref in difficulty recommender
2021-06-16 15:20:45 +09:00
Dean Herbert
f802679d38
Merge pull request #13497 from smoogipoo/fix-present-score
...
Make PresentScore() use replay hash as fallback
2021-06-16 15:18:01 +09:00
smoogipoo
4c5268694e
Localise some of the BeatmapListingOverlay
2021-06-16 13:46:13 +09:00
smoogipoo
fa00d07107
Upgrade osu-resources
2021-06-16 13:26:36 +09:00
Dean Herbert
66efc3c4de
Merge branch 'master' into realm-key-binding-store
2021-06-16 13:23:13 +09:00
smoogipoo
a5261f0cb3
Add difficulty recommender instantly
2021-06-16 11:48:49 +09:00
smoogipoo
6be41e497a
Fix possible nullref in difficulty recommender
2021-06-16 11:27:38 +09:00
Bartłomiej Dach
022b1a28d5
Add missing equality implementation for seasonal backgrounds
...
The equality operator is used to determine whether the next background
in the cycle should be loaded, to avoid pointless loads of the same
background several times (see #13362 and #13393 ). Its omission in the
latter pull caused seasonal backgrounds to no longer cycle.
Closes #13508 .
2021-06-15 23:21:48 +02:00
Dean Herbert
9d168b19c9
Switch to non-beta release
2021-06-16 02:15:25 +09:00
Dean Herbert
acc06ca398
Merge branch 'master' into realm-key-binding-store
2021-06-16 02:14:58 +09:00
Dan Balasescu
e9d4ee3c87
Merge branch 'master' into enhance-mod-settings-text-box-visibility
2021-06-15 16:09:55 +09:00
ekrctb
ef96ceb4ab
Introduce IPlayfieldProvider
2021-06-15 14:43:04 +09:00
smoogipoo
579a4aa9c8
Remove comment
2021-06-15 14:10:09 +09:00
smoogipoo
eb4c093371
Use hash as fallback
2021-06-15 14:06:17 +09:00
ekrctb
bbf0022689
Use natural anchor for TimeAtPosition and PositionAtTime
...
The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).
2021-06-15 13:15:20 +09:00
smoogipoo
f6c6eea6dc
Make PresentScore() only consider replay hash
2021-06-15 11:16:35 +09:00
Bartłomiej Dach
cb1e2e3d97
Improve xmldoc
2021-06-14 21:54:55 +02:00
Dan Balasescu
84ec378be1
Merge branch 'master' into refactor-scrolling-hoc-1
2021-06-14 20:42:38 +09:00
Dan Balasescu
980afd6a04
Merge branch 'master' into fix-song-select-leaderboard-events
2021-06-14 20:03:36 +09:00
Dan Balasescu
15a20ed9d6
Merge pull request #13486 from peppy/revert-nested-platform-container
...
Revert "Add nested `PlatformActionContainer` to allow testing of platform actions in visual tests"
2021-06-14 19:53:14 +09:00
Dean Herbert
75b5b50aee
Merge pull request #13490 from smoogipoo/arbitrary-localisation-assembly
...
Match any arbitrary assembly for localisations
2021-06-14 19:05:22 +09:00
Dean Herbert
13d0eaa9fe
Update framework
2021-06-14 19:03:31 +09:00
smoogipoo
b327baa4de
Match any arbitrary assembly for localisations
2021-06-14 17:47:31 +09:00
smoogipoo
aa5dae84b2
Make all localisation class strings verbatim
2021-06-14 16:51:17 +09:00
Dean Herbert
83402a70db
Fix potential null ref when no beatmap is selected
2021-06-14 15:06:24 +09:00
Dean Herbert
f8b09b7c81
Avoid refresh if score is not related to current display
2021-06-14 14:28:14 +09:00
Dean Herbert
fc442713bb
Debounce schedule at base class
2021-06-14 14:26:40 +09:00
Dean Herbert
8dd48d48f6
Add support for song select leaderboard to handle newly imported scores
2021-06-14 14:20:23 +09:00
Dean Herbert
564682270a
Revert "Add nested PlatformActionContainer to allow testing of platform actions in visual tests"
...
This reverts commit be91203c92
2021-06-14 13:18:52 +09:00
ekrctb
660bf50dc7
Clarify multiple coordinate systems
...
- Fix wrong position is set for DHOs for down/right scrolling direction.
2021-06-14 13:13:27 +09:00
ekrctb
09f1cbde7e
Fix TimeAtPosition doc comment
2021-06-14 13:13:27 +09:00
ekrctb
fdb09ef4d7
Simplify flipPositionIfRequired using scrollLength
2021-06-14 13:13:27 +09:00
ekrctb
8cf4454780
Use Direction enum instead of int
...
The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).
2021-06-14 13:13:27 +09:00
Dean Herbert
17347401cf
Remove unused RankingType enum
...
We have `BeatmapLeaderboardScope` instead.
2021-06-14 11:27:46 +09:00
Pasi4K5
ef9cb2c958
Rename nested classes
2021-06-12 18:37:31 +02:00
Pasi4K5
b79d57b68c
Move OsuSettingsNumberBox into SettingsNumberBox
2021-06-12 17:57:40 +02:00
Pasi4K5
c728f673d6
Rename classes
2021-06-12 17:37:01 +02:00
Pasi4K5
29f3880415
Move classes into SettingsTextBox
2021-06-12 17:34:02 +02:00
Pasi4K5
bb661abfa6
Clean up OsuModSettingsTextBox
2021-06-12 17:25:22 +02:00
Pasi4K5
fe39a47797
Add OsuModSettingsTextBox and OsuModSettingsNumberBox
2021-06-12 00:34:53 +02:00
Bartłomiej Dach
902bb84ca8
Merge branch 'master' into fix-wave-overlay-sound-on-switch
2021-06-11 22:05:08 +02:00
Dean Herbert
f773ea475d
Update framework
2021-06-12 01:37:13 +09:00
Dean Herbert
c2759121b9
Merge pull request #13454 from nekodex/change-default-hover-click-sample
...
Change default HoverSounds/HoverClickSounds samples
2021-06-12 01:01:35 +09:00
Dean Herbert
121df57dca
Fix focused overlays playing their "appear" sound when not necessarily changing state
2021-06-12 00:26:33 +09:00
Dean Herbert
0dbe5dd219
Remove unused using statement
2021-06-12 00:23:18 +09:00
Dean Herbert
d9ea8d64d4
Remove weird local sample logic in ChangelogOverlay
2021-06-12 00:05:49 +09:00
Dean Herbert
e098cac1cf
Minor code reformatting / moving
2021-06-11 23:49:14 +09:00
Dean Herbert
5887b4a27c
Update stand-alone usage of hover/select sounds in DrawableOsuMenuItem
2021-06-11 23:46:42 +09:00
Dean Herbert
97bb3de1c9
Update resources
2021-06-11 23:03:27 +09:00
Dean Herbert
9c6c1dd237
Merge branch 'master' into change-default-hover-click-sample
2021-06-11 23:03:23 +09:00
smoogipoo
dca001a72d
Upgraed localisation analyser packages
2021-06-11 22:22:47 +09:00
Bartłomiej Dach
550d566bf9
Simplify member access
2021-06-11 14:24:17 +02:00
Bartłomiej Dach
876a357bf2
Add support for animated colour fill in new style legacy health bar
2021-06-11 14:24:17 +02:00
Jamie Taylor
0b95d07390
Change 'default' hover/click samples into 'button' samples and make 'soft' the new 'default'
2021-06-11 20:47:57 +09:00
Dan Balasescu
3389c4830b
Merge branch 'master' into refactor-scrolling-hoc-1
2021-06-11 20:35:19 +09:00
Jamie Taylor
4f80a3b66d
Add fallback-to-default logic for HoverSounds and HoverClickSounds
2021-06-11 20:14:35 +09:00
Robin Avery
0c8851f4b7
Extract drawable.ScreenSpaceDrawQuad to a variable
2021-06-11 07:06:22 -04:00
Dean Herbert
26312bf60a
Merge branch 'master' into chat-mention
2021-06-11 20:03:44 +09:00
Robin Avery
a6774eb5b5
Inline getOriginPositionFromQuad
2021-06-11 06:59:00 -04:00
Robin Avery
c9b4f9eb71
Make getOriginPositionFromQuad local
2021-06-11 06:55:47 -04:00
Robin Avery
1bc8460902
Rename getTieredComponent to getAnchorFromPosition
...
Also rename parameter `component` to `xOrY`.
2021-06-11 06:53:40 -04:00
Robin Avery
6e181a6b63
Rename parameters of getTieredComponent
2021-06-11 06:53:04 -04:00
Robin Avery
a76eaeb52d
Make getTieredComponent local
2021-06-11 06:51:12 -04:00
Jamie Taylor
15d3b4444d
Rename HoverSounds and HoverClickSounds samples
2021-06-11 19:34:54 +09:00
Robin Avery
635300b311
Recalculate closest anchor when origin is changed
2021-06-11 06:28:30 -04:00
Robin Avery
a506f2a776
Revert rename of lambda variables
2021-06-11 06:22:24 -04:00
ekrctb
af3f253b21
Refactor ScrollingHitObjectContainer and expose more useful methods
2021-06-11 18:28:48 +09:00
Dean Herbert
8eab7df955
Move BindCollectionChanged out of async load
2021-06-11 17:51:58 +09:00
Dean Herbert
20759657de
Rename configuration variables and refactor lots more
2021-06-11 16:37:31 +09:00
Dean Herbert
3d645608eb
Remove nullability of DI dependencies and fix incorrect load order
2021-06-11 16:28:53 +09:00
Dean Herbert
139401a04a
Inline and refactor overly verbose MessageNotifier code
2021-06-11 16:27:31 +09:00
Bartłomiej Dach
296761ade5
Add missing CurrentSkin null check in DHO disposal
2021-06-11 09:18:58 +02:00
Dean Herbert
c00f9ae4b7
Reword settings text
2021-06-11 16:11:37 +09:00
Dean Herbert
04413f1634
Merge pull request #13444 from peppy/editor-timeline-taiko-hit-colouring
...
Show osu!taiko centre/rim colouring in editor timeline
2021-06-11 15:10:24 +09:00
Dean Herbert
562cfe8703
Fix filename not matching type rename
2021-06-11 14:34:18 +09:00
Dan Balasescu
97375d9625
Merge pull request #13438 from bdach/more-metadata-fields
...
Add remaining metadata fields to editor setup screen
2021-06-11 14:17:34 +09:00
Dean Herbert
bc3b7233ab
Show osu!taiko centre/rim colouring in editor timeline
...
Closes #13443 .
2021-06-11 14:17:30 +09:00
Bartłomiej Dach
375f64ffd1
Check empty string more explicitly in IsRomanised()
...
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2021-06-11 06:38:53 +02:00
Bartłomiej Dach
7fd26ff3b0
Merge branch 'master' into more-metadata-fields
2021-06-11 06:35:51 +02:00
Dean Herbert
38bf04d7ff
Give more space for time values to allow for negative offsets
2021-06-11 13:25:09 +09:00
Bartłomiej Dach
417aaacc53
Add test coverage for romanised data transfer
2021-06-10 22:18:39 +02:00
Bartłomiej Dach
e41a5a0fcd
Add romanised author & title fields
2021-06-10 22:17:45 +02:00
ilsubyeega-desu
f65f074131
Add star keyword to FilterQueryParser criteria
2021-06-11 02:46:29 +09:00
Bartłomiej Dach
252fe0a6cc
Add source and tags text boxes to metadata section
2021-06-10 14:13:59 +02:00
Bartłomiej Dach
5a2e710095
Split common method for metadata textbox creation
2021-06-10 13:55:34 +02:00
Dan Balasescu
35d5632355
Merge pull request #13378 from Syriiin/diffcalc/refactor/auto-properties
...
Refactor DifficultyAttributes to use auto properties over public fields
2021-06-10 18:42:11 +09:00
Dan Balasescu
1505534c7e
Merge pull request #13428 from peppy/fix-pm-tab-avatars
...
Fix avatars missing in private message channel tabs / local leaderboards
2021-06-10 18:34:23 +09:00
Dean Herbert
4a4a561ca4
Merge pull request #13330 from nekodex/results-screen-sfx
...
Add sound effects to the results screen
2021-06-10 18:27:17 +09:00
Dan Balasescu
3cd7d45b0f
Merge pull request #13401 from peppy/no-unranked-display
...
Remove the concept of "unranked" mods
2021-06-10 17:51:31 +09:00
Dean Herbert
6a40ef581c
Fix avatars missing in private message channel tabs / local leaderboards
...
Regressed in https://github.com/ppy/osu/pull/12204 .
Adding this back in a central location for now, as each of the remaining cases will
need a local solution.
2021-06-10 17:47:17 +09:00
Dean Herbert
0667354fbd
Remove unused resolved skin
2021-06-10 17:30:04 +09:00
Dean Herbert
4f8000a574
Combine cases which return the same value
2021-06-10 17:29:36 +09:00
Dean Herbert
5e80f454ce
Merge branch 'master' into results-screen-sfx
2021-06-10 17:25:35 +09:00
Dan Balasescu
a44fd887ee
Merge branch 'master' into no-unranked-display
2021-06-10 17:09:46 +09:00
Dan Balasescu
479d6d3fc5
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-10 16:37:58 +09:00
Dan Balasescu
4eab717a80
Merge pull request #13408 from peppy/default-skin-fallback
...
Add fallback lookup support for `DefaultSkin`
2021-06-10 16:37:48 +09:00
Joseph Madamba
cc38556f61
Fix background being dimmed forever after toggling statistics in results screen
2021-06-09 23:26:57 -07:00
Dean Herbert
9a3ca09501
Merge pull request #13384 from bdach/fixed-label-width
...
Align label widths of editor setup screen controls
2021-06-10 14:55:49 +09:00
Dean Herbert
b55a4053cf
Merge pull request #13426 from gagahpangeran/wiki-image-title
...
Fix wiki image tooltips not showing inside table views
2021-06-10 14:28:49 +09:00
Dean Herbert
9044a20120
Merge branch 'master' into realm-key-binding-store
2021-06-10 13:58:08 +09:00
Dean Herbert
209d217024
Remove unused using statement
2021-06-10 12:37:56 +09:00
Gagah Pangeran Rosfatiputra
05cb935a94
change WikiMarkdownImage to extend OsuMarkdownImage
2021-06-10 09:38:48 +07:00
Gagah Pangeran Rosfatiputra
28d7b06908
create OsuMarkdownImage
2021-06-10 09:38:07 +07:00
Dean Herbert
3d508f9266
Merge branch 'master' into results-screen-sfx
2021-06-10 11:28:35 +09:00
Joseph Madamba
e3f3c37953
Add ability to navigate score panels with left/right arrows
2021-06-09 17:03:46 -07:00
Bartłomiej Dach
209f658d05
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 20:22:00 +02:00
Bartłomiej Dach
89cdea8123
Merge branch 'master' into fix-results-exit-transition
2021-06-09 19:40:56 +02:00
Bartłomiej Dach
266c1e2e25
Merge branch 'master' into fix-beatmap-skin-disables
2021-06-09 18:43:15 +02:00
Bartłomiej Dach
222ae40a04
Merge branch 'master' into update-framework
2021-06-09 17:36:17 +02:00
Bartłomiej Dach
7fe878299f
Merge branch 'master' into wiki-article
2021-06-09 16:24:45 +02:00
Dean Herbert
f113c095ce
Update framework
2021-06-09 20:29:06 +09:00
Dean Herbert
b02b8ae2bc
Merge pull request #13381 from smoogipoo/improve-hit-error-judgements
...
Improve hit error judgement displays
2021-06-09 19:40:17 +09:00
Dean Herbert
31b46afa71
Fix wrong naming scheme for applause samples
2021-06-09 19:35:05 +09:00
Dean Herbert
7d86dafd4f
Simplify tick calculation/playback method
2021-06-09 19:31:53 +09:00
Dean Herbert
57bc34f224
Move consts closer to usage
2021-06-09 19:24:35 +09:00
Dean Herbert
cb4f366651
Move forgotten private function down more
2021-06-09 19:15:55 +09:00
Dean Herbert
81cecac90b
Move tick rate initialisation to earlier
2021-06-09 19:09:00 +09:00
Dean Herbert
499aba95c0
Simplify sample construction logic and move private functions down
2021-06-09 19:06:37 +09:00
Dean Herbert
489a5a3c1d
Add back missing space in csproj
2021-06-09 19:01:05 +09:00
Dean Herbert
21a63efd78
Rename variable back to withFlair to match parent class
2021-06-09 18:55:29 +09:00
Dean Herbert
330bb7cb45
Remove unnecessary skin lookup logic
2021-06-09 18:55:29 +09:00
Dean Herbert
0cf7c56e7e
Add fallback lookup support for DefaultSkin
2021-06-09 18:51:42 +09:00
Dean Herbert
8fda04c2d9
Merge branch 'master' into results-screen-sfx
2021-06-09 18:00:11 +09:00
Dean Herbert
2438c20d63
Fix SourceChanged not being correctly forwarded through LegacySkinTransformer
2021-06-09 17:56:07 +09:00
Dean Herbert
a65b76bdbf
Add a simple fade to the results screen
...
Stops it from immediately disappearing.
2021-06-09 17:19:37 +09:00
Dean Herbert
7b0c5e9d32
Fix results screen changing applied colour to background on exit
...
The general rule is that screens should only apply colours and the likes
on enter / resume, and leave the outwards transition to whatever screen
is coming next.
2021-06-09 17:18:55 +09:00
Dean Herbert
258d05d1e0
Ensure PlayerLoader restores the background colour to its own value on resume
2021-06-09 17:17:39 +09:00
Dean Herbert
a7ef0173e9
Add safety to ensure background is correct tint when entering gameplay
2021-06-09 17:07:28 +09:00
Bartłomiej Dach
020c63017e
Fix inspectcode issues
2021-06-09 09:21:02 +02:00
Dean Herbert
448e4e7ee5
Fix FindProvider calls on SkinProvidingContainer not considering disable flags
...
Closes #13394 .
2021-06-09 16:19:04 +09:00
Bartłomiej Dach
023015f9a6
Merge branch 'master' into fix-skin-background-regression
2021-06-09 08:09:21 +02:00
Bartłomiej Dach
a801a9a14d
Ensure background rotation on default skins
2021-06-09 07:59:47 +02:00
Dean Herbert
b754c52392
Update ModAutoplay matching to use new UserPlayable flag instead
2021-06-09 14:32:48 +09:00
Dean Herbert
b8df3fff9e
Fix incorrect method referenced in xmldco
...
Co-authored-by: ekrctb <32995012+ekrctb@users.noreply.github.com>
2021-06-09 14:20:01 +09:00
Dean Herbert
d0e9f8ef90
Replace and obsolete Ranked flag with IsUserPlayable
2021-06-09 14:17:03 +09:00
Dean Herbert
62199a38a8
Add one missing obsoletion removal date
2021-06-09 14:11:50 +09:00
Dean Herbert
f41e34ae2c
Remove more obsoleted members
2021-06-09 14:10:48 +09:00
