1047 Commits

• Apply further changes to remove remaining weirdness
  Bartłomiej Dach · 2024-02-05 13:37:38 +01:00
  fb80d76b4a
• Merge branch 'master' into hit-object-result-allocations
  Bartłomiej Dach · 2024-02-05 13:24:10 +01:00
  39fe078984
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Merge pull request #26698 from EVAST9919/slider-sample-alloc

  Reduce sliding sample allocations in `DrawableSlider`

  Dean Herbert · 2024-01-29 20:37:32 +09:00
  a3199333bb
• Also fix spinner case
  Dean Herbert · 2024-01-29 20:36:59 +09:00
  034f8c0388
• Reduce allocation overheads in SliderInputManager
  Dean Herbert · 2024-01-26 17:49:20 +09:00
  b6fa50c312
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• Remove weird red fade that didn't work
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  fd9527d523
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Fix slider sliding samples allocation
  Andrei Zavatski · 2024-01-25 04:06:15 +03:00
  21b11092d6
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Fix slider sometimes not updating relative anchor position
  Salman Ahmed · 2024-01-22 02:07:32 +03:00
  57b2d018a9
• change wording
  OliBomby · 2024-01-15 12:51:08 +01:00
  96ffe8e737
• Clarify comment
  OliBomby · 2024-01-15 12:49:40 +01:00
  86382f4408
• Fix so it reacts to PathVersion with Scheduler
  OliBomby · 2024-01-13 12:50:39 +01:00
  fca9b1f536
• Use invalidation based logic for child anchor position updpates in DrawableSlider
  Dean Herbert · 2024-01-09 14:17:33 +09:00
  5970a68e2d
• Reset child anchor position cache on hitobject position change
  Dean Herbert · 2024-01-07 20:55:28 +09:00
  962c8ba4ac
• Avoid iteration over NestedHitObjects in silder's Update unless necessary
  Dean Herbert · 2024-01-07 14:31:22 +09:00
  5cc4a586ac
• Remove unnecessary second iteration over NestedHitObjects
  Dean Herbert · 2024-01-07 14:31:22 +09:00
  35eff639cb
• Fix spinner max bonus not respecting ISamplePlaybackDisabler

  The spinner max bonus was loaded through SkinnableSound instead of PausableSkinnableSound, leading to it not respecting the case where sample playback is globally disabled through ISamplePlaybackDisabler, and can be easily heard in situations like during the catchup period after seeking using the ArgonSongProgressBar with song volume at 0

  rushiiMachine · 2023-12-27 12:55:49 -08:00
  cf39bb7a18
• Fix relax mod not considering full follow area radius when automatically holding sliders

  Closes https://github.com/ppy/osu/issues/25947.
  
  Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
  `DrawableSliderBall`.
  
  I would have liked to include tests, but relax mod is a bit untestable,
  because it disengages completely in the presence of a replay:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs#L49-L58
  
  Additionally, `RulesetInputManager` disengages completely from parent
  inputs when there is a replay active:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game/Rulesets/UI/RulesetInputManager.cs#L116
  
  which means there is really no easy way to control positional input
  while still having relax logic work. So I'm hoping the fix could be
  considered obvious enough to not require test coverage.

  Bartłomiej Dach · 2023-12-22 12:50:42 +01:00
  7e557152fb
• Expose only as one method
  Dan Balasescu · 2023-12-21 14:58:23 +09:00
  6b4b2a57fc
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Add support for showing tick misses
  Dean Herbert · 2023-12-20 20:23:19 +09:00
  9b383e3276
• Fix sliding sample playing before Slider's start time
  Dan Balasescu · 2023-12-19 17:01:52 +09:00
  fe5e071e70
• Require slider head to be judged before ticks
  Dan Balasescu · 2023-12-17 21:26:48 +09:00
  2b33aec124
• Fix 1-frame issues due to referencing external value
  Dan Balasescu · 2023-12-17 20:19:25 +09:00
  fddfa33e49
• Only track if in slider ball after any ticks missed
  Dan Balasescu · 2023-12-17 20:12:02 +09:00
  9b02bd712b
• Fix tail being missed too early
  Dan Balasescu · 2023-12-17 20:11:15 +09:00
  fbe48d7be8
• Only hit passed-through ticks if none were missed
  Dan Balasescu · 2023-12-17 19:57:48 +09:00
  f77884b62f
• Use the cursor position to test nested object validity
  Dan Balasescu · 2023-12-15 17:05:14 +09:00
  12210017e4
• Refactor all slider input into SliderInputManager
  Dan Balasescu · 2023-12-15 16:13:32 +09:00
  6bd190c55d
• Add lenience for late-hit of slider heads
  Dan Balasescu · 2023-12-15 14:14:58 +09:00
  599fdb0128
• Allow slider to be tracked before its start time
  Dan Balasescu · 2023-12-13 16:59:41 +09:00
  3f67538d61
• Merge pull request #25343 from peppy/spinner-max-sample

  Continue to play spinner bonus sounds when MAX display occurs

  Bartłomiej Dach · 2023-11-09 13:34:29 +01:00
  5180fa669b
• Add spinnerbonus-max support and fallback to spinnerbonus
  Dean Herbert · 2023-11-06 18:43:47 +09:00
  92e4a8666d
• Move sample playback logic local to avoid edge case with no bonus ticks

  Can't see a better way of doing this.

  Dean Herbert · 2023-11-06 18:29:51 +09:00
  b219a371a9
• Clean up comment
  Bartłomiej Dach · 2023-11-02 18:52:47 +01:00
  86ede717cb
• Remove nested ternary
  Dean Herbert · 2023-11-02 23:42:52 +09:00
  ac6fb386d1
• Continue to play spinner bonus sounds when MAX display occurs
  Dean Herbert · 2023-11-02 19:52:49 +09:00
  f0f595ca40
• Add better commenting around DrawableSliderHead logic
  Dean Herbert · 2023-11-02 18:31:28 +09:00
  a7705284e7
• Rename and invert flags for slider classic behaviours
  Dean Herbert · 2023-11-02 17:43:21 +09:00
  9c1f4b552e
• Trim redundant comments
  Bartłomiej Dach · 2023-11-02 08:18:37 +01:00
  ad82ada030
• Fix all spinner ticks being alive and causing performance degradation

  Regressed in https://github.com/ppy/osu/pull/25216.
  
  The new logic will ensure at least one tick is ready for judgement.
  There shouldn't be a case where more than one is needed in a single
  frame.

  Dean Herbert · 2023-11-01 18:28:07 +09:00
  c2de03aa44
• Merge pull request #25218 from peppy/better-slider-judgement-handling

  Fix out-of-order judgements when missing a slider head

  Dan Balasescu · 2023-10-27 15:50:13 +09:00
  9a0882af69
• Add note about implementation being shared
  Dean Herbert · 2023-10-25 15:44:51 +09:00
  2f95e7a284
• Fix DrawableSliderTail potentially forcing miss on head too early
  Dean Herbert · 2023-10-25 15:44:42 +09:00
  6eafb66fdf
• Fix repeat circles on sliders not correctly getting dimmed
  Dean Herbert · 2023-10-25 14:01:55 +09:00
  74f794a549
• Merge pull request #25185 from bdach/minimum-sample-volume
  Dean Herbert · 2023-10-24 22:04:43 +09:00
  34505b3933