Dean Herbert
8e25c94452
Fix kiai fountains sometimes not displaying when they should
...
The previous logic was very wrong, as the check would only occur on each
beat. But that's not how kiai sections work – they can be placed at any
timestamp, even if that doesn't align with a beat.
In addition, the rate limiting has been removed because it didn't exist
on stable and causes some fountains to be missed. Overlap scenarios are
already handled internally by the `StarFountain` class.
Closes https://github.com/ppy/osu/issues/31855 .
2025-02-18 14:12:16 +09:00
Bartłomiej Dach
0b29a762b8
Add precautionary guard to avoid potential div-by-zero
...
Probably wouldn't happen outside of tests, but I'd rather not find out
next release.
2024-03-26 17:36:40 +01:00
Dean Herbert
a5f15a119e
Apply rate adjust fix in all cases rather than specifically for Clock.Rate == 1
2024-03-26 22:51:54 +08:00
Dean Herbert
3f9c2b41f7
Adjust BeatSyncContainer's early animate offset based on source's rate
2024-01-25 21:40:37 +09:00
Dean Herbert
20e4e2581a
Change IBeatSyncProvider.Clock to always be non-null
2023-07-13 22:13:40 +09:00
Dean Herbert
044b0604b2
Move OmitFirstBarLine to TimingControlPoint
2023-02-28 19:29:31 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dean Herbert
a32149fda1
Convert interface methods to extension methods
2022-08-03 20:07:55 +09:00
Dean Herbert
16ff8d5c38
Use different variable source
2022-08-03 17:47:32 +09:00
Dean Herbert
258ad7c6b9
Tidy up kiai time access
2022-08-02 18:18:40 +09:00
Dean Herbert
cc4cde2c79
Improve IBeatSyncProvider interface and reduce beatmap track dependence
2022-08-02 17:59:18 +09:00
TacoGuyAT
2f16174d3d
Changed control points set to private; Cleanup
2022-07-21 07:25:44 +03:00
TacoGuyAT
ed8e065a86
Logo triangles speed and beat sync tweaks
2022-07-21 06:13:45 +03:00
Dean Herbert
ae49aafde2
Fix BeatSyncedContainer unintentionally blocking on beatmap load
2022-07-06 14:58:06 +09:00
Dan Balasescu
e0c82d11ab
Convert == usages to ReferenceEquals
2022-06-20 16:56:19 +09:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Dean Herbert
eabf578282
Use interface to convey beat sync information
2022-05-22 22:44:54 +09:00
Dean Herbert
d3f115bfe2
Remove redundant qualifiers
2022-05-21 13:53:58 +09:00
Dean Herbert
c3bfbe8880
Allow BeatSyncedContainer to prefer EditorBeatmap when available
2022-05-20 23:24:57 +09:00
ColdVolcano
81215b9f0e
Use correct effect points when EarlyActivationMilliseconds is not zero
2021-12-04 22:31:55 -06:00
Dean Herbert
87d3bd4b93
Fix time until next beat potentially being exactly zero at point of trigger
2021-07-17 14:35:43 +09:00
Dean Herbert
b6996d647e
Add ability to disable mistimed event firings
2021-07-15 16:22:48 +09:00
Dean Herbert
98a1f40a98
Ensure EarlyActivationMilliseconds is applied even in idle state
2021-07-15 15:10:14 +09:00
Dean Herbert
c47ff1919c
Fix regression in idle behaviour and refactor further
2021-07-15 14:56:49 +09:00
Dean Herbert
5ecf6511e6
Fix default timing points being used if "track" is not running
2021-07-15 14:41:50 +09:00
Dean Herbert
a3129ad00e
Refactor BeatSyncedContainer to support GameplayClock
2021-07-15 14:37:13 +09:00
PercyDan54
e1c646b9b2
Remove redundant arguments
2021-07-05 23:52:39 +08:00
Dean Herbert
f65991f31f
Revert some usages based on review feedback
2020-08-26 23:28:58 +09:00
smoogipoo
11a6c9bdcc
Revert unnecessary change
2020-08-06 16:24:14 +09:00
smoogipoo
5c05fe3988
Expose track from MusicController
2020-08-06 16:24:14 +09:00
smoogipoo
6e42b8219c
Move track to MusicController, compiles
2020-08-06 16:24:14 +09:00
Dean Herbert
8147e67f53
Use static instances in all fallback ControlPoint lookups to reduce allocations
2020-07-18 11:53:04 +09:00
Dean Herbert
f2735a7797
Use new empty ChannelAmplitudes spec
2020-06-23 21:30:37 +09:00
Dean Herbert
14ad3835ff
Update naming
2020-06-23 21:27:01 +09:00
smoogipoo
69fb984e71
Remove EquivalentTo() and Equals()
2020-04-17 17:04:09 +09:00
Dean Herbert
c1f52ef594
Refactor BeatSyncContainer to handle zero length tracks
2020-02-09 21:25:28 +09:00
Dean Herbert
619fe29871
Make reverse arrow animate faster via divisor specification
...
Adds MinimumBeatLength to BeatSyncedContainer to make sure things don't get out of hand.
2020-01-14 01:39:45 +09:00
smoogipoo
d65e37d795
Fix typo
2019-12-18 17:58:29 +09:00
Dean Herbert
795416c066
Move first beat offset to BeatSyncedContainer
2019-12-17 12:06:09 +09:00
Dean Herbert
72404bff9a
Add support for simple triple time
2019-12-16 19:16:54 +09:00
Dean Herbert
0f9ff32cdc
Fix beat playing while paused
2019-12-16 18:51:22 +09:00
Dean Herbert
8baf569f59
Remove necessity of AutoGenerated flag
2019-10-25 19:58:42 +09:00
Dean Herbert
e987db37ec
Add grouping of ControlPoints
2019-10-25 19:52:02 +09:00
smoogipoo
eab06995d0
Add some whitespace
2019-09-03 11:37:56 +09:00
jorolf
3b769128a8
Add a 60bpm beat when no beatmap is playing
2019-09-03 00:57:29 +02:00
smoogipoo
d8c55bc729
Adjust namespaces
2019-02-21 19:05:52 +09:00
Dean Herbert
ca5c8d37d1
Use leased bindables
2019-02-01 16:44:06 +09:00
Dean Herbert
8617aaa2a7
Update licence header (and remove year)
2019-01-24 17:43:03 +09:00
smoogipoo
72cc53aded
Rename GameBeatmap -> BindableBeatmap
2018-06-06 20:16:20 +09:00
smoogipoo
8004b8af4d
Privatise the OsuGame beatmap, add local beatmap to OsuTestCase
2018-05-23 17:38:02 +09:00
