osu-lazer

Fix crash when dragging rotation control in editor with both mouse buttons

Closes https://github.com/ppy/osu/issues/26325.

Dean Herbert · 2024-01-03 13:34:50 +09:00

bdfaa4b583

Use alternative workaround

Bartłomiej Dach · 2023-12-29 11:07:45 +01:00

99cddb6317

Fix crash after changing audio track in editor

Closes https://github.com/ppy/osu/issues/26213.

Reproduction scenario: switch audio track in editor after timeline
loads.

Happens because `beatmap.Value.Track.Length` is 0 immediately after a
track switch, until BASS computes the actual track length on the audio
thread.

Yes this is a hack. No I have no better immediate ideas how to address
this otherwise.

Bartłomiej Dach · 2023-12-29 10:37:36 +01:00

cd1f6b46c4

Use new icons in editor

Some that exist on figma are purposefully not used due to an editorial
request from @peppy.

Bartłomiej Dach · 2023-12-27 17:42:18 +01:00

288ac930e4

Add visual offset to better align editor waveforms with expectations

Dean Herbert · 2023-12-26 17:44:49 +09:00

f9e47242db

fix crash from dragging near zero-length repeating object in timeline

OliBomby · 2023-12-19 21:20:45 +01:00

c167f10ad5

Merge pull request #25371 from RatinFX/open-editor-timestamp

Implement opening editor timestamp links

Bartłomiej Dach · 2023-11-21 15:48:36 +09:00

d83b2e24e7

Rectify selection keep-alive logic

Bartłomiej Dach · 2023-11-20 21:57:14 +09:00

234ef6f923

Rename diagonal scale variable and update xmldoc

Dean Herbert · 2023-11-10 17:55:02 +09:00

35e11c7c63

Change selection handling to adjust Size instead of Scale for edge nodes

Dean Herbert · 2023-11-10 14:22:28 +09:00

ec3b6e47fb

Renamed CollectionChanged event handler

ratinfx · 2023-11-07 11:11:32 +01:00

bdbeb2bce4

Renamed method and made private

ratinfx · 2023-11-07 01:02:45 +01:00

44f127c8a8

Ensure every SelectedItem is alive and has Blueprint

ratinfx · 2023-11-05 18:26:51 +01:00

277cf7dc12

Update autoselect implementation to work correctly with framework changes

Bartłomiej Dach · 2023-10-31 08:38:22 +01:00

144006fbe8

Merge branch 'master' into beat-divisor-select-text-on-click

Bartłomiej Dach · 2023-10-31 08:36:53 +01:00

8a68333425

Fix failing tests

Dean Herbert · 2023-10-30 18:06:11 +09:00

63e6eaf538

Fix right clicks on timeline objects potentially getting eaten by playfield area

`SelectionHandler` is receiving input from anywhere out of necessity:

https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs#L119-L125

Also important is that `BlueprintContainer` will selectively not block
right clicks to make sure they fall through to the
`ContextMenuContainer`:

https://github.com/ppy/osu/blob/19f892687a0607afbe4e0d010366dc2a66236073/osu.Game/Screens/Edit/Compose/Components/BlueprintContainer.cs#L122-L126

But because the whole editor is sharing a `ContextMenuContainer` and
it's at a higher level than both components, we observe here the
playfield's `SelectionHandler` intercepting the right click before it
can reach the `ContextMenuContainer`.

The fix here is similar to what we're already doing in
`TimelineBlueprintContaienr`.

Dean Herbert · 2023-10-30 18:06:11 +09:00

57d88a0ac4

Disallow setting sample volume lower than 5% in editor

Bartłomiej Dach · 2023-10-20 15:50:21 +02:00

12282fff5c

Merge branch 'master' into taiko-beat-snap-grid

Dean Herbert · 2023-10-19 23:53:01 +09:00

52c2eb93de

Bypass Parent nullability checks for now

Dean Herbert · 2023-10-17 17:48:45 +09:00

5341a335a6

Add beat snap grid to osu!taiko editor

Addresses https://github.com/ppy/osu/discussions/25150.

Dean Herbert · 2023-10-17 16:59:56 +09:00

2a89a25790

Abstract out common implementation of BeatSnapGrid

Dean Herbert · 2023-10-17 16:42:52 +09:00

1b9acdf55c

Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity

Dean Herbert · 2023-09-06 19:01:08 +09:00

1a37543d28

Fix formatting

Hồ Nguyên Minh · 2023-09-04 13:32:42 +07:00

d5a89c4c45

Add length check for slider velocity

Hồ Nguyên Minh · 2023-09-04 10:43:05 +07:00

b17a55d6a8

let SelectionBox perform flip with scale handles

Wleter · 2023-09-01 13:01:51 +02:00

fc4069f794

Merge branch 'ppy:master' into skin-editor-selection-negative-scaling

Wleter · 2023-08-29 17:30:55 +02:00

14ee0ee395

change names

Wleter · 2023-08-29 17:25:52 +02:00

d56ab0fe9a

working negative scaling

Wleter · 2023-08-28 16:41:55 +02:00

07e126241d

Merge branch 'master' into new-overlay-sfx

Dean Herbert · 2023-08-24 18:29:00 +09:00

081fb308e1

Change some component samples to go better with overlay pop-in samples

Jamie Taylor · 2023-08-17 18:36:37 +09:00

d10d7b6ea4

Add precise rotation control to osu! editor

Bartłomiej Dach · 2023-08-16 11:37:52 +02:00

19f892687a

Interface with SelectionRotationHandler via DI rather than explicit passing

Bartłomiej Dach · 2023-07-30 20:21:41 +02:00

ebe5dd2ac9

Make SelectionRotationHandler a Component

Bartłomiej Dach · 2023-07-30 20:18:33 +02:00

262f25dce8

Merge branch 'master' into selection-operations-refactor

Bartłomiej Dach · 2023-07-30 19:29:06 +02:00

821cd08f34

Use better safety in rectangular grid

- Checking `DrawSize != Vector2.Zero` is too specific. It could also
  crash on zero-height-but-non-zero-width, or
  zero-width-but-non-zero-height.

- Take the `gridCache.Validate()` call out of the zero checks, because
  even if the width or height are zero, not generating anything is valid
  and there is no reason to validate every frame until `gridCache` gets
  invalidated again.

Bartłomiej Dach · 2023-07-28 22:57:02 +02:00

c6f0cf50ca